All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: wei@redhat.com, peter.maydell@linaro.org, drjones@redhat.com,
	mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org,
	qemu-arm@nongnu.org, abologna@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct
Date: Wed, 23 Mar 2016 19:56:40 +0800	[thread overview]
Message-ID: <20160323115640.GS28183@pxdev.xzpeter.org> (raw)
In-Reply-To: <87mvppbkbf.fsf@blackfin.pond.sub.org>

On Wed, Mar 23, 2016 at 10:44:04AM +0100, Markus Armbruster wrote:
> Depends.
> 
> The general rule is to keep separate things separate, and patches
> self-contained.  The narrow sense of self-contained is each patch
> compiles and works.  The wider sense is each patch makes sense to its
> readers on its own.  You can't always have a perfect score on the
> latter, but you should try.
> 
> Adding a definition without a user is generally not advised, because you
> generally need to see the user to make sense of it.
> 
> For a complex feature, adding its abstract interface before its concrete
> implementation may help liberate interface review from implementation
> details.
> 
> Note that your interface consists of type GICCapability and command
> query-gic-capabilities.  You could add just the interface with a stub
> implementation first, then flesh out the implementation.  But I doubt
> the thing is complex enough to justify that.

Thanks for the thorough explaination on this.

It's indeed not easy to figure out the best way every time for
me... Now I do feel it strange to split the first patch alone from
the 2nd one. Anyway, it's squashed into the 2nd patch in v6.

-- peterx

  reply	other threads:[~2016-03-23 11:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18  3:27 [Qemu-devel] [PATCH v5 0/5] ARM: add query-gic-capabilities SMP command Peter Xu
2016-03-18  3:27 ` [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct Peter Xu
2016-03-22 18:29   ` Markus Armbruster
2016-03-22 18:41     ` Markus Armbruster
2016-03-23  2:58       ` Peter Xu
2016-03-23  9:33         ` Markus Armbruster
2016-03-23 11:48           ` Peter Xu
2016-03-23 12:21             ` Markus Armbruster
2016-03-23 14:25               ` Peter Xu
2016-03-23 15:17                 ` Markus Armbruster
2016-03-24  2:27                   ` Peter Xu
2016-03-22 18:32   ` Eric Blake
2016-03-23  3:09     ` Peter Xu
2016-03-23  9:44       ` Markus Armbruster
2016-03-23 11:56         ` Peter Xu [this message]
2016-03-18  3:27 ` [Qemu-devel] [PATCH v5 2/5] arm: qmp: add query-gic-capabilities interface Peter Xu
2016-03-22 18:28   ` Markus Armbruster
2016-03-23  4:14     ` Peter Xu
2016-03-23  9:52       ` Markus Armbruster
2016-03-23 12:04         ` Peter Xu
2016-03-23 14:06           ` Markus Armbruster
2016-03-23 14:31             ` Eric Blake
2016-03-22 18:42   ` Eric Blake
2016-03-22 19:09     ` Markus Armbruster
2016-03-23  4:07     ` Peter Xu
2016-03-23  9:54       ` Markus Armbruster
2016-03-18  3:27 ` [Qemu-devel] [PATCH v5 3/5] arm: enhance kvm_arm_create_scratch_host_vcpu Peter Xu
2016-03-18  3:27 ` [Qemu-devel] [PATCH v5 4/5] kvm: add kvm_support_device() helper function Peter Xu
2016-03-18  3:27 ` [Qemu-devel] [PATCH v5 5/5] arm: implement query-gic-capabilities Peter Xu
2016-03-21 15:56 ` [Qemu-devel] [PATCH v5 0/5] ARM: add query-gic-capabilities SMP command Andrea Bolognani
2016-03-22  2:23   ` Peter Xu
2016-03-22 14:20 ` Markus Armbruster
2016-03-23  5:19   ` Peter Xu
2016-03-22 14:49 ` Peter Maydell
2016-03-23  5:43   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160323115640.GS28183@pxdev.xzpeter.org \
    --to=peterx@redhat.com \
    --cc=abologna@redhat.com \
    --cc=armbru@redhat.com \
    --cc=drjones@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.