All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Feng Xiao <xf@rock-chips.com>
Cc: linux@arm.linux.org.uk, heiko@sntech.de, rjw@rjwysocki.net,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, wxt@rock-chips.com, zyw@rock-chips.com,
	jay.xu@rock-chips.com, tim.chen@rock-chips.com,
	xxx@rock-chips.com, huangtao@rock-chips.com
Subject: Re: [PATCH v2] cpufreq: rockchip: add driver
Date: Wed, 23 Mar 2016 10:10:33 +0530	[thread overview]
Message-ID: <20160323044033.GQ5272@vireshk-i7> (raw)
In-Reply-To: <1458699487-58470-1-git-send-email-xf@rock-chips.com>

On 23-03-16, 10:18, Feng Xiao wrote:
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 14b1f93..1786315 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -97,6 +97,16 @@ config ARM_OMAP2PLUS_CPUFREQ
>  	depends on ARCH_OMAP2PLUS
>  	default ARCH_OMAP2PLUS
>  
> +config ARM_ROCKCHIP_CPUFREQ
> +	tristate "Rockchip CPUfreq driver"

Since you are allowing it to be built as a module ...

> +	depends on ARCH_ROCKCHIP && CPUFREQ_DT
> +	select PM_OPP
> +	help
> +	  This adds the CPUFreq driver support for Rockchip SoCs.
> +	  The driver will directly use cpufreq-dt driver as backend.
> +
> +	  If in doubt, say N.

> +++ b/drivers/cpufreq/rockchip-cpufreq.c
> +static int __init rockchip_cpufreq_driver_init(void)
> +{
> +	struct platform_device *pdev;
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(rockchip_compat); i++) {
> +		if (of_machine_is_compatible(rockchip_compat[i])) {
> +			pdev = platform_device_register_simple("cpufreq-dt",
> +							       -1, NULL, 0);
> +			return PTR_ERR_OR_ZERO(pdev);
> +		}
> +	}
> +
> +	return -ENODEV;
> +}
> +module_init(rockchip_cpufreq_driver_init);

You need a module exit as well to remove the device. Otherwise following
sequence will give you errors:

insmod rockchip-cpufreq.ko
rmmod rockchip-cpufreq.ko
insmod rockchip-cpufreq.ko //Errors on this..

So, either don't allow it to be built as a module or fix the module-exit path.

-- 
viresh

WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] cpufreq: rockchip: add driver
Date: Wed, 23 Mar 2016 10:10:33 +0530	[thread overview]
Message-ID: <20160323044033.GQ5272@vireshk-i7> (raw)
In-Reply-To: <1458699487-58470-1-git-send-email-xf@rock-chips.com>

On 23-03-16, 10:18, Feng Xiao wrote:
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 14b1f93..1786315 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -97,6 +97,16 @@ config ARM_OMAP2PLUS_CPUFREQ
>  	depends on ARCH_OMAP2PLUS
>  	default ARCH_OMAP2PLUS
>  
> +config ARM_ROCKCHIP_CPUFREQ
> +	tristate "Rockchip CPUfreq driver"

Since you are allowing it to be built as a module ...

> +	depends on ARCH_ROCKCHIP && CPUFREQ_DT
> +	select PM_OPP
> +	help
> +	  This adds the CPUFreq driver support for Rockchip SoCs.
> +	  The driver will directly use cpufreq-dt driver as backend.
> +
> +	  If in doubt, say N.

> +++ b/drivers/cpufreq/rockchip-cpufreq.c
> +static int __init rockchip_cpufreq_driver_init(void)
> +{
> +	struct platform_device *pdev;
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(rockchip_compat); i++) {
> +		if (of_machine_is_compatible(rockchip_compat[i])) {
> +			pdev = platform_device_register_simple("cpufreq-dt",
> +							       -1, NULL, 0);
> +			return PTR_ERR_OR_ZERO(pdev);
> +		}
> +	}
> +
> +	return -ENODEV;
> +}
> +module_init(rockchip_cpufreq_driver_init);

You need a module exit as well to remove the device. Otherwise following
sequence will give you errors:

insmod rockchip-cpufreq.ko
rmmod rockchip-cpufreq.ko
insmod rockchip-cpufreq.ko //Errors on this..

So, either don't allow it to be built as a module or fix the module-exit path.

-- 
viresh

  reply	other threads:[~2016-03-23  4:40 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18 12:10 [PATCH] cpufreq: rockchip: add driver Feng Xiao
2016-03-18 12:10 ` Feng Xiao
2016-03-18 12:56 ` Heiko Stübner
2016-03-18 12:56   ` Heiko Stübner
2016-03-21  9:50   ` Viresh Kumar
2016-03-21  9:50     ` Viresh Kumar
2016-03-21  9:54     ` Heiko Stübner
2016-03-21  9:54       ` Heiko Stübner
2016-03-21  9:58       ` Viresh Kumar
2016-03-21  9:58         ` Viresh Kumar
2016-03-21 13:24         ` Feng Xiao
2016-03-21 13:24           ` Feng Xiao
2016-03-21 15:13           ` Viresh Kumar
2016-03-21 15:13             ` Viresh Kumar
2016-03-21 15:13           ` Heiko Stübner
2016-03-21 15:13             ` Heiko Stübner
2016-03-21 15:52             ` Heiko Stübner
2016-03-21 15:52               ` Heiko Stübner
2016-03-22  1:28               ` Feng Xiao
2016-03-22  1:28                 ` Feng Xiao
2016-03-22  1:28                 ` Feng Xiao
2016-03-22 11:57 ` [PATCH v1] " Feng Xiao
2016-03-22 11:57   ` Feng Xiao
2016-03-22 16:07   ` Heiko Stübner
2016-03-22 16:07     ` Heiko Stübner
2016-03-23  2:18   ` [PATCH v2] " Feng Xiao
2016-03-23  2:18     ` Feng Xiao
2016-03-23  4:40     ` Viresh Kumar [this message]
2016-03-23  4:40       ` Viresh Kumar
2016-03-24  3:01       ` Feng Xiao
2016-03-24  3:01         ` Feng Xiao
2016-03-24  3:01         ` Feng Xiao
2016-03-24  6:43         ` Viresh Kumar
2016-03-24  6:43           ` Viresh Kumar
2016-03-24 15:09           ` Finley Xiao
2016-03-24 15:09             ` Finley Xiao
2016-03-25  4:42             ` Viresh Kumar
2016-03-25  4:42               ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160323044033.GQ5272@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=jay.xu@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rjw@rjwysocki.net \
    --cc=tim.chen@rock-chips.com \
    --cc=wxt@rock-chips.com \
    --cc=xf@rock-chips.com \
    --cc=xxx@rock-chips.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.