* btrfs_destroy_inode WARN_ON.
@ 2016-03-24 22:54 Dave Jones
2016-03-25 8:25 ` Markus Trippelsdorf
2016-03-28 1:14 ` Dave Jones
0 siblings, 2 replies; 8+ messages in thread
From: Dave Jones @ 2016-03-24 22:54 UTC (permalink / raw)
To: Linux Kernel; +Cc: Chris Mason, Josef Bacik, David Sterba, linux-btrfs
Just hit this on a tree from earlier this morning, v4.5-11140 or so.
WARNING: CPU: 2 PID: 32570 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0x389/0x3f0 [btrfs]
CPU: 2 PID: 32570 Comm: rm Not tainted 4.5.0-think+ #14
ffffffffc039baf9 00000000ef721ef0 ffff88025966fc08 ffffffff8957bcdb
0000000000000000 0000000000000000 ffff88025966fc50 ffffffff890b41f1
ffff88045d918040 0000242d4eed6048 ffff88024eed6048 ffff88024eed6048
Call Trace:
[<ffffffffc039baf9>] ? btrfs_destroy_inode+0x389/0x3f0 [btrfs]
[<ffffffff8957bcdb>] dump_stack+0x68/0x9d
[<ffffffff890b41f1>] __warn+0x111/0x130
[<ffffffff890b43fd>] warn_slowpath_null+0x1d/0x20
[<ffffffffc039baf9>] btrfs_destroy_inode+0x389/0x3f0 [btrfs]
[<ffffffff89352307>] destroy_inode+0x67/0x90
[<ffffffff893524e7>] evict+0x1b7/0x240
[<ffffffff893529be>] iput+0x3ae/0x4e0
[<ffffffff8934c93e>] ? dput+0x20e/0x460
[<ffffffff8933ee26>] do_unlinkat+0x256/0x440
[<ffffffff8933ebd0>] ? do_rmdir+0x350/0x350
[<ffffffff890031e7>] ? syscall_trace_enter_phase1+0x87/0x260
[<ffffffff89003160>] ? enter_from_user_mode+0x50/0x50
[<ffffffff8913c3b5>] ? __lock_is_held+0x25/0xd0
[<ffffffff891411f2>] ? mark_held_locks+0x22/0xc0
[<ffffffff890034ed>] ? syscall_trace_enter_phase2+0x12d/0x3d0
[<ffffffff893400b0>] ? SyS_rmdir+0x20/0x20
[<ffffffff893400cb>] SyS_unlinkat+0x1b/0x30
[<ffffffff89003ac4>] do_syscall_64+0xf4/0x240
[<ffffffff89d520da>] entry_SYSCALL64_slow_path+0x25/0x25
---[ end trace a48ce4e6a1b5e409 ]---
That's WARN_ON(BTRFS_I(inode)->csum_bytes);
*maybe* it's a bad disk, but there's no indication in dmesg of anything awry.
Spinning rust on SATA, nothing special.
Dave
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs_destroy_inode WARN_ON.
2016-03-24 22:54 btrfs_destroy_inode WARN_ON Dave Jones
@ 2016-03-25 8:25 ` Markus Trippelsdorf
2016-03-28 14:05 ` Josef Bacik
2016-03-28 1:14 ` Dave Jones
1 sibling, 1 reply; 8+ messages in thread
From: Markus Trippelsdorf @ 2016-03-25 8:25 UTC (permalink / raw)
To: Dave Jones, Linux Kernel, Chris Mason, Josef Bacik, David Sterba,
linux-btrfs
On 2016.03.24 at 18:54 -0400, Dave Jones wrote:
> Just hit this on a tree from earlier this morning, v4.5-11140 or so.
>
> WARNING: CPU: 2 PID: 32570 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0x389/0x3f0 [btrfs]
> CPU: 2 PID: 32570 Comm: rm Not tainted 4.5.0-think+ #14
> ffffffffc039baf9 00000000ef721ef0 ffff88025966fc08 ffffffff8957bcdb
> 0000000000000000 0000000000000000 ffff88025966fc50 ffffffff890b41f1
> ffff88045d918040 0000242d4eed6048 ffff88024eed6048 ffff88024eed6048
> Call Trace:
> [<ffffffffc039baf9>] ? btrfs_destroy_inode+0x389/0x3f0 [btrfs]
> [<ffffffff8957bcdb>] dump_stack+0x68/0x9d
> [<ffffffff890b41f1>] __warn+0x111/0x130
> [<ffffffff890b43fd>] warn_slowpath_null+0x1d/0x20
> [<ffffffffc039baf9>] btrfs_destroy_inode+0x389/0x3f0 [btrfs]
> [<ffffffff89352307>] destroy_inode+0x67/0x90
> [<ffffffff893524e7>] evict+0x1b7/0x240
> [<ffffffff893529be>] iput+0x3ae/0x4e0
> [<ffffffff8934c93e>] ? dput+0x20e/0x460
> [<ffffffff8933ee26>] do_unlinkat+0x256/0x440
> [<ffffffff8933ebd0>] ? do_rmdir+0x350/0x350
> [<ffffffff890031e7>] ? syscall_trace_enter_phase1+0x87/0x260
> [<ffffffff89003160>] ? enter_from_user_mode+0x50/0x50
> [<ffffffff8913c3b5>] ? __lock_is_held+0x25/0xd0
> [<ffffffff891411f2>] ? mark_held_locks+0x22/0xc0
> [<ffffffff890034ed>] ? syscall_trace_enter_phase2+0x12d/0x3d0
> [<ffffffff893400b0>] ? SyS_rmdir+0x20/0x20
> [<ffffffff893400cb>] SyS_unlinkat+0x1b/0x30
> [<ffffffff89003ac4>] do_syscall_64+0xf4/0x240
> [<ffffffff89d520da>] entry_SYSCALL64_slow_path+0x25/0x25
> ---[ end trace a48ce4e6a1b5e409 ]---
>
>
> That's WARN_ON(BTRFS_I(inode)->csum_bytes);
>
> *maybe* it's a bad disk, but there's no indication in dmesg of anything awry.
> Spinning rust on SATA, nothing special.
Same thing here:
Mar 24 10:37:27 x4 kernel: ------------[ cut here ]------------
Mar 24 10:37:27 x4 kernel: WARNING: CPU: 3 PID: 11838 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0x22b/0x2a0
Mar 24 10:37:27 x4 kernel: CPU: 3 PID: 11838 Comm: rm Not tainted 4.5.0-11787-ga24e3d414e59-dirty #64
Mar 24 10:37:27 x4 kernel: Hardware name: System manufacturer System Product Name/M4A78T-E, BIOS 3503 04/13/2011
Mar 24 10:37:27 x4 kernel: 0000000000000000 ffffffff813c0d1a ffffffff81b8bb84 ffffffff812ffd0b
Mar 24 10:37:27 x4 kernel: ffffffff81099a9a 0000000000000000 ffff880149b86088 ffff88021585f000
Mar 24 10:37:27 x4 kernel: ffffffff812ffd0b 0000000000000000 ffff88005f526000 0000000000000000
Mar 24 10:37:27 x4 kernel: Call Trace:
Mar 24 10:37:27 x4 kernel: [<ffffffff813c0d1a>] ? dump_stack+0x46/0x6c
Mar 24 10:37:27 x4 kernel: [<ffffffff812ffd0b>] ? btrfs_destroy_inode+0x22b/0x2a0
Mar 24 10:37:27 x4 kernel: [<ffffffff81099a9a>] ? warn_slowpath_null+0x5a/0xe0
Mar 24 10:37:27 x4 kernel: [<ffffffff812ffd0b>] ? btrfs_destroy_inode+0x22b/0x2a0
Mar 24 10:37:27 x4 kernel: [<ffffffff811ab31c>] ? do_unlinkat+0x13c/0x3e0
Mar 24 10:37:27 x4 kernel: [<ffffffff810930db>] ? entry_SYSCALL_64_fastpath+0x13/0x8f
Mar 24 10:37:27 x4 kernel: ---[ end trace e9bae5be848e7a9e ]---
--
Markus
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs_destroy_inode WARN_ON.
2016-03-24 22:54 btrfs_destroy_inode WARN_ON Dave Jones
2016-03-25 8:25 ` Markus Trippelsdorf
@ 2016-03-28 1:14 ` Dave Jones
2016-04-01 18:12 ` Dave Jones
1 sibling, 1 reply; 8+ messages in thread
From: Dave Jones @ 2016-03-28 1:14 UTC (permalink / raw)
To: Linux Kernel, Chris Mason, Josef Bacik, David Sterba, linux-btrfs
On Thu, Mar 24, 2016 at 06:54:11PM -0400, Dave Jones wrote:
> Just hit this on a tree from earlier this morning, v4.5-11140 or so.
>
> WARNING: CPU: 2 PID: 32570 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0x389/0x3f0 [btrfs]
> CPU: 2 PID: 32570 Comm: rm Not tainted 4.5.0-think+ #14
> ffffffffc039baf9 00000000ef721ef0 ffff88025966fc08 ffffffff8957bcdb
> 0000000000000000 0000000000000000 ffff88025966fc50 ffffffff890b41f1
> ffff88045d918040 0000242d4eed6048 ffff88024eed6048 ffff88024eed6048
> Call Trace:
> [<ffffffffc039baf9>] ? btrfs_destroy_inode+0x389/0x3f0 [btrfs]
> [<ffffffff8957bcdb>] dump_stack+0x68/0x9d
> [<ffffffff890b41f1>] __warn+0x111/0x130
> [<ffffffff890b43fd>] warn_slowpath_null+0x1d/0x20
> [<ffffffffc039baf9>] btrfs_destroy_inode+0x389/0x3f0 [btrfs]
> [<ffffffff89352307>] destroy_inode+0x67/0x90
> [<ffffffff893524e7>] evict+0x1b7/0x240
> [<ffffffff893529be>] iput+0x3ae/0x4e0
> [<ffffffff8934c93e>] ? dput+0x20e/0x460
> [<ffffffff8933ee26>] do_unlinkat+0x256/0x440
> [<ffffffff8933ebd0>] ? do_rmdir+0x350/0x350
> [<ffffffff890031e7>] ? syscall_trace_enter_phase1+0x87/0x260
> [<ffffffff89003160>] ? enter_from_user_mode+0x50/0x50
> [<ffffffff8913c3b5>] ? __lock_is_held+0x25/0xd0
> [<ffffffff891411f2>] ? mark_held_locks+0x22/0xc0
> [<ffffffff890034ed>] ? syscall_trace_enter_phase2+0x12d/0x3d0
> [<ffffffff893400b0>] ? SyS_rmdir+0x20/0x20
> [<ffffffff893400cb>] SyS_unlinkat+0x1b/0x30
> [<ffffffff89003ac4>] do_syscall_64+0xf4/0x240
> [<ffffffff89d520da>] entry_SYSCALL64_slow_path+0x25/0x25
> ---[ end trace a48ce4e6a1b5e409 ]---
>
>
> That's WARN_ON(BTRFS_I(inode)->csum_bytes);
>
> *maybe* it's a bad disk, but there's no indication in dmesg of anything awry.
> Spinning rust on SATA, nothing special.
Same WARN_ON is reachable from umount too..
WARNING: CPU: 2 PID: 20092 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0x40c/0x480 [btrfs]
CPU: 2 PID: 20092 Comm: umount Tainted: G W 4.5.0-think+ #1
00000000ffffffff 00000000a32c482b ffff8803cd187b60 ffffffff9d63af84
0000000000000000 0000000000000000 ffffffffc05c5e40 ffffffffc04d316c
ffff8803cd187ba8 ffffffff9d0c4c27 ffff880460d80040 0000242dcd187bb0
Call Trace:
[<ffffffff9d63af84>] dump_stack+0x95/0xe1
[<ffffffffc04d316c>] ? btrfs_destroy_inode+0x40c/0x480 [btrfs]
[<ffffffff9d0c4c27>] __warn+0x147/0x170
[<ffffffff9d0c4e91>] warn_slowpath_null+0x31/0x40
[<ffffffffc04d316c>] btrfs_destroy_inode+0x40c/0x480 [btrfs]
[<ffffffffc04d2d60>] ? btrfs_test_destroy_inode+0x40/0x40 [btrfs]
[<ffffffff9d3bf7e7>] destroy_inode+0x77/0xb0
[<ffffffff9d3bfa2e>] evict+0x20e/0x2c0
[<ffffffff9d3bfb50>] dispose_list+0x70/0xb0
[<ffffffff9d3c14ef>] evict_inodes+0x26f/0x2c0
[<ffffffff9d3c1280>] ? inode_add_lru+0x60/0x60
[<ffffffff9d40baa5>] ? fsnotify_unmount_inodes+0x215/0x2c0
[<ffffffff9d38e336>] generic_shutdown_super+0x76/0x1c0
[<ffffffff9d38e899>] kill_anon_super+0x29/0x40
[<ffffffffc044c421>] btrfs_kill_super+0x31/0x130 [btrfs]
[<ffffffff9d38ec1f>] deactivate_locked_super+0x6f/0xb0
[<ffffffff9d38f2c9>] deactivate_super+0x99/0xb0
[<ffffffff9d3c8610>] cleanup_mnt+0x70/0xd0
[<ffffffff9d3c86db>] __cleanup_mnt+0x1b/0x20
[<ffffffff9d103d1f>] task_work_run+0xef/0x130
[<ffffffff9d0023c9>] exit_to_usermode_loop+0xf9/0x100
[<ffffffff9d004068>] do_syscall_64+0x238/0x2b0
[<ffffffff9df3831a>] entry_SYSCALL64_slow_path+0x25/0x25
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs_destroy_inode WARN_ON.
2016-03-25 8:25 ` Markus Trippelsdorf
@ 2016-03-28 14:05 ` Josef Bacik
2016-03-28 14:14 ` Markus Trippelsdorf
0 siblings, 1 reply; 8+ messages in thread
From: Josef Bacik @ 2016-03-28 14:05 UTC (permalink / raw)
To: Markus Trippelsdorf, Dave Jones, Linux Kernel, Chris Mason,
David Sterba, linux-btrfs
On 03/25/2016 04:25 AM, Markus Trippelsdorf wrote:
> On 2016.03.24 at 18:54 -0400, Dave Jones wrote:
>> Just hit this on a tree from earlier this morning, v4.5-11140 or so.
>>
>> WARNING: CPU: 2 PID: 32570 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0x389/0x3f0 [btrfs]
>> CPU: 2 PID: 32570 Comm: rm Not tainted 4.5.0-think+ #14
>> ffffffffc039baf9 00000000ef721ef0 ffff88025966fc08 ffffffff8957bcdb
>> 0000000000000000 0000000000000000 ffff88025966fc50 ffffffff890b41f1
>> ffff88045d918040 0000242d4eed6048 ffff88024eed6048 ffff88024eed6048
>> Call Trace:
>> [<ffffffffc039baf9>] ? btrfs_destroy_inode+0x389/0x3f0 [btrfs]
>> [<ffffffff8957bcdb>] dump_stack+0x68/0x9d
>> [<ffffffff890b41f1>] __warn+0x111/0x130
>> [<ffffffff890b43fd>] warn_slowpath_null+0x1d/0x20
>> [<ffffffffc039baf9>] btrfs_destroy_inode+0x389/0x3f0 [btrfs]
>> [<ffffffff89352307>] destroy_inode+0x67/0x90
>> [<ffffffff893524e7>] evict+0x1b7/0x240
>> [<ffffffff893529be>] iput+0x3ae/0x4e0
>> [<ffffffff8934c93e>] ? dput+0x20e/0x460
>> [<ffffffff8933ee26>] do_unlinkat+0x256/0x440
>> [<ffffffff8933ebd0>] ? do_rmdir+0x350/0x350
>> [<ffffffff890031e7>] ? syscall_trace_enter_phase1+0x87/0x260
>> [<ffffffff89003160>] ? enter_from_user_mode+0x50/0x50
>> [<ffffffff8913c3b5>] ? __lock_is_held+0x25/0xd0
>> [<ffffffff891411f2>] ? mark_held_locks+0x22/0xc0
>> [<ffffffff890034ed>] ? syscall_trace_enter_phase2+0x12d/0x3d0
>> [<ffffffff893400b0>] ? SyS_rmdir+0x20/0x20
>> [<ffffffff893400cb>] SyS_unlinkat+0x1b/0x30
>> [<ffffffff89003ac4>] do_syscall_64+0xf4/0x240
>> [<ffffffff89d520da>] entry_SYSCALL64_slow_path+0x25/0x25
>> ---[ end trace a48ce4e6a1b5e409 ]---
>>
>>
>> That's WARN_ON(BTRFS_I(inode)->csum_bytes);
>>
>> *maybe* it's a bad disk, but there's no indication in dmesg of anything awry.
>> Spinning rust on SATA, nothing special.
>
> Same thing here:
>
> Mar 24 10:37:27 x4 kernel: ------------[ cut here ]------------
> Mar 24 10:37:27 x4 kernel: WARNING: CPU: 3 PID: 11838 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0x22b/0x2a0
> Mar 24 10:37:27 x4 kernel: CPU: 3 PID: 11838 Comm: rm Not tainted 4.5.0-11787-ga24e3d414e59-dirty #64
> Mar 24 10:37:27 x4 kernel: Hardware name: System manufacturer System Product Name/M4A78T-E, BIOS 3503 04/13/2011
> Mar 24 10:37:27 x4 kernel: 0000000000000000 ffffffff813c0d1a ffffffff81b8bb84 ffffffff812ffd0b
> Mar 24 10:37:27 x4 kernel: ffffffff81099a9a 0000000000000000 ffff880149b86088 ffff88021585f000
> Mar 24 10:37:27 x4 kernel: ffffffff812ffd0b 0000000000000000 ffff88005f526000 0000000000000000
> Mar 24 10:37:27 x4 kernel: Call Trace:
> Mar 24 10:37:27 x4 kernel: [<ffffffff813c0d1a>] ? dump_stack+0x46/0x6c
> Mar 24 10:37:27 x4 kernel: [<ffffffff812ffd0b>] ? btrfs_destroy_inode+0x22b/0x2a0
> Mar 24 10:37:27 x4 kernel: [<ffffffff81099a9a>] ? warn_slowpath_null+0x5a/0xe0
> Mar 24 10:37:27 x4 kernel: [<ffffffff812ffd0b>] ? btrfs_destroy_inode+0x22b/0x2a0
> Mar 24 10:37:27 x4 kernel: [<ffffffff811ab31c>] ? do_unlinkat+0x13c/0x3e0
> Mar 24 10:37:27 x4 kernel: [<ffffffff810930db>] ? entry_SYSCALL_64_fastpath+0x13/0x8f
> Mar 24 10:37:27 x4 kernel: ---[ end trace e9bae5be848e7a9e ]---
>
I saw this running some xfstests on our internal kernels but haven't
been able to reproduce it on my latest enospc work (which is obviously
perfect). What were you doing when you tripped this? I'd like to see
if I actually did fix it or if I still need to run it down. Thanks,
Josef
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs_destroy_inode WARN_ON.
2016-03-28 14:05 ` Josef Bacik
@ 2016-03-28 14:14 ` Markus Trippelsdorf
2016-04-26 1:40 ` Adam Borowski
0 siblings, 1 reply; 8+ messages in thread
From: Markus Trippelsdorf @ 2016-03-28 14:14 UTC (permalink / raw)
To: Josef Bacik
Cc: Dave Jones, Linux Kernel, Chris Mason, David Sterba, linux-btrfs
On 2016.03.28 at 10:05 -0400, Josef Bacik wrote:
> >Mar 24 10:37:27 x4 kernel: WARNING: CPU: 3 PID: 11838 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0x22b/0x2a0
>
> I saw this running some xfstests on our internal kernels but haven't been
> able to reproduce it on my latest enospc work (which is obviously perfect).
> What were you doing when you tripped this? I'd like to see if I actually
> did fix it or if I still need to run it down. Thanks,
I cannot really tell. Looking at the backtrace, both Dave and I were
running rm.
This warning happened just once on my machine, so the issue is obviously
very hard to trigger.
--
Markus
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs_destroy_inode WARN_ON.
2016-03-28 1:14 ` Dave Jones
@ 2016-04-01 18:12 ` Dave Jones
2016-04-01 18:18 ` Dave Jones
0 siblings, 1 reply; 8+ messages in thread
From: Dave Jones @ 2016-04-01 18:12 UTC (permalink / raw)
To: Linux Kernel, Chris Mason, Josef Bacik, David Sterba, linux-btrfs
On Sun, Mar 27, 2016 at 09:14:00PM -0400, Dave Jones wrote:
> > WARNING: CPU: 2 PID: 32570 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0x389/0x3f0 [btrfs]
> > CPU: 2 PID: 32570 Comm: rm Not tainted 4.5.0-think+ #14
> > ffffffffc039baf9 00000000ef721ef0 ffff88025966fc08 ffffffff8957bcdb
> > 0000000000000000 0000000000000000 ffff88025966fc50 ffffffff890b41f1
> > ffff88045d918040 0000242d4eed6048 ffff88024eed6048 ffff88024eed6048
> > Call Trace:
> > [<ffffffffc039baf9>] ? btrfs_destroy_inode+0x389/0x3f0 [btrfs]
> > [<ffffffff8957bcdb>] dump_stack+0x68/0x9d
> > [<ffffffff890b41f1>] __warn+0x111/0x130
> > [<ffffffff890b43fd>] warn_slowpath_null+0x1d/0x20
> > [<ffffffffc039baf9>] btrfs_destroy_inode+0x389/0x3f0 [btrfs]
> > [<ffffffff89352307>] destroy_inode+0x67/0x90
> > [<ffffffff893524e7>] evict+0x1b7/0x240
> > [<ffffffff893529be>] iput+0x3ae/0x4e0
> > [<ffffffff8934c93e>] ? dput+0x20e/0x460
> > [<ffffffff8933ee26>] do_unlinkat+0x256/0x440
> > [<ffffffff8933ebd0>] ? do_rmdir+0x350/0x350
> > [<ffffffff890031e7>] ? syscall_trace_enter_phase1+0x87/0x260
> > [<ffffffff89003160>] ? enter_from_user_mode+0x50/0x50
> > [<ffffffff8913c3b5>] ? __lock_is_held+0x25/0xd0
> > [<ffffffff891411f2>] ? mark_held_locks+0x22/0xc0
> > [<ffffffff890034ed>] ? syscall_trace_enter_phase2+0x12d/0x3d0
> > [<ffffffff893400b0>] ? SyS_rmdir+0x20/0x20
> > [<ffffffff893400cb>] SyS_unlinkat+0x1b/0x30
> > [<ffffffff89003ac4>] do_syscall_64+0xf4/0x240
> > [<ffffffff89d520da>] entry_SYSCALL64_slow_path+0x25/0x25
> > ---[ end trace a48ce4e6a1b5e409 ]---
> >
> > That's WARN_ON(BTRFS_I(inode)->csum_bytes);
> >
> > *maybe* it's a bad disk, but there's no indication in dmesg of anything awry.
> > Spinning rust on SATA, nothing special.
>
> Same WARN_ON is reachable from umount too..
>
> WARNING: CPU: 2 PID: 20092 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0x40c/0x480 [btrfs]
> CPU: 2 PID: 20092 Comm: umount Tainted: G W 4.5.0-think+ #1
> 00000000ffffffff 00000000a32c482b ffff8803cd187b60 ffffffff9d63af84
> 0000000000000000 0000000000000000 ffffffffc05c5e40 ffffffffc04d316c
> ffff8803cd187ba8 ffffffff9d0c4c27 ffff880460d80040 0000242dcd187bb0
> Call Trace:
> [<ffffffff9d63af84>] dump_stack+0x95/0xe1
> [<ffffffffc04d316c>] ? btrfs_destroy_inode+0x40c/0x480 [btrfs]
> [<ffffffff9d0c4c27>] __warn+0x147/0x170
> [<ffffffff9d0c4e91>] warn_slowpath_null+0x31/0x40
> [<ffffffffc04d316c>] btrfs_destroy_inode+0x40c/0x480 [btrfs]
> [<ffffffffc04d2d60>] ? btrfs_test_destroy_inode+0x40/0x40 [btrfs]
> [<ffffffff9d3bf7e7>] destroy_inode+0x77/0xb0
> [<ffffffff9d3bfa2e>] evict+0x20e/0x2c0
> [<ffffffff9d3bfb50>] dispose_list+0x70/0xb0
> [<ffffffff9d3c14ef>] evict_inodes+0x26f/0x2c0
> [<ffffffff9d3c1280>] ? inode_add_lru+0x60/0x60
> [<ffffffff9d40baa5>] ? fsnotify_unmount_inodes+0x215/0x2c0
> [<ffffffff9d38e336>] generic_shutdown_super+0x76/0x1c0
> [<ffffffff9d38e899>] kill_anon_super+0x29/0x40
> [<ffffffffc044c421>] btrfs_kill_super+0x31/0x130 [btrfs]
> [<ffffffff9d38ec1f>] deactivate_locked_super+0x6f/0xb0
> [<ffffffff9d38f2c9>] deactivate_super+0x99/0xb0
> [<ffffffff9d3c8610>] cleanup_mnt+0x70/0xd0
> [<ffffffff9d3c86db>] __cleanup_mnt+0x1b/0x20
> [<ffffffff9d103d1f>] task_work_run+0xef/0x130
> [<ffffffff9d0023c9>] exit_to_usermode_loop+0xf9/0x100
> [<ffffffff9d004068>] do_syscall_64+0x238/0x2b0
> [<ffffffff9df3831a>] entry_SYSCALL64_slow_path+0x25/0x25
Additional fallout:
BTRFS: assertion failed: num_extents, file: fs/btrfs/extent-tree.c, line: 5584
------------[ cut here ]------------
kernel BUG at fs/btrfs/ctree.h:4320!
invalid opcode: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC KASAN
CPU: 1 PID: 18815 Comm: trinity-c13 Tainted: G W 4.6.0-rc1-think+ #1
task: ffff88045de10040 ti: ffff8803afa38000 task.ti: ffff8803afa38000
RIP: 0010:[<ffffffffc045caf3>] [<ffffffffc045caf3>] assfail.constprop.88+0x2b/0x2d [btrfs]
RSP: 0018:ffff8803afa3f838 EFLAGS: 00010282
RAX: 000000000000004e RBX: ffffffffc046e200 RCX: 0000000000000000
RDX: 0000000000000000 RSI: 0000000000000003 RDI: ffffed0075f47efb
RBP: ffff8803afa3f848 R08: 0000000000000001 R09: 0000000000000001
R10: 0000000000000000 R11: 0000000000000001 R12: 00000000000015d0
R13: ffff8803fda0e048 R14: ffff8803fda0dc38 R15: ffff8803fda0dc58
FS: 00007fa0566d6700(0000) GS:ffff880468a00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fa0566d9000 CR3: 0000000333bc4000 CR4: 00000000001406e0
DR0: 00007fa0554fb000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000600
Stack:
0000000000000000 ffff8803fda0e048 ffff8803afa3f880 ffffffffc032288b
0000000000000000 ffff880460bb33f8 ffff8803fda0e048 ffff8803fda0dc38
ffff8803fda0dc58 ffff8803afa3f8c8 ffffffffc032f851 0000000000000001
Call Trace:
[<ffffffffc032288b>] drop_outstanding_extent+0x10b/0x130 [btrfs]
[<ffffffffc032f851>] btrfs_delalloc_release_metadata+0x71/0x480 [btrfs]
[<ffffffffc03879bf>] ? __btrfs_buffered_write+0xa6f/0xb50 [btrfs]
[<ffffffffc032fc87>] btrfs_delalloc_release_space+0x27/0x50 [btrfs]
[<ffffffffc0387978>] __btrfs_buffered_write+0xa28/0xb50 [btrfs]
[<ffffffffc0386f50>] ? btrfs_dirty_pages+0x1c0/0x1c0 [btrfs]
[<ffffffff982bb6fe>] ? filemap_fdatawait_range+0x3e/0x50
[<ffffffff982c16a7>] ? generic_file_direct_write+0x237/0x2f0
[<ffffffff982c1470>] ? filemap_write_and_wait_range+0xa0/0xa0
[<ffffffffc038dc00>] ? btrfs_file_write_iter+0x670/0x9a0 [btrfs]
[<ffffffffc038dcdd>] btrfs_file_write_iter+0x74d/0x9a0 [btrfs]
[<ffffffff983886e3>] do_iter_readv_writev+0x153/0x1f0
[<ffffffffc038d590>] ? btrfs_sync_file+0x920/0x920 [btrfs]
[<ffffffff98388590>] ? vfs_iter_read+0x1e0/0x1e0
[<ffffffff98112179>] ? preempt_count_sub+0xb9/0x130
[<ffffffff98154577>] ? percpu_down_read+0x57/0xa0
[<ffffffff9838f94e>] ? __sb_start_write+0xee/0x130
[<ffffffffc038d590>] ? btrfs_sync_file+0x920/0x920 [btrfs]
[<ffffffff9838a09f>] do_readv_writev+0x30f/0x460
[<ffffffff98389d90>] ? vfs_write+0x2b0/0x2b0
[<ffffffff9815be00>] ? debug_check_no_locks_freed+0x1b0/0x1b0
[<ffffffff98256a5d>] ? trace_preempt_off+0x3d/0x1c0
[<ffffffff9815ed67>] ? lock_release+0x547/0x8f0
[<ffffffff98674c7b>] ? check_preemption_disabled+0x3b/0x160
[<ffffffff982568bd>] ? trace_preempt_on+0x3d/0x1a0
[<ffffffff98112179>] ? preempt_count_sub+0xb9/0x130
[<ffffffff982b886b>] ? __context_tracking_exit.part.5+0x9b/0x2b0
[<ffffffff9800347c>] ? syscall_trace_enter_phase1+0xbc/0x2a0
[<ffffffff9838a638>] vfs_writev+0x78/0xa0
[<ffffffff9838a967>] do_pwritev+0x117/0x140
[<ffffffff9838c9f0>] ? SyS_preadv2+0x80/0x80
[<ffffffff9838ca25>] SyS_pwritev+0x35/0x40
[<ffffffff98003f33>] do_syscall_64+0x103/0x2b0
[<ffffffff98f3881a>] entry_SYSCALL64_slow_path+0x25/0x25
Code: 55 48 89 e5 41 54 41 89 f4 53 48 89 fb e8 e6 95 da d7 44 89 e1 48 89 de 48 c7 c2 60 de 46 c0 48 c7 c7 a0 e1 46 c0 e8 fc d5 e5 d7 <0f> 0b 55 48 89 e5 41 57 45 89 c7 41 56 49 89 ce 41 55 49 89 d5
RIP [<ffffffffc045caf3>] assfail.constprop.88+0x2b/0x2d [btrfs]
RSP <ffff8803afa3f838>
---[ end trace 40e67d85fcda7cb2 ]---
BUG: workqueue lockup - pool cpus=1 node=0 flags=0x0 nice=0 stuck for 30s!
Showing busy workqueues and worker pools:
workqueue events: flags=0x0
pwq 6: cpus=3 node=0 flags=0x0 nice=0 active=1/256
pending: vmstat_shepherd
pwq 4: cpus=2 node=0 flags=0x0 nice=0 active=1/256
pending: check_corruption
pwq 2: cpus=1 node=0 flags=0x0 nice=0 active=3/256
pending: usb_serial_port_work, lru_add_drain_per_cpu BAR(17230), e1000_watchdog_task
workqueue events_power_efficient: flags=0x82
pwq 8: cpus=0-3 flags=0x4 nice=0 active=3/256
pending: fb_flashcursor, neigh_periodic_work, neigh_periodic_work
workqueue events_freezable_power_: flags=0x86
pwq 8: cpus=0-3 flags=0x4 nice=0 active=1/256
pending: disk_events_workfn
workqueue netns: flags=0x6000a
pwq 8: cpus=0-3 flags=0x4 nice=0 active=1/1
in-flight: 10038:cleanup_net
workqueue writeback: flags=0x4e
pwq 8: cpus=0-3 flags=0x4 nice=0 active=2/256
pending: wb_workfn, wb_workfn
workqueue kblockd: flags=0x18
pwq 3: cpus=1 node=0 flags=0x0 nice=-20 active=2/256
pending: blk_mq_timeout_work, blk_mq_timeout_work
workqueue vmstat: flags=0xc
pwq 4: cpus=2 node=0 flags=0x0 nice=0 active=1/256
pending: vmstat_update
pwq 2: cpus=1 node=0 flags=0x0 nice=0 active=1/256
pending: vmstat_update
pwq 0: cpus=0 node=0 flags=0x0 nice=0 active=1/256
pending: vmstat_update
pool 8: cpus=0-3 flags=0x4 nice=0 hung=0s workers=11 idle: 11638 10276 609 17937 606 9237 605 891 15998 14100
note: trinity-c13[18815] exited with preempt_count 1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs_destroy_inode WARN_ON.
2016-04-01 18:12 ` Dave Jones
@ 2016-04-01 18:18 ` Dave Jones
0 siblings, 0 replies; 8+ messages in thread
From: Dave Jones @ 2016-04-01 18:18 UTC (permalink / raw)
To: Linux Kernel, Chris Mason, Josef Bacik, David Sterba, linux-btrfs
On Fri, Apr 01, 2016 at 02:12:27PM -0400, Dave Jones wrote:
> BUG: workqueue lockup - pool cpus=1 node=0 flags=0x0 nice=0 stuck for 30s!
> Showing busy workqueues and worker pools:
> workqueue events: flags=0x0
> pwq 6: cpus=3 node=0 flags=0x0 nice=0 active=1/256
> pending: vmstat_shepherd
> pwq 4: cpus=2 node=0 flags=0x0 nice=0 active=1/256
> pending: check_corruption
> pwq 2: cpus=1 node=0 flags=0x0 nice=0 active=3/256
> pending: usb_serial_port_work, lru_add_drain_per_cpu BAR(17230), e1000_watchdog_task
> workqueue events_power_efficient: flags=0x82
> pwq 8: cpus=0-3 flags=0x4 nice=0 active=3/256
> pending: fb_flashcursor, neigh_periodic_work, neigh_periodic_work
> workqueue events_freezable_power_: flags=0x86
> pwq 8: cpus=0-3 flags=0x4 nice=0 active=1/256
> pending: disk_events_workfn
> workqueue netns: flags=0x6000a
> pwq 8: cpus=0-3 flags=0x4 nice=0 active=1/1
> in-flight: 10038:cleanup_net
> workqueue writeback: flags=0x4e
> pwq 8: cpus=0-3 flags=0x4 nice=0 active=2/256
> pending: wb_workfn, wb_workfn
> workqueue kblockd: flags=0x18
> pwq 3: cpus=1 node=0 flags=0x0 nice=-20 active=2/256
> pending: blk_mq_timeout_work, blk_mq_timeout_work
> workqueue vmstat: flags=0xc
> pwq 4: cpus=2 node=0 flags=0x0 nice=0 active=1/256
> pending: vmstat_update
> pwq 2: cpus=1 node=0 flags=0x0 nice=0 active=1/256
> pending: vmstat_update
> pwq 0: cpus=0 node=0 flags=0x0 nice=0 active=1/256
> pending: vmstat_update
> pool 8: cpus=0-3 flags=0x4 nice=0 hung=0s workers=11 idle: 11638 10276 609 17937 606 9237 605 891 15998 14100
> note: trinity-c13[18815] exited with preempt_count 1
This has wedged userspace too:
23082 pts/2 SN+ 0:00 | \_ /bin/bash scripts/test-multi.sh
14140 pts/2 SNL+ 0:15 | \_ ../trinity -q -l off -N 1000000 -a64 -x fsync -x fdatasync
16900 ? DNs 0:04 | \_ ../trinity -q -l off -N 1000000 -a64 -x fsync -x fdata
18894 ? DNs 0:02 | \_ ../trinity -q -l off -N 1000000 -a64 -x fsync -x fdata
(14:16:02:davej@think:trinity[master])$ stack 16900
[<ffffffff982c1fb6>] wait_on_page_bit_killable+0x156/0x1b0
[<ffffffff982c3182>] __lock_page_or_retry+0x112/0x1b0
[<ffffffff982c3587>] filemap_fault+0x367/0xb30
[<ffffffff983194a7>] __do_fault+0x167/0x3d0
[<ffffffff983216b7>] handle_mm_fault+0x1837/0x2520
[<ffffffff9807e1e8>] __do_page_fault+0x248/0x770
[<ffffffff9807e749>] do_page_fault+0x39/0xa0
[<ffffffff98f3a49f>] page_fault+0x1f/0x30
[<ffffffff980bf9fc>] mm_release+0x1ec/0x230
[<ffffffff980c9370>] do_exit+0x5d0/0x18c0
[<ffffffff980cce5c>] do_group_exit+0xac/0x190
[<ffffffff980e537f>] get_signal+0x48f/0xeb0
[<ffffffff9802ee40>] do_signal+0xa0/0xb50
[<ffffffff980023a9>] exit_to_usermode_loop+0xd9/0x100
[<ffffffff98004068>] do_syscall_64+0x238/0x2b0
[<ffffffff98f3881a>] return_from_SYSCALL_64+0x0/0x7a
[<ffffffffffffffff>] 0xffffffffffffffff
(14:16:09:davej@think:trinity[master])$ stack 18894
[<ffffffffc038d678>] btrfs_file_write_iter+0xe8/0x9a0 [btrfs]
[<ffffffff98387e69>] __vfs_write+0x279/0x2e0
[<ffffffff98389bfe>] vfs_write+0x11e/0x2b0
[<ffffffff9838c342>] SyS_write+0xd2/0x1a0
[<ffffffff98003f33>] do_syscall_64+0x103/0x2b0
[<ffffffff98f3881a>] return_from_SYSCALL_64+0x0/0x7a
[<ffffffffffffffff>] 0xffffffffffffffff
I tried to ftrace the latter process, and the box completely hung.
Dave
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: btrfs_destroy_inode WARN_ON.
2016-03-28 14:14 ` Markus Trippelsdorf
@ 2016-04-26 1:40 ` Adam Borowski
0 siblings, 0 replies; 8+ messages in thread
From: Adam Borowski @ 2016-04-26 1:40 UTC (permalink / raw)
To: Markus Trippelsdorf
Cc: Josef Bacik, Dave Jones, Chris Mason, David Sterba, linux-btrfs
On Mon, Mar 28, 2016 at 04:14:46PM +0200, Markus Trippelsdorf wrote:
> On 2016.03.28 at 10:05 -0400, Josef Bacik wrote:
> > >Mar 24 10:37:27 x4 kernel: WARNING: CPU: 3 PID: 11838 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0x22b/0x2a0
> >
> > I saw this running some xfstests on our internal kernels but haven't been
> > able to reproduce it on my latest enospc work (which is obviously perfect).
> > What were you doing when you tripped this? I'd like to see if I actually
> > did fix it or if I still need to run it down. Thanks,
>
> I cannot really tell. Looking at the backtrace, both Dave and I were
> running rm.
> This warning happened just once on my machine, so the issue is obviously
> very hard to trigger.
On the other hand, it seems to be triggering really often (on the order of
~10 mins of light use) on my box. I understandably ran away from 4.6-rc to
stable kernels (no one likes to risk data loss), but even in that little
time it triggered 328 times (over ~20ish boots).
Despite all of these WARNs, there's no data loss yet on the disk in
question, and the filesystem appears consistent.
Call stacks show a variety of callers of btrfs_destroy_inode, originating
from do_unlinkat, SyS_rename, btrfs_ioctl_snap_destroy, shrink_zone, or
task_work_run, direct callers being:
do_unlinkat
__dentry_kill
dput
__dentry_kill
shrink_dentry_list
dispose_list
prune_icache_sb
Just tried 4.6-rc5, it's still there.
Any way I could help debug this?
--
A tit a day keeps the vet away.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-04-26 2:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-24 22:54 btrfs_destroy_inode WARN_ON Dave Jones
2016-03-25 8:25 ` Markus Trippelsdorf
2016-03-28 14:05 ` Josef Bacik
2016-03-28 14:14 ` Markus Trippelsdorf
2016-04-26 1:40 ` Adam Borowski
2016-03-28 1:14 ` Dave Jones
2016-04-01 18:12 ` Dave Jones
2016-04-01 18:18 ` Dave Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.