All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Matthew McClintock <mmcclint@codeaurora.org>
Cc: Rob Herring <robh@kernel.org>,
	andy.gross@linaro.org, linux-arm-msm@vger.kernel.org,
	qca-upstream.external@qca.qualcomm.com,
	linux-watchdog@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding
Date: Mon, 28 Mar 2016 11:15:44 -0700	[thread overview]
Message-ID: <20160328181544.GB29820@roeck-us.net> (raw)
In-Reply-To: <0F389D09-1165-4686-98DF-0265351A086A@codeaurora.org>

On Mon, Mar 28, 2016 at 12:02:47PM -0500, Matthew McClintock wrote:
> On Mar 25, 2016, at 9:15 AM, Rob Herring <robh@kernel.org> wrote:
> > 
> > On Wed, Mar 23, 2016 at 05:05:04PM -0500, Matthew McClintock wrote:
> >> Update the compatible string to add new device tree binding
> >> 
> >> CC: linux-watchdog@vger.kernel.org
> >> Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org>
> >> ---
> >> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 +
> >> 1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> >> index 60bb2f98..45b37cf 100644
> >> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> >> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> >> @@ -6,6 +6,7 @@ Required properties :
> >> 
> >> 			"qcom,kpss-timer"
> >> 			"qcom,scss-timer"
> >> +			"qcom,kpss-standalone"
> > 
> > What SoC(s) is this in. Use SoC specific compatible strings please.
> 
> So ipq4019 wins the race because we are the first to try to enable watchdog for this block?
> 
> qcom,kpss-ipq4019 ?
> 
It is a dedicated watchdog block, isn't it ? "qcom,kpss-ipq4019" would not
refer to a specific block. Devicetree maintainers may have a better idea,
but it seems to me that there should be 'wdt' or 'watchdog' in the property
name.

Guenter

  parent reply	other threads:[~2016-03-28 18:15 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 22:04 [PATCH 00/17] Additional IPQ4019 platform support Matthew McClintock
2016-03-23 22:04 ` [PATCH 01/17] pinctrl: qcom: ipq4019: set ngpios to correct value Matthew McClintock
2016-03-23 22:04   ` Matthew McClintock
2016-03-25 21:19   ` Bjorn Andersson
2016-03-31  9:53   ` Linus Walleij
2016-03-31  9:53     ` Linus Walleij
2016-03-23 22:04 ` [PATCH 02/17] pinctrl: qcom: ipq4019: fix the function enum for gpio mode Matthew McClintock
2016-03-23 22:04   ` Matthew McClintock
2016-03-25 21:22   ` Bjorn Andersson
2016-03-31  9:55   ` Linus Walleij
2016-03-31  9:55     ` Linus Walleij
2016-03-23 22:04 ` [PATCH 03/17] pinctrl: qcom: ipq4019: fix register offsets Matthew McClintock
2016-03-23 22:04   ` Matthew McClintock
2016-03-25 21:31   ` Bjorn Andersson
2016-03-31  9:57   ` Linus Walleij
2016-03-23 22:04 ` [PATCH 04/17] clk: qcom: ipq4019: switch remaining defines to enums Matthew McClintock
2016-03-23 22:04   ` Matthew McClintock
2016-03-29 23:31   ` Stephen Boyd
2016-03-23 22:05 ` [PATCH 05/17] clk: qcom: ipq4019: add some fixed clocks for ddrppl and fepll Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-29 23:31   ` Stephen Boyd
     [not found] ` <1458770712-10880-1-git-send-email-mmcclint-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-23 22:05   ` [PATCH 06/17] watchdog: qcom: update device tree bindings Matthew McClintock
2016-03-23 22:05     ` Matthew McClintock
2016-03-23 22:26     ` Stephen Boyd
2016-03-23 22:26       ` Stephen Boyd
2016-03-24 15:49       ` Matthew McClintock
2016-03-24 15:49         ` Matthew McClintock
     [not found]     ` <1458770712-10880-7-git-send-email-mmcclint-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-25 14:13       ` Rob Herring
2016-03-25 14:13         ` Rob Herring
2016-03-25 14:13         ` Rob Herring
2016-03-23 22:05   ` [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding Matthew McClintock
2016-03-23 22:05     ` Matthew McClintock
2016-03-25 14:15     ` Rob Herring
2016-03-25 14:15       ` Rob Herring
2016-03-28 17:02       ` Matthew McClintock
2016-03-28 17:02         ` Matthew McClintock
2016-03-28 17:26         ` Rob Herring
2016-03-28 17:26           ` Rob Herring
2016-03-28 18:15         ` Guenter Roeck [this message]
2016-03-28 18:15           ` Guenter Roeck
     [not found]           ` <20160328181544.GB29820-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-03-28 22:22             ` Matthew McClintock
2016-03-28 22:22               ` Matthew McClintock
2016-03-28 22:22               ` Matthew McClintock
2016-03-23 22:05   ` [PATCH 15/17] qcom: ipq4019: add cpu operating points for cpufreq support Matthew McClintock
2016-03-23 22:05     ` Matthew McClintock
2016-03-23 22:05     ` Matthew McClintock
     [not found]     ` <1458770712-10880-16-git-send-email-mmcclint-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-23 22:33       ` Stephen Boyd
2016-03-23 22:33         ` Stephen Boyd
2016-03-23 22:33         ` Stephen Boyd
2017-03-22 14:10     ` [15/17] " Sven Eckelmann
2017-03-22 14:10       ` Sven Eckelmann
2016-03-23 22:05 ` [PATCH 07/17] watchdog: qcom: add option for standalone watchdog not in timer block Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
     [not found]   ` <1458770712-10880-8-git-send-email-mmcclint-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-23 22:40     ` Stephen Boyd
2016-03-23 22:40       ` Stephen Boyd
2016-03-25 16:23     ` Guenter Roeck
2016-03-25 16:23       ` Guenter Roeck
     [not found]       ` <20160325162326.GA25767-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-03-28 16:55         ` Matthew McClintock
2016-03-28 16:55           ` Matthew McClintock
     [not found]           ` <D54FA5B6-F170-40D3-BF0D-60D40A2C2829-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-28 18:13             ` Guenter Roeck
2016-03-28 18:13               ` Guenter Roeck
2016-03-28 18:13               ` Guenter Roeck
2016-03-28 20:40               ` Matthew McClintock
2016-03-28 20:40                 ` Matthew McClintock
2016-03-28 21:56                 ` Guenter Roeck
     [not found]                   ` <20160328215638.GA25221-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-03-28 22:21                     ` Matthew McClintock
2016-03-28 22:21                       ` Matthew McClintock
2016-03-28 22:21                       ` Matthew McClintock
2016-03-23 22:05 ` [PATCH 08/17] watchdog: qcom: configure BARK time in addition to BITE time Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
     [not found]   ` <1458770712-10880-9-git-send-email-mmcclint-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-23 22:42     ` Stephen Boyd
2016-03-23 22:42       ` Stephen Boyd
2016-03-24 15:46       ` Matthew McClintock
2016-03-24 15:46         ` Matthew McClintock
2016-03-24 16:17         ` Guenter Roeck
2016-03-24 19:49           ` Matthew McClintock
2016-03-24 19:49             ` Matthew McClintock
2016-04-07  7:02     ` Guenter Roeck
2016-04-07  7:02       ` Guenter Roeck
2016-03-23 22:05 ` [PATCH 10/17] qcom: ipq4019: add watchdog node to ipq4019 SoC and DK01 device tree Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-23 22:05 ` [PATCH 11/17] qcom: ipq4019: add support for reset via qcom,ps-hold Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-23 22:05 ` [PATCH 12/17] qcom: ipq4019: add spi node to ipq4019 SoC and DK01 device tree Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-23 22:05 ` [PATCH 13/17] qcom: ipq4019: add i2c " Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-23 22:05 ` [PATCH 14/17] cpufreq: ipq4019: add cpufreq driver Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-24  6:44   ` Viresh Kumar
2016-03-24 15:42     ` Matthew McClintock
2016-03-23 22:05 ` [PATCH 16/17] qcom: ipq4019: add crypto nodes to ipq4019 SoC and DK01 device tree Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-23 22:05 ` [PATCH 17/17] qcom: ipq4019: add DMA " Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock
2016-03-23 22:05   ` Matthew McClintock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160328181544.GB29820@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=andy.gross@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mmcclint@codeaurora.org \
    --cc=pawel.moll@arm.com \
    --cc=qca-upstream.external@qca.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.