All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH 6/8] rtc: m41t80: add alarm functionality (fwd)
@ 2016-03-29  9:20 ` Julia Lawall
  0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2016-03-29  9:20 UTC (permalink / raw)
  To: Mylène Josserand
  Cc: kbuild-all, alexandre.belloni, rtc-linux, Alessandro Zummo, linux-kernel

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2561 bytes --]

It looks suspicious.  Please check.

thanks,
julia

---------- Forwarded message ----------
Date: Tue, 29 Mar 2016 15:36:02 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH 6/8] rtc: m41t80: add alarm functionality

CC: kbuild-all@01.org
In-Reply-To: <1932c2b8c5f0c5d89c0578c300c9e18a283e8df0.1459233897.git.mylene.josserand@free-electrons.com>
TO: "Mylène Josserand" <mylene.josserand@free-electrons.com>
CC: alexandre.belloni@free-electrons.com, rtc-linux@googlegroups.com
CC: Alessandro Zummo <a.zummo@towertech.it>, linux-kernel@vger.kernel.org, mylene.josserand@free-electrons.com

Hi Mylène,

[auto build test WARNING on abelloni/rtc-next]
[also build test WARNING on v4.6-rc1 next-20160329]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Myl-ne-Josserand/rtc-m41t80-update-sysfs-entries-export/20160329-150848
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
:::::: branch date: 27 minutes ago
:::::: commit date: 27 minutes ago

>> drivers/rtc/rtc-m41t80.c:105:2-8: preceding lock on line 101

git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 41be232d1b3079b5d675eea5e95fd7ab39c2a1b2
vim +105 drivers/rtc/rtc-m41t80.c

41be232d Mylène Josserand 2016-03-29   95  	struct i2c_client *client = dev_id;
41be232d Mylène Josserand 2016-03-29   96  	struct m41t80_data *m41t80 = i2c_get_clientdata(client);
41be232d Mylène Josserand 2016-03-29   97  	struct mutex *lock = &m41t80->rtc->ops_lock;
41be232d Mylène Josserand 2016-03-29   98  	unsigned long events = 0;
41be232d Mylène Josserand 2016-03-29   99  	int flags, flags_afe;
41be232d Mylène Josserand 2016-03-29  100
41be232d Mylène Josserand 2016-03-29 @101  	mutex_lock(lock);
41be232d Mylène Josserand 2016-03-29  102
41be232d Mylène Josserand 2016-03-29  103  	flags_afe = i2c_smbus_read_byte_data(client, M41T80_REG_ALARM_MON);
41be232d Mylène Josserand 2016-03-29  104  	if (flags_afe < 0)
41be232d Mylène Josserand 2016-03-29 @105  		return IRQ_NONE;
41be232d Mylène Josserand 2016-03-29  106
41be232d Mylène Josserand 2016-03-29  107  	flags = i2c_smbus_read_byte_data(client, M41T80_REG_FLAGS);
41be232d Mylène Josserand 2016-03-29  108  	if (flags <= 0)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [rtc-linux] Re: [PATCH 6/8] rtc: m41t80: add alarm functionality (fwd)
@ 2016-03-29  9:20 ` Julia Lawall
  0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2016-03-29  9:20 UTC (permalink / raw)
  To: Mylène Josserand
  Cc: kbuild-all, alexandre.belloni, rtc-linux, Alessandro Zummo, linux-kernel

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2561 bytes --]

It looks suspicious.  Please check.

thanks,
julia

---------- Forwarded message ----------
Date: Tue, 29 Mar 2016 15:36:02 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH 6/8] rtc: m41t80: add alarm functionality

CC: kbuild-all@01.org
In-Reply-To: <1932c2b8c5f0c5d89c0578c300c9e18a283e8df0.1459233897.git.mylene.josserand@free-electrons.com>
TO: "Mylène Josserand" <mylene.josserand@free-electrons.com>
CC: alexandre.belloni@free-electrons.com, rtc-linux@googlegroups.com
CC: Alessandro Zummo <a.zummo@towertech.it>, linux-kernel@vger.kernel.org, mylene.josserand@free-electrons.com

Hi Mylène,

[auto build test WARNING on abelloni/rtc-next]
[also build test WARNING on v4.6-rc1 next-20160329]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Myl-ne-Josserand/rtc-m41t80-update-sysfs-entries-export/20160329-150848
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
:::::: branch date: 27 minutes ago
:::::: commit date: 27 minutes ago

>> drivers/rtc/rtc-m41t80.c:105:2-8: preceding lock on line 101

git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 41be232d1b3079b5d675eea5e95fd7ab39c2a1b2
vim +105 drivers/rtc/rtc-m41t80.c

41be232d Mylène Josserand 2016-03-29   95  	struct i2c_client *client = dev_id;
41be232d Mylène Josserand 2016-03-29   96  	struct m41t80_data *m41t80 = i2c_get_clientdata(client);
41be232d Mylène Josserand 2016-03-29   97  	struct mutex *lock = &m41t80->rtc->ops_lock;
41be232d Mylène Josserand 2016-03-29   98  	unsigned long events = 0;
41be232d Mylène Josserand 2016-03-29   99  	int flags, flags_afe;
41be232d Mylène Josserand 2016-03-29  100
41be232d Mylène Josserand 2016-03-29 @101  	mutex_lock(lock);
41be232d Mylène Josserand 2016-03-29  102
41be232d Mylène Josserand 2016-03-29  103  	flags_afe = i2c_smbus_read_byte_data(client, M41T80_REG_ALARM_MON);
41be232d Mylène Josserand 2016-03-29  104  	if (flags_afe < 0)
41be232d Mylène Josserand 2016-03-29 @105  		return IRQ_NONE;
41be232d Mylène Josserand 2016-03-29  106
41be232d Mylène Josserand 2016-03-29  107  	flags = i2c_smbus_read_byte_data(client, M41T80_REG_FLAGS);
41be232d Mylène Josserand 2016-03-29  108  	if (flags <= 0)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 6/8] rtc: m41t80: add alarm functionality (fwd)
  2016-03-29  9:20 ` [rtc-linux] " Julia Lawall
@ 2016-03-29 10:08   ` Alexandre Belloni
  -1 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2016-03-29 10:08 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Mylène Josserand, kbuild-all, rtc-linux, Alessandro Zummo,
	linux-kernel

Hi Julia,

On 29/03/2016 at 11:20:49 +0200, Julia Lawall wrote :
> It looks suspicious.  Please check.
> 

Yes, Mylène just sent v2 which should solve the issue. Thanks for the
report!


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [rtc-linux] Re: [PATCH 6/8] rtc: m41t80: add alarm functionality (fwd)
@ 2016-03-29 10:08   ` Alexandre Belloni
  0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2016-03-29 10:08 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Mylène Josserand, kbuild-all, rtc-linux, Alessandro Zummo,
	linux-kernel

Hi Julia,

On 29/03/2016 at 11:20:49 +0200, Julia Lawall wrote :
> It looks suspicious.  Please check.
>=20

Yes, Myl=C4=8Dne just sent v2 which should solve the issue. Thanks for the
report!


--=20
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-03-29 10:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-29  9:20 [PATCH 6/8] rtc: m41t80: add alarm functionality (fwd) Julia Lawall
2016-03-29  9:20 ` [rtc-linux] " Julia Lawall
2016-03-29 10:08 ` Alexandre Belloni
2016-03-29 10:08   ` [rtc-linux] " Alexandre Belloni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.