From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linaro-kernel@lists.linaro.org, k.kozlowski@samsung.com,
kgene.kim@samsung.com, heiko@sntech.de, xf@rock-chips.com,
linux-pm@vger.kernel.org, Rafael Wysocki <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, mmcclint@codeaurora.org
Subject: Re: [PATCH V1 Resend 2/3] cpufreq: dt: Add generic platform-device creation support
Date: Tue, 29 Mar 2016 22:06:49 +0530 [thread overview]
Message-ID: <20160329163649.GE14322@vireshk-i7> (raw)
In-Reply-To: <5412084.gVvuDFzkvo@wuerfel>
On 29-03-16, 17:14, Arnd Bergmann wrote:
> On Tuesday 29 March 2016 12:09:48 Viresh Kumar wrote:
> > +config CPUFREQ_DT_PLATDEV
> > + bool
> > + depends on CPUFREQ_DT
>
> The 'depends on' line is redundant as you always 'select' the code
> from CPUFREQ_DT. Since they are always set together, you can also
> just drop the new symbol, or put the new code into the same file.
I would like to keep a separate file for this, it looks awkward to update the
driver for any new user platform.
I added a separate symbol to take care of the Modular case of cpufreq-dt. i.e. I
didn't wanted to add module_exit() code in the new file. Currently, it gets
included in the kernel even if cpufreq-dt is selected as a Module, so we just
create the platform-device just once and never touch it again.
--
viresh
next prev parent reply other threads:[~2016-03-29 16:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 6:39 [PATCH V2 0/3] cpufreq: dt: Create platform device from generic code Viresh Kumar
2016-03-29 6:39 ` [PATCH V1 Resend 1/3] cpufreq: dt: Include types.h from cpufreq-dt.h Viresh Kumar
2016-03-29 6:39 ` [PATCH V1 Resend 2/3] cpufreq: dt: Add generic platform-device creation support Viresh Kumar
2016-03-29 15:14 ` Arnd Bergmann
2016-03-29 16:36 ` Viresh Kumar [this message]
2016-03-29 19:45 ` Arnd Bergmann
2016-03-30 3:22 ` Viresh Kumar
2016-03-30 7:53 ` Arnd Bergmann
2016-04-01 10:23 ` Viresh Kumar
2016-04-01 12:30 ` Mason
2016-04-01 12:52 ` Viresh Kumar
2016-04-01 14:15 ` Rob Herring
2016-04-07 8:30 ` Viresh Kumar
2016-04-18 21:00 ` Arnd Bergmann
2016-03-29 16:42 ` Viresh Kumar
2016-03-29 19:46 ` Arnd Bergmann
2016-03-29 6:39 ` [PATCH V2 3/3] cpufreq: exynos: Use generic platdev driver Viresh Kumar
2016-03-29 6:39 ` Viresh Kumar
2016-03-29 15:04 ` Arnd Bergmann
2016-03-29 15:04 ` Arnd Bergmann
2016-03-29 15:22 ` Viresh Kumar
2016-03-29 15:22 ` Viresh Kumar
2016-03-29 23:46 ` Krzysztof Kozlowski
2016-03-29 23:46 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329163649.GE14322@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=arnd@arndb.de \
--cc=heiko@sntech.de \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mmcclint@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=xf@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.