All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	Rafael Wysocki <rjw@rjwysocki.net>,
	arnd.bergmann@linaro.org, Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	kgene.kim@samsung.com, heiko@sntech.de, xf@rock-chips.com,
	mmcclint@codeaurora.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linaro-kernel@lists.linaro.org
Subject: Re: [PATCH V2 3/3] cpufreq: exynos: Use generic platdev driver
Date: Tue, 29 Mar 2016 17:04:26 +0200	[thread overview]
Message-ID: <3810049.oQlCXiQ5bk@wuerfel> (raw)
In-Reply-To: <81a8da75a0e7783e2b47f9e04297f167e8134afe.1459233524.git.viresh.kumar@linaro.org>

On Tuesday 29 March 2016 12:09:49 Viresh Kumar wrote:
> -static void __init exynos_cpufreq_init(void)
> -{
> -       struct device_node *root = of_find_node_by_path("/");
> -       const struct of_device_id *match;
> -
> -       match = of_match_node(exynos_cpufreq_matches, root);
> -       if (!match) {
> -               platform_device_register_simple("exynos-cpufreq", -1, NULL, 0);
> -               return;
> -       }
> -
> -       platform_device_register_simple(match->data, -1, NULL, 0);
> -}

How is the "exynos-cpufreq" case handled now? Is that no longer used now?
I assume the patch is correct based on Krzysztof's review, but it might be
good to explain this better.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/3] cpufreq: exynos: Use generic platdev driver
Date: Tue, 29 Mar 2016 17:04:26 +0200	[thread overview]
Message-ID: <3810049.oQlCXiQ5bk@wuerfel> (raw)
In-Reply-To: <81a8da75a0e7783e2b47f9e04297f167e8134afe.1459233524.git.viresh.kumar@linaro.org>

On Tuesday 29 March 2016 12:09:49 Viresh Kumar wrote:
> -static void __init exynos_cpufreq_init(void)
> -{
> -       struct device_node *root = of_find_node_by_path("/");
> -       const struct of_device_id *match;
> -
> -       match = of_match_node(exynos_cpufreq_matches, root);
> -       if (!match) {
> -               platform_device_register_simple("exynos-cpufreq", -1, NULL, 0);
> -               return;
> -       }
> -
> -       platform_device_register_simple(match->data, -1, NULL, 0);
> -}

How is the "exynos-cpufreq" case handled now? Is that no longer used now?
I assume the patch is correct based on Krzysztof's review, but it might be
good to explain this better.

	Arnd

  reply	other threads:[~2016-03-29 15:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29  6:39 [PATCH V2 0/3] cpufreq: dt: Create platform device from generic code Viresh Kumar
2016-03-29  6:39 ` [PATCH V1 Resend 1/3] cpufreq: dt: Include types.h from cpufreq-dt.h Viresh Kumar
2016-03-29  6:39 ` [PATCH V1 Resend 2/3] cpufreq: dt: Add generic platform-device creation support Viresh Kumar
2016-03-29 15:14   ` Arnd Bergmann
2016-03-29 16:36     ` Viresh Kumar
2016-03-29 19:45       ` Arnd Bergmann
2016-03-30  3:22         ` Viresh Kumar
2016-03-30  7:53           ` Arnd Bergmann
2016-04-01 10:23             ` Viresh Kumar
2016-04-01 12:30               ` Mason
2016-04-01 12:52                 ` Viresh Kumar
2016-04-01 14:15               ` Rob Herring
2016-04-07  8:30                 ` Viresh Kumar
2016-04-18 21:00                   ` Arnd Bergmann
2016-03-29 16:42     ` Viresh Kumar
2016-03-29 19:46       ` Arnd Bergmann
2016-03-29  6:39 ` [PATCH V2 3/3] cpufreq: exynos: Use generic platdev driver Viresh Kumar
2016-03-29  6:39   ` Viresh Kumar
2016-03-29 15:04   ` Arnd Bergmann [this message]
2016-03-29 15:04     ` Arnd Bergmann
2016-03-29 15:22     ` Viresh Kumar
2016-03-29 15:22       ` Viresh Kumar
2016-03-29 23:46       ` Krzysztof Kozlowski
2016-03-29 23:46         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3810049.oQlCXiQ5bk@wuerfel \
    --to=arnd@arndb.de \
    --cc=arnd.bergmann@linaro.org \
    --cc=heiko@sntech.de \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mmcclint@codeaurora.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    --cc=xf@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.