* Compilation error: ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
@ 2016-03-29 14:12 Marcin Mirosław
2016-03-29 21:01 ` Kent Overstreet
0 siblings, 1 reply; 7+ messages in thread
From: Marcin Mirosław @ 2016-03-29 14:12 UTC (permalink / raw)
To: linux-bcache
Hi again!
Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
Kernel: arch/x86/boot/bzImage is ready (#6)
Building modules, stage 2.
MODPOST 538 modules
ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "pagecache_block_put" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "pagecache_add_get" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "__pagecache_block_get" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "__pagecache_block_put" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "pagecache_block_get" [drivers/md/bcache/bcache.ko] undefined!
scripts/Makefile.modpost:91: polecenia dla obiektu '__modpost' nie
powiodły się
make[1]: *** [__modpost] Błąd 1
Makefile:1108: recipe for target 'modules' failed
make: *** [modules] Error 2
Marcin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Compilation error: ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
2016-03-29 14:12 Compilation error: ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined! Marcin Mirosław
@ 2016-03-29 21:01 ` Kent Overstreet
2016-03-30 7:56 ` Marcin Mirosław
0 siblings, 1 reply; 7+ messages in thread
From: Kent Overstreet @ 2016-03-29 21:01 UTC (permalink / raw)
To: Marcin Mirosław; +Cc: linux-bcache
On Tue, Mar 29, 2016 at 04:12:12PM +0200, Marcin Mirosław wrote:
> Hi again!
> Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
> Kernel: arch/x86/boot/bzImage is ready (#6)
> Building modules, stage 2.
> MODPOST 538 modules
> ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
Thanks, fixed.
Also pushed another small patch for the memory allocation failure in the lz4
code - it ought to work reliably in practice now.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Compilation error: ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
2016-03-29 21:01 ` Kent Overstreet
@ 2016-03-30 7:56 ` Marcin Mirosław
2016-03-30 8:20 ` Kent Overstreet
0 siblings, 1 reply; 7+ messages in thread
From: Marcin Mirosław @ 2016-03-30 7:56 UTC (permalink / raw)
To: Kent Overstreet; +Cc: linux-bcache
W dniu 29.03.2016 o 23:01, Kent Overstreet pisze:
> On Tue, Mar 29, 2016 at 04:12:12PM +0200, Marcin Mirosław wrote:
>> Hi again!
>> Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
>> Kernel: arch/x86/boot/bzImage is ready (#6)
>> Building modules, stage 2.
>> MODPOST 538 modules
>> ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
>
> Thanks, fixed.
>
> Also pushed another small patch for the memory allocation failure in the lz4
> code - it ought to work reliably in practice now.
I didn't expect such fast fix for lz4:)
BTW, I'd like to ask how should I update my working tree via git. I run
git pull in tree to fetch your fix and (again) I got conflict:
git pull
remote: Counting objects: 251, done.
remote: Compressing objects: 100% (52/52), done.
remote: Total 251 (delta 219), reused 231 (delta 199)
Receiving objects: 100% (251/251), 36.73 KiB | 0 bytes/s, done.
Resolving deltas: 100% (219/219), completed with 63 local objects.
From https://evilpiepirate.org/git/linux-bcache
+ 800353d...97951d0 bcache-dev -> origin/bcache-dev (forced update)
+ ad59dfd...eda3e8b bcache-dev-wip -> origin/bcache-dev-wip (forced
update)
Auto-merging mm/filemap.c
CONFLICT (content): Merge conflict in mm/filemap.c
Auto-merging drivers/md/bcache/fs-io.c
CONFLICT (content): Merge conflict in drivers/md/bcache/fs-io.c
Auto-merging drivers/md/bcache/extents.h
CONFLICT (content): Merge conflict in drivers/md/bcache/extents.h
Automatic merge failed; fix conflicts and then commit the result.
How I should update bcache git tree?
Marcin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Compilation error: ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
2016-03-30 7:56 ` Marcin Mirosław
@ 2016-03-30 8:20 ` Kent Overstreet
2016-03-30 9:38 ` Marcin Mirosław
0 siblings, 1 reply; 7+ messages in thread
From: Kent Overstreet @ 2016-03-30 8:20 UTC (permalink / raw)
To: Marcin Mirosław; +Cc: linux-bcache
On Wed, Mar 30, 2016 at 09:56:30AM +0200, Marcin Mirosław wrote:
> W dniu 29.03.2016 o 23:01, Kent Overstreet pisze:
> > On Tue, Mar 29, 2016 at 04:12:12PM +0200, Marcin Mirosław wrote:
> >> Hi again!
> >> Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
> >> Kernel: arch/x86/boot/bzImage is ready (#6)
> >> Building modules, stage 2.
> >> MODPOST 538 modules
> >> ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
> >
> > Thanks, fixed.
> >
> > Also pushed another small patch for the memory allocation failure in the lz4
> > code - it ought to work reliably in practice now.
>
> I didn't expect such fast fix for lz4:)
> BTW, I'd like to ask how should I update my working tree via git. I run
> git pull in tree to fetch your fix and (again) I got conflict:
> git pull
> remote: Counting objects: 251, done.
> remote: Compressing objects: 100% (52/52), done.
> remote: Total 251 (delta 219), reused 231 (delta 199)
> Receiving objects: 100% (251/251), 36.73 KiB | 0 bytes/s, done.
> Resolving deltas: 100% (219/219), completed with 63 local objects.
> From https://evilpiepirate.org/git/linux-bcache
> + 800353d...97951d0 bcache-dev -> origin/bcache-dev (forced update)
> + ad59dfd...eda3e8b bcache-dev-wip -> origin/bcache-dev-wip (forced
> update)
> Auto-merging mm/filemap.c
> CONFLICT (content): Merge conflict in mm/filemap.c
> Auto-merging drivers/md/bcache/fs-io.c
> CONFLICT (content): Merge conflict in drivers/md/bcache/fs-io.c
> Auto-merging drivers/md/bcache/extents.h
> CONFLICT (content): Merge conflict in drivers/md/bcache/extents.h
> Automatic merge failed; fix conflicts and then commit the result.
>
>
> How I should update bcache git tree?
git reset --hard origin/bcache-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Compilation error: ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
2016-03-30 8:20 ` Kent Overstreet
@ 2016-03-30 9:38 ` Marcin Mirosław
2016-03-30 10:14 ` Kent Overstreet
0 siblings, 1 reply; 7+ messages in thread
From: Marcin Mirosław @ 2016-03-30 9:38 UTC (permalink / raw)
To: Kent Overstreet; +Cc: linux-bcache
W dniu 30.03.2016 o 10:20, Kent Overstreet pisze:
> On Wed, Mar 30, 2016 at 09:56:30AM +0200, Marcin Mirosław wrote:
>> W dniu 29.03.2016 o 23:01, Kent Overstreet pisze:
>>> On Tue, Mar 29, 2016 at 04:12:12PM +0200, Marcin Mirosław wrote:
>>>> Hi again!
>>>> Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
>>>> Kernel: arch/x86/boot/bzImage is ready (#6)
>>>> Building modules, stage 2.
>>>> MODPOST 538 modules
>>>> ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
>>>
>>> Thanks, fixed.
>>>
>>> Also pushed another small patch for the memory allocation failure in the lz4
>>> code - it ought to work reliably in practice now.
>>
>> I didn't expect such fast fix for lz4:)
>> BTW, I'd like to ask how should I update my working tree via git. I run
>> git pull in tree to fetch your fix and (again) I got conflict:
>> git pull
>> remote: Counting objects: 251, done.
>> remote: Compressing objects: 100% (52/52), done.
>> remote: Total 251 (delta 219), reused 231 (delta 199)
>> Receiving objects: 100% (251/251), 36.73 KiB | 0 bytes/s, done.
>> Resolving deltas: 100% (219/219), completed with 63 local objects.
>> From https://evilpiepirate.org/git/linux-bcache
>> + 800353d...97951d0 bcache-dev -> origin/bcache-dev (forced update)
>> + ad59dfd...eda3e8b bcache-dev-wip -> origin/bcache-dev-wip (forced
>> update)
>> Auto-merging mm/filemap.c
>> CONFLICT (content): Merge conflict in mm/filemap.c
>> Auto-merging drivers/md/bcache/fs-io.c
>> CONFLICT (content): Merge conflict in drivers/md/bcache/fs-io.c
>> Auto-merging drivers/md/bcache/extents.h
>> CONFLICT (content): Merge conflict in drivers/md/bcache/extents.h
>> Automatic merge failed; fix conflicts and then commit the result.
>>
>>
>> How I should update bcache git tree?
>
> git reset --hard origin/bcache-dev
Hmm, I'm using:
url = https://evilpiepirate.org/git/linux-bcache.git
branch "bcache-dev"
should I expect fix of building in this branch? I'm still at
commit 97951d039d3991d29035390ba5f0497af4e32ca3
bcachefs: fix fallocate + compression
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Compilation error: ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
2016-03-30 9:38 ` Marcin Mirosław
@ 2016-03-30 10:14 ` Kent Overstreet
2016-03-30 13:09 ` Marcin Mirosław
0 siblings, 1 reply; 7+ messages in thread
From: Kent Overstreet @ 2016-03-30 10:14 UTC (permalink / raw)
To: Marcin Mirosław; +Cc: linux-bcache
On Wed, Mar 30, 2016 at 11:38:55AM +0200, Marcin Mirosław wrote:
> W dniu 30.03.2016 o 10:20, Kent Overstreet pisze:
> > On Wed, Mar 30, 2016 at 09:56:30AM +0200, Marcin Mirosław wrote:
> >> W dniu 29.03.2016 o 23:01, Kent Overstreet pisze:
> >>> On Tue, Mar 29, 2016 at 04:12:12PM +0200, Marcin Mirosław wrote:
> >>>> Hi again!
> >>>> Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
> >>>> Kernel: arch/x86/boot/bzImage is ready (#6)
> >>>> Building modules, stage 2.
> >>>> MODPOST 538 modules
> >>>> ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
> >>>
> >>> Thanks, fixed.
> >>>
> >>> Also pushed another small patch for the memory allocation failure in the lz4
> >>> code - it ought to work reliably in practice now.
> >>
> >> I didn't expect such fast fix for lz4:)
> >> BTW, I'd like to ask how should I update my working tree via git. I run
> >> git pull in tree to fetch your fix and (again) I got conflict:
> >> git pull
> >> remote: Counting objects: 251, done.
> >> remote: Compressing objects: 100% (52/52), done.
> >> remote: Total 251 (delta 219), reused 231 (delta 199)
> >> Receiving objects: 100% (251/251), 36.73 KiB | 0 bytes/s, done.
> >> Resolving deltas: 100% (219/219), completed with 63 local objects.
> >> From https://evilpiepirate.org/git/linux-bcache
> >> + 800353d...97951d0 bcache-dev -> origin/bcache-dev (forced update)
> >> + ad59dfd...eda3e8b bcache-dev-wip -> origin/bcache-dev-wip (forced
> >> update)
> >> Auto-merging mm/filemap.c
> >> CONFLICT (content): Merge conflict in mm/filemap.c
> >> Auto-merging drivers/md/bcache/fs-io.c
> >> CONFLICT (content): Merge conflict in drivers/md/bcache/fs-io.c
> >> Auto-merging drivers/md/bcache/extents.h
> >> CONFLICT (content): Merge conflict in drivers/md/bcache/extents.h
> >> Automatic merge failed; fix conflicts and then commit the result.
> >>
> >>
> >> How I should update bcache git tree?
> >
> > git reset --hard origin/bcache-dev
>
>
> Hmm, I'm using:
> url = https://evilpiepirate.org/git/linux-bcache.git
> branch "bcache-dev"
>
> should I expect fix of building in this branch? I'm still at
> commit 97951d039d3991d29035390ba5f0497af4e32ca3
> bcachefs: fix fallocate + compression
yeah, that commit should work - I squashed the fix with the faulty commit,
that's why you got the merge conflicts
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Compilation error: ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
2016-03-30 10:14 ` Kent Overstreet
@ 2016-03-30 13:09 ` Marcin Mirosław
0 siblings, 0 replies; 7+ messages in thread
From: Marcin Mirosław @ 2016-03-30 13:09 UTC (permalink / raw)
To: Kent Overstreet; +Cc: linux-bcache
W dniu 30.03.2016 o 12:14, Kent Overstreet pisze:
> On Wed, Mar 30, 2016 at 11:38:55AM +0200, Marcin Mirosław wrote:
>> W dniu 30.03.2016 o 10:20, Kent Overstreet pisze:
>>> On Wed, Mar 30, 2016 at 09:56:30AM +0200, Marcin Mirosław wrote:
>>>> W dniu 29.03.2016 o 23:01, Kent Overstreet pisze:
>>>>> On Tue, Mar 29, 2016 at 04:12:12PM +0200, Marcin Mirosław wrote:
>>>>>> Hi again!
>>>>>> Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
>>>>>> Kernel: arch/x86/boot/bzImage is ready (#6)
>>>>>> Building modules, stage 2.
>>>>>> MODPOST 538 modules
>>>>>> ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
>>>>>
>>>>> Thanks, fixed.
>>>>>
>>>>> Also pushed another small patch for the memory allocation failure in the lz4
>>>>> code - it ought to work reliably in practice now.
>>>>
>>>> I didn't expect such fast fix for lz4:)
>>>> BTW, I'd like to ask how should I update my working tree via git. I run
>>>> git pull in tree to fetch your fix and (again) I got conflict:
>>>> git pull
>>>> remote: Counting objects: 251, done.
>>>> remote: Compressing objects: 100% (52/52), done.
>>>> remote: Total 251 (delta 219), reused 231 (delta 199)
>>>> Receiving objects: 100% (251/251), 36.73 KiB | 0 bytes/s, done.
>>>> Resolving deltas: 100% (219/219), completed with 63 local objects.
>>>> From https://evilpiepirate.org/git/linux-bcache
>>>> + 800353d...97951d0 bcache-dev -> origin/bcache-dev (forced update)
>>>> + ad59dfd...eda3e8b bcache-dev-wip -> origin/bcache-dev-wip (forced
>>>> update)
>>>> Auto-merging mm/filemap.c
>>>> CONFLICT (content): Merge conflict in mm/filemap.c
>>>> Auto-merging drivers/md/bcache/fs-io.c
>>>> CONFLICT (content): Merge conflict in drivers/md/bcache/fs-io.c
>>>> Auto-merging drivers/md/bcache/extents.h
>>>> CONFLICT (content): Merge conflict in drivers/md/bcache/extents.h
>>>> Automatic merge failed; fix conflicts and then commit the result.
>>>>
>>>>
>>>> How I should update bcache git tree?
>>>
>>> git reset --hard origin/bcache-dev
>>
>>
>> Hmm, I'm using:
>> url = https://evilpiepirate.org/git/linux-bcache.git
>> branch "bcache-dev"
>>
>> should I expect fix of building in this branch? I'm still at
>> commit 97951d039d3991d29035390ba5f0497af4e32ca3
>> bcachefs: fix fallocate + compression
>
> yeah, that commit should work - I squashed the fix with the faulty commit,
> that's why you got the merge conflicts
I still live in svn world with immutable commits;)
Thank you for help. I'm using bcachefs with lz4 since a few hours and I
don't have any problem.
Marcin
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-03-30 13:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-29 14:12 Compilation error: ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined! Marcin Mirosław
2016-03-29 21:01 ` Kent Overstreet
2016-03-30 7:56 ` Marcin Mirosław
2016-03-30 8:20 ` Kent Overstreet
2016-03-30 9:38 ` Marcin Mirosław
2016-03-30 10:14 ` Kent Overstreet
2016-03-30 13:09 ` Marcin Mirosław
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.