* [PATCH 1/7] ARM: dts: armv7-m: add unit name to interrupt-controller
2016-03-29 22:30 ` Joachim Eastwood
@ 2016-03-29 22:30 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Joachim Eastwood, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA,
u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ
Add unit name to nvic to remove the following warning:
Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a reg
or ranges property, but no unit name
Also correct the node name to 'interrupt-controller' while changing the
line.
Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/armv7-m.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/armv7-m.dtsi b/arch/arm/boot/dts/armv7-m.dtsi
index b1ad7cf..16331aa 100644
--- a/arch/arm/boot/dts/armv7-m.dtsi
+++ b/arch/arm/boot/dts/armv7-m.dtsi
@@ -1,7 +1,7 @@
#include "skeleton.dtsi"
/ {
- nvic: nv-interrupt-controller {
+ nvic: interrupt-controller@e000e100 {
compatible = "arm,armv7m-nvic";
interrupt-controller;
#interrupt-cells = <1>;
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 56+ messages in thread* [PATCH 1/7] ARM: dts: armv7-m: add unit name to interrupt-controller
@ 2016-03-29 22:30 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel
Add unit name to nvic to remove the following warning:
Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a reg
or ranges property, but no unit name
Also correct the node name to 'interrupt-controller' while changing the
line.
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
arch/arm/boot/dts/armv7-m.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/armv7-m.dtsi b/arch/arm/boot/dts/armv7-m.dtsi
index b1ad7cf..16331aa 100644
--- a/arch/arm/boot/dts/armv7-m.dtsi
+++ b/arch/arm/boot/dts/armv7-m.dtsi
@@ -1,7 +1,7 @@
#include "skeleton.dtsi"
/ {
- nvic: nv-interrupt-controller {
+ nvic: interrupt-controller at e000e100 {
compatible = "arm,armv7m-nvic";
interrupt-controller;
#interrupt-cells = <1>;
--
2.7.4
^ permalink raw reply related [flat|nested] 56+ messages in thread[parent not found: <1459290646-3592-2-git-send-email-manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 1/7] ARM: dts: armv7-m: add unit name to interrupt-controller
2016-03-29 22:30 ` Joachim Eastwood
@ 2016-04-04 6:05 ` Uwe Kleine-König
-1 siblings, 0 replies; 56+ messages in thread
From: Uwe Kleine-König @ 2016-04-04 6:05 UTC (permalink / raw)
To: Joachim Eastwood
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA
Hello Joachim,
On Wed, Mar 30, 2016 at 12:30:40AM +0200, Joachim Eastwood wrote:
> Add unit name to nvic to remove the following warning:
> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a reg
> or ranges property, but no unit name
>
> Also correct the node name to 'interrupt-controller' while changing the
> line.
>
> Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Looks right,
Acked-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH 1/7] ARM: dts: armv7-m: add unit name to interrupt-controller
@ 2016-04-04 6:05 ` Uwe Kleine-König
0 siblings, 0 replies; 56+ messages in thread
From: Uwe Kleine-König @ 2016-04-04 6:05 UTC (permalink / raw)
To: linux-arm-kernel
Hello Joachim,
On Wed, Mar 30, 2016 at 12:30:40AM +0200, Joachim Eastwood wrote:
> Add unit name to nvic to remove the following warning:
> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a reg
> or ranges property, but no unit name
>
> Also correct the node name to 'interrupt-controller' while changing the
> line.
>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
Looks right,
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 56+ messages in thread
[parent not found: <20160404060558.GY6191-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]
* Re: [PATCH 1/7] ARM: dts: armv7-m: add unit name to interrupt-controller
2016-04-04 6:05 ` Uwe Kleine-König
@ 2016-04-04 6:42 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-04-04 6:42 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
devicetree, Maxime Coquelin, Stefan Agner, Arnd Bergmann
On 4 April 2016 at 08:05, Uwe Kleine-König
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> Hello Joachim,
>
> On Wed, Mar 30, 2016 at 12:30:40AM +0200, Joachim Eastwood wrote:
>> Add unit name to nvic to remove the following warning:
>> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a reg
>> or ranges property, but no unit name
>>
>> Also correct the node name to 'interrupt-controller' while changing the
>> line.
>>
>> Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Looks right,
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Thanks, Uwe.
Unless any of the other Cortex-M platform maintainers (added more CCs)
has any objections I'll take this through the lpc18xx tree. I will
send a pull request to arm-soc with this soon.
regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH 1/7] ARM: dts: armv7-m: add unit name to interrupt-controller
@ 2016-04-04 6:42 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-04-04 6:42 UTC (permalink / raw)
To: linux-arm-kernel
On 4 April 2016 at 08:05, Uwe Kleine-K?nig
<u.kleine-koenig@pengutronix.de> wrote:
> Hello Joachim,
>
> On Wed, Mar 30, 2016 at 12:30:40AM +0200, Joachim Eastwood wrote:
>> Add unit name to nvic to remove the following warning:
>> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a reg
>> or ranges property, but no unit name
>>
>> Also correct the node name to 'interrupt-controller' while changing the
>> line.
>>
>> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> Looks right,
>
> Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Thanks, Uwe.
Unless any of the other Cortex-M platform maintainers (added more CCs)
has any objections I'll take this through the lpc18xx tree. I will
send a pull request to arm-soc with this soon.
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 56+ messages in thread
[parent not found: <CAGhQ9Vxyf1m6mCpFZdfFymA-_PO9KsGuvPaBBrPxxbSEHT9eUA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 1/7] ARM: dts: armv7-m: add unit name to interrupt-controller
2016-04-04 6:42 ` Joachim Eastwood
@ 2016-04-04 6:51 ` Stefan Agner
-1 siblings, 0 replies; 56+ messages in thread
From: Stefan Agner @ 2016-04-04 6:51 UTC (permalink / raw)
To: Joachim Eastwood
Cc: Uwe Kleine-König,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
devicetree, Maxime Coquelin, Arnd Bergmann
On 2016-04-03 23:42, Joachim Eastwood wrote:
> On 4 April 2016 at 08:05, Uwe Kleine-König
> <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
>> Hello Joachim,
>>
>> On Wed, Mar 30, 2016 at 12:30:40AM +0200, Joachim Eastwood wrote:
>>> Add unit name to nvic to remove the following warning:
>>> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a reg
>>> or ranges property, but no unit name
>>>
>>> Also correct the node name to 'interrupt-controller' while changing the
>>> line.
>>>
>>> Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Looks right,
>>
>> Acked-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>
> Thanks, Uwe.
>
>
> Unless any of the other Cortex-M platform maintainers (added more CCs)
> has any objections I'll take this through the lpc18xx tree. I will
> send a pull request to arm-soc with this soon.
Your patch looks right, I agree we should merge yours.
Acked-by: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH 1/7] ARM: dts: armv7-m: add unit name to interrupt-controller
@ 2016-04-04 6:51 ` Stefan Agner
0 siblings, 0 replies; 56+ messages in thread
From: Stefan Agner @ 2016-04-04 6:51 UTC (permalink / raw)
To: linux-arm-kernel
On 2016-04-03 23:42, Joachim Eastwood wrote:
> On 4 April 2016 at 08:05, Uwe Kleine-K?nig
> <u.kleine-koenig@pengutronix.de> wrote:
>> Hello Joachim,
>>
>> On Wed, Mar 30, 2016 at 12:30:40AM +0200, Joachim Eastwood wrote:
>>> Add unit name to nvic to remove the following warning:
>>> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a reg
>>> or ranges property, but no unit name
>>>
>>> Also correct the node name to 'interrupt-controller' while changing the
>>> line.
>>>
>>> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
>> Looks right,
>>
>> Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
>
> Thanks, Uwe.
>
>
> Unless any of the other Cortex-M platform maintainers (added more CCs)
> has any objections I'll take this through the lpc18xx tree. I will
> send a pull request to arm-soc with this soon.
Your patch looks right, I agree we should merge yours.
Acked-by: Stefan Agner <stefan@agner.ch>
--
Stefan
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH 1/7] ARM: dts: armv7-m: add unit name to interrupt-controller
2016-04-04 6:42 ` Joachim Eastwood
@ 2016-04-04 7:30 ` Uwe Kleine-König
-1 siblings, 0 replies; 56+ messages in thread
From: Uwe Kleine-König @ 2016-04-04 7:30 UTC (permalink / raw)
To: Joachim Eastwood
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
devicetree, Maxime Coquelin, Stefan Agner, Arnd Bergmann
Hello Joachim,
On Mon, Apr 04, 2016 at 08:42:48AM +0200, Joachim Eastwood wrote:
> Unless any of the other Cortex-M platform maintainers (added more CCs)
> has any objections I'll take this through the lpc18xx tree. I will
> send a pull request to arm-soc with this soon.
that is fine for me.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH 1/7] ARM: dts: armv7-m: add unit name to interrupt-controller
@ 2016-04-04 7:30 ` Uwe Kleine-König
0 siblings, 0 replies; 56+ messages in thread
From: Uwe Kleine-König @ 2016-04-04 7:30 UTC (permalink / raw)
To: linux-arm-kernel
Hello Joachim,
On Mon, Apr 04, 2016 at 08:42:48AM +0200, Joachim Eastwood wrote:
> Unless any of the other Cortex-M platform maintainers (added more CCs)
> has any objections I'll take this through the lpc18xx tree. I will
> send a pull request to arm-soc with this soon.
that is fine for me.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-29 22:30 ` Joachim Eastwood
@ 2016-03-29 22:30 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Joachim Eastwood, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA
Add unit name to memory to remove the following warning:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges
property, but no unit name
Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/skeleton.dtsi | 2 +-
arch/arm/boot/dts/skeleton64.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/skeleton.dtsi b/arch/arm/boot/dts/skeleton.dtsi
index b41d241..a20da0a 100644
--- a/arch/arm/boot/dts/skeleton.dtsi
+++ b/arch/arm/boot/dts/skeleton.dtsi
@@ -9,5 +9,5 @@
#size-cells = <1>;
chosen { };
aliases { };
- memory { device_type = "memory"; reg = <0 0>; };
+ memory@0 { device_type = "memory"; reg = <0 0>; };
};
diff --git a/arch/arm/boot/dts/skeleton64.dtsi b/arch/arm/boot/dts/skeleton64.dtsi
index b5d7f36..6dbe9f9 100644
--- a/arch/arm/boot/dts/skeleton64.dtsi
+++ b/arch/arm/boot/dts/skeleton64.dtsi
@@ -9,5 +9,5 @@
#size-cells = <2>;
chosen { };
aliases { };
- memory { device_type = "memory"; reg = <0 0 0 0>; };
+ memory@0 { device_type = "memory"; reg = <0 0 0 0>; };
};
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-29 22:30 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel
Add unit name to memory to remove the following warning:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges
property, but no unit name
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
arch/arm/boot/dts/skeleton.dtsi | 2 +-
arch/arm/boot/dts/skeleton64.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/skeleton.dtsi b/arch/arm/boot/dts/skeleton.dtsi
index b41d241..a20da0a 100644
--- a/arch/arm/boot/dts/skeleton.dtsi
+++ b/arch/arm/boot/dts/skeleton.dtsi
@@ -9,5 +9,5 @@
#size-cells = <1>;
chosen { };
aliases { };
- memory { device_type = "memory"; reg = <0 0>; };
+ memory at 0 { device_type = "memory"; reg = <0 0>; };
};
diff --git a/arch/arm/boot/dts/skeleton64.dtsi b/arch/arm/boot/dts/skeleton64.dtsi
index b5d7f36..6dbe9f9 100644
--- a/arch/arm/boot/dts/skeleton64.dtsi
+++ b/arch/arm/boot/dts/skeleton64.dtsi
@@ -9,5 +9,5 @@
#size-cells = <2>;
chosen { };
aliases { };
- memory { device_type = "memory"; reg = <0 0 0 0>; };
+ memory at 0 { device_type = "memory"; reg = <0 0 0 0>; };
};
--
2.7.4
^ permalink raw reply related [flat|nested] 56+ messages in thread[parent not found: <1459290646-3592-3-git-send-email-manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-29 22:30 ` Joachim Eastwood
@ 2016-03-30 10:12 ` Vladimir Zapolskiy
-1 siblings, 0 replies; 56+ messages in thread
From: Vladimir Zapolskiy @ 2016-03-30 10:12 UTC (permalink / raw)
To: Joachim Eastwood, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, devicetree-u79uwXL29TY76Z2rM5mHXA
Hi Joachim,
On 30.03.2016 01:30, Joachim Eastwood wrote:
> Add unit name to memory to remove the following warning:
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
> property, but no unit name
>
> Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/boot/dts/skeleton.dtsi | 2 +-
> arch/arm/boot/dts/skeleton64.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/skeleton.dtsi b/arch/arm/boot/dts/skeleton.dtsi
> index b41d241..a20da0a 100644
> --- a/arch/arm/boot/dts/skeleton.dtsi
> +++ b/arch/arm/boot/dts/skeleton.dtsi
> @@ -9,5 +9,5 @@
> #size-cells = <1>;
> chosen { };
> aliases { };
> - memory { device_type = "memory"; reg = <0 0>; };
> + memory@0 { device_type = "memory"; reg = <0 0>; };
> };
> diff --git a/arch/arm/boot/dts/skeleton64.dtsi b/arch/arm/boot/dts/skeleton64.dtsi
> index b5d7f36..6dbe9f9 100644
> --- a/arch/arm/boot/dts/skeleton64.dtsi
> +++ b/arch/arm/boot/dts/skeleton64.dtsi
> @@ -9,5 +9,5 @@
> #size-cells = <2>;
> chosen { };
> aliases { };
> - memory { device_type = "memory"; reg = <0 0 0 0>; };
> + memory@0 { device_type = "memory"; reg = <0 0 0 0>; };
> };
>
this looks wrong, because all inherited compiled dtbs will contain memory@0
device node, for example (with applied 4/7 from this series):
% scripts/dtc/dtc -I dtb -O dts arch/arm/boot/dts/lpc4357-ea4357-devkit.dtb
| grep -A3 memory@
memory@0 {
device_type = "memory";
reg = <0x0 0x0>;
};
--
memory@28000000 {
device_type = "memory";
reg = <0x28000000 0x2000000>;
};
--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-30 10:12 ` Vladimir Zapolskiy
0 siblings, 0 replies; 56+ messages in thread
From: Vladimir Zapolskiy @ 2016-03-30 10:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi Joachim,
On 30.03.2016 01:30, Joachim Eastwood wrote:
> Add unit name to memory to remove the following warning:
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
> property, but no unit name
>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
> arch/arm/boot/dts/skeleton.dtsi | 2 +-
> arch/arm/boot/dts/skeleton64.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/skeleton.dtsi b/arch/arm/boot/dts/skeleton.dtsi
> index b41d241..a20da0a 100644
> --- a/arch/arm/boot/dts/skeleton.dtsi
> +++ b/arch/arm/boot/dts/skeleton.dtsi
> @@ -9,5 +9,5 @@
> #size-cells = <1>;
> chosen { };
> aliases { };
> - memory { device_type = "memory"; reg = <0 0>; };
> + memory at 0 { device_type = "memory"; reg = <0 0>; };
> };
> diff --git a/arch/arm/boot/dts/skeleton64.dtsi b/arch/arm/boot/dts/skeleton64.dtsi
> index b5d7f36..6dbe9f9 100644
> --- a/arch/arm/boot/dts/skeleton64.dtsi
> +++ b/arch/arm/boot/dts/skeleton64.dtsi
> @@ -9,5 +9,5 @@
> #size-cells = <2>;
> chosen { };
> aliases { };
> - memory { device_type = "memory"; reg = <0 0 0 0>; };
> + memory at 0 { device_type = "memory"; reg = <0 0 0 0>; };
> };
>
this looks wrong, because all inherited compiled dtbs will contain memory at 0
device node, for example (with applied 4/7 from this series):
% scripts/dtc/dtc -I dtb -O dts arch/arm/boot/dts/lpc4357-ea4357-devkit.dtb
| grep -A3 memory@
memory at 0 {
device_type = "memory";
reg = <0x0 0x0>;
};
--
memory at 28000000 {
device_type = "memory";
reg = <0x28000000 0x2000000>;
};
--
With best wishes,
Vladimir
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-29 22:30 ` Joachim Eastwood
@ 2016-03-30 11:06 ` Mark Rutland
-1 siblings, 0 replies; 56+ messages in thread
From: Mark Rutland @ 2016-03-30 11:06 UTC (permalink / raw)
To: Joachim Eastwood
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA
On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
> Add unit name to memory to remove the following warning:
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
> property, but no unit name
If anything, it would be better to get rid of the memory node from the
skeleton DTs.
For DTs which have a memory node there's no problem, and DTs which
expect a bootlaoder to fill things in have a logical place to document
that fact.
Thanks,
Mark.
>
> Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/boot/dts/skeleton.dtsi | 2 +-
> arch/arm/boot/dts/skeleton64.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/skeleton.dtsi b/arch/arm/boot/dts/skeleton.dtsi
> index b41d241..a20da0a 100644
> --- a/arch/arm/boot/dts/skeleton.dtsi
> +++ b/arch/arm/boot/dts/skeleton.dtsi
> @@ -9,5 +9,5 @@
> #size-cells = <1>;
> chosen { };
> aliases { };
> - memory { device_type = "memory"; reg = <0 0>; };
> + memory@0 { device_type = "memory"; reg = <0 0>; };
> };
> diff --git a/arch/arm/boot/dts/skeleton64.dtsi b/arch/arm/boot/dts/skeleton64.dtsi
> index b5d7f36..6dbe9f9 100644
> --- a/arch/arm/boot/dts/skeleton64.dtsi
> +++ b/arch/arm/boot/dts/skeleton64.dtsi
> @@ -9,5 +9,5 @@
> #size-cells = <2>;
> chosen { };
> aliases { };
> - memory { device_type = "memory"; reg = <0 0 0 0>; };
> + memory@0 { device_type = "memory"; reg = <0 0 0 0>; };
> };
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-30 11:06 ` Mark Rutland
0 siblings, 0 replies; 56+ messages in thread
From: Mark Rutland @ 2016-03-30 11:06 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
> Add unit name to memory to remove the following warning:
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
> property, but no unit name
If anything, it would be better to get rid of the memory node from the
skeleton DTs.
For DTs which have a memory node there's no problem, and DTs which
expect a bootlaoder to fill things in have a logical place to document
that fact.
Thanks,
Mark.
>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
> arch/arm/boot/dts/skeleton.dtsi | 2 +-
> arch/arm/boot/dts/skeleton64.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/skeleton.dtsi b/arch/arm/boot/dts/skeleton.dtsi
> index b41d241..a20da0a 100644
> --- a/arch/arm/boot/dts/skeleton.dtsi
> +++ b/arch/arm/boot/dts/skeleton.dtsi
> @@ -9,5 +9,5 @@
> #size-cells = <1>;
> chosen { };
> aliases { };
> - memory { device_type = "memory"; reg = <0 0>; };
> + memory at 0 { device_type = "memory"; reg = <0 0>; };
> };
> diff --git a/arch/arm/boot/dts/skeleton64.dtsi b/arch/arm/boot/dts/skeleton64.dtsi
> index b5d7f36..6dbe9f9 100644
> --- a/arch/arm/boot/dts/skeleton64.dtsi
> +++ b/arch/arm/boot/dts/skeleton64.dtsi
> @@ -9,5 +9,5 @@
> #size-cells = <2>;
> chosen { };
> aliases { };
> - memory { device_type = "memory"; reg = <0 0 0 0>; };
> + memory at 0 { device_type = "memory"; reg = <0 0 0 0>; };
> };
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-30 11:06 ` Mark Rutland
@ 2016-03-30 12:36 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-30 12:36 UTC (permalink / raw)
To: Mark Rutland
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
devicetree, vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA
Hi Mark,
On 30 March 2016 at 13:06, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>> Add unit name to memory to remove the following warning:
>> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>> property, but no unit name
>
> If anything, it would be better to get rid of the memory node from the
> skeleton DTs.
Yes, I agree and as Vladimir notes just by adding a unit name we
create duplicate memory nodes.
I'll send an updated patch set once Rob has a change to look at it also.
> For DTs which have a memory node there's no problem, and DTs which
> expect a bootlaoder to fill things in have a logical place to document
> that fact.
I'll take a look at which DTs that currently doesn't have a memory and add it.
Thanks for looking.
regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-30 12:36 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-30 12:36 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mark,
On 30 March 2016 at 13:06, Mark Rutland <mark.rutland@arm.com> wrote:
> On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>> Add unit name to memory to remove the following warning:
>> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>> property, but no unit name
>
> If anything, it would be better to get rid of the memory node from the
> skeleton DTs.
Yes, I agree and as Vladimir notes just by adding a unit name we
create duplicate memory nodes.
I'll send an updated patch set once Rob has a change to look at it also.
> For DTs which have a memory node there's no problem, and DTs which
> expect a bootlaoder to fill things in have a logical place to document
> that fact.
I'll take a look at which DTs that currently doesn't have a memory and add it.
Thanks for looking.
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-30 11:06 ` Mark Rutland
@ 2016-03-30 13:06 ` Vladimir Zapolskiy
-1 siblings, 0 replies; 56+ messages in thread
From: Vladimir Zapolskiy @ 2016-03-30 13:06 UTC (permalink / raw)
To: Mark Rutland, Joachim Eastwood
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA
On 30.03.2016 14:06, Mark Rutland wrote:
> On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>> Add unit name to memory to remove the following warning:
>> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>> property, but no unit name
>
> If anything, it would be better to get rid of the memory node from the
> skeleton DTs.
>
> For DTs which have a memory node there's no problem, and DTs which
> expect a bootlaoder to fill things in have a logical place to document
> that fact.
Generally I support this.
U-boot still creates or fixes up "/memory" node only, assuming that
a bootloader is updated rarely the kernel should continue to process
in expected way "/memory" device node, also note that ePAPR says
ePAPR> If a system has multiple ranges of memory, multiple memory nodes
ePAPR> can be created, or the ranges can be specified in the reg property
ePAPR> of a single memory node.
Having just a DT on hand it won't be possible to make assumptions about
a bootloader, also "/memory" without a given unit address is used by
other kernels and a bootloader can respect this.
The only problem I see if DTB is updated on a board but a board bootloader
on fix-up is capable to fill a preexisting "/memory" device node in only,
otherwise it is not clear why the device node is present in skeleton.dtsi.
>> Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>> arch/arm/boot/dts/skeleton.dtsi | 2 +-
>> arch/arm/boot/dts/skeleton64.dtsi | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/skeleton.dtsi b/arch/arm/boot/dts/skeleton.dtsi
>> index b41d241..a20da0a 100644
>> --- a/arch/arm/boot/dts/skeleton.dtsi
>> +++ b/arch/arm/boot/dts/skeleton.dtsi
>> @@ -9,5 +9,5 @@
>> #size-cells = <1>;
>> chosen { };
>> aliases { };
>> - memory { device_type = "memory"; reg = <0 0>; };
>> + memory@0 { device_type = "memory"; reg = <0 0>; };
>> };
>> diff --git a/arch/arm/boot/dts/skeleton64.dtsi b/arch/arm/boot/dts/skeleton64.dtsi
>> index b5d7f36..6dbe9f9 100644
>> --- a/arch/arm/boot/dts/skeleton64.dtsi
>> +++ b/arch/arm/boot/dts/skeleton64.dtsi
>> @@ -9,5 +9,5 @@
>> #size-cells = <2>;
>> chosen { };
>> aliases { };
>> - memory { device_type = "memory"; reg = <0 0 0 0>; };
>> + memory@0 { device_type = "memory"; reg = <0 0 0 0>; };
>> };
>> --
>> 2.7.4
>>
--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-30 13:06 ` Vladimir Zapolskiy
0 siblings, 0 replies; 56+ messages in thread
From: Vladimir Zapolskiy @ 2016-03-30 13:06 UTC (permalink / raw)
To: linux-arm-kernel
On 30.03.2016 14:06, Mark Rutland wrote:
> On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>> Add unit name to memory to remove the following warning:
>> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>> property, but no unit name
>
> If anything, it would be better to get rid of the memory node from the
> skeleton DTs.
>
> For DTs which have a memory node there's no problem, and DTs which
> expect a bootlaoder to fill things in have a logical place to document
> that fact.
Generally I support this.
U-boot still creates or fixes up "/memory" node only, assuming that
a bootloader is updated rarely the kernel should continue to process
in expected way "/memory" device node, also note that ePAPR says
ePAPR> If a system has multiple ranges of memory, multiple memory nodes
ePAPR> can be created, or the ranges can be specified in the reg property
ePAPR> of a single memory node.
Having just a DT on hand it won't be possible to make assumptions about
a bootloader, also "/memory" without a given unit address is used by
other kernels and a bootloader can respect this.
The only problem I see if DTB is updated on a board but a board bootloader
on fix-up is capable to fill a preexisting "/memory" device node in only,
otherwise it is not clear why the device node is present in skeleton.dtsi.
>> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
>> ---
>> arch/arm/boot/dts/skeleton.dtsi | 2 +-
>> arch/arm/boot/dts/skeleton64.dtsi | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/skeleton.dtsi b/arch/arm/boot/dts/skeleton.dtsi
>> index b41d241..a20da0a 100644
>> --- a/arch/arm/boot/dts/skeleton.dtsi
>> +++ b/arch/arm/boot/dts/skeleton.dtsi
>> @@ -9,5 +9,5 @@
>> #size-cells = <1>;
>> chosen { };
>> aliases { };
>> - memory { device_type = "memory"; reg = <0 0>; };
>> + memory at 0 { device_type = "memory"; reg = <0 0>; };
>> };
>> diff --git a/arch/arm/boot/dts/skeleton64.dtsi b/arch/arm/boot/dts/skeleton64.dtsi
>> index b5d7f36..6dbe9f9 100644
>> --- a/arch/arm/boot/dts/skeleton64.dtsi
>> +++ b/arch/arm/boot/dts/skeleton64.dtsi
>> @@ -9,5 +9,5 @@
>> #size-cells = <2>;
>> chosen { };
>> aliases { };
>> - memory { device_type = "memory"; reg = <0 0 0 0>; };
>> + memory at 0 { device_type = "memory"; reg = <0 0 0 0>; };
>> };
>> --
>> 2.7.4
>>
--
With best wishes,
Vladimir
^ permalink raw reply [flat|nested] 56+ messages in thread[parent not found: <56FBCF70.80006-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-30 13:06 ` Vladimir Zapolskiy
@ 2016-03-30 13:41 ` Mark Rutland
-1 siblings, 0 replies; 56+ messages in thread
From: Mark Rutland @ 2016-03-30 13:41 UTC (permalink / raw)
To: Vladimir Zapolskiy
Cc: Joachim Eastwood,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA
On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
> On 30.03.2016 14:06, Mark Rutland wrote:
> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
> >> Add unit name to memory to remove the following warning:
> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
> >> property, but no unit name
> >
> > If anything, it would be better to get rid of the memory node from the
> > skeleton DTs.
> >
> > For DTs which have a memory node there's no problem, and DTs which
> > expect a bootlaoder to fill things in have a logical place to document
> > that fact.
> The only problem I see if DTB is updated on a board but a board bootloader
> on fix-up is capable to fill a preexisting "/memory" device node in only,
> otherwise it is not clear why the device node is present in skeleton.dtsi.
Sure. To clarify the above, what I expect that for this case is that the
empty memory node would exist in the dts for that particular board,
along with a comment, e.g.
/* The firmware/bootloader for $BOARD fills this in */
memory {
device_type = "memory";
reg = <0 0 0 0>;
};
That way you can tell at a glance that the lack of memory information in
the DT for a board is intentional, and the bootloader still gets the
node it expects.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-30 13:41 ` Mark Rutland
0 siblings, 0 replies; 56+ messages in thread
From: Mark Rutland @ 2016-03-30 13:41 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
> On 30.03.2016 14:06, Mark Rutland wrote:
> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
> >> Add unit name to memory to remove the following warning:
> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
> >> property, but no unit name
> >
> > If anything, it would be better to get rid of the memory node from the
> > skeleton DTs.
> >
> > For DTs which have a memory node there's no problem, and DTs which
> > expect a bootlaoder to fill things in have a logical place to document
> > that fact.
> The only problem I see if DTB is updated on a board but a board bootloader
> on fix-up is capable to fill a preexisting "/memory" device node in only,
> otherwise it is not clear why the device node is present in skeleton.dtsi.
Sure. To clarify the above, what I expect that for this case is that the
empty memory node would exist in the dts for that particular board,
along with a comment, e.g.
/* The firmware/bootloader for $BOARD fills this in */
memory {
device_type = "memory";
reg = <0 0 0 0>;
};
That way you can tell at a glance that the lack of memory information in
the DT for a board is intentional, and the bootloader still gets the
node it expects.
Thanks,
Mark.
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-30 13:41 ` Mark Rutland
@ 2016-03-30 16:15 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-30 16:15 UTC (permalink / raw)
To: Mark Rutland
Cc: devicetree, Rob Herring, linux-arm-kernel, Vladimir Zapolskiy
Hi Mark,
On 30 March 2016 at 15:41, Mark Rutland <mark.rutland@arm.com> wrote:
> On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
>> On 30.03.2016 14:06, Mark Rutland wrote:
>> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>> >> Add unit name to memory to remove the following warning:
>> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>> >> property, but no unit name
>> >
>> > If anything, it would be better to get rid of the memory node from the
>> > skeleton DTs.
>> >
>> > For DTs which have a memory node there's no problem, and DTs which
>> > expect a bootlaoder to fill things in have a logical place to document
>> > that fact.
>
>> The only problem I see if DTB is updated on a board but a board bootloader
>> on fix-up is capable to fill a preexisting "/memory" device node in only,
>> otherwise it is not clear why the device node is present in skeleton.dtsi.
>
> Sure. To clarify the above, what I expect that for this case is that the
> empty memory node would exist in the dts for that particular board,
> along with a comment, e.g.
>
> /* The firmware/bootloader for $BOARD fills this in */
> memory {
> device_type = "memory";
> reg = <0 0 0 0>;
> };
To avoid the warning with the new dtc this would need to be memory@0.
> That way you can tell at a glance that the lack of memory information in
> the DT for a board is intentional, and the bootloader still gets the
> node it expects.
But this doesn't seem to be a "problem" with any of the DTs in
arch/arm/boot as they all defined a memory node.
I used the following script to check for the memory node in all built dtb's.
make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
for i in $(ls arch/arm/boot/dts/*.dtb); do
m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
if [ -z "$m" ]; then
echo "Missing memory node in $i"
fi
done
So it should be pretty safe to just remove the memory node entry in
the skeleton files. Unless I have missed something with the script
above.
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-30 16:15 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-30 16:15 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mark,
On 30 March 2016 at 15:41, Mark Rutland <mark.rutland@arm.com> wrote:
> On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
>> On 30.03.2016 14:06, Mark Rutland wrote:
>> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>> >> Add unit name to memory to remove the following warning:
>> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>> >> property, but no unit name
>> >
>> > If anything, it would be better to get rid of the memory node from the
>> > skeleton DTs.
>> >
>> > For DTs which have a memory node there's no problem, and DTs which
>> > expect a bootlaoder to fill things in have a logical place to document
>> > that fact.
>
>> The only problem I see if DTB is updated on a board but a board bootloader
>> on fix-up is capable to fill a preexisting "/memory" device node in only,
>> otherwise it is not clear why the device node is present in skeleton.dtsi.
>
> Sure. To clarify the above, what I expect that for this case is that the
> empty memory node would exist in the dts for that particular board,
> along with a comment, e.g.
>
> /* The firmware/bootloader for $BOARD fills this in */
> memory {
> device_type = "memory";
> reg = <0 0 0 0>;
> };
To avoid the warning with the new dtc this would need to be memory at 0.
> That way you can tell at a glance that the lack of memory information in
> the DT for a board is intentional, and the bootloader still gets the
> node it expects.
But this doesn't seem to be a "problem" with any of the DTs in
arch/arm/boot as they all defined a memory node.
I used the following script to check for the memory node in all built dtb's.
make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
for i in $(ls arch/arm/boot/dts/*.dtb); do
m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
if [ -z "$m" ]; then
echo "Missing memory node in $i"
fi
done
So it should be pretty safe to just remove the memory node entry in
the skeleton files. Unless I have missed something with the script
above.
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 56+ messages in thread[parent not found: <CAGhQ9VykiwMWaw3xcJdg2CahNFt+sp7tFC5O8VwA=-_=UoJ8kA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-30 16:15 ` Joachim Eastwood
@ 2016-03-30 17:06 ` Mark Rutland
-1 siblings, 0 replies; 56+ messages in thread
From: Mark Rutland @ 2016-03-30 17:06 UTC (permalink / raw)
To: Joachim Eastwood
Cc: Vladimir Zapolskiy,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
devicetree
On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
> Hi Mark,
>
> On 30 March 2016 at 15:41, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> > On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
> >> On 30.03.2016 14:06, Mark Rutland wrote:
> >> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
> >> >> Add unit name to memory to remove the following warning:
> >> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
> >> >> property, but no unit name
> >> >
> >> > If anything, it would be better to get rid of the memory node from the
> >> > skeleton DTs.
> >> >
> >> > For DTs which have a memory node there's no problem, and DTs which
> >> > expect a bootlaoder to fill things in have a logical place to document
> >> > that fact.
> >
> >> The only problem I see if DTB is updated on a board but a board bootloader
> >> on fix-up is capable to fill a preexisting "/memory" device node in only,
> >> otherwise it is not clear why the device node is present in skeleton.dtsi.
> >
> > Sure. To clarify the above, what I expect that for this case is that the
> > empty memory node would exist in the dts for that particular board,
> > along with a comment, e.g.
> >
> > /* The firmware/bootloader for $BOARD fills this in */
> > memory {
> > device_type = "memory";
> > reg = <0 0 0 0>;
> > };
>
> To avoid the warning with the new dtc this would need to be memory@0.
Hmm... That's a little sub-optimal in the case that a bootloader is
patching this. Presumably a bootloader that needs an existing node won't
patch the unit-address to match the reg (which might not start at 0).
I'd rather not have the unit-address than have an incorrect
unit-address, though I guess we don't have much of a choice here, unless
there's some override we can place in the dts.
> > That way you can tell at a glance that the lack of memory information in
> > the DT for a board is intentional, and the bootloader still gets the
> > node it expects.
>
> But this doesn't seem to be a "problem" with any of the DTs in
> arch/arm/boot as they all defined a memory node.
>
> I used the following script to check for the memory node in all built dtb's.
> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
> for i in $(ls arch/arm/boot/dts/*.dtb); do
> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
> if [ -z "$m" ]; then
> echo "Missing memory node in $i"
> fi
> done
>
> So it should be pretty safe to just remove the memory node entry in
> the skeleton files. Unless I have missed something with the script
> above.
The above might match reserved-memory nodes; it might be better to check
for 'device_type\s*=\s*"memory"'.
I assume that was run after deleting the memory node from the skeletons?
Otherwise, that looks fairly convincing!
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-30 17:06 ` Mark Rutland
0 siblings, 0 replies; 56+ messages in thread
From: Mark Rutland @ 2016-03-30 17:06 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
> Hi Mark,
>
> On 30 March 2016 at 15:41, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
> >> On 30.03.2016 14:06, Mark Rutland wrote:
> >> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
> >> >> Add unit name to memory to remove the following warning:
> >> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
> >> >> property, but no unit name
> >> >
> >> > If anything, it would be better to get rid of the memory node from the
> >> > skeleton DTs.
> >> >
> >> > For DTs which have a memory node there's no problem, and DTs which
> >> > expect a bootlaoder to fill things in have a logical place to document
> >> > that fact.
> >
> >> The only problem I see if DTB is updated on a board but a board bootloader
> >> on fix-up is capable to fill a preexisting "/memory" device node in only,
> >> otherwise it is not clear why the device node is present in skeleton.dtsi.
> >
> > Sure. To clarify the above, what I expect that for this case is that the
> > empty memory node would exist in the dts for that particular board,
> > along with a comment, e.g.
> >
> > /* The firmware/bootloader for $BOARD fills this in */
> > memory {
> > device_type = "memory";
> > reg = <0 0 0 0>;
> > };
>
> To avoid the warning with the new dtc this would need to be memory at 0.
Hmm... That's a little sub-optimal in the case that a bootloader is
patching this. Presumably a bootloader that needs an existing node won't
patch the unit-address to match the reg (which might not start at 0).
I'd rather not have the unit-address than have an incorrect
unit-address, though I guess we don't have much of a choice here, unless
there's some override we can place in the dts.
> > That way you can tell at a glance that the lack of memory information in
> > the DT for a board is intentional, and the bootloader still gets the
> > node it expects.
>
> But this doesn't seem to be a "problem" with any of the DTs in
> arch/arm/boot as they all defined a memory node.
>
> I used the following script to check for the memory node in all built dtb's.
> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
> for i in $(ls arch/arm/boot/dts/*.dtb); do
> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
> if [ -z "$m" ]; then
> echo "Missing memory node in $i"
> fi
> done
>
> So it should be pretty safe to just remove the memory node entry in
> the skeleton files. Unless I have missed something with the script
> above.
The above might match reserved-memory nodes; it might be better to check
for 'device_type\s*=\s*"memory"'.
I assume that was run after deleting the memory node from the skeletons?
Otherwise, that looks fairly convincing!
Thanks,
Mark.
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-30 17:06 ` Mark Rutland
@ 2016-03-30 20:45 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-30 20:45 UTC (permalink / raw)
To: Mark Rutland
Cc: Vladimir Zapolskiy,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
devicetree
On 30 March 2016 at 19:06, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
>> Hi Mark,
>>
>> On 30 March 2016 at 15:41, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
>> > On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
>> >> On 30.03.2016 14:06, Mark Rutland wrote:
>> >> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>> >> >> Add unit name to memory to remove the following warning:
>> >> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>> >> >> property, but no unit name
>> >> >
>> >> > If anything, it would be better to get rid of the memory node from the
>> >> > skeleton DTs.
>> >> >
>> >> > For DTs which have a memory node there's no problem, and DTs which
>> >> > expect a bootlaoder to fill things in have a logical place to document
>> >> > that fact.
>> >
>> >> The only problem I see if DTB is updated on a board but a board bootloader
>> >> on fix-up is capable to fill a preexisting "/memory" device node in only,
>> >> otherwise it is not clear why the device node is present in skeleton.dtsi.
>> >
>> > Sure. To clarify the above, what I expect that for this case is that the
>> > empty memory node would exist in the dts for that particular board,
>> > along with a comment, e.g.
>> >
>> > /* The firmware/bootloader for $BOARD fills this in */
>> > memory {
>> > device_type = "memory";
>> > reg = <0 0 0 0>;
>> > };
>>
>> To avoid the warning with the new dtc this would need to be memory@0.
>
> Hmm... That's a little sub-optimal in the case that a bootloader is
> patching this. Presumably a bootloader that needs an existing node won't
> patch the unit-address to match the reg (which might not start at 0).
>
> I'd rather not have the unit-address than have an incorrect
> unit-address, though I guess we don't have much of a choice here, unless
> there's some override we can place in the dts.
>
>> > That way you can tell at a glance that the lack of memory information in
>> > the DT for a board is intentional, and the bootloader still gets the
>> > node it expects.
>>
>> But this doesn't seem to be a "problem" with any of the DTs in
>> arch/arm/boot as they all defined a memory node.
>>
>> I used the following script to check for the memory node in all built dtb's.
>> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>> for i in $(ls arch/arm/boot/dts/*.dtb); do
>> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>> if [ -z "$m" ]; then
>> echo "Missing memory node in $i"
>> fi
>> done
>>
>> So it should be pretty safe to just remove the memory node entry in
>> the skeleton files. Unless I have missed something with the script
>> above.
>
> The above might match reserved-memory nodes; it might be better to check
> for 'device_type\s*=\s*"memory"'.
I did check the output of the grep and it looks good. But there are
indeed DTs that are missing the 'device_type = "memory"' parameter.
Actually; _a lot_ or 438 of 741 to be exact. ugh...
I guess all those should be fixed up before we can remove the memory
node from skeleton. :/
> I assume that was run after deleting the memory node from the skeletons?
Yes :)
regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-30 20:45 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-30 20:45 UTC (permalink / raw)
To: linux-arm-kernel
On 30 March 2016 at 19:06, Mark Rutland <mark.rutland@arm.com> wrote:
> On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
>> Hi Mark,
>>
>> On 30 March 2016 at 15:41, Mark Rutland <mark.rutland@arm.com> wrote:
>> > On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
>> >> On 30.03.2016 14:06, Mark Rutland wrote:
>> >> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>> >> >> Add unit name to memory to remove the following warning:
>> >> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>> >> >> property, but no unit name
>> >> >
>> >> > If anything, it would be better to get rid of the memory node from the
>> >> > skeleton DTs.
>> >> >
>> >> > For DTs which have a memory node there's no problem, and DTs which
>> >> > expect a bootlaoder to fill things in have a logical place to document
>> >> > that fact.
>> >
>> >> The only problem I see if DTB is updated on a board but a board bootloader
>> >> on fix-up is capable to fill a preexisting "/memory" device node in only,
>> >> otherwise it is not clear why the device node is present in skeleton.dtsi.
>> >
>> > Sure. To clarify the above, what I expect that for this case is that the
>> > empty memory node would exist in the dts for that particular board,
>> > along with a comment, e.g.
>> >
>> > /* The firmware/bootloader for $BOARD fills this in */
>> > memory {
>> > device_type = "memory";
>> > reg = <0 0 0 0>;
>> > };
>>
>> To avoid the warning with the new dtc this would need to be memory at 0.
>
> Hmm... That's a little sub-optimal in the case that a bootloader is
> patching this. Presumably a bootloader that needs an existing node won't
> patch the unit-address to match the reg (which might not start at 0).
>
> I'd rather not have the unit-address than have an incorrect
> unit-address, though I guess we don't have much of a choice here, unless
> there's some override we can place in the dts.
>
>> > That way you can tell at a glance that the lack of memory information in
>> > the DT for a board is intentional, and the bootloader still gets the
>> > node it expects.
>>
>> But this doesn't seem to be a "problem" with any of the DTs in
>> arch/arm/boot as they all defined a memory node.
>>
>> I used the following script to check for the memory node in all built dtb's.
>> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>> for i in $(ls arch/arm/boot/dts/*.dtb); do
>> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>> if [ -z "$m" ]; then
>> echo "Missing memory node in $i"
>> fi
>> done
>>
>> So it should be pretty safe to just remove the memory node entry in
>> the skeleton files. Unless I have missed something with the script
>> above.
>
> The above might match reserved-memory nodes; it might be better to check
> for 'device_type\s*=\s*"memory"'.
I did check the output of the grep and it looks good. But there are
indeed DTs that are missing the 'device_type = "memory"' parameter.
Actually; _a lot_ or 438 of 741 to be exact. ugh...
I guess all those should be fixed up before we can remove the memory
node from skeleton. :/
> I assume that was run after deleting the memory node from the skeletons?
Yes :)
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 56+ messages in thread[parent not found: <CAGhQ9Vykn=G+cmVuBCAA_ATTz4XNEPeUWYbZRb5NsrVBOjaS-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-30 20:45 ` Joachim Eastwood
@ 2016-03-31 10:38 ` Mark Rutland
-1 siblings, 0 replies; 56+ messages in thread
From: Mark Rutland @ 2016-03-31 10:38 UTC (permalink / raw)
To: Joachim Eastwood
Cc: Vladimir Zapolskiy,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
devicetree
On Wed, Mar 30, 2016 at 10:45:06PM +0200, Joachim Eastwood wrote:
> On 30 March 2016 at 19:06, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> > On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
> >> I used the following script to check for the memory node in all built dtb's.
> >> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
> >> for i in $(ls arch/arm/boot/dts/*.dtb); do
> >> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
> >> if [ -z "$m" ]; then
> >> echo "Missing memory node in $i"
> >> fi
> >> done
> >>
> >> So it should be pretty safe to just remove the memory node entry in
> >> the skeleton files. Unless I have missed something with the script
> >> above.
> >
> > The above might match reserved-memory nodes; it might be better to check
> > for 'device_type\s*=\s*"memory"'.
>
> I did check the output of the grep and it looks good. But there are
> indeed DTs that are missing the 'device_type = "memory"' parameter.
> Actually; _a lot_ or 438 of 741 to be exact. ugh...
>
> I guess all those should be fixed up before we can remove the memory
> node from skeleton. :/
Ouch, yes. :(
That said, the cahnges don't need to be an atomic operation. We could
start adding device_type = "memory" to dts immediately (in as whatever
size batches maintainers are happy with), as a duplicate device_type
shouldn't be problematic.
When we hit critical mass, we could then remove the skeleton memory
nodes, fixing up any remaining fallout.
As for the mechanical changes, it sounds like we need coccinelle for DT.
That, or a laptop, a long flight, and a gin and tonic.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-31 10:38 ` Mark Rutland
0 siblings, 0 replies; 56+ messages in thread
From: Mark Rutland @ 2016-03-31 10:38 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 30, 2016 at 10:45:06PM +0200, Joachim Eastwood wrote:
> On 30 March 2016 at 19:06, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
> >> I used the following script to check for the memory node in all built dtb's.
> >> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
> >> for i in $(ls arch/arm/boot/dts/*.dtb); do
> >> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
> >> if [ -z "$m" ]; then
> >> echo "Missing memory node in $i"
> >> fi
> >> done
> >>
> >> So it should be pretty safe to just remove the memory node entry in
> >> the skeleton files. Unless I have missed something with the script
> >> above.
> >
> > The above might match reserved-memory nodes; it might be better to check
> > for 'device_type\s*=\s*"memory"'.
>
> I did check the output of the grep and it looks good. But there are
> indeed DTs that are missing the 'device_type = "memory"' parameter.
> Actually; _a lot_ or 438 of 741 to be exact. ugh...
>
> I guess all those should be fixed up before we can remove the memory
> node from skeleton. :/
Ouch, yes. :(
That said, the cahnges don't need to be an atomic operation. We could
start adding device_type = "memory" to dts immediately (in as whatever
size batches maintainers are happy with), as a duplicate device_type
shouldn't be problematic.
When we hit critical mass, we could then remove the skeleton memory
nodes, fixing up any remaining fallout.
As for the mechanical changes, it sounds like we need coccinelle for DT.
That, or a laptop, a long flight, and a gin and tonic.
Thanks,
Mark.
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-31 10:38 ` Mark Rutland
@ 2016-03-31 15:21 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-31 15:21 UTC (permalink / raw)
To: Mark Rutland
Cc: Vladimir Zapolskiy,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
devicetree
On 31 March 2016 at 12:38, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> On Wed, Mar 30, 2016 at 10:45:06PM +0200, Joachim Eastwood wrote:
>> On 30 March 2016 at 19:06, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
>> > On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
>> >> I used the following script to check for the memory node in all built dtb's.
>> >> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>> >> for i in $(ls arch/arm/boot/dts/*.dtb); do
>> >> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>> >> if [ -z "$m" ]; then
>> >> echo "Missing memory node in $i"
>> >> fi
>> >> done
>> >>
>> >> So it should be pretty safe to just remove the memory node entry in
>> >> the skeleton files. Unless I have missed something with the script
>> >> above.
>> >
>> > The above might match reserved-memory nodes; it might be better to check
>> > for 'device_type\s*=\s*"memory"'.
>>
>> I did check the output of the grep and it looks good. But there are
>> indeed DTs that are missing the 'device_type = "memory"' parameter.
>> Actually; _a lot_ or 438 of 741 to be exact. ugh...
>>
>> I guess all those should be fixed up before we can remove the memory
>> node from skeleton. :/
>
> Ouch, yes. :(
>
> That said, the cahnges don't need to be an atomic operation. We could
> start adding device_type = "memory" to dts immediately (in as whatever
> size batches maintainers are happy with), as a duplicate device_type
> shouldn't be problematic.
Yes, that is true.
> When we hit critical mass, we could then remove the skeleton memory
> nodes, fixing up any remaining fallout.
>
> As for the mechanical changes, it sounds like we need coccinelle for DT.
>
> That, or a laptop, a long flight, and a gin and tonic.
:-)
I'll see if I can cook up something with awk.
Anyway, I am dropping the memory node changes from this patch set so I
can get a pull request sent to arm-soc for lpc18xx sooner rather than
later.
regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-31 15:21 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-31 15:21 UTC (permalink / raw)
To: linux-arm-kernel
On 31 March 2016 at 12:38, Mark Rutland <mark.rutland@arm.com> wrote:
> On Wed, Mar 30, 2016 at 10:45:06PM +0200, Joachim Eastwood wrote:
>> On 30 March 2016 at 19:06, Mark Rutland <mark.rutland@arm.com> wrote:
>> > On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
>> >> I used the following script to check for the memory node in all built dtb's.
>> >> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>> >> for i in $(ls arch/arm/boot/dts/*.dtb); do
>> >> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>> >> if [ -z "$m" ]; then
>> >> echo "Missing memory node in $i"
>> >> fi
>> >> done
>> >>
>> >> So it should be pretty safe to just remove the memory node entry in
>> >> the skeleton files. Unless I have missed something with the script
>> >> above.
>> >
>> > The above might match reserved-memory nodes; it might be better to check
>> > for 'device_type\s*=\s*"memory"'.
>>
>> I did check the output of the grep and it looks good. But there are
>> indeed DTs that are missing the 'device_type = "memory"' parameter.
>> Actually; _a lot_ or 438 of 741 to be exact. ugh...
>>
>> I guess all those should be fixed up before we can remove the memory
>> node from skeleton. :/
>
> Ouch, yes. :(
>
> That said, the cahnges don't need to be an atomic operation. We could
> start adding device_type = "memory" to dts immediately (in as whatever
> size batches maintainers are happy with), as a duplicate device_type
> shouldn't be problematic.
Yes, that is true.
> When we hit critical mass, we could then remove the skeleton memory
> nodes, fixing up any remaining fallout.
>
> As for the mechanical changes, it sounds like we need coccinelle for DT.
>
> That, or a laptop, a long flight, and a gin and tonic.
:-)
I'll see if I can cook up something with awk.
Anyway, I am dropping the memory node changes from this patch set so I
can get a pull request sent to arm-soc for lpc18xx sooner rather than
later.
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 56+ messages in thread[parent not found: <CAGhQ9Vy8TKPxPdYF-wXbCo_LZkBsSsficEG8wCn1bCbS9JN+vg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-31 15:21 ` Joachim Eastwood
@ 2016-03-31 16:34 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-31 16:34 UTC (permalink / raw)
To: Mark Rutland
Cc: Vladimir Zapolskiy,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
devicetree
On 31 March 2016 at 17:21, Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 31 March 2016 at 12:38, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
>> On Wed, Mar 30, 2016 at 10:45:06PM +0200, Joachim Eastwood wrote:
>>> On 30 March 2016 at 19:06, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
>>> > On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
>>> >> I used the following script to check for the memory node in all built dtb's.
>>> >> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>>> >> for i in $(ls arch/arm/boot/dts/*.dtb); do
>>> >> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>>> >> if [ -z "$m" ]; then
>>> >> echo "Missing memory node in $i"
>>> >> fi
>>> >> done
>>> >>
>>> >> So it should be pretty safe to just remove the memory node entry in
>>> >> the skeleton files. Unless I have missed something with the script
>>> >> above.
>>> >
>>> > The above might match reserved-memory nodes; it might be better to check
>>> > for 'device_type\s*=\s*"memory"'.
>>>
>>> I did check the output of the grep and it looks good. But there are
>>> indeed DTs that are missing the 'device_type = "memory"' parameter.
>>> Actually; _a lot_ or 438 of 741 to be exact. ugh...
>>>
>>> I guess all those should be fixed up before we can remove the memory
>>> node from skeleton. :/
>>
>> Ouch, yes. :(
>>
>> That said, the cahnges don't need to be an atomic operation. We could
>> start adding device_type = "memory" to dts immediately (in as whatever
>> size batches maintainers are happy with), as a duplicate device_type
>> shouldn't be problematic.
>
> Yes, that is true.
>
>
>> When we hit critical mass, we could then remove the skeleton memory
>> nodes, fixing up any remaining fallout.
>>
>> As for the mechanical changes, it sounds like we need coccinelle for DT.
>>
>> That, or a laptop, a long flight, and a gin and tonic.
>
> :-)
>
> I'll see if I can cook up something with awk.
Something like this should do it:
#!/usr/bin/gawk -f
# find arch/arm/boot/dts/ -type f -name *.dts* | xargs
./mem_node_add_dev_type.awk -i inplace
BEGIN { go = 0 }
/[^-]memory ?{/ { go = 1; idx = 0; device_type = 0 }
go == 1 {
buf[idx++] = $0
if ($0 ~ /device_type/)
device_type = 1
if ($0 ~ /};/) {
print buf[0]
if (!device_type) {
buf[0] = buf[1]
gsub(/[^\t]*/, "", buf[0])
buf[0] = buf[0] "device_type = \"memory\";"
} else {
delete buf[0]
}
for (i in buf)
print buf[i]
delete buf
go = 0
device_type = 0
}
next
}
{ print }
Gives me: 249 files changed, 249 insertions(+), 1 deletion(-) on v4.6-rc1.
Running the my check script after this reveals that 83 DTs lack the
device_type parameter, but these seem to also lack the memory node as
well. Wonder why my script didn't pick up the missing memory node in
those... I also doubt that the memory node is set by the boot loader
in some of these boards.
regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-31 16:34 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-31 16:34 UTC (permalink / raw)
To: linux-arm-kernel
On 31 March 2016 at 17:21, Joachim Eastwood <manabian@gmail.com> wrote:
> On 31 March 2016 at 12:38, Mark Rutland <mark.rutland@arm.com> wrote:
>> On Wed, Mar 30, 2016 at 10:45:06PM +0200, Joachim Eastwood wrote:
>>> On 30 March 2016 at 19:06, Mark Rutland <mark.rutland@arm.com> wrote:
>>> > On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
>>> >> I used the following script to check for the memory node in all built dtb's.
>>> >> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>>> >> for i in $(ls arch/arm/boot/dts/*.dtb); do
>>> >> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>>> >> if [ -z "$m" ]; then
>>> >> echo "Missing memory node in $i"
>>> >> fi
>>> >> done
>>> >>
>>> >> So it should be pretty safe to just remove the memory node entry in
>>> >> the skeleton files. Unless I have missed something with the script
>>> >> above.
>>> >
>>> > The above might match reserved-memory nodes; it might be better to check
>>> > for 'device_type\s*=\s*"memory"'.
>>>
>>> I did check the output of the grep and it looks good. But there are
>>> indeed DTs that are missing the 'device_type = "memory"' parameter.
>>> Actually; _a lot_ or 438 of 741 to be exact. ugh...
>>>
>>> I guess all those should be fixed up before we can remove the memory
>>> node from skeleton. :/
>>
>> Ouch, yes. :(
>>
>> That said, the cahnges don't need to be an atomic operation. We could
>> start adding device_type = "memory" to dts immediately (in as whatever
>> size batches maintainers are happy with), as a duplicate device_type
>> shouldn't be problematic.
>
> Yes, that is true.
>
>
>> When we hit critical mass, we could then remove the skeleton memory
>> nodes, fixing up any remaining fallout.
>>
>> As for the mechanical changes, it sounds like we need coccinelle for DT.
>>
>> That, or a laptop, a long flight, and a gin and tonic.
>
> :-)
>
> I'll see if I can cook up something with awk.
Something like this should do it:
#!/usr/bin/gawk -f
# find arch/arm/boot/dts/ -type f -name *.dts* | xargs
./mem_node_add_dev_type.awk -i inplace
BEGIN { go = 0 }
/[^-]memory ?{/ { go = 1; idx = 0; device_type = 0 }
go == 1 {
buf[idx++] = $0
if ($0 ~ /device_type/)
device_type = 1
if ($0 ~ /};/) {
print buf[0]
if (!device_type) {
buf[0] = buf[1]
gsub(/[^\t]*/, "", buf[0])
buf[0] = buf[0] "device_type = \"memory\";"
} else {
delete buf[0]
}
for (i in buf)
print buf[i]
delete buf
go = 0
device_type = 0
}
next
}
{ print }
Gives me: 249 files changed, 249 insertions(+), 1 deletion(-) on v4.6-rc1.
Running the my check script after this reveals that 83 DTs lack the
device_type parameter, but these seem to also lack the memory node as
well. Wonder why my script didn't pick up the missing memory node in
those... I also doubt that the memory node is set by the boot loader
in some of these boards.
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 56+ messages in thread[parent not found: <CAGhQ9VyQYeKrpPD-YhWjysvHmYaKssCO7xsU9MyRvFivEym=Hw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-31 16:34 ` Joachim Eastwood
@ 2016-04-12 22:45 ` Rob Herring
-1 siblings, 0 replies; 56+ messages in thread
From: Rob Herring @ 2016-04-12 22:45 UTC (permalink / raw)
To: Joachim Eastwood
Cc: Mark Rutland, Vladimir Zapolskiy,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree
On Thu, Mar 31, 2016 at 11:34 AM, Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 31 March 2016 at 17:21, Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On 31 March 2016 at 12:38, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
>>> On Wed, Mar 30, 2016 at 10:45:06PM +0200, Joachim Eastwood wrote:
>>>> On 30 March 2016 at 19:06, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
>>>> > On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
>>>> >> I used the following script to check for the memory node in all built dtb's.
>>>> >> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>>>> >> for i in $(ls arch/arm/boot/dts/*.dtb); do
>>>> >> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>>>> >> if [ -z "$m" ]; then
>>>> >> echo "Missing memory node in $i"
>>>> >> fi
>>>> >> done
>>>> >>
>>>> >> So it should be pretty safe to just remove the memory node entry in
>>>> >> the skeleton files. Unless I have missed something with the script
>>>> >> above.
>>>> >
>>>> > The above might match reserved-memory nodes; it might be better to check
>>>> > for 'device_type\s*=\s*"memory"'.
>>>>
>>>> I did check the output of the grep and it looks good. But there are
>>>> indeed DTs that are missing the 'device_type = "memory"' parameter.
>>>> Actually; _a lot_ or 438 of 741 to be exact. ugh...
>>>>
>>>> I guess all those should be fixed up before we can remove the memory
>>>> node from skeleton. :/
>>>
>>> Ouch, yes. :(
>>>
>>> That said, the cahnges don't need to be an atomic operation. We could
>>> start adding device_type = "memory" to dts immediately (in as whatever
>>> size batches maintainers are happy with), as a duplicate device_type
>>> shouldn't be problematic.
>>
>> Yes, that is true.
>>
>>
>>> When we hit critical mass, we could then remove the skeleton memory
>>> nodes, fixing up any remaining fallout.
>>>
>>> As for the mechanical changes, it sounds like we need coccinelle for DT.
>>>
>>> That, or a laptop, a long flight, and a gin and tonic.
>>
>> :-)
>>
>> I'll see if I can cook up something with awk.
>
> Something like this should do it:
> #!/usr/bin/gawk -f
> # find arch/arm/boot/dts/ -type f -name *.dts* | xargs
> ./mem_node_add_dev_type.awk -i inplace
> BEGIN { go = 0 }
> /[^-]memory ?{/ { go = 1; idx = 0; device_type = 0 }
>
> go == 1 {
> buf[idx++] = $0
> if ($0 ~ /device_type/)
> device_type = 1
>
> if ($0 ~ /};/) {
> print buf[0]
>
> if (!device_type) {
> buf[0] = buf[1]
> gsub(/[^\t]*/, "", buf[0])
> buf[0] = buf[0] "device_type = \"memory\";"
> } else {
> delete buf[0]
> }
>
> for (i in buf)
> print buf[i]
> delete buf
>
> go = 0
> device_type = 0
> }
> next
> }
>
> { print }
>
> Gives me: 249 files changed, 249 insertions(+), 1 deletion(-) on v4.6-rc1.
>
> Running the my check script after this reveals that 83 DTs lack the
> device_type parameter, but these seem to also lack the memory node as
> well. Wonder why my script didn't pick up the missing memory node in
> those... I also doubt that the memory node is set by the boot loader
> in some of these boards.
I don't think this script is right. It will not work if the memory
node is spread across dtsi files. You would need to compiler
everything to dtb and then back to a flat dts file before running thru
this script.
I don't see the rest of the series in -next. Is that going to happen soon?
Rob
>
>
> regards,
> Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-04-12 22:45 ` Rob Herring
0 siblings, 0 replies; 56+ messages in thread
From: Rob Herring @ 2016-04-12 22:45 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Mar 31, 2016 at 11:34 AM, Joachim Eastwood <manabian@gmail.com> wrote:
> On 31 March 2016 at 17:21, Joachim Eastwood <manabian@gmail.com> wrote:
>> On 31 March 2016 at 12:38, Mark Rutland <mark.rutland@arm.com> wrote:
>>> On Wed, Mar 30, 2016 at 10:45:06PM +0200, Joachim Eastwood wrote:
>>>> On 30 March 2016 at 19:06, Mark Rutland <mark.rutland@arm.com> wrote:
>>>> > On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
>>>> >> I used the following script to check for the memory node in all built dtb's.
>>>> >> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>>>> >> for i in $(ls arch/arm/boot/dts/*.dtb); do
>>>> >> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>>>> >> if [ -z "$m" ]; then
>>>> >> echo "Missing memory node in $i"
>>>> >> fi
>>>> >> done
>>>> >>
>>>> >> So it should be pretty safe to just remove the memory node entry in
>>>> >> the skeleton files. Unless I have missed something with the script
>>>> >> above.
>>>> >
>>>> > The above might match reserved-memory nodes; it might be better to check
>>>> > for 'device_type\s*=\s*"memory"'.
>>>>
>>>> I did check the output of the grep and it looks good. But there are
>>>> indeed DTs that are missing the 'device_type = "memory"' parameter.
>>>> Actually; _a lot_ or 438 of 741 to be exact. ugh...
>>>>
>>>> I guess all those should be fixed up before we can remove the memory
>>>> node from skeleton. :/
>>>
>>> Ouch, yes. :(
>>>
>>> That said, the cahnges don't need to be an atomic operation. We could
>>> start adding device_type = "memory" to dts immediately (in as whatever
>>> size batches maintainers are happy with), as a duplicate device_type
>>> shouldn't be problematic.
>>
>> Yes, that is true.
>>
>>
>>> When we hit critical mass, we could then remove the skeleton memory
>>> nodes, fixing up any remaining fallout.
>>>
>>> As for the mechanical changes, it sounds like we need coccinelle for DT.
>>>
>>> That, or a laptop, a long flight, and a gin and tonic.
>>
>> :-)
>>
>> I'll see if I can cook up something with awk.
>
> Something like this should do it:
> #!/usr/bin/gawk -f
> # find arch/arm/boot/dts/ -type f -name *.dts* | xargs
> ./mem_node_add_dev_type.awk -i inplace
> BEGIN { go = 0 }
> /[^-]memory ?{/ { go = 1; idx = 0; device_type = 0 }
>
> go == 1 {
> buf[idx++] = $0
> if ($0 ~ /device_type/)
> device_type = 1
>
> if ($0 ~ /};/) {
> print buf[0]
>
> if (!device_type) {
> buf[0] = buf[1]
> gsub(/[^\t]*/, "", buf[0])
> buf[0] = buf[0] "device_type = \"memory\";"
> } else {
> delete buf[0]
> }
>
> for (i in buf)
> print buf[i]
> delete buf
>
> go = 0
> device_type = 0
> }
> next
> }
>
> { print }
>
> Gives me: 249 files changed, 249 insertions(+), 1 deletion(-) on v4.6-rc1.
>
> Running the my check script after this reveals that 83 DTs lack the
> device_type parameter, but these seem to also lack the memory node as
> well. Wonder why my script didn't pick up the missing memory node in
> those... I also doubt that the memory node is set by the boot loader
> in some of these boards.
I don't think this script is right. It will not work if the memory
node is spread across dtsi files. You would need to compiler
everything to dtb and then back to a flat dts file before running thru
this script.
I don't see the rest of the series in -next. Is that going to happen soon?
Rob
>
>
> regards,
> Joachim Eastwood
^ permalink raw reply [flat|nested] 56+ messages in thread[parent not found: <CAL_JsqK7Fwk0CTW420=NFja5Asq22ckanWZGWp0G7Wo4rS9gkQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-04-12 22:45 ` Rob Herring
@ 2016-04-12 23:03 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-04-12 23:03 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, Vladimir Zapolskiy,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree
On 13 April 2016 at 00:45, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Thu, Mar 31, 2016 at 11:34 AM, Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On 31 March 2016 at 17:21, Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>> On 31 March 2016 at 12:38, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
>>>> On Wed, Mar 30, 2016 at 10:45:06PM +0200, Joachim Eastwood wrote:
>>>>> On 30 March 2016 at 19:06, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
>>>>> > On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
>>>>> >> I used the following script to check for the memory node in all built dtb's.
>>>>> >> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>>>>> >> for i in $(ls arch/arm/boot/dts/*.dtb); do
>>>>> >> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>>>>> >> if [ -z "$m" ]; then
>>>>> >> echo "Missing memory node in $i"
>>>>> >> fi
>>>>> >> done
>>>>> >>
>>>>> >> So it should be pretty safe to just remove the memory node entry in
>>>>> >> the skeleton files. Unless I have missed something with the script
>>>>> >> above.
>>>>> >
>>>>> > The above might match reserved-memory nodes; it might be better to check
>>>>> > for 'device_type\s*=\s*"memory"'.
>>>>>
>>>>> I did check the output of the grep and it looks good. But there are
>>>>> indeed DTs that are missing the 'device_type = "memory"' parameter.
>>>>> Actually; _a lot_ or 438 of 741 to be exact. ugh...
>>>>>
>>>>> I guess all those should be fixed up before we can remove the memory
>>>>> node from skeleton. :/
>>>>
>>>> Ouch, yes. :(
>>>>
>>>> That said, the cahnges don't need to be an atomic operation. We could
>>>> start adding device_type = "memory" to dts immediately (in as whatever
>>>> size batches maintainers are happy with), as a duplicate device_type
>>>> shouldn't be problematic.
>>>
>>> Yes, that is true.
>>>
>>>
>>>> When we hit critical mass, we could then remove the skeleton memory
>>>> nodes, fixing up any remaining fallout.
>>>>
>>>> As for the mechanical changes, it sounds like we need coccinelle for DT.
>>>>
>>>> That, or a laptop, a long flight, and a gin and tonic.
>>>
>>> :-)
>>>
>>> I'll see if I can cook up something with awk.
>>
>> Something like this should do it:
>> #!/usr/bin/gawk -f
>> # find arch/arm/boot/dts/ -type f -name *.dts* | xargs
>> ./mem_node_add_dev_type.awk -i inplace
>> BEGIN { go = 0 }
>> /[^-]memory ?{/ { go = 1; idx = 0; device_type = 0 }
>>
>> go == 1 {
>> buf[idx++] = $0
>> if ($0 ~ /device_type/)
>> device_type = 1
>>
>> if ($0 ~ /};/) {
>> print buf[0]
>>
>> if (!device_type) {
>> buf[0] = buf[1]
>> gsub(/[^\t]*/, "", buf[0])
>> buf[0] = buf[0] "device_type = \"memory\";"
>> } else {
>> delete buf[0]
>> }
>>
>> for (i in buf)
>> print buf[i]
>> delete buf
>>
>> go = 0
>> device_type = 0
>> }
>> next
>> }
>>
>> { print }
>>
>> Gives me: 249 files changed, 249 insertions(+), 1 deletion(-) on v4.6-rc1.
>>
>> Running the my check script after this reveals that 83 DTs lack the
>> device_type parameter, but these seem to also lack the memory node as
>> well. Wonder why my script didn't pick up the missing memory node in
>> those... I also doubt that the memory node is set by the boot loader
>> in some of these boards.
>
> I don't think this script is right. It will not work if the memory
> node is spread across dtsi files. You would need to compiler
> everything to dtb and then back to a flat dts file before running thru
> this script.
The script will simply add 'device_type = memory' to all dts and dtsi
files that are missing this property.
What do you by spread across dtsi files? Got an example DT that I
could take a look at?
> I don't see the rest of the series in -next. Is that going to happen soon?
Pull request was sent to arm-soc some time ago, but it seems they
haven't pulled in anything for 4.7 yet.
Link: http://permalink.gmane.org/gmane.linux.ports.arm.kernel/490303
(All memory node "fixes" was removed from this pull request)
regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-04-12 23:03 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-04-12 23:03 UTC (permalink / raw)
To: linux-arm-kernel
On 13 April 2016 at 00:45, Rob Herring <robh+dt@kernel.org> wrote:
> On Thu, Mar 31, 2016 at 11:34 AM, Joachim Eastwood <manabian@gmail.com> wrote:
>> On 31 March 2016 at 17:21, Joachim Eastwood <manabian@gmail.com> wrote:
>>> On 31 March 2016 at 12:38, Mark Rutland <mark.rutland@arm.com> wrote:
>>>> On Wed, Mar 30, 2016 at 10:45:06PM +0200, Joachim Eastwood wrote:
>>>>> On 30 March 2016 at 19:06, Mark Rutland <mark.rutland@arm.com> wrote:
>>>>> > On Wed, Mar 30, 2016 at 06:15:35PM +0200, Joachim Eastwood wrote:
>>>>> >> I used the following script to check for the memory node in all built dtb's.
>>>>> >> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>>>>> >> for i in $(ls arch/arm/boot/dts/*.dtb); do
>>>>> >> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>>>>> >> if [ -z "$m" ]; then
>>>>> >> echo "Missing memory node in $i"
>>>>> >> fi
>>>>> >> done
>>>>> >>
>>>>> >> So it should be pretty safe to just remove the memory node entry in
>>>>> >> the skeleton files. Unless I have missed something with the script
>>>>> >> above.
>>>>> >
>>>>> > The above might match reserved-memory nodes; it might be better to check
>>>>> > for 'device_type\s*=\s*"memory"'.
>>>>>
>>>>> I did check the output of the grep and it looks good. But there are
>>>>> indeed DTs that are missing the 'device_type = "memory"' parameter.
>>>>> Actually; _a lot_ or 438 of 741 to be exact. ugh...
>>>>>
>>>>> I guess all those should be fixed up before we can remove the memory
>>>>> node from skeleton. :/
>>>>
>>>> Ouch, yes. :(
>>>>
>>>> That said, the cahnges don't need to be an atomic operation. We could
>>>> start adding device_type = "memory" to dts immediately (in as whatever
>>>> size batches maintainers are happy with), as a duplicate device_type
>>>> shouldn't be problematic.
>>>
>>> Yes, that is true.
>>>
>>>
>>>> When we hit critical mass, we could then remove the skeleton memory
>>>> nodes, fixing up any remaining fallout.
>>>>
>>>> As for the mechanical changes, it sounds like we need coccinelle for DT.
>>>>
>>>> That, or a laptop, a long flight, and a gin and tonic.
>>>
>>> :-)
>>>
>>> I'll see if I can cook up something with awk.
>>
>> Something like this should do it:
>> #!/usr/bin/gawk -f
>> # find arch/arm/boot/dts/ -type f -name *.dts* | xargs
>> ./mem_node_add_dev_type.awk -i inplace
>> BEGIN { go = 0 }
>> /[^-]memory ?{/ { go = 1; idx = 0; device_type = 0 }
>>
>> go == 1 {
>> buf[idx++] = $0
>> if ($0 ~ /device_type/)
>> device_type = 1
>>
>> if ($0 ~ /};/) {
>> print buf[0]
>>
>> if (!device_type) {
>> buf[0] = buf[1]
>> gsub(/[^\t]*/, "", buf[0])
>> buf[0] = buf[0] "device_type = \"memory\";"
>> } else {
>> delete buf[0]
>> }
>>
>> for (i in buf)
>> print buf[i]
>> delete buf
>>
>> go = 0
>> device_type = 0
>> }
>> next
>> }
>>
>> { print }
>>
>> Gives me: 249 files changed, 249 insertions(+), 1 deletion(-) on v4.6-rc1.
>>
>> Running the my check script after this reveals that 83 DTs lack the
>> device_type parameter, but these seem to also lack the memory node as
>> well. Wonder why my script didn't pick up the missing memory node in
>> those... I also doubt that the memory node is set by the boot loader
>> in some of these boards.
>
> I don't think this script is right. It will not work if the memory
> node is spread across dtsi files. You would need to compiler
> everything to dtb and then back to a flat dts file before running thru
> this script.
The script will simply add 'device_type = memory' to all dts and dtsi
files that are missing this property.
What do you by spread across dtsi files? Got an example DT that I
could take a look at?
> I don't see the rest of the series in -next. Is that going to happen soon?
Pull request was sent to arm-soc some time ago, but it seems they
haven't pulled in anything for 4.7 yet.
Link: http://permalink.gmane.org/gmane.linux.ports.arm.kernel/490303
(All memory node "fixes" was removed from this pull request)
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-30 16:15 ` Joachim Eastwood
@ 2016-03-31 16:27 ` Rob Herring
-1 siblings, 0 replies; 56+ messages in thread
From: Rob Herring @ 2016-03-31 16:27 UTC (permalink / raw)
To: Joachim Eastwood
Cc: Mark Rutland, Vladimir Zapolskiy,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree
On Wed, Mar 30, 2016 at 11:15 AM, Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hi Mark,
>
> On 30 March 2016 at 15:41, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
>> On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
>>> On 30.03.2016 14:06, Mark Rutland wrote:
>>> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>>> >> Add unit name to memory to remove the following warning:
>>> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>>> >> property, but no unit name
>>> >
>>> > If anything, it would be better to get rid of the memory node from the
>>> > skeleton DTs.
>>> >
>>> > For DTs which have a memory node there's no problem, and DTs which
>>> > expect a bootlaoder to fill things in have a logical place to document
>>> > that fact.
>>
>>> The only problem I see if DTB is updated on a board but a board bootloader
>>> on fix-up is capable to fill a preexisting "/memory" device node in only,
>>> otherwise it is not clear why the device node is present in skeleton.dtsi.
>>
>> Sure. To clarify the above, what I expect that for this case is that the
>> empty memory node would exist in the dts for that particular board,
>> along with a comment, e.g.
>>
>> /* The firmware/bootloader for $BOARD fills this in */
>> memory {
>> device_type = "memory";
>> reg = <0 0 0 0>;
>> };
>
> To avoid the warning with the new dtc this would need to be memory@0.
Except memory is probably not actually at 0 here. This has come up
before and been beaten to death. Bottom line is plain "memory" is
allowed, and I plan to add that exception to dtc.
>> That way you can tell at a glance that the lack of memory information in
>> the DT for a board is intentional, and the bootloader still gets the
>> node it expects.
>
>
> But this doesn't seem to be a "problem" with any of the DTs in
> arch/arm/boot as they all defined a memory node.
>
> I used the following script to check for the memory node in all built dtb's.
> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
> for i in $(ls arch/arm/boot/dts/*.dtb); do
> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
> if [ -z "$m" ]; then
> echo "Missing memory node in $i"
> fi
> done
>
> So it should be pretty safe to just remove the memory node entry in
> the skeleton files. Unless I have missed something with the script
> above.
You've got to make sure they have 'device_type = "memory";' which they
could rely on inheriting.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-31 16:27 ` Rob Herring
0 siblings, 0 replies; 56+ messages in thread
From: Rob Herring @ 2016-03-31 16:27 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 30, 2016 at 11:15 AM, Joachim Eastwood <manabian@gmail.com> wrote:
> Hi Mark,
>
> On 30 March 2016 at 15:41, Mark Rutland <mark.rutland@arm.com> wrote:
>> On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
>>> On 30.03.2016 14:06, Mark Rutland wrote:
>>> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>>> >> Add unit name to memory to remove the following warning:
>>> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>>> >> property, but no unit name
>>> >
>>> > If anything, it would be better to get rid of the memory node from the
>>> > skeleton DTs.
>>> >
>>> > For DTs which have a memory node there's no problem, and DTs which
>>> > expect a bootlaoder to fill things in have a logical place to document
>>> > that fact.
>>
>>> The only problem I see if DTB is updated on a board but a board bootloader
>>> on fix-up is capable to fill a preexisting "/memory" device node in only,
>>> otherwise it is not clear why the device node is present in skeleton.dtsi.
>>
>> Sure. To clarify the above, what I expect that for this case is that the
>> empty memory node would exist in the dts for that particular board,
>> along with a comment, e.g.
>>
>> /* The firmware/bootloader for $BOARD fills this in */
>> memory {
>> device_type = "memory";
>> reg = <0 0 0 0>;
>> };
>
> To avoid the warning with the new dtc this would need to be memory at 0.
Except memory is probably not actually at 0 here. This has come up
before and been beaten to death. Bottom line is plain "memory" is
allowed, and I plan to add that exception to dtc.
>> That way you can tell at a glance that the lack of memory information in
>> the DT for a board is intentional, and the bootloader still gets the
>> node it expects.
>
>
> But this doesn't seem to be a "problem" with any of the DTs in
> arch/arm/boot as they all defined a memory node.
>
> I used the following script to check for the memory node in all built dtb's.
> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
> for i in $(ls arch/arm/boot/dts/*.dtb); do
> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
> if [ -z "$m" ]; then
> echo "Missing memory node in $i"
> fi
> done
>
> So it should be pretty safe to just remove the memory node entry in
> the skeleton files. Unless I have missed something with the script
> above.
You've got to make sure they have 'device_type = "memory";' which they
could rely on inheriting.
Rob
^ permalink raw reply [flat|nested] 56+ messages in thread[parent not found: <CAL_JsqKYx=sUjo-UTXSAFh3UpHLyTPFHwx5xg=Px-RVabHJ-Ew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-31 16:27 ` Rob Herring
@ 2016-03-31 16:31 ` Rob Herring
-1 siblings, 0 replies; 56+ messages in thread
From: Rob Herring @ 2016-03-31 16:31 UTC (permalink / raw)
To: Joachim Eastwood
Cc: Mark Rutland, Vladimir Zapolskiy,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree
On Thu, Mar 31, 2016 at 11:27 AM, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Wed, Mar 30, 2016 at 11:15 AM, Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> Hi Mark,
>>
>> On 30 March 2016 at 15:41, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
>>> On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
>>>> On 30.03.2016 14:06, Mark Rutland wrote:
>>>> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>>>> >> Add unit name to memory to remove the following warning:
>>>> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>>>> >> property, but no unit name
>>>> >
>>>> > If anything, it would be better to get rid of the memory node from the
>>>> > skeleton DTs.
>>>> >
>>>> > For DTs which have a memory node there's no problem, and DTs which
>>>> > expect a bootlaoder to fill things in have a logical place to document
>>>> > that fact.
>>>
>>>> The only problem I see if DTB is updated on a board but a board bootloader
>>>> on fix-up is capable to fill a preexisting "/memory" device node in only,
>>>> otherwise it is not clear why the device node is present in skeleton.dtsi.
>>>
>>> Sure. To clarify the above, what I expect that for this case is that the
>>> empty memory node would exist in the dts for that particular board,
>>> along with a comment, e.g.
>>>
>>> /* The firmware/bootloader for $BOARD fills this in */
>>> memory {
>>> device_type = "memory";
>>> reg = <0 0 0 0>;
>>> };
>>
>> To avoid the warning with the new dtc this would need to be memory@0.
>
> Except memory is probably not actually at 0 here. This has come up
> before and been beaten to death. Bottom line is plain "memory" is
> allowed, and I plan to add that exception to dtc.
>
>>> That way you can tell at a glance that the lack of memory information in
>>> the DT for a board is intentional, and the bootloader still gets the
>>> node it expects.
>>
>>
>> But this doesn't seem to be a "problem" with any of the DTs in
>> arch/arm/boot as they all defined a memory node.
>>
>> I used the following script to check for the memory node in all built dtb's.
>> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>> for i in $(ls arch/arm/boot/dts/*.dtb); do
>> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>> if [ -z "$m" ]; then
>> echo "Missing memory node in $i"
>> fi
>> done
>>
>> So it should be pretty safe to just remove the memory node entry in
>> the skeleton files. Unless I have missed something with the script
>> above.
>
> You've got to make sure they have 'device_type = "memory";' which they
> could rely on inheriting.
BTW, you could add this as a check to dtc and then it will find all
the missing ones for you.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-31 16:31 ` Rob Herring
0 siblings, 0 replies; 56+ messages in thread
From: Rob Herring @ 2016-03-31 16:31 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Mar 31, 2016 at 11:27 AM, Rob Herring <robh+dt@kernel.org> wrote:
> On Wed, Mar 30, 2016 at 11:15 AM, Joachim Eastwood <manabian@gmail.com> wrote:
>> Hi Mark,
>>
>> On 30 March 2016 at 15:41, Mark Rutland <mark.rutland@arm.com> wrote:
>>> On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
>>>> On 30.03.2016 14:06, Mark Rutland wrote:
>>>> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>>>> >> Add unit name to memory to remove the following warning:
>>>> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>>>> >> property, but no unit name
>>>> >
>>>> > If anything, it would be better to get rid of the memory node from the
>>>> > skeleton DTs.
>>>> >
>>>> > For DTs which have a memory node there's no problem, and DTs which
>>>> > expect a bootlaoder to fill things in have a logical place to document
>>>> > that fact.
>>>
>>>> The only problem I see if DTB is updated on a board but a board bootloader
>>>> on fix-up is capable to fill a preexisting "/memory" device node in only,
>>>> otherwise it is not clear why the device node is present in skeleton.dtsi.
>>>
>>> Sure. To clarify the above, what I expect that for this case is that the
>>> empty memory node would exist in the dts for that particular board,
>>> along with a comment, e.g.
>>>
>>> /* The firmware/bootloader for $BOARD fills this in */
>>> memory {
>>> device_type = "memory";
>>> reg = <0 0 0 0>;
>>> };
>>
>> To avoid the warning with the new dtc this would need to be memory at 0.
>
> Except memory is probably not actually at 0 here. This has come up
> before and been beaten to death. Bottom line is plain "memory" is
> allowed, and I plan to add that exception to dtc.
>
>>> That way you can tell at a glance that the lack of memory information in
>>> the DT for a board is intentional, and the bootloader still gets the
>>> node it expects.
>>
>>
>> But this doesn't seem to be a "problem" with any of the DTs in
>> arch/arm/boot as they all defined a memory node.
>>
>> I used the following script to check for the memory node in all built dtb's.
>> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>> for i in $(ls arch/arm/boot/dts/*.dtb); do
>> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>> if [ -z "$m" ]; then
>> echo "Missing memory node in $i"
>> fi
>> done
>>
>> So it should be pretty safe to just remove the memory node entry in
>> the skeleton files. Unless I have missed something with the script
>> above.
>
> You've got to make sure they have 'device_type = "memory";' which they
> could rely on inheriting.
BTW, you could add this as a check to dtc and then it will find all
the missing ones for you.
Rob
^ permalink raw reply [flat|nested] 56+ messages in thread[parent not found: <CAL_JsqKMV-k7VkzLsKMAZ9yzwoNS2nw-=DwK+MYCZkOh97P5FA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
2016-03-31 16:31 ` Rob Herring
@ 2016-03-31 16:33 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-31 16:33 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, Vladimir Zapolskiy,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree
On 31 March 2016 at 18:31, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Thu, Mar 31, 2016 at 11:27 AM, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>> On Wed, Mar 30, 2016 at 11:15 AM, Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>> Hi Mark,
>>>
>>> On 30 March 2016 at 15:41, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
>>>> On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
>>>>> On 30.03.2016 14:06, Mark Rutland wrote:
>>>>> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>>>>> >> Add unit name to memory to remove the following warning:
>>>>> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>>>>> >> property, but no unit name
>>>>> >
>>>>> > If anything, it would be better to get rid of the memory node from the
>>>>> > skeleton DTs.
>>>>> >
>>>>> > For DTs which have a memory node there's no problem, and DTs which
>>>>> > expect a bootlaoder to fill things in have a logical place to document
>>>>> > that fact.
>>>>
>>>>> The only problem I see if DTB is updated on a board but a board bootloader
>>>>> on fix-up is capable to fill a preexisting "/memory" device node in only,
>>>>> otherwise it is not clear why the device node is present in skeleton.dtsi.
>>>>
>>>> Sure. To clarify the above, what I expect that for this case is that the
>>>> empty memory node would exist in the dts for that particular board,
>>>> along with a comment, e.g.
>>>>
>>>> /* The firmware/bootloader for $BOARD fills this in */
>>>> memory {
>>>> device_type = "memory";
>>>> reg = <0 0 0 0>;
>>>> };
>>>
>>> To avoid the warning with the new dtc this would need to be memory@0.
>>
>> Except memory is probably not actually at 0 here. This has come up
>> before and been beaten to death. Bottom line is plain "memory" is
>> allowed, and I plan to add that exception to dtc.
Okey, good.
>>>> That way you can tell at a glance that the lack of memory information in
>>>> the DT for a board is intentional, and the bootloader still gets the
>>>> node it expects.
>>>
>>>
>>> But this doesn't seem to be a "problem" with any of the DTs in
>>> arch/arm/boot as they all defined a memory node.
>>>
>>> I used the following script to check for the memory node in all built dtb's.
>>> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>>> for i in $(ls arch/arm/boot/dts/*.dtb); do
>>> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>>> if [ -z "$m" ]; then
>>> echo "Missing memory node in $i"
>>> fi
>>> done
>>>
>>> So it should be pretty safe to just remove the memory node entry in
>>> the skeleton files. Unless I have missed something with the script
>>> above.
>>
>> You've got to make sure they have 'device_type = "memory";' which they
>> could rely on inheriting.
>
> BTW, you could add this as a check to dtc and then it will find all
> the missing ones for you.
I have created a script now that will check and add it if it is missing.
regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 56+ messages in thread* [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
@ 2016-03-31 16:33 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-31 16:33 UTC (permalink / raw)
To: linux-arm-kernel
On 31 March 2016 at 18:31, Rob Herring <robh+dt@kernel.org> wrote:
> On Thu, Mar 31, 2016 at 11:27 AM, Rob Herring <robh+dt@kernel.org> wrote:
>> On Wed, Mar 30, 2016 at 11:15 AM, Joachim Eastwood <manabian@gmail.com> wrote:
>>> Hi Mark,
>>>
>>> On 30 March 2016 at 15:41, Mark Rutland <mark.rutland@arm.com> wrote:
>>>> On Wed, Mar 30, 2016 at 04:06:56PM +0300, Vladimir Zapolskiy wrote:
>>>>> On 30.03.2016 14:06, Mark Rutland wrote:
>>>>> > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
>>>>> >> Add unit name to memory to remove the following warning:
>>>>> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>>>>> >> property, but no unit name
>>>>> >
>>>>> > If anything, it would be better to get rid of the memory node from the
>>>>> > skeleton DTs.
>>>>> >
>>>>> > For DTs which have a memory node there's no problem, and DTs which
>>>>> > expect a bootlaoder to fill things in have a logical place to document
>>>>> > that fact.
>>>>
>>>>> The only problem I see if DTB is updated on a board but a board bootloader
>>>>> on fix-up is capable to fill a preexisting "/memory" device node in only,
>>>>> otherwise it is not clear why the device node is present in skeleton.dtsi.
>>>>
>>>> Sure. To clarify the above, what I expect that for this case is that the
>>>> empty memory node would exist in the dts for that particular board,
>>>> along with a comment, e.g.
>>>>
>>>> /* The firmware/bootloader for $BOARD fills this in */
>>>> memory {
>>>> device_type = "memory";
>>>> reg = <0 0 0 0>;
>>>> };
>>>
>>> To avoid the warning with the new dtc this would need to be memory at 0.
>>
>> Except memory is probably not actually at 0 here. This has come up
>> before and been beaten to death. Bottom line is plain "memory" is
>> allowed, and I plan to add that exception to dtc.
Okey, good.
>>>> That way you can tell at a glance that the lack of memory information in
>>>> the DT for a board is intentional, and the bootloader still gets the
>>>> node it expects.
>>>
>>>
>>> But this doesn't seem to be a "problem" with any of the DTs in
>>> arch/arm/boot as they all defined a memory node.
>>>
>>> I used the following script to check for the memory node in all built dtb's.
>>> make ARCH=arm CONFIG_OF_ALL_DTBS=y dtbs
>>> for i in $(ls arch/arm/boot/dts/*.dtb); do
>>> m=$(scripts/dtc/dtc -I dtb -O dts $i | grep -m1 'memory.*{')
>>> if [ -z "$m" ]; then
>>> echo "Missing memory node in $i"
>>> fi
>>> done
>>>
>>> So it should be pretty safe to just remove the memory node entry in
>>> the skeleton files. Unless I have missed something with the script
>>> above.
>>
>> You've got to make sure they have 'device_type = "memory";' which they
>> could rely on inheriting.
>
> BTW, you could add this as a check to dtc and then it will find all
> the missing ones for you.
I have created a script now that will check and add it if it is missing.
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH 3/7] ARM: dts: lpc18xx: remove unit addresses from creg childs
2016-03-29 22:30 ` Joachim Eastwood
@ 2016-03-29 22:30 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Joachim Eastwood, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA
DT nodes without reg properties should not have a unit address. This
fixes the following warnings from dtc.
Warning (unit_address_vs_reg): Node /soc/syscon@40043000/phy@004 has a
unit name, but no reg property
Warning (unit_address_vs_reg): Node /soc/syscon@40043000/dma-mux@11c has
a unit name, but no reg property
Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/lpc18xx.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/lpc18xx.dtsi
index fdc991b..fdb736c 100644
--- a/arch/arm/boot/dts/lpc18xx.dtsi
+++ b/arch/arm/boot/dts/lpc18xx.dtsi
@@ -201,13 +201,13 @@
#clock-cells = <1>;
};
- usb0_otg_phy: phy@004 {
+ usb0_otg_phy: phy {
compatible = "nxp,lpc1850-usb-otg-phy";
clocks = <&ccu1 CLK_USB0>;
#phy-cells = <0>;
};
- dmamux: dma-mux@11c {
+ dmamux: dma-mux {
compatible = "nxp,lpc1850-dmamux";
#dma-cells = <3>;
dma-requests = <64>;
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 56+ messages in thread* [PATCH 3/7] ARM: dts: lpc18xx: remove unit addresses from creg childs
@ 2016-03-29 22:30 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel
DT nodes without reg properties should not have a unit address. This
fixes the following warnings from dtc.
Warning (unit_address_vs_reg): Node /soc/syscon at 40043000/phy at 004 has a
unit name, but no reg property
Warning (unit_address_vs_reg): Node /soc/syscon at 40043000/dma-mux at 11c has
a unit name, but no reg property
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
arch/arm/boot/dts/lpc18xx.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/lpc18xx.dtsi
index fdc991b..fdb736c 100644
--- a/arch/arm/boot/dts/lpc18xx.dtsi
+++ b/arch/arm/boot/dts/lpc18xx.dtsi
@@ -201,13 +201,13 @@
#clock-cells = <1>;
};
- usb0_otg_phy: phy at 004 {
+ usb0_otg_phy: phy {
compatible = "nxp,lpc1850-usb-otg-phy";
clocks = <&ccu1 CLK_USB0>;
#phy-cells = <0>;
};
- dmamux: dma-mux at 11c {
+ dmamux: dma-mux {
compatible = "nxp,lpc1850-dmamux";
#dma-cells = <3>;
dma-requests = <64>;
--
2.7.4
^ permalink raw reply related [flat|nested] 56+ messages in thread
* [PATCH 4/7] ARM: dts: lpc4357-ea4357: fix unit name warnings from dtc
2016-03-29 22:30 ` Joachim Eastwood
@ 2016-03-29 22:30 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Joachim Eastwood, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA
Fix the following warnings from dtc by either adding or removing
the unit name from the node.
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/flash-controller@40003000/flash@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /gpio_joystick/button@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /gpio_joystick/button@1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /gpio_joystick/button@2 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /gpio_joystick/button@3 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /gpio_joystick/button@4 has a unit name, but no reg property
Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/lpc4357-ea4357-devkit.dts | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/lpc4357-ea4357-devkit.dts b/arch/arm/boot/dts/lpc4357-ea4357-devkit.dts
index a211b6e..9b5fad6 100644
--- a/arch/arm/boot/dts/lpc4357-ea4357-devkit.dts
+++ b/arch/arm/boot/dts/lpc4357-ea4357-devkit.dts
@@ -33,7 +33,7 @@
stdout-path = &uart0;
};
- memory {
+ memory@28000000 {
device_type = "memory";
reg = <0x28000000 0x2000000>; /* 32 MB */
};
@@ -62,31 +62,31 @@
poll-interval = <100>;
autorepeat;
- button@0 {
+ button0 {
label = "joy_enter";
linux,code = <KEY_ENTER>;
gpios = <&gpio LPC_GPIO(4,8) GPIO_ACTIVE_LOW>;
};
- button@1 {
+ button1 {
label = "joy_left";
linux,code = <KEY_LEFT>;
gpios = <&gpio LPC_GPIO(4,9) GPIO_ACTIVE_LOW>;
};
- button@2 {
+ button2 {
label = "joy_up";
linux,code = <KEY_UP>;
gpios = <&gpio LPC_GPIO(4,10) GPIO_ACTIVE_LOW>;
};
- button@3 {
+ button3 {
label = "joy_right";
linux,code = <KEY_RIGHT>;
gpios = <&gpio LPC_GPIO(4,12) GPIO_ACTIVE_LOW>;
};
- button@4 {
+ button4 {
label = "joy_down";
linux,code = <KEY_DOWN>;
gpios = <&gpio LPC_GPIO(4,13) GPIO_ACTIVE_LOW>;
@@ -584,7 +584,7 @@
pinctrl-names = "default";
pinctrl-0 = <&spifi_pins>;
- flash@0 {
+ flash {
compatible = "jedec,spi-nor";
spi-cpol;
spi-cpha;
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 56+ messages in thread* [PATCH 4/7] ARM: dts: lpc4357-ea4357: fix unit name warnings from dtc
@ 2016-03-29 22:30 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel
Fix the following warnings from dtc by either adding or removing
the unit name from the node.
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/flash-controller at 40003000/flash at 0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /gpio_joystick/button at 0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /gpio_joystick/button at 1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /gpio_joystick/button at 2 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /gpio_joystick/button at 3 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /gpio_joystick/button at 4 has a unit name, but no reg property
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
arch/arm/boot/dts/lpc4357-ea4357-devkit.dts | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/lpc4357-ea4357-devkit.dts b/arch/arm/boot/dts/lpc4357-ea4357-devkit.dts
index a211b6e..9b5fad6 100644
--- a/arch/arm/boot/dts/lpc4357-ea4357-devkit.dts
+++ b/arch/arm/boot/dts/lpc4357-ea4357-devkit.dts
@@ -33,7 +33,7 @@
stdout-path = &uart0;
};
- memory {
+ memory at 28000000 {
device_type = "memory";
reg = <0x28000000 0x2000000>; /* 32 MB */
};
@@ -62,31 +62,31 @@
poll-interval = <100>;
autorepeat;
- button at 0 {
+ button0 {
label = "joy_enter";
linux,code = <KEY_ENTER>;
gpios = <&gpio LPC_GPIO(4,8) GPIO_ACTIVE_LOW>;
};
- button at 1 {
+ button1 {
label = "joy_left";
linux,code = <KEY_LEFT>;
gpios = <&gpio LPC_GPIO(4,9) GPIO_ACTIVE_LOW>;
};
- button at 2 {
+ button2 {
label = "joy_up";
linux,code = <KEY_UP>;
gpios = <&gpio LPC_GPIO(4,10) GPIO_ACTIVE_LOW>;
};
- button at 3 {
+ button3 {
label = "joy_right";
linux,code = <KEY_RIGHT>;
gpios = <&gpio LPC_GPIO(4,12) GPIO_ACTIVE_LOW>;
};
- button at 4 {
+ button4 {
label = "joy_down";
linux,code = <KEY_DOWN>;
gpios = <&gpio LPC_GPIO(4,13) GPIO_ACTIVE_LOW>;
@@ -584,7 +584,7 @@
pinctrl-names = "default";
pinctrl-0 = <&spifi_pins>;
- flash at 0 {
+ flash {
compatible = "jedec,spi-nor";
spi-cpol;
spi-cpha;
--
2.7.4
^ permalink raw reply related [flat|nested] 56+ messages in thread
* [PATCH 5/7] ARM: dts: lpc4350-hitex-eval: fix unit name warnings from dtc
2016-03-29 22:30 ` Joachim Eastwood
@ 2016-03-29 22:30 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Joachim Eastwood, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA
Fix the following warnings from dtc by either adding or removing
the unit name from the node.
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/flash-controller@40003000/flash@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button@1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button@2 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button@3 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button@4 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button@5 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button@6 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button@7 has a unit name, but no reg property
Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/lpc4350-hitex-eval.dts | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/lpc4350-hitex-eval.dts b/arch/arm/boot/dts/lpc4350-hitex-eval.dts
index 6d0c698..cb65352 100644
--- a/arch/arm/boot/dts/lpc4350-hitex-eval.dts
+++ b/arch/arm/boot/dts/lpc4350-hitex-eval.dts
@@ -33,7 +33,7 @@
stdout-path = &uart0;
};
- memory {
+ memory@28000000 {
device_type = "memory";
reg = <0x28000000 0x800000>; /* 8 MB */
};
@@ -45,50 +45,50 @@
poll-interval = <100>;
autorepeat;
- button@0 {
+ button0 {
label = "joy:right";
linux,code = <KEY_RIGHT>;
gpios = <&pca_gpio 8 GPIO_ACTIVE_LOW>;
};
- button@1 {
+ button1 {
label = "joy:up";
linux,code = <KEY_UP>;
gpios = <&pca_gpio 9 GPIO_ACTIVE_LOW>;
};
- button@2 {
+ button2 {
label = "joy:enter";
linux,code = <KEY_ENTER>;
gpios = <&pca_gpio 10 GPIO_ACTIVE_LOW>;
};
- button@3 {
+ button3 {
label = "joy:left";
linux,code = <KEY_LEFT>;
gpios = <&pca_gpio 11 GPIO_ACTIVE_LOW>;
};
- button@4 {
+ button4 {
label = "joy:down";
linux,code = <KEY_DOWN>;
gpios = <&pca_gpio 12 GPIO_ACTIVE_LOW>;
};
- button@5 {
+ button5 {
label = "user:sw3";
linux,code = <KEY_F1>;
gpios = <&pca_gpio 13 GPIO_ACTIVE_LOW>;
};
- button@6 {
+ button6 {
label = "user:sw4";
linux,code = <KEY_F2>;
gpios = <&pca_gpio 14 GPIO_ACTIVE_LOW>;
};
- button@7 {
+ button7 {
label = "user:sw5";
linux,code = <KEY_F3>;
gpios = <&pca_gpio 15 GPIO_ACTIVE_LOW>;
@@ -453,7 +453,7 @@
pinctrl-names = "default";
pinctrl-0 = <&spifi_pins>;
- flash@0 {
+ flash {
compatible = "jedec,spi-nor";
spi-rx-bus-width = <4>;
#address-cells = <1>;
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 56+ messages in thread* [PATCH 5/7] ARM: dts: lpc4350-hitex-eval: fix unit name warnings from dtc
@ 2016-03-29 22:30 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel
Fix the following warnings from dtc by either adding or removing
the unit name from the node.
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/flash-controller at 40003000/flash at 0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button at 0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button at 1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button at 2 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button at 3 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button at 4 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button at 5 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button at 6 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pca_buttons/button at 7 has a unit name, but no reg property
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
arch/arm/boot/dts/lpc4350-hitex-eval.dts | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/lpc4350-hitex-eval.dts b/arch/arm/boot/dts/lpc4350-hitex-eval.dts
index 6d0c698..cb65352 100644
--- a/arch/arm/boot/dts/lpc4350-hitex-eval.dts
+++ b/arch/arm/boot/dts/lpc4350-hitex-eval.dts
@@ -33,7 +33,7 @@
stdout-path = &uart0;
};
- memory {
+ memory at 28000000 {
device_type = "memory";
reg = <0x28000000 0x800000>; /* 8 MB */
};
@@ -45,50 +45,50 @@
poll-interval = <100>;
autorepeat;
- button at 0 {
+ button0 {
label = "joy:right";
linux,code = <KEY_RIGHT>;
gpios = <&pca_gpio 8 GPIO_ACTIVE_LOW>;
};
- button at 1 {
+ button1 {
label = "joy:up";
linux,code = <KEY_UP>;
gpios = <&pca_gpio 9 GPIO_ACTIVE_LOW>;
};
- button at 2 {
+ button2 {
label = "joy:enter";
linux,code = <KEY_ENTER>;
gpios = <&pca_gpio 10 GPIO_ACTIVE_LOW>;
};
- button at 3 {
+ button3 {
label = "joy:left";
linux,code = <KEY_LEFT>;
gpios = <&pca_gpio 11 GPIO_ACTIVE_LOW>;
};
- button at 4 {
+ button4 {
label = "joy:down";
linux,code = <KEY_DOWN>;
gpios = <&pca_gpio 12 GPIO_ACTIVE_LOW>;
};
- button at 5 {
+ button5 {
label = "user:sw3";
linux,code = <KEY_F1>;
gpios = <&pca_gpio 13 GPIO_ACTIVE_LOW>;
};
- button at 6 {
+ button6 {
label = "user:sw4";
linux,code = <KEY_F2>;
gpios = <&pca_gpio 14 GPIO_ACTIVE_LOW>;
};
- button at 7 {
+ button7 {
label = "user:sw5";
linux,code = <KEY_F3>;
gpios = <&pca_gpio 15 GPIO_ACTIVE_LOW>;
@@ -453,7 +453,7 @@
pinctrl-names = "default";
pinctrl-0 = <&spifi_pins>;
- flash at 0 {
+ flash {
compatible = "jedec,spi-nor";
spi-rx-bus-width = <4>;
#address-cells = <1>;
--
2.7.4
^ permalink raw reply related [flat|nested] 56+ messages in thread
* [PATCH 6/7] ARM: dts: lpc4337-ciaa:: fix unit name warning from dtc
2016-03-29 22:30 ` Joachim Eastwood
@ 2016-03-29 22:30 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Joachim Eastwood, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA,
ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ
Fix the following warning from dtc by either adding a unit name
to the memory node.
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/lpc4337-ciaa.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/lpc4337-ciaa.dts b/arch/arm/boot/dts/lpc4337-ciaa.dts
index 5cfadb0..7c16d63 100644
--- a/arch/arm/boot/dts/lpc4337-ciaa.dts
+++ b/arch/arm/boot/dts/lpc4337-ciaa.dts
@@ -30,7 +30,7 @@
stdout-path = &uart2;
};
- memory {
+ memory@28000000 {
device_type = "memory";
reg = <0x28000000 0x0800000>; /* 8 MB */
};
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 56+ messages in thread* [PATCH 6/7] ARM: dts: lpc4337-ciaa:: fix unit name warning from dtc
@ 2016-03-29 22:30 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel
Fix the following warning from dtc by either adding a unit name
to the memory node.
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
arch/arm/boot/dts/lpc4337-ciaa.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/lpc4337-ciaa.dts b/arch/arm/boot/dts/lpc4337-ciaa.dts
index 5cfadb0..7c16d63 100644
--- a/arch/arm/boot/dts/lpc4337-ciaa.dts
+++ b/arch/arm/boot/dts/lpc4337-ciaa.dts
@@ -30,7 +30,7 @@
stdout-path = &uart2;
};
- memory {
+ memory at 28000000 {
device_type = "memory";
reg = <0x28000000 0x0800000>; /* 8 MB */
};
--
2.7.4
^ permalink raw reply related [flat|nested] 56+ messages in thread
* [PATCH 7/7] dt-bindings: phy-lpc18xx-usb-otg: remove unit address from binding
2016-03-29 22:30 ` Joachim Eastwood
@ 2016-03-29 22:30 ` Joachim Eastwood
-1 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Joachim Eastwood, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA
DT bindings should either use a unit address and a reg property
or none of them. Since either of them aren't really useful for
such a simple device like this one remove the unit address.
Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
Documentation/devicetree/bindings/phy/phy-lpc18xx-usb-otg.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/phy-lpc18xx-usb-otg.txt b/Documentation/devicetree/bindings/phy/phy-lpc18xx-usb-otg.txt
index bd61b46..3bb821c 100644
--- a/Documentation/devicetree/bindings/phy/phy-lpc18xx-usb-otg.txt
+++ b/Documentation/devicetree/bindings/phy/phy-lpc18xx-usb-otg.txt
@@ -18,7 +18,7 @@ creg: syscon@40043000 {
compatible = "nxp,lpc1850-creg", "syscon", "simple-mfd";
reg = <0x40043000 0x1000>;
- usb0_otg_phy: phy@004 {
+ usb0_otg_phy: phy {
compatible = "nxp,lpc1850-usb-otg-phy";
clocks = <&ccu1 CLK_USB0>;
#phy-cells = <0>;
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 56+ messages in thread* [PATCH 7/7] dt-bindings: phy-lpc18xx-usb-otg: remove unit address from binding
@ 2016-03-29 22:30 ` Joachim Eastwood
0 siblings, 0 replies; 56+ messages in thread
From: Joachim Eastwood @ 2016-03-29 22:30 UTC (permalink / raw)
To: linux-arm-kernel
DT bindings should either use a unit address and a reg property
or none of them. Since either of them aren't really useful for
such a simple device like this one remove the unit address.
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/phy/phy-lpc18xx-usb-otg.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/phy-lpc18xx-usb-otg.txt b/Documentation/devicetree/bindings/phy/phy-lpc18xx-usb-otg.txt
index bd61b46..3bb821c 100644
--- a/Documentation/devicetree/bindings/phy/phy-lpc18xx-usb-otg.txt
+++ b/Documentation/devicetree/bindings/phy/phy-lpc18xx-usb-otg.txt
@@ -18,7 +18,7 @@ creg: syscon at 40043000 {
compatible = "nxp,lpc1850-creg", "syscon", "simple-mfd";
reg = <0x40043000 0x1000>;
- usb0_otg_phy: phy at 004 {
+ usb0_otg_phy: phy {
compatible = "nxp,lpc1850-usb-otg-phy";
clocks = <&ccu1 CLK_USB0>;
#phy-cells = <0>;
--
2.7.4
^ permalink raw reply related [flat|nested] 56+ messages in thread