From: Olaf Hering <olaf@aepfle.de>
To: Juergen Gross <jgross@suse.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v10 4/5] libxl: add support for vscsi
Date: Thu, 31 Mar 2016 11:12:12 +0200 [thread overview]
Message-ID: <20160331091120.GA3317@aepfle.de> (raw)
In-Reply-To: <56FCE62F.3090806@suse.com>
On Thu, Mar 31, Juergen Gross wrote:
> On 22/03/16 09:23, Olaf Hering wrote:
> > +#define COMPARE_VSCSI(a, b) ((a)->devid == (b)->devid)
> Is this really needed? I'd prefer using COMPARE_DEVID() instead.
COMPARE_VSCSI used to do something else in an earlier variant.
Now COMPARE_DEVID can be used.
> > + if (sscanf(p, "naa.%16c:%llu", wwn, &lun) == 2 && vscsi_wwn_valid(wwn)) {
> Or even: omit the whole function and use "%16[0-9a-fA-F]" as format of
> sscanf().
Yes, thanks for the feedback. I will change it.
Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-31 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 8:23 [PATCH v10 0/5] libxl: add support for pvscsi, iteration 10 Olaf Hering
2016-03-22 8:23 ` [PATCH v10 1/5] vscsiif.h: fix WWN notation for p-dev property Olaf Hering
2016-03-22 8:23 ` [PATCH v10 2/5] docs: add vscsi to xenstore-paths.markdown Olaf Hering
2016-03-22 8:23 ` [PATCH v10 3/5] vscsiif.h: add some notes about xenstore layout Olaf Hering
2016-03-22 8:23 ` [PATCH v10 4/5] libxl: add support for vscsi Olaf Hering
2016-03-31 8:56 ` Juergen Gross
2016-03-31 9:12 ` Olaf Hering [this message]
2016-04-01 17:25 ` Ian Jackson
2016-04-01 17:52 ` Olaf Hering
2016-04-01 18:04 ` Ian Jackson
2016-04-08 7:17 ` Olaf Hering
2016-03-22 8:23 ` [PATCH v10 5/5] Scripts to create and delete xen-scsiback nodes in Linux target framework Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331091120.GA3317@aepfle.de \
--to=olaf@aepfle.de \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.