All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v10 4/5] libxl: add support for vscsi
Date: Fri, 1 Apr 2016 19:04:12 +0100	[thread overview]
Message-ID: <22270.47132.938730.118547@mariner.uk.xensource.com> (raw)
In-Reply-To: <20160401175257.GA28514@aepfle.de>

Olaf Hering writes ("Re: [PATCH v10 4/5] libxl: add support for vscsi"):
> On Fri, Apr 01, Ian Jackson wrote:
> > I'm not sure that this sysfs parsing ought to be in xl rather than
> > libxl.  Also, this is Linux-specific code.  So it needs to be made
> > conditional somehow.
> 
> The whole libxlu file is inside #ifdef __linux__?

Oh, so it is.  Sorry for not spotting that.  TBH I think it might be
better to do this the way that other kernel-specific things are done,
eg libxl_linux.c etc.

But I think changing this ought to wait until we settle whether this
code ought to be in xl or libxl.

> I will address the other comments in another mail.

Thanks
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-01 18:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22  8:23 [PATCH v10 0/5] libxl: add support for pvscsi, iteration 10 Olaf Hering
2016-03-22  8:23 ` [PATCH v10 1/5] vscsiif.h: fix WWN notation for p-dev property Olaf Hering
2016-03-22  8:23 ` [PATCH v10 2/5] docs: add vscsi to xenstore-paths.markdown Olaf Hering
2016-03-22  8:23 ` [PATCH v10 3/5] vscsiif.h: add some notes about xenstore layout Olaf Hering
2016-03-22  8:23 ` [PATCH v10 4/5] libxl: add support for vscsi Olaf Hering
2016-03-31  8:56   ` Juergen Gross
2016-03-31  9:12     ` Olaf Hering
2016-04-01 17:25   ` Ian Jackson
2016-04-01 17:52     ` Olaf Hering
2016-04-01 18:04       ` Ian Jackson [this message]
2016-04-08  7:17     ` Olaf Hering
2016-03-22  8:23 ` [PATCH v10 5/5] Scripts to create and delete xen-scsiback nodes in Linux target framework Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22270.47132.938730.118547@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=olaf@aepfle.de \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.