All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] regulator: core: Use parent voltage from the supply when bypassed
Date: Thu, 31 Mar 2016 10:55:27 -0700	[thread overview]
Message-ID: <20160331175527.GP2350@sirena.org.uk> (raw)
In-Reply-To: <56FD33EE.6030109-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

On Thu, Mar 31, 2016 at 03:27:58PM +0100, Jon Hunter wrote:
> On 30/03/16 18:32, Mark Brown wrote:

> > +		if (bypassed) {
> > +			if (rdev->supply) {
> > +				ret = _regulator_get_voltage(rdev->supply->rdev);

> Should this be a return here?

Gnargh, yes.

> I gave this a quick test on tegra124 having populated the
> get/set_bypass() operators for the as3722. In this case, there is still
> a problem because _regulator_get_voltage() is called during regulator
> registration when set_machine_constraints() is called, which is before
> we have called regulator_register_resolve_supply(). Therefore, it seems
> to me that we still need to resolve the supply before we call
> set_machine_constraints().

OK, we need to change the code there to defer probe in the case where
the device is in bypass mode as well.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] regulator: core: Use parent voltage from the supply when bypassed
Date: Thu, 31 Mar 2016 10:55:27 -0700	[thread overview]
Message-ID: <20160331175527.GP2350@sirena.org.uk> (raw)
In-Reply-To: <56FD33EE.6030109@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

On Thu, Mar 31, 2016 at 03:27:58PM +0100, Jon Hunter wrote:
> On 30/03/16 18:32, Mark Brown wrote:

> > +		if (bypassed) {
> > +			if (rdev->supply) {
> > +				ret = _regulator_get_voltage(rdev->supply->rdev);

> Should this be a return here?

Gnargh, yes.

> I gave this a quick test on tegra124 having populated the
> get/set_bypass() operators for the as3722. In this case, there is still
> a problem because _regulator_get_voltage() is called during regulator
> registration when set_machine_constraints() is called, which is before
> we have called regulator_register_resolve_supply(). Therefore, it seems
> to me that we still need to resolve the supply before we call
> set_machine_constraints().

OK, we need to change the code there to defer probe in the case where
the device is in bypass mode as well.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  parent reply	other threads:[~2016-03-31 17:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30 17:32 [PATCH] regulator: core: Use parent voltage from the supply when bypassed Mark Brown
2016-03-31 14:27 ` Jon Hunter
2016-03-31 14:27   ` Jon Hunter
     [not found]   ` <56FD33EE.6030109-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-31 17:55     ` Mark Brown [this message]
2016-03-31 17:55       ` Mark Brown
2016-04-01 16:58       ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160331175527.GP2350@sirena.org.uk \
    --to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.