All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] wilc1000-firmware: new package
@ 2016-04-01  6:19 Ludovic Desroches
  2016-04-01  6:22 ` Baruch Siach
  2016-04-02 15:20 ` Thomas Petazzoni
  0 siblings, 2 replies; 5+ messages in thread
From: Ludovic Desroches @ 2016-04-01  6:19 UTC (permalink / raw)
  To: buildroot

Firmware for Atmel Wilc1000 wireless device.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
 package/Config.in                              |  1 +
 package/wilc1000-firmware/Config.in            |  6 ++++++
 package/wilc1000-firmware/wilc1000-firmware.mk | 25 +++++++++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/wilc1000-firmware/Config.in
 create mode 100644 package/wilc1000-firmware/wilc1000-firmware.mk

diff --git a/package/Config.in b/package/Config.in
index 1467f33..661b010 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -336,6 +336,7 @@ menu "Firmware"
 	source "package/rpi-firmware/Config.in"
 	source "package/sunxi-boards/Config.in"
 	source "package/ux500-firmware/Config.in"
+	source "package/wilc1000-firmware/Config.in"
 	source "package/zd1211-firmware/Config.in"
 endmenu
 	source "package/a10disp/Config.in"
diff --git a/package/wilc1000-firmware/Config.in b/package/wilc1000-firmware/Config.in
new file mode 100644
index 0000000..df8a7a6
--- /dev/null
+++ b/package/wilc1000-firmware/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_WILC1000_FIRMWARE
+	bool "wilc1000-firmware"
+	help
+	  Firmware for Atmel Wilc1000 wireless device
+
+	  https://github.com/linux4sc/wireless-firmware.git
diff --git a/package/wilc1000-firmware/wilc1000-firmware.mk b/package/wilc1000-firmware/wilc1000-firmware.mk
new file mode 100644
index 0000000..a3ec86f
--- /dev/null
+++ b/package/wilc1000-firmware/wilc1000-firmware.mk
@@ -0,0 +1,25 @@
+################################################################################
+#
+# wilc1000-firmware
+#
+################################################################################
+
+WILC1000_FIRMWARE_VERSION = 14.1
+WILC1000_FIRMWARE_SITE = https://github.com/linux4sc/wireless-firmware/archive
+WILC1000_FIRMWARE_SOURCE = v$(WILC1000_FIRMWARE_VERSION)_Firmware.zip
+WILC1000_FIRMWARE_DRIVER_FILE = wilc1003_firmware.bin
+
+WILC1000_FIRMWARE_LICENSE = PROPRIETARY
+
+define WILC1000_FIRMWARE_EXTRACT_CMDS
+	$(UNZIP) -d $(BUILD_DIR) $(DL_DIR)/$(WILC1000_FIRMWARE_SOURCE)
+	mv $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware/* $(@D)
+	rmdir $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware
+endef
+
+define WILC1000_FIRMWARE_INSTALL_TARGET_CMDS
+	$(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/atmel/
+	cp $(@D)/$(WILC1000_FIRMWARE_DRIVER_FILE) $(TARGET_DIR)/lib/firmware/atmel/
+endef
+
+$(eval $(generic-package))
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] wilc1000-firmware: new package
  2016-04-01  6:19 [Buildroot] [PATCH] wilc1000-firmware: new package Ludovic Desroches
@ 2016-04-01  6:22 ` Baruch Siach
  2016-04-01  7:16   ` Ludovic Desroches
  2016-04-02 15:20 ` Thomas Petazzoni
  1 sibling, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2016-04-01  6:22 UTC (permalink / raw)
  To: buildroot

Hi Ludovic,

On Fri, Apr 01, 2016 at 08:19:36AM +0200, Ludovic Desroches wrote:
> diff --git a/package/wilc1000-firmware/wilc1000-firmware.mk 
> b/package/wilc1000-firmware/wilc1000-firmware.mk
> new file mode 100644
> index 0000000..a3ec86f
> --- /dev/null
> +++ b/package/wilc1000-firmware/wilc1000-firmware.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# wilc1000-firmware
> +#
> +################################################################################
> +
> +WILC1000_FIRMWARE_VERSION = 14.1
> +WILC1000_FIRMWARE_SITE = https://github.com/linux4sc/wireless-firmware/archive
> +WILC1000_FIRMWARE_SOURCE = v$(WILC1000_FIRMWARE_VERSION)_Firmware.zip
> +WILC1000_FIRMWARE_DRIVER_FILE = wilc1003_firmware.bin
> +
> +WILC1000_FIRMWARE_LICENSE = PROPRIETARY

No LICENSE_FILES? Is it distributable? I would guess it is, but we have no 
indication.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] wilc1000-firmware: new package
  2016-04-01  6:22 ` Baruch Siach
@ 2016-04-01  7:16   ` Ludovic Desroches
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Desroches @ 2016-04-01  7:16 UTC (permalink / raw)
  To: buildroot

Hi Baruch,

On Fri, Apr 01, 2016 at 09:22:45AM +0300, Baruch Siach wrote:
> Hi Ludovic,
> 
> On Fri, Apr 01, 2016 at 08:19:36AM +0200, Ludovic Desroches wrote:
> > diff --git a/package/wilc1000-firmware/wilc1000-firmware.mk 
> > b/package/wilc1000-firmware/wilc1000-firmware.mk
> > new file mode 100644
> > index 0000000..a3ec86f
> > --- /dev/null
> > +++ b/package/wilc1000-firmware/wilc1000-firmware.mk
> > @@ -0,0 +1,25 @@
> > +################################################################################
> > +#
> > +# wilc1000-firmware
> > +#
> > +################################################################################
> > +
> > +WILC1000_FIRMWARE_VERSION = 14.1
> > +WILC1000_FIRMWARE_SITE = https://github.com/linux4sc/wireless-firmware/archive
> > +WILC1000_FIRMWARE_SOURCE = v$(WILC1000_FIRMWARE_VERSION)_Firmware.zip
> > +WILC1000_FIRMWARE_DRIVER_FILE = wilc1003_firmware.bin
> > +
> > +WILC1000_FIRMWARE_LICENSE = PROPRIETARY
> 
> No LICENSE_FILES? Is it distributable? I would guess it is, but we have no 
> indication.

Unfortunately there is no license file in this repository.

Yes it is distributable, I thought _REDISTRIBUTE was only used if not.

Regards

Ludovic

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] wilc1000-firmware: new package
  2016-04-01  6:19 [Buildroot] [PATCH] wilc1000-firmware: new package Ludovic Desroches
  2016-04-01  6:22 ` Baruch Siach
@ 2016-04-02 15:20 ` Thomas Petazzoni
  2016-04-04  6:01   ` Ludovic Desroches
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2016-04-02 15:20 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri, 1 Apr 2016 08:19:36 +0200, Ludovic Desroches wrote:
> Firmware for Atmel Wilc1000 wireless device.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> ---
>  package/Config.in                              |  1 +
>  package/wilc1000-firmware/Config.in            |  6 ++++++
>  package/wilc1000-firmware/wilc1000-firmware.mk | 25 +++++++++++++++++++++++++

A hash file was missing.

> +WILC1000_FIRMWARE_VERSION = 14.1
> +WILC1000_FIRMWARE_SITE = https://github.com/linux4sc/wireless-firmware/archive
> +WILC1000_FIRMWARE_SOURCE = v$(WILC1000_FIRMWARE_VERSION)_Firmware.zip

What a crappy file name, which doesn't even contain the name of the
project :-/

> +WILC1000_FIRMWARE_DRIVER_FILE = wilc1003_firmware.bin

This variable is not really needed, it's only used once

> +WILC1000_FIRMWARE_LICENSE = PROPRIETARY
> +
> +define WILC1000_FIRMWARE_EXTRACT_CMDS
> +	$(UNZIP) -d $(BUILD_DIR) $(DL_DIR)/$(WILC1000_FIRMWARE_SOURCE)
> +	mv $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware/* $(@D)
> +	rmdir $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware
> +endef
> +
> +define WILC1000_FIRMWARE_INSTALL_TARGET_CMDS
> +	$(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/atmel/
> +	cp $(@D)/$(WILC1000_FIRMWARE_DRIVER_FILE) $(TARGET_DIR)/lib/firmware/atmel/

I've simplified this to use just one $(INSTALL) -D -m 0644 invocation,
which is sufficient since 1/ there is only one file to install and 2/
option -D tells $(INSTALL) to create sub-directories as necessary.

Applied with those fixes. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] wilc1000-firmware: new package
  2016-04-02 15:20 ` Thomas Petazzoni
@ 2016-04-04  6:01   ` Ludovic Desroches
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Desroches @ 2016-04-04  6:01 UTC (permalink / raw)
  To: buildroot

On Sat, Apr 02, 2016 at 05:20:58PM +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Fri, 1 Apr 2016 08:19:36 +0200, Ludovic Desroches wrote:
> > Firmware for Atmel Wilc1000 wireless device.
> > 
> > Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> > ---
> >  package/Config.in                              |  1 +
> >  package/wilc1000-firmware/Config.in            |  6 ++++++
> >  package/wilc1000-firmware/wilc1000-firmware.mk | 25 +++++++++++++++++++++++++
> 
> A hash file was missing.
> 
> > +WILC1000_FIRMWARE_VERSION = 14.1
> > +WILC1000_FIRMWARE_SITE = https://github.com/linux4sc/wireless-firmware/archive
> > +WILC1000_FIRMWARE_SOURCE = v$(WILC1000_FIRMWARE_VERSION)_Firmware.zip
> 
> What a crappy file name, which doesn't even contain the name of the
> project :-/

I agree.

> 
> > +WILC1000_FIRMWARE_DRIVER_FILE = wilc1003_firmware.bin
> 
> This variable is not really needed, it's only used once
> 
> > +WILC1000_FIRMWARE_LICENSE = PROPRIETARY
> > +
> > +define WILC1000_FIRMWARE_EXTRACT_CMDS
> > +	$(UNZIP) -d $(BUILD_DIR) $(DL_DIR)/$(WILC1000_FIRMWARE_SOURCE)
> > +	mv $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware/* $(@D)
> > +	rmdir $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware
> > +endef
> > +
> > +define WILC1000_FIRMWARE_INSTALL_TARGET_CMDS
> > +	$(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/atmel/
> > +	cp $(@D)/$(WILC1000_FIRMWARE_DRIVER_FILE) $(TARGET_DIR)/lib/firmware/atmel/
> 
> I've simplified this to use just one $(INSTALL) -D -m 0644 invocation,
> which is sufficient since 1/ there is only one file to install and 2/
> option -D tells $(INSTALL) to create sub-directories as necessary.
> 
> Applied with those fixes. Thanks!

Great, thanks.


Regards

Ludovic

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-04  6:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-01  6:19 [Buildroot] [PATCH] wilc1000-firmware: new package Ludovic Desroches
2016-04-01  6:22 ` Baruch Siach
2016-04-01  7:16   ` Ludovic Desroches
2016-04-02 15:20 ` Thomas Petazzoni
2016-04-04  6:01   ` Ludovic Desroches

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.