* [U-Boot] [PATCH] post: Delete unnecessary bitmask of POST_MANUAL from POST_ALWAYS
@ 2016-03-27 14:18 Robert P. J. Day
2016-04-02 1:58 ` [U-Boot] " Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2016-03-27 14:18 UTC (permalink / raw)
To: u-boot
Since POST_ALWAYS is defined as:
#define POST_ALWAYS (POST_NORMAL | \
POST_SLOWTEST | \
POST_MANUAL | \
POST_POWERON )
there is no need to redundantly bitmask it with POST_MANUAL.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
diff --git a/post/tests.c b/post/tests.c
index a4d4165..d8ac54e 100644
--- a/post/tests.c
+++ b/post/tests.c
@@ -173,7 +173,7 @@ struct post_test post_list[] =
"ETHERNET test",
"ethernet",
"This test verifies the ETHERNET operation.",
- POST_RAM | POST_ALWAYS | POST_MANUAL,
+ POST_RAM | POST_ALWAYS,
ðer_post_test,
NULL,
NULL,
@@ -185,7 +185,7 @@ struct post_test post_list[] =
"SPI test",
"spi",
"This test verifies the SPI operation.",
- POST_RAM | POST_ALWAYS | POST_MANUAL,
+ POST_RAM | POST_ALWAYS,
&spi_post_test,
NULL,
NULL,
@@ -197,7 +197,7 @@ struct post_test post_list[] =
"USB test",
"usb",
"This test verifies the USB operation.",
- POST_RAM | POST_ALWAYS | POST_MANUAL,
+ POST_RAM | POST_ALWAYS,
&usb_post_test,
NULL,
NULL,
@@ -233,7 +233,7 @@ struct post_test post_list[] =
"DSP test",
"dsp",
"This test checks any connected DSP(s).",
- POST_RAM | POST_ALWAYS | POST_MANUAL,
+ POST_RAM | POST_ALWAYS,
&dsp_post_test,
NULL,
NULL,
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] post: Delete unnecessary bitmask of POST_MANUAL from POST_ALWAYS
2016-03-27 14:18 [U-Boot] [PATCH] post: Delete unnecessary bitmask of POST_MANUAL from POST_ALWAYS Robert P. J. Day
@ 2016-04-02 1:58 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2016-04-02 1:58 UTC (permalink / raw)
To: u-boot
On Sun, Mar 27, 2016 at 10:18:55AM -0400, Robert P. J. Day wrote:
> Since POST_ALWAYS is defined as:
>
> #define POST_ALWAYS (POST_NORMAL | \
> POST_SLOWTEST | \
> POST_MANUAL | \
> POST_POWERON )
>
> there is no need to redundantly bitmask it with POST_MANUAL.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> diff --git a/post/tests.c b/post/tests.c
> index a4d4165..d8ac54e 100644
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160401/ee91628b/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-02 1:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-27 14:18 [U-Boot] [PATCH] post: Delete unnecessary bitmask of POST_MANUAL from POST_ALWAYS Robert P. J. Day
2016-04-02 1:58 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.