From: Krzysztof Kozlowski <k.kozlowski@samsung.com> To: Javier Martinez Canillas <javier@osg.samsung.com> Subject: Re: [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos5250 Date: Sun, 3 Apr 2016 11:56:33 +0900 [thread overview] Message-ID: <20160403025633.GA3789@kozik-lap> (raw) In-Reply-To: <56FEAE29.6010405@osg.samsung.com> On Fri, Apr 01, 2016 at 01:21:45PM -0400, Javier Martinez Canillas wrote: > > > > - usb@12000000 { > > + usb_dwc3 { > > compatible = "samsung,exynos5250-dwusb3"; > > clocks = <&clock CLK_USB3>; > > clock-names = "usbdrd30"; > > The ePAPR document says that "The name of a node should be somewhat generic, > reflecting the function of the device and not its precise programming model" > > So I wonder if this shouldn't be instead: > > usb_dwc3: usb { There are already nodes with 'usb' name: ehci: usb@12110000 { compatible = "samsung,exynos4210-ehci"; ... } ohci: usb@12120000 { compatible = "samsung,exynos4210-ohci"; } Having nodes with the same name but some with address some not, should work (none should be overridden)... but looks a little bit weird. Anyway I am fine with both. > Although it seems that not all DT bindings follow this convention so probably > the name in your patch is correct. > > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Thanks for review and comments. I already spotted the 'memory' node issue so I won't be replying to you with acknowledging comments. :) BR, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos5250 Date: Sun, 3 Apr 2016 11:56:33 +0900 [thread overview] Message-ID: <20160403025633.GA3789@kozik-lap> (raw) In-Reply-To: <56FEAE29.6010405@osg.samsung.com> On Fri, Apr 01, 2016 at 01:21:45PM -0400, Javier Martinez Canillas wrote: > > > > - usb at 12000000 { > > + usb_dwc3 { > > compatible = "samsung,exynos5250-dwusb3"; > > clocks = <&clock CLK_USB3>; > > clock-names = "usbdrd30"; > > The ePAPR document says that "The name of a node should be somewhat generic, > reflecting the function of the device and not its precise programming model" > > So I wonder if this shouldn't be instead: > > usb_dwc3: usb { There are already nodes with 'usb' name: ehci: usb at 12110000 { compatible = "samsung,exynos4210-ehci"; ... } ohci: usb at 12120000 { compatible = "samsung,exynos4210-ohci"; } Having nodes with the same name but some with address some not, should work (none should be overridden)... but looks a little bit weird. Anyway I am fine with both. > Although it seems that not all DT bindings follow this convention so probably > the name in your patch is correct. > > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Thanks for review and comments. I already spotted the 'memory' node issue so I won't be replying to you with acknowledging comments. :) BR, Krzysztof
next prev parent reply other threads:[~2016-04-03 3:03 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-01 6:57 [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in cros-adc-thermistors Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 6:57 ` [PATCH 02/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos3250 Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 14:27 ` Javier Martinez Canillas 2016-04-01 14:27 ` Javier Martinez Canillas 2016-04-01 14:27 ` Javier Martinez Canillas 2016-04-01 6:57 ` [PATCH 03/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos4 Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 14:30 ` Javier Martinez Canillas 2016-04-01 14:30 ` Javier Martinez Canillas 2016-04-01 6:57 ` [PATCH 04/11] ARM: dts: exynos: Fix DTC unit name warnings in Trats2 board Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 8:17 ` Krzysztof Kozlowski 2016-04-01 8:17 ` Krzysztof Kozlowski 2016-04-01 14:35 ` Javier Martinez Canillas 2016-04-01 14:35 ` Javier Martinez Canillas 2016-04-01 6:57 ` [PATCH 05/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos4x12 Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 14:38 ` Javier Martinez Canillas 2016-04-01 14:38 ` Javier Martinez Canillas 2016-04-01 6:57 ` [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos5250 Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 17:21 ` Javier Martinez Canillas 2016-04-01 17:21 ` Javier Martinez Canillas 2016-04-01 17:21 ` Javier Martinez Canillas [not found] ` <56FEAE29.6010405-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> 2016-04-03 2:56 ` Krzysztof Kozlowski 2016-04-03 2:56 ` Krzysztof Kozlowski [this message] 2016-04-03 2:56 ` Krzysztof Kozlowski 2016-04-03 4:08 ` Krzysztof Kozlowski 2016-04-03 4:08 ` Krzysztof Kozlowski 2016-04-01 6:57 ` [PATCH 07/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos542x Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 17:25 ` Javier Martinez Canillas 2016-04-01 17:25 ` Javier Martinez Canillas 2016-04-01 17:25 ` Javier Martinez Canillas 2016-04-01 6:57 ` [PATCH 08/11] ARM: dts: exynos: Fix DTC unit name warnings in Peach Pit Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 17:27 ` Javier Martinez Canillas 2016-04-01 17:27 ` Javier Martinez Canillas 2016-04-01 6:57 ` [PATCH 09/11] ARM: dts: exynos: Fix DTC unit name warnings in SMDK5420 Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 17:30 ` Javier Martinez Canillas 2016-04-01 17:30 ` Javier Martinez Canillas 2016-04-01 6:57 ` [PATCH 10/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos5440 Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 17:46 ` Javier Martinez Canillas 2016-04-01 17:46 ` Javier Martinez Canillas 2016-04-01 6:57 ` [PATCH 11/11] ARM: dts: s5p: Fix DTC unit name warnings in S5Pv210 boards Krzysztof Kozlowski 2016-04-01 6:57 ` Krzysztof Kozlowski 2016-04-01 17:50 ` Javier Martinez Canillas 2016-04-01 17:50 ` Javier Martinez Canillas 2016-04-01 17:50 ` Javier Martinez Canillas 2016-04-01 14:24 ` [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in cros-adc-thermistors Javier Martinez Canillas 2016-04-01 14:24 ` Javier Martinez Canillas 2016-04-01 15:31 ` Rob Herring 2016-04-01 15:31 ` Rob Herring 2016-04-01 15:31 ` Rob Herring 2016-04-03 3:46 ` Krzysztof Kozlowski 2016-04-03 3:46 ` Krzysztof Kozlowski 2016-04-03 3:46 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160403025633.GA3789@kozik-lap \ --to=k.kozlowski@samsung.com \ --cc=javier@osg.samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.