* [PATCH] mwifiex: ie_list is an array, so no need to check if NULL
@ 2016-03-28 15:53 Colin King
2016-04-07 16:39 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-03-28 15:53 UTC (permalink / raw)
To: Amitkumar Karwar, Nishant Sarmukadam, Kalle Valo, linux-wireless, netdev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
ap_ie->ie_list is an array of struct mwifiex_ie and can never
be null, so the null check on this array is redundant and can
be removed.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/marvell/mwifiex/uap_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
index 16d95b2..92ce32f 100644
--- a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
+++ b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
@@ -694,7 +694,7 @@ static int mwifiex_uap_custom_ie_prepare(u8 *tlv, void *cmd_buf, u16 *ie_size)
struct mwifiex_ie_list *ap_ie = cmd_buf;
struct mwifiex_ie_types_header *tlv_ie = (void *)tlv;
- if (!ap_ie || !ap_ie->len || !ap_ie->ie_list)
+ if (!ap_ie || !ap_ie->len)
return -1;
*ie_size += le16_to_cpu(ap_ie->len) +
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: mwifiex: ie_list is an array, so no need to check if NULL
2016-03-28 15:53 [PATCH] mwifiex: ie_list is an array, so no need to check if NULL Colin King
@ 2016-04-07 16:39 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2016-04-07 16:39 UTC (permalink / raw)
To: Colin Ian King
Cc: Amitkumar Karwar, Nishant Sarmukadam, linux-wireless, netdev,
linux-kernel
> From: Colin Ian King <colin.king@canonical.com>
>
> ap_ie->ie_list is an array of struct mwifiex_ie and can never
> be null, so the null check on this array is redundant and can
> be removed.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-07 16:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-28 15:53 [PATCH] mwifiex: ie_list is an array, so no need to check if NULL Colin King
2016-04-07 16:39 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.