From: Mark Brown <broonie@kernel.org>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org,
CARLOS.PALMINHA@synopsys.com, Alexey.Brodkin@synopsys.com,
Vineet.Gupta1@synopsys.com, architt@codeaurora.org,
airlied@linux.ie, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com
Subject: Re: [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver
Date: Thu, 7 Apr 2016 10:53:26 -0700 [thread overview]
Message-ID: <20160407175326.GX1924@sirena.org.uk> (raw)
In-Reply-To: <ce97e6bb7ddb71e532c4066334ceead4d4d3e692.1460047238.git.joabreu@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote:
> + Optional properties:
> + - snps,use-dmaengine: If set the driver will use ALSA DMA engine. If set
> + it is required to use the properties 'dmas' and 'dma-names'.
This is not a good interface, it's describing Linux internal APIs. If
the device needs to operate in PIO mode it should just do that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
Vineet.Gupta1@synopsys.com, Alexey.Brodkin@synopsys.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
CARLOS.PALMINHA@synopsys.com, perex@perex.cz, tiwai@suse.com,
linux-snps-arc@lists.infradead.org
Subject: Re: [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver
Date: Thu, 7 Apr 2016 10:53:26 -0700 [thread overview]
Message-ID: <20160407175326.GX1924@sirena.org.uk> (raw)
In-Reply-To: <ce97e6bb7ddb71e532c4066334ceead4d4d3e692.1460047238.git.joabreu@synopsys.com>
[-- Attachment #1.1: Type: text/plain, Size: 366 bytes --]
On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote:
> + Optional properties:
> + - snps,use-dmaengine: If set the driver will use ALSA DMA engine. If set
> + it is required to use the properties 'dmas' and 'dma-names'.
This is not a good interface, it's describing Linux internal APIs. If
the device needs to operate in PIO mode it should just do that.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver
Date: Thu, 7 Apr 2016 10:53:26 -0700 [thread overview]
Message-ID: <20160407175326.GX1924@sirena.org.uk> (raw)
In-Reply-To: <ce97e6bb7ddb71e532c4066334ceead4d4d3e692.1460047238.git.joabreu@synopsys.com>
On Thu, Apr 07, 2016@05:53:59PM +0100, Jose Abreu wrote:
> + Optional properties:
> + - snps,use-dmaengine: If set the driver will use ALSA DMA engine. If set
> + it is required to use the properties 'dmas' and 'dma-names'.
This is not a good interface, it's describing Linux internal APIs. If
the device needs to operate in PIO mode it should just do that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-snps-arc/attachments/20160407/566c90a6/attachment-0001.sig>
next prev parent reply other threads:[~2016-04-07 17:53 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 16:53 [PATCH 0/5 v4] Add I2S/ADV7511 audio support for ARC AXS10x boards Jose Abreu
2016-04-07 16:53 ` Jose Abreu
2016-04-07 16:53 ` Jose Abreu
2016-04-07 16:53 ` [PATCH 1/5 v4] drm/i2c/adv7511: Rename and move to separate folder Jose Abreu
2016-04-07 16:53 ` Jose Abreu
2016-04-07 16:53 ` Jose Abreu
2016-04-07 16:53 ` [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support Jose Abreu
2016-04-07 16:53 ` Jose Abreu
2016-04-08 15:46 ` [alsa-devel] " Lars-Peter Clausen
2016-04-08 15:46 ` Lars-Peter Clausen
2016-04-08 16:05 ` Jose Abreu
2016-04-08 16:12 ` Jose Abreu
2016-04-08 16:12 ` Jose Abreu
2016-04-08 16:12 ` Jose Abreu
2016-04-09 15:02 ` [alsa-devel] " Lars-Peter Clausen
2016-04-09 15:02 ` Lars-Peter Clausen
2016-04-09 15:02 ` Lars-Peter Clausen
2016-04-11 9:27 ` Jose Abreu
2016-04-11 9:27 ` Jose Abreu
2016-04-11 9:27 ` Jose Abreu
2016-04-11 9:33 ` Lars-Peter Clausen
2016-04-11 9:33 ` Lars-Peter Clausen
2016-04-11 9:33 ` Lars-Peter Clausen
2016-04-11 11:32 ` Jose Abreu
2016-04-11 11:32 ` Jose Abreu
2016-04-11 11:32 ` Jose Abreu
2016-04-11 12:23 ` [alsa-devel] " Lars-Peter Clausen
2016-04-11 12:23 ` Lars-Peter Clausen
2016-04-11 12:23 ` Lars-Peter Clausen
2016-04-11 14:08 ` Jose Abreu
2016-04-11 14:08 ` Jose Abreu
2016-04-11 14:08 ` Jose Abreu
2016-04-11 19:34 ` [alsa-devel] " Lars-Peter Clausen
2016-04-11 19:34 ` Lars-Peter Clausen
2016-04-11 19:34 ` Lars-Peter Clausen
2016-04-07 16:53 ` [PATCH 3/5 v4] ASoC: dwc: Use fifo depth to program FCR Jose Abreu
2016-04-07 16:53 ` Jose Abreu
2016-04-07 16:53 ` Jose Abreu
2016-04-07 17:57 ` Applied "ASoC: dwc: Use fifo depth to program FCR" to the asoc tree Mark Brown
2016-04-07 17:57 ` Mark Brown
2016-04-07 17:57 ` Mark Brown
2016-04-07 16:53 ` [PATCH 4/5 v4] ASoC: dwc: Add custom PCM driver Jose Abreu
2016-04-07 16:53 ` Jose Abreu
2016-04-07 17:54 ` kbuild test robot
2016-04-07 17:54 ` kbuild test robot
2016-04-07 17:54 ` kbuild test robot
2016-04-07 16:53 ` [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver Jose Abreu
2016-04-07 16:53 ` Jose Abreu
2016-04-07 17:53 ` Mark Brown [this message]
2016-04-07 17:53 ` Mark Brown
2016-04-07 17:53 ` Mark Brown
2016-04-08 10:06 ` Jose Abreu
2016-04-08 10:06 ` Jose Abreu
2016-04-08 10:06 ` Jose Abreu
2016-04-08 15:52 ` [alsa-devel] " Lars-Peter Clausen
2016-04-08 15:52 ` Lars-Peter Clausen
2016-04-08 15:52 ` Lars-Peter Clausen
2016-04-08 16:08 ` Jose Abreu
2016-04-08 16:08 ` Jose Abreu
2016-04-08 16:08 ` Jose Abreu
2016-04-09 14:55 ` Lars-Peter Clausen
2016-04-09 14:55 ` Lars-Peter Clausen
2016-04-09 14:55 ` Lars-Peter Clausen
2016-04-11 9:24 ` Jose Abreu
2016-04-11 9:24 ` Jose Abreu
2016-04-11 9:24 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407175326.GX1924@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Alexey.Brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.