All of lore.kernel.org
 help / color / mirror / Atom feed
* master - tests: use mkfs.ext3
@ 2016-04-07 22:22 Zdenek Kabelac
  0 siblings, 0 replies; only message in thread
From: Zdenek Kabelac @ 2016-04-07 22:22 UTC (permalink / raw)
  To: lvm-devel

Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=9ab53dddf553867ba9a19367bf74307a36c43c9f
Commit:        9ab53dddf553867ba9a19367bf74307a36c43c9f
Parent:        8b2108e6b16cbcb528a138413e9050dd6f420e0d
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Thu Apr 7 22:07:41 2016 +0200
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Thu Apr 7 22:32:09 2016 +0200

tests: use mkfs.ext3

mkfs.ext4 is not really needed so use more widespread mkfs.ext3
so test runs on older system.
---
 test/shell/lvconvert-repair-mirror.sh |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/test/shell/lvconvert-repair-mirror.sh b/test/shell/lvconvert-repair-mirror.sh
index 242028d..e40f9aa 100644
--- a/test/shell/lvconvert-repair-mirror.sh
+++ b/test/shell/lvconvert-repair-mirror.sh
@@ -12,10 +12,13 @@
 SKIP_WITH_LVMLOCKD=1
 SKIP_WITH_LVMPOLLD=1
 
+MKFS=mkfs.ext3
 MOUNT_DIR=mnt
 
 . lib/inittest
 
+which "$MKFS" || skp
+
 cleanup_mounted_and_teardown()
 {
 	umount "$MOUNT_DIR" || true
@@ -33,7 +36,7 @@ aux prepare_vg 5
 # with the default 512K - my C2D T61 reads just couple MB/s!
 #
 lvcreate -aey --type mirror -L10 --regionsize 1M -m1 -n $lv1 $vg "$dev1" "$dev2" "$dev3"
-mkfs.ext4 "$DM_DEV_DIR/$vg/$lv1"
+"$MKFS" "$DM_DEV_DIR/$vg/$lv1"
 mkdir "$MOUNT_DIR"
 
 aux delay_dev "$dev2" 0 500 $(get first_extent_sector "$dev2"):
@@ -42,7 +45,7 @@ aux delay_dev "$dev4" 0 500 $(get first_extent_sector "$dev4"):
 # Enforce syncronization
 # ATM requires unmounted/unused LV??
 #
-lvchange --yes --resync --noudevsync $vg/$lv1
+lvchange --yes --resync $vg/$lv1
 trap 'cleanup_mounted_and_teardown' EXIT
 mount "$DM_DEV_DIR/$vg/$lv1" "$MOUNT_DIR"
 
@@ -52,7 +55,8 @@ dd if=/dev/zero of=mnt/zero bs=4K count=100 conv=fdatasync 2>err &
 
 PERCENT=$(get lv_field $vg/$lv1 copy_percent)
 PERCENT=${PERCENT%%\.*}  # cut decimal
-test "$PERCENT" -lt 50   # and check less then 50% mirror is in sync
+# and check less then 50% mirror is in sync (could be unusable delay_dev ?)
+test "$PERCENT" -lt 50 || skip
 #lvs -a -o+devices $vg
 
 #aux disable_dev "$dev3"



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-04-07 22:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-07 22:22 master - tests: use mkfs.ext3 Zdenek Kabelac

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.