* [PATCH 1/2] mfd: max77693: Allow building as a module
@ 2016-04-04 7:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-04 7:54 UTC (permalink / raw)
To: Lee Jones, Chanwoo Choi, Krzysztof Kozlowski, Arnd Bergmann,
Javier Martinez Canillas, Kukjin Kim, Olof Johansson,
linux-arm-kernel, linux-kernel, linux-samsung-soc
Cc: Kevin Hilman, Paul Gortmaker
The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
driver) supports deferred probing so the max77693 main MFD driver can be
built now as a module. This gives more flexibility and removes manual
ordering of init calls.
Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/mfd/Kconfig | 4 ++--
drivers/mfd/max77693.c | 14 ++------------
2 files changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index eea61e349e26..aa1e7c3f82ee 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -543,8 +543,8 @@ config MFD_MAX77686
of the device.
config MFD_MAX77693
- bool "Maxim Semiconductor MAX77693 PMIC Support"
- depends on I2C=y
+ tristate "Maxim Semiconductor MAX77693 PMIC Support"
+ depends on I2C
select MFD_CORE
select REGMAP_I2C
select REGMAP_IRQ
diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
index b83b7a7da1ae..78e501feb96c 100644
--- a/drivers/mfd/max77693.c
+++ b/drivers/mfd/max77693.c
@@ -368,6 +368,7 @@ static const struct of_device_id max77693_dt_match[] = {
{ .compatible = "maxim,max77693" },
{},
};
+MODULE_DEVICE_TABLE(of, max77693_dt_match);
#endif
static struct i2c_driver max77693_i2c_driver = {
@@ -381,18 +382,7 @@ static struct i2c_driver max77693_i2c_driver = {
.id_table = max77693_i2c_id,
};
-static int __init max77693_i2c_init(void)
-{
- return i2c_add_driver(&max77693_i2c_driver);
-}
-/* init early so consumer devices can complete system boot */
-subsys_initcall(max77693_i2c_init);
-
-static void __exit max77693_i2c_exit(void)
-{
- i2c_del_driver(&max77693_i2c_driver);
-}
-module_exit(max77693_i2c_exit);
+module_i2c_driver(max77693_i2c_driver);
MODULE_DESCRIPTION("MAXIM 77693 multi-function core driver");
MODULE_AUTHOR("SangYoung, Son <hello.son@samsung.com>");
--
2.5.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 1/2] mfd: max77693: Allow building as a module
@ 2016-04-04 7:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-04 7:54 UTC (permalink / raw)
To: linux-arm-kernel
The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
driver) supports deferred probing so the max77693 main MFD driver can be
built now as a module. This gives more flexibility and removes manual
ordering of init calls.
Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/mfd/Kconfig | 4 ++--
drivers/mfd/max77693.c | 14 ++------------
2 files changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index eea61e349e26..aa1e7c3f82ee 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -543,8 +543,8 @@ config MFD_MAX77686
of the device.
config MFD_MAX77693
- bool "Maxim Semiconductor MAX77693 PMIC Support"
- depends on I2C=y
+ tristate "Maxim Semiconductor MAX77693 PMIC Support"
+ depends on I2C
select MFD_CORE
select REGMAP_I2C
select REGMAP_IRQ
diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
index b83b7a7da1ae..78e501feb96c 100644
--- a/drivers/mfd/max77693.c
+++ b/drivers/mfd/max77693.c
@@ -368,6 +368,7 @@ static const struct of_device_id max77693_dt_match[] = {
{ .compatible = "maxim,max77693" },
{},
};
+MODULE_DEVICE_TABLE(of, max77693_dt_match);
#endif
static struct i2c_driver max77693_i2c_driver = {
@@ -381,18 +382,7 @@ static struct i2c_driver max77693_i2c_driver = {
.id_table = max77693_i2c_id,
};
-static int __init max77693_i2c_init(void)
-{
- return i2c_add_driver(&max77693_i2c_driver);
-}
-/* init early so consumer devices can complete system boot */
-subsys_initcall(max77693_i2c_init);
-
-static void __exit max77693_i2c_exit(void)
-{
- i2c_del_driver(&max77693_i2c_driver);
-}
-module_exit(max77693_i2c_exit);
+module_i2c_driver(max77693_i2c_driver);
MODULE_DESCRIPTION("MAXIM 77693 multi-function core driver");
MODULE_AUTHOR("SangYoung, Son <hello.son@samsung.com>");
--
2.5.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 2/2] ARM: multi_v7_defconfig: Switch max77693 to module
2016-04-04 7:54 ` Krzysztof Kozlowski
@ 2016-04-04 7:54 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-04 7:54 UTC (permalink / raw)
To: Lee Jones, Chanwoo Choi, Krzysztof Kozlowski, Arnd Bergmann,
Javier Martinez Canillas, Kukjin Kim, Olof Johansson,
linux-arm-kernel, linux-kernel, linux-samsung-soc
Cc: Kevin Hilman
The driver can be built as a module, so use this possibility.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
This patch depends on previous one "mfd: max77693: Allow building as a
module". Please pick-up everything or provide a tag for me (so I could
pick up this one to samsung-soc tree).
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 4eb10f5ea493..d92f6bfbba0e 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -453,7 +453,7 @@ CONFIG_MFD_CROS_EC_SPI=m
CONFIG_MFD_DA9063=m
CONFIG_MFD_MAX14577=y
CONFIG_MFD_MAX77686=y
-CONFIG_MFD_MAX77693=y
+CONFIG_MFD_MAX77693=m
CONFIG_MFD_MAX8907=y
CONFIG_MFD_MAX8997=y
CONFIG_MFD_RK808=y
--
2.5.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 2/2] ARM: multi_v7_defconfig: Switch max77693 to module
@ 2016-04-04 7:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-04 7:54 UTC (permalink / raw)
To: linux-arm-kernel
The driver can be built as a module, so use this possibility.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
This patch depends on previous one "mfd: max77693: Allow building as a
module". Please pick-up everything or provide a tag for me (so I could
pick up this one to samsung-soc tree).
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 4eb10f5ea493..d92f6bfbba0e 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -453,7 +453,7 @@ CONFIG_MFD_CROS_EC_SPI=m
CONFIG_MFD_DA9063=m
CONFIG_MFD_MAX14577=y
CONFIG_MFD_MAX77686=y
-CONFIG_MFD_MAX77693=y
+CONFIG_MFD_MAX77693=m
CONFIG_MFD_MAX8907=y
CONFIG_MFD_MAX8997=y
CONFIG_MFD_RK808=y
--
2.5.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] mfd: max77693: Allow building as a module
2016-04-04 7:54 ` Krzysztof Kozlowski
@ 2016-04-05 14:02 ` Javier Martinez Canillas
-1 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-04-05 14:02 UTC (permalink / raw)
To: Krzysztof Kozlowski, Lee Jones, Chanwoo Choi, Arnd Bergmann,
Kukjin Kim, Olof Johansson, linux-arm-kernel, linux-kernel,
linux-samsung-soc
Cc: Kevin Hilman, Paul Gortmaker
Hello Krzysztof,
On 04/04/2016 03:54 AM, Krzysztof Kozlowski wrote:
> The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
> driver) supports deferred probing so the max77693 main MFD driver can be
> built now as a module. This gives more flexibility and removes manual
> ordering of init calls.
>
> Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] mfd: max77693: Allow building as a module
@ 2016-04-05 14:02 ` Javier Martinez Canillas
0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-04-05 14:02 UTC (permalink / raw)
To: linux-arm-kernel
Hello Krzysztof,
On 04/04/2016 03:54 AM, Krzysztof Kozlowski wrote:
> The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
> driver) supports deferred probing so the max77693 main MFD driver can be
> built now as a module. This gives more flexibility and removes manual
> ordering of init calls.
>
> Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/2] ARM: multi_v7_defconfig: Switch max77693 to module
2016-04-04 7:54 ` Krzysztof Kozlowski
@ 2016-04-05 14:02 ` Javier Martinez Canillas
-1 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-04-05 14:02 UTC (permalink / raw)
To: Krzysztof Kozlowski, Lee Jones, Chanwoo Choi, Arnd Bergmann,
Kukjin Kim, Olof Johansson, linux-arm-kernel, linux-kernel,
linux-samsung-soc
Cc: Kevin Hilman
Hello Krzysztof,
On 04/04/2016 03:54 AM, Krzysztof Kozlowski wrote:
> The driver can be built as a module, so use this possibility.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> This patch depends on previous one "mfd: max77693: Allow building as a
> module". Please pick-up everything or provide a tag for me (so I could
> pick up this one to samsung-soc tree).
> ---
> arch/arm/configs/multi_v7_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 4eb10f5ea493..d92f6bfbba0e 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -453,7 +453,7 @@ CONFIG_MFD_CROS_EC_SPI=m
> CONFIG_MFD_DA9063=m
> CONFIG_MFD_MAX14577=y
> CONFIG_MFD_MAX77686=y
> -CONFIG_MFD_MAX77693=y
> +CONFIG_MFD_MAX77693=m
> CONFIG_MFD_MAX8907=y
> CONFIG_MFD_MAX8997=y
> CONFIG_MFD_RK808=y
>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 2/2] ARM: multi_v7_defconfig: Switch max77693 to module
@ 2016-04-05 14:02 ` Javier Martinez Canillas
0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-04-05 14:02 UTC (permalink / raw)
To: linux-arm-kernel
Hello Krzysztof,
On 04/04/2016 03:54 AM, Krzysztof Kozlowski wrote:
> The driver can be built as a module, so use this possibility.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> This patch depends on previous one "mfd: max77693: Allow building as a
> module". Please pick-up everything or provide a tag for me (so I could
> pick up this one to samsung-soc tree).
> ---
> arch/arm/configs/multi_v7_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 4eb10f5ea493..d92f6bfbba0e 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -453,7 +453,7 @@ CONFIG_MFD_CROS_EC_SPI=m
> CONFIG_MFD_DA9063=m
> CONFIG_MFD_MAX14577=y
> CONFIG_MFD_MAX77686=y
> -CONFIG_MFD_MAX77693=y
> +CONFIG_MFD_MAX77693=m
> CONFIG_MFD_MAX8907=y
> CONFIG_MFD_MAX8997=y
> CONFIG_MFD_RK808=y
>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] mfd: max77693: Allow building as a module
2016-04-04 7:54 ` Krzysztof Kozlowski
@ 2016-04-07 13:29 ` Lee Jones
-1 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2016-04-07 13:29 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Chanwoo Choi, Arnd Bergmann, Javier Martinez Canillas,
Kukjin Kim, Olof Johansson, linux-arm-kernel, linux-kernel,
linux-samsung-soc, Kevin Hilman, Paul Gortmaker
On Mon, 04 Apr 2016, Krzysztof Kozlowski wrote:
> The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
> driver) supports deferred probing so the max77693 main MFD driver can be
> built now as a module. This gives more flexibility and removes manual
> ordering of init calls.
>
> Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/mfd/Kconfig | 4 ++--
> drivers/mfd/max77693.c | 14 ++------------
> 2 files changed, 4 insertions(+), 14 deletions(-)
I assume this can be taken immediately and doesn't depend on anything
external to the set?
For my own reference:
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index eea61e349e26..aa1e7c3f82ee 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -543,8 +543,8 @@ config MFD_MAX77686
> of the device.
>
> config MFD_MAX77693
> - bool "Maxim Semiconductor MAX77693 PMIC Support"
> - depends on I2C=y
> + tristate "Maxim Semiconductor MAX77693 PMIC Support"
> + depends on I2C
> select MFD_CORE
> select REGMAP_I2C
> select REGMAP_IRQ
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index b83b7a7da1ae..78e501feb96c 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -368,6 +368,7 @@ static const struct of_device_id max77693_dt_match[] = {
> { .compatible = "maxim,max77693" },
> {},
> };
> +MODULE_DEVICE_TABLE(of, max77693_dt_match);
> #endif
>
> static struct i2c_driver max77693_i2c_driver = {
> @@ -381,18 +382,7 @@ static struct i2c_driver max77693_i2c_driver = {
> .id_table = max77693_i2c_id,
> };
>
> -static int __init max77693_i2c_init(void)
> -{
> - return i2c_add_driver(&max77693_i2c_driver);
> -}
> -/* init early so consumer devices can complete system boot */
> -subsys_initcall(max77693_i2c_init);
> -
> -static void __exit max77693_i2c_exit(void)
> -{
> - i2c_del_driver(&max77693_i2c_driver);
> -}
> -module_exit(max77693_i2c_exit);
> +module_i2c_driver(max77693_i2c_driver);
>
> MODULE_DESCRIPTION("MAXIM 77693 multi-function core driver");
> MODULE_AUTHOR("SangYoung, Son <hello.son@samsung.com>");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] mfd: max77693: Allow building as a module
@ 2016-04-07 13:29 ` Lee Jones
0 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2016-04-07 13:29 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 04 Apr 2016, Krzysztof Kozlowski wrote:
> The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
> driver) supports deferred probing so the max77693 main MFD driver can be
> built now as a module. This gives more flexibility and removes manual
> ordering of init calls.
>
> Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/mfd/Kconfig | 4 ++--
> drivers/mfd/max77693.c | 14 ++------------
> 2 files changed, 4 insertions(+), 14 deletions(-)
I assume this can be taken immediately and doesn't depend on anything
external to the set?
For my own reference:
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index eea61e349e26..aa1e7c3f82ee 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -543,8 +543,8 @@ config MFD_MAX77686
> of the device.
>
> config MFD_MAX77693
> - bool "Maxim Semiconductor MAX77693 PMIC Support"
> - depends on I2C=y
> + tristate "Maxim Semiconductor MAX77693 PMIC Support"
> + depends on I2C
> select MFD_CORE
> select REGMAP_I2C
> select REGMAP_IRQ
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index b83b7a7da1ae..78e501feb96c 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -368,6 +368,7 @@ static const struct of_device_id max77693_dt_match[] = {
> { .compatible = "maxim,max77693" },
> {},
> };
> +MODULE_DEVICE_TABLE(of, max77693_dt_match);
> #endif
>
> static struct i2c_driver max77693_i2c_driver = {
> @@ -381,18 +382,7 @@ static struct i2c_driver max77693_i2c_driver = {
> .id_table = max77693_i2c_id,
> };
>
> -static int __init max77693_i2c_init(void)
> -{
> - return i2c_add_driver(&max77693_i2c_driver);
> -}
> -/* init early so consumer devices can complete system boot */
> -subsys_initcall(max77693_i2c_init);
> -
> -static void __exit max77693_i2c_exit(void)
> -{
> - i2c_del_driver(&max77693_i2c_driver);
> -}
> -module_exit(max77693_i2c_exit);
> +module_i2c_driver(max77693_i2c_driver);
>
> MODULE_DESCRIPTION("MAXIM 77693 multi-function core driver");
> MODULE_AUTHOR("SangYoung, Son <hello.son@samsung.com>");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] mfd: max77693: Allow building as a module
2016-04-07 13:29 ` Lee Jones
@ 2016-04-08 3:54 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-08 3:54 UTC (permalink / raw)
To: Lee Jones
Cc: Krzysztof Kozlowski, Chanwoo Choi, Arnd Bergmann,
Javier Martinez Canillas, Kukjin Kim, Olof Johansson,
linux-arm-kernel, linux-kernel, linux-samsung-soc, Kevin Hilman,
Paul Gortmaker
On Thu, Apr 07, 2016 at 02:29:47PM +0100, Lee Jones wrote:
> On Mon, 04 Apr 2016, Krzysztof Kozlowski wrote:
>
> > The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
> > driver) supports deferred probing so the max77693 main MFD driver can be
> > built now as a module. This gives more flexibility and removes manual
> > ordering of init calls.
> >
> > Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > drivers/mfd/Kconfig | 4 ++--
> > drivers/mfd/max77693.c | 14 ++------------
> > 2 files changed, 4 insertions(+), 14 deletions(-)
>
> I assume this can be taken immediately and doesn't depend on anything
> external to the set?
>
> For my own reference:
> Acked-by: Lee Jones <lee.jones@linaro.org>
Hi,
Yes, this can be taken as is. Only second patch (changing defconfig)
depends on this. I can take the second patch through samsung tree but
that would require a tag/branch with this... which looks like an
overkill. So maybe you would take both?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] mfd: max77693: Allow building as a module
@ 2016-04-08 3:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-08 3:54 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Apr 07, 2016 at 02:29:47PM +0100, Lee Jones wrote:
> On Mon, 04 Apr 2016, Krzysztof Kozlowski wrote:
>
> > The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
> > driver) supports deferred probing so the max77693 main MFD driver can be
> > built now as a module. This gives more flexibility and removes manual
> > ordering of init calls.
> >
> > Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > drivers/mfd/Kconfig | 4 ++--
> > drivers/mfd/max77693.c | 14 ++------------
> > 2 files changed, 4 insertions(+), 14 deletions(-)
>
> I assume this can be taken immediately and doesn't depend on anything
> external to the set?
>
> For my own reference:
> Acked-by: Lee Jones <lee.jones@linaro.org>
Hi,
Yes, this can be taken as is. Only second patch (changing defconfig)
depends on this. I can take the second patch through samsung tree but
that would require a tag/branch with this... which looks like an
overkill. So maybe you would take both?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] mfd: max77693: Allow building as a module
2016-04-08 3:54 ` Krzysztof Kozlowski
@ 2016-04-08 7:17 ` Lee Jones
-1 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2016-04-08 7:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Chanwoo Choi, Arnd Bergmann, Javier Martinez Canillas,
Kukjin Kim, Olof Johansson, linux-arm-kernel, linux-kernel,
linux-samsung-soc, Kevin Hilman, Paul Gortmaker
On Fri, 08 Apr 2016, Krzysztof Kozlowski wrote:
> On Thu, Apr 07, 2016 at 02:29:47PM +0100, Lee Jones wrote:
> > On Mon, 04 Apr 2016, Krzysztof Kozlowski wrote:
> >
> > > The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
> > > driver) supports deferred probing so the max77693 main MFD driver can be
> > > built now as a module. This gives more flexibility and removes manual
> > > ordering of init calls.
> > >
> > > Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > > Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > > ---
> > > drivers/mfd/Kconfig | 4 ++--
> > > drivers/mfd/max77693.c | 14 ++------------
> > > 2 files changed, 4 insertions(+), 14 deletions(-)
> >
> > I assume this can be taken immediately and doesn't depend on anything
> > external to the set?
> >
> > For my own reference:
> > Acked-by: Lee Jones <lee.jones@linaro.org>
>
> Hi,
>
> Yes, this can be taken as is. Only second patch (changing defconfig)
> depends on this. I can take the second patch through samsung tree but
> that would require a tag/branch with this... which looks like an
> overkill. So maybe you would take both?
If I take the defconfig patch without a tag, there will almost
certainly be merge conflicts. Other solutions include; delaying the
defconfig patch for one cycle or trying to get it in post -rc1.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] mfd: max77693: Allow building as a module
@ 2016-04-08 7:17 ` Lee Jones
0 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2016-04-08 7:17 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 08 Apr 2016, Krzysztof Kozlowski wrote:
> On Thu, Apr 07, 2016 at 02:29:47PM +0100, Lee Jones wrote:
> > On Mon, 04 Apr 2016, Krzysztof Kozlowski wrote:
> >
> > > The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
> > > driver) supports deferred probing so the max77693 main MFD driver can be
> > > built now as a module. This gives more flexibility and removes manual
> > > ordering of init calls.
> > >
> > > Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > > Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > > ---
> > > drivers/mfd/Kconfig | 4 ++--
> > > drivers/mfd/max77693.c | 14 ++------------
> > > 2 files changed, 4 insertions(+), 14 deletions(-)
> >
> > I assume this can be taken immediately and doesn't depend on anything
> > external to the set?
> >
> > For my own reference:
> > Acked-by: Lee Jones <lee.jones@linaro.org>
>
> Hi,
>
> Yes, this can be taken as is. Only second patch (changing defconfig)
> depends on this. I can take the second patch through samsung tree but
> that would require a tag/branch with this... which looks like an
> overkill. So maybe you would take both?
If I take the defconfig patch without a tag, there will almost
certainly be merge conflicts. Other solutions include; delaying the
defconfig patch for one cycle or trying to get it in post -rc1.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] mfd: max77693: Allow building as a module
2016-04-08 7:17 ` Lee Jones
@ 2016-04-10 8:46 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-10 8:46 UTC (permalink / raw)
To: Lee Jones
Cc: Krzysztof Kozlowski, Chanwoo Choi, Arnd Bergmann,
Javier Martinez Canillas, Kukjin Kim, Olof Johansson,
linux-arm-kernel, linux-kernel, linux-samsung-soc, Kevin Hilman,
Paul Gortmaker
On Fri, Apr 08, 2016 at 08:17:21AM +0100, Lee Jones wrote:
> > Yes, this can be taken as is. Only second patch (changing defconfig)
> > depends on this. I can take the second patch through samsung tree but
> > that would require a tag/branch with this... which looks like an
> > overkill. So maybe you would take both?
>
> If I take the defconfig patch without a tag, there will almost
> certainly be merge conflicts. Other solutions include; delaying the
> defconfig patch for one cycle or trying to get it in post -rc1.
Let's wait for next cycle then. Anyway Javier added module-capability
to some other drivers as well so we can change all them at once.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] mfd: max77693: Allow building as a module
@ 2016-04-10 8:46 ` Krzysztof Kozlowski
0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-10 8:46 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Apr 08, 2016 at 08:17:21AM +0100, Lee Jones wrote:
> > Yes, this can be taken as is. Only second patch (changing defconfig)
> > depends on this. I can take the second patch through samsung tree but
> > that would require a tag/branch with this... which looks like an
> > overkill. So maybe you would take both?
>
> If I take the defconfig patch without a tag, there will almost
> certainly be merge conflicts. Other solutions include; delaying the
> defconfig patch for one cycle or trying to get it in post -rc1.
Let's wait for next cycle then. Anyway Javier added module-capability
to some other drivers as well so we can change all them at once.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] mfd: max77693: Allow building as a module
2016-04-04 7:54 ` Krzysztof Kozlowski
@ 2016-04-11 8:00 ` Lee Jones
-1 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2016-04-11 8:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Chanwoo Choi, Arnd Bergmann, Javier Martinez Canillas,
Kukjin Kim, Olof Johansson, linux-arm-kernel, linux-kernel,
linux-samsung-soc, Kevin Hilman, Paul Gortmaker
On Mon, 04 Apr 2016, Krzysztof Kozlowski wrote:
> The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
> driver) supports deferred probing so the max77693 main MFD driver can be
> built now as a module. This gives more flexibility and removes manual
> ordering of init calls.
>
> Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/mfd/Kconfig | 4 ++--
> drivers/mfd/max77693.c | 14 ++------------
> 2 files changed, 4 insertions(+), 14 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index eea61e349e26..aa1e7c3f82ee 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -543,8 +543,8 @@ config MFD_MAX77686
> of the device.
>
> config MFD_MAX77693
> - bool "Maxim Semiconductor MAX77693 PMIC Support"
> - depends on I2C=y
> + tristate "Maxim Semiconductor MAX77693 PMIC Support"
> + depends on I2C
> select MFD_CORE
> select REGMAP_I2C
> select REGMAP_IRQ
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index b83b7a7da1ae..78e501feb96c 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -368,6 +368,7 @@ static const struct of_device_id max77693_dt_match[] = {
> { .compatible = "maxim,max77693" },
> {},
> };
> +MODULE_DEVICE_TABLE(of, max77693_dt_match);
> #endif
>
> static struct i2c_driver max77693_i2c_driver = {
> @@ -381,18 +382,7 @@ static struct i2c_driver max77693_i2c_driver = {
> .id_table = max77693_i2c_id,
> };
>
> -static int __init max77693_i2c_init(void)
> -{
> - return i2c_add_driver(&max77693_i2c_driver);
> -}
> -/* init early so consumer devices can complete system boot */
> -subsys_initcall(max77693_i2c_init);
> -
> -static void __exit max77693_i2c_exit(void)
> -{
> - i2c_del_driver(&max77693_i2c_driver);
> -}
> -module_exit(max77693_i2c_exit);
> +module_i2c_driver(max77693_i2c_driver);
>
> MODULE_DESCRIPTION("MAXIM 77693 multi-function core driver");
> MODULE_AUTHOR("SangYoung, Son <hello.son@samsung.com>");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] mfd: max77693: Allow building as a module
@ 2016-04-11 8:00 ` Lee Jones
0 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2016-04-11 8:00 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 04 Apr 2016, Krzysztof Kozlowski wrote:
> The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy
> driver) supports deferred probing so the max77693 main MFD driver can be
> built now as a module. This gives more flexibility and removes manual
> ordering of init calls.
>
> Suggested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/mfd/Kconfig | 4 ++--
> drivers/mfd/max77693.c | 14 ++------------
> 2 files changed, 4 insertions(+), 14 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index eea61e349e26..aa1e7c3f82ee 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -543,8 +543,8 @@ config MFD_MAX77686
> of the device.
>
> config MFD_MAX77693
> - bool "Maxim Semiconductor MAX77693 PMIC Support"
> - depends on I2C=y
> + tristate "Maxim Semiconductor MAX77693 PMIC Support"
> + depends on I2C
> select MFD_CORE
> select REGMAP_I2C
> select REGMAP_IRQ
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index b83b7a7da1ae..78e501feb96c 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -368,6 +368,7 @@ static const struct of_device_id max77693_dt_match[] = {
> { .compatible = "maxim,max77693" },
> {},
> };
> +MODULE_DEVICE_TABLE(of, max77693_dt_match);
> #endif
>
> static struct i2c_driver max77693_i2c_driver = {
> @@ -381,18 +382,7 @@ static struct i2c_driver max77693_i2c_driver = {
> .id_table = max77693_i2c_id,
> };
>
> -static int __init max77693_i2c_init(void)
> -{
> - return i2c_add_driver(&max77693_i2c_driver);
> -}
> -/* init early so consumer devices can complete system boot */
> -subsys_initcall(max77693_i2c_init);
> -
> -static void __exit max77693_i2c_exit(void)
> -{
> - i2c_del_driver(&max77693_i2c_driver);
> -}
> -module_exit(max77693_i2c_exit);
> +module_i2c_driver(max77693_i2c_driver);
>
> MODULE_DESCRIPTION("MAXIM 77693 multi-function core driver");
> MODULE_AUTHOR("SangYoung, Son <hello.son@samsung.com>");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2016-04-11 8:00 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-04 7:54 [PATCH 1/2] mfd: max77693: Allow building as a module Krzysztof Kozlowski
2016-04-04 7:54 ` Krzysztof Kozlowski
2016-04-04 7:54 ` [PATCH 2/2] ARM: multi_v7_defconfig: Switch max77693 to module Krzysztof Kozlowski
2016-04-04 7:54 ` Krzysztof Kozlowski
2016-04-05 14:02 ` Javier Martinez Canillas
2016-04-05 14:02 ` Javier Martinez Canillas
2016-04-05 14:02 ` [PATCH 1/2] mfd: max77693: Allow building as a module Javier Martinez Canillas
2016-04-05 14:02 ` Javier Martinez Canillas
2016-04-07 13:29 ` Lee Jones
2016-04-07 13:29 ` Lee Jones
2016-04-08 3:54 ` Krzysztof Kozlowski
2016-04-08 3:54 ` Krzysztof Kozlowski
2016-04-08 7:17 ` Lee Jones
2016-04-08 7:17 ` Lee Jones
2016-04-10 8:46 ` Krzysztof Kozlowski
2016-04-10 8:46 ` Krzysztof Kozlowski
2016-04-11 8:00 ` Lee Jones
2016-04-11 8:00 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.