[Buildroot] [PATCH 1/1] xorriso: Add host variant

[Buildroot] [PATCH 1/1] xorriso: Add host variant

[Benoît Allard]

Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
---
Changes v1 -> v2
  - Disable all external dependencies (Suggested by Yann)
---
 package/Config.in.host         |  1 +
 package/xorriso/Config.in.host | 14 ++++++++++++++
 package/xorriso/xorriso.mk     | 11 +++++++++++
 3 files changed, 26 insertions(+)
 create mode 100644 package/xorriso/Config.in.host

diff --git a/package/Config.in.host b/package/Config.in.host
index 09c98fb..a91612b 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -32,6 +32,7 @@ menu "Host utilities"
 	source "package/uboot-tools/Config.in.host"
 	source "package/util-linux/Config.in.host"
 	source "package/vboot-utils/Config.in.host"
+	source "package/xorriso/Config.in.host"
 	source "package/zip/Config.in.host"
 
 endmenu
diff --git a/package/xorriso/Config.in.host b/package/xorriso/Config.in.host
new file mode 100644
index 0000000..2baa043
--- /dev/null
+++ b/package/xorriso/Config.in.host
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_HOST_XORRISO
+	bool "host xorriso"
+	help
+	  xorriso copies file objects from POSIX compliant
+	  filesystems into Rock Ridge enhanced ISO 9660 filesystems
+	  and allows session-wise manipulation of such filesystems.
+	  It can load the management information of existing ISO
+	  images and it writes the session results to optical media
+	  or to filesystem objects.
+
+	  Vice versa xorriso is able to copy file objects out of ISO
+	  9660 filesystems.
+
+	  https://www.gnu.org/software/xorriso
diff --git a/package/xorriso/xorriso.mk b/package/xorriso/xorriso.mk
index e8bb5cb..57537e8 100644
--- a/package/xorriso/xorriso.mk
+++ b/package/xorriso/xorriso.mk
@@ -8,6 +8,16 @@ XORRISO_VERSION = 1.4.2
 XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
 XORRISO_LICENSE = GPLv3+
 XORRISO_LICENSE_FILES = COPYING COPYRIGHT
+HOST_XORRISO_DEPENDENCIES =
+# Disable everything until we actually need those feature, and add the correct
+# host-libraries
+HOST_XORRISO_CONF_OPTS = \
+        --disable-zlib \
+        --disable-bzip2 \
+        --disable-libcdio \
+        --disable-libreadline \
+        --disable-libedit \
+        --disable-libacl
 
 ifeq ($(BR2_PACKAGE_LIBICONV),y)
 XORRISO_DEPENDENCIES += libiconv
@@ -64,3 +74,4 @@ XORRISO_CONF_OPTS += --disable-jtethreads
 endif
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
-- 
2.1.4

[Buildroot] [PATCH 1/1] xorriso: Add host variant

[Thomas Petazzoni]

Hello,

On Wed, 16 Mar 2016 14:55:15 +0100, Beno?t Allard wrote:
> Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>

Thanks, I've applied. But a few questions/comments below.


> +	  xorriso copies file objects from POSIX compliant
> +	  filesystems into Rock Ridge enhanced ISO 9660 filesystems
> +	  and allows session-wise manipulation of such filesystems.
> +	  It can load the management information of existing ISO
> +	  images and it writes the session results to optical media
> +	  or to filesystem objects.
> +
> +	  Vice versa xorriso is able to copy file objects out of ISO
> +	  9660 filesystems.
> +
> +	  https://www.gnu.org/software/xorriso

The Config.in help text for the target variant, in
package/xorriso/Config.in, is completely different. Yours is
copy/pasted from the xorriso home page, which looks good. So maybe it
would be good to use the same for the target variant of xorriso.

Another question is: can we use xorisso instead of cdrkit in
fs/iso9660/ to build ISO images ?

I don't have anything against cdrkit, but it uses CMake, and it takes
ages to build.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] xorriso: Add host variant

[Benoît Allard]

On Wed, 30 Mar 2016 21:13:49 +0200
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Hello,
> 
> On Wed, 16 Mar 2016 14:55:15 +0100, Beno?t Allard wrote:
> > Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
> 
> Thanks, I've applied. But a few questions/comments below.

Great, thanks !

> 
> 
> > +	  xorriso copies file objects from POSIX compliant
> > +	  filesystems into Rock Ridge enhanced ISO 9660 filesystems
> > +	  and allows session-wise manipulation of such filesystems.
> > +	  It can load the management information of existing ISO
> > +	  images and it writes the session results to optical media
> > +	  or to filesystem objects.
> > +
> > +	  Vice versa xorriso is able to copy file objects out of
> > ISO
> > +	  9660 filesystems.
> > +
> > +	  https://www.gnu.org/software/xorriso
> 
> The Config.in help text for the target variant, in
> package/xorriso/Config.in, is completely different. Yours is
> copy/pasted from the xorriso home page, which looks good. So maybe it
> would be good to use the same for the target variant of xorriso.

I will submit a patch for that.

> 
> Another question is: can we use xorisso instead of cdrkit in
> fs/iso9660/ to build ISO images ?

The reason I need xorriso is that it can generates hybrid images out
of the box (Even EFI-hybrid ones !). The next steps are indeed to use
it for fs/iso9660/.

The issue with integrating hybrid EFI images though is that we need a
whole FAT EFI boot-filesystem (with initramfs, kernel and such) to
embed into the ISO image, which if integrated will blow up the
fs/iso9660 process a bit. How are the opinion on that ?

Regard,
Ben.

> 
> I don't have anything against cdrkit, but it uses CMake, and it takes
> ages to build.
> 
> Thanks!
> 
> Thomas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160408/92f7a87a/attachment.asc>