From: William Breathitt Gray <vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 04/10] iio: stx104: Change STX104 dependency to ISA_BUS Date: Fri, 8 Apr 2016 11:09:22 -0400 [thread overview] Message-ID: <20160408150922.GA28058@sophia> (raw) In-Reply-To: <5707AF91.5010704-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> On Fri, Apr 08, 2016 at 06:18:09AM -0700, Guenter Roeck wrote: > From the context, arm and mips use "select ISA". For those, adding and >auto-selecting ISA_BUS would make sense. For the remaining architectures >you could simply add "config ISA_BUS". I would suggest to update default >configurations, though. > >There is also "um", for which you effectively disabled ISA support >as far as I can see. You might want to look into that as well. > >> My avoidance of making ISA a selection of ISA_BUS is the possibility of >> an invalid configuration: a user may initially enable ISA_BUS, then >> later disable ISA, resulting in ISA_BUS remaining enabled without ISA >> selected. >> >Does that even make sense ? Not sure I understand why you don't just >select ISA_BUS if ISA is selected. That would also be backward compatible >and avoid the problem I was concerned about. I feel now that the introduction of the ISA_BUS option may the wrong approach to resolve lack of ISA support for the X86_64 architecture; adding ISA_BUS depends or selects through various Kconfigs would simply obfuscate the ISA option. The true issue is that various driver configs are assuming X86_32 architecture when they depend on the ISA option, but the ISA bus does not require an X86_32 architecture. The proper resolution then is to remove the misguided ISA_BUS option and move the X86_32 dependency to the relevant drivers configs explicitly. A grep for isa_register_driver calls within the kernel reveals that only a few drivers explicitly use it. It should be trivial to create a patch to add the explicit X86_32 dependency to the relevant drivers, so I will submit one soon when I get the time to decouple X86_32 from the ISA config option. Once ISA is freed from the X86_32 dependency, I will simply use it instead of ISA_BUS, and rebase this patchset for version 2. >> As a side note, should the dummy isa_register_driver return 0? Would it >> be more appropriate for it to return an error code to indicate lack of >> support for ISA, rather than silently fail? >> >One should think so. > >Thanks, >Guenter > I'll submit a separate patch for this as well then. William Breathitt Gray -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: William Breathitt Gray <vilhelm.gray@gmail.com> To: Guenter Roeck <linux@roeck-us.net> Cc: gregkh@linuxfoundation.org, tglx@linutronix.de, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, wim@iguana.be, linus.walleij@linaro.org, gnurou@gmail.com, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 04/10] iio: stx104: Change STX104 dependency to ISA_BUS Date: Fri, 8 Apr 2016 11:09:22 -0400 [thread overview] Message-ID: <20160408150922.GA28058@sophia> (raw) In-Reply-To: <5707AF91.5010704@roeck-us.net> On Fri, Apr 08, 2016 at 06:18:09AM -0700, Guenter Roeck wrote: > From the context, arm and mips use "select ISA". For those, adding and >auto-selecting ISA_BUS would make sense. For the remaining architectures >you could simply add "config ISA_BUS". I would suggest to update default >configurations, though. > >There is also "um", for which you effectively disabled ISA support >as far as I can see. You might want to look into that as well. > >> My avoidance of making ISA a selection of ISA_BUS is the possibility of >> an invalid configuration: a user may initially enable ISA_BUS, then >> later disable ISA, resulting in ISA_BUS remaining enabled without ISA >> selected. >> >Does that even make sense ? Not sure I understand why you don't just >select ISA_BUS if ISA is selected. That would also be backward compatible >and avoid the problem I was concerned about. I feel now that the introduction of the ISA_BUS option may the wrong approach to resolve lack of ISA support for the X86_64 architecture; adding ISA_BUS depends or selects through various Kconfigs would simply obfuscate the ISA option. The true issue is that various driver configs are assuming X86_32 architecture when they depend on the ISA option, but the ISA bus does not require an X86_32 architecture. The proper resolution then is to remove the misguided ISA_BUS option and move the X86_32 dependency to the relevant drivers configs explicitly. A grep for isa_register_driver calls within the kernel reveals that only a few drivers explicitly use it. It should be trivial to create a patch to add the explicit X86_32 dependency to the relevant drivers, so I will submit one soon when I get the time to decouple X86_32 from the ISA config option. Once ISA is freed from the X86_32 dependency, I will simply use it instead of ISA_BUS, and rebase this patchset for version 2. >> As a side note, should the dummy isa_register_driver return 0? Would it >> be more appropriate for it to return an error code to indicate lack of >> support for ISA, rather than silently fail? >> >One should think so. > >Thanks, >Guenter > I'll submit a separate patch for this as well then. William Breathitt Gray
next prev parent reply other threads:[~2016-04-08 15:09 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-07 14:47 [PATCH 00/10] Use the ISA bus driver for PC/104 and ISA devices William Breathitt Gray 2016-04-07 14:47 ` William Breathitt Gray 2016-04-07 14:47 ` [PATCH 01/10] isa: Implement the module_isa_driver macro William Breathitt Gray 2016-04-07 14:47 ` [PATCH 02/10] isa: Implement the max_num_isa_dev macro William Breathitt Gray 2016-04-07 14:47 ` [PATCH 03/10] Documentation: Add ISA bus driver documentation William Breathitt Gray 2016-05-01 21:26 ` Greg KH 2016-04-07 14:47 ` [PATCH 04/10] iio: stx104: Change STX104 dependency to ISA_BUS William Breathitt Gray [not found] ` <783be62acf68b35f3fe4785a2cedfe017624688b.1460040201.git.vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2016-04-08 0:45 ` Guenter Roeck 2016-04-08 0:45 ` Guenter Roeck [not found] ` <20160408004503.GB10211-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> 2016-04-08 12:31 ` William Breathitt Gray 2016-04-08 12:31 ` William Breathitt Gray 2016-04-08 13:18 ` Guenter Roeck 2016-04-08 13:18 ` Guenter Roeck [not found] ` <5707AF91.5010704-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> 2016-04-08 15:09 ` William Breathitt Gray [this message] 2016-04-08 15:09 ` William Breathitt Gray 2016-04-08 18:28 ` Guenter Roeck [not found] ` <20160408182801.GB7083-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> 2016-04-08 19:27 ` William Breathitt Gray 2016-04-08 19:27 ` William Breathitt Gray 2016-04-09 12:58 ` One Thousand Gnomes [not found] ` <20160409135814.359e24d6-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org> 2016-04-09 13:50 ` William Breathitt Gray 2016-04-09 13:50 ` William Breathitt Gray 2016-04-09 15:51 ` One Thousand Gnomes 2016-04-09 15:51 ` One Thousand Gnomes 2016-04-07 14:47 ` [PATCH 05/10] iio: stx104: Utilize the module_isa_driver and max_num_isa_dev macros William Breathitt Gray 2016-04-07 14:47 ` [PATCH 06/10] watchdog: ebc-c384_wdt: Utilize the ISA bus driver William Breathitt Gray [not found] ` <1f5bf2e21006f0fd4f10ab3948cf69a737c0b039.1460040201.git.vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2016-04-08 0:35 ` Guenter Roeck 2016-04-08 0:35 ` Guenter Roeck 2016-04-08 12:03 ` William Breathitt Gray 2016-05-11 17:04 ` Sasha Levin 2016-05-11 17:04 ` Sasha Levin [not found] ` <57336622.9070508-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2016-05-11 19:34 ` William Breathitt Gray 2016-05-11 19:34 ` William Breathitt Gray 2016-04-07 14:47 ` [PATCH 07/10] gpio: 104-dio-48e: " William Breathitt Gray 2016-04-07 14:47 ` [PATCH 08/10] gpio: 104-idi-48: " William Breathitt Gray 2016-04-07 14:47 ` [PATCH 09/10] gpio: 104-idio-16: " William Breathitt Gray 2016-04-07 14:47 ` [PATCH 10/10] gpio: ws16c48: " William Breathitt Gray 2016-04-11 6:59 ` [PATCH 00/10] Use the ISA bus driver for PC/104 and ISA devices Linus Walleij [not found] ` <cover.1460040201.git.vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2016-05-01 21:26 ` Greg KH 2016-05-01 21:26 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160408150922.GA28058@sophia \ --to=vilhelm.gray-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \ --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \ --cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \ --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \ --cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \ --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \ --cc=wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.