From: Rob Herring <robh@kernel.org> To: Marcin Niestroj <m.niestroj@grinn-global.com> Cc: rtc-linux@googlegroups.com, devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, Keerthy <j-keerthy@ti.com>, Tony Lindgren <tony@atomide.com> Subject: [rtc-linux] Re: [PATCH v2] rtc: omap: Support ext_wakeup configuration Date: Mon, 11 Apr 2016 08:57:53 -0500 [thread overview] Message-ID: <20160411135753.GA29858@rob-hp-laptop> (raw) In-Reply-To: <1459960367-29399-2-git-send-email-m.niestroj@grinn-global.com> On Wed, Apr 06, 2016 at 06:32:47PM +0200, Marcin Niestroj wrote: > Support configuration of ext_wakeup sources. This patch makes it > possible to enable ext_wakeup (and set it's polarity), depending on > board configuration. AM335x's dedicated PMIC (tps65217) uses ext_wakeup > in SLEEP mode (RTC-only) to notify about power-button presses. Handling > power-button presses enables to recover from RTC-only power states > correctly. > > Implementation uses gpiochip to utilize standard bindings. However, > configuration is possible only using device-tree (no runtime changes). > > Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com> > --- Why are you doing a cover letter for a single patch. Put any commentary and version history here instead. > Documentation/devicetree/bindings/rtc/rtc-omap.txt | 18 ++- > drivers/rtc/Kconfig | 2 +- > drivers/rtc/rtc-omap.c | 137 ++++++++++++++++++++- > 3 files changed, 154 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/rtc-omap.txt b/Documentation/devicetree/bindings/rtc/rtc-omap.txt > index bf7d11a..4a7738e 100644 > --- a/Documentation/devicetree/bindings/rtc/rtc-omap.txt > +++ b/Documentation/devicetree/bindings/rtc/rtc-omap.txt > @@ -18,8 +18,12 @@ Optional properties: > through pmic_power_en > - clocks: Any internal or external clocks feeding in to rtc > - clock-names: Corresponding names of the clocks > +- gpio-controller: Mark as gpio controller when using ext_wakeup > +- #gpio-cells: Should be set to 2 > +- ngpios: Number of ext_wakeup sources supported by processor (board) This is not how this property is intended to be used. > +- ext-wakeup-gpios: List of ext_wakeup sources to configure This doesn't belong here. It should be in the PMIC node if that is where it is attached. Rob -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Marcin Niestroj <m.niestroj-z3quKL4iOrmQ6ZAhV5LmOA@public.gmane.org> Cc: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>, Alessandro Zummo <a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>, Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Subject: Re: [PATCH v2] rtc: omap: Support ext_wakeup configuration Date: Mon, 11 Apr 2016 08:57:53 -0500 [thread overview] Message-ID: <20160411135753.GA29858@rob-hp-laptop> (raw) In-Reply-To: <1459960367-29399-2-git-send-email-m.niestroj-z3quKL4iOrmQ6ZAhV5LmOA@public.gmane.org> On Wed, Apr 06, 2016 at 06:32:47PM +0200, Marcin Niestroj wrote: > Support configuration of ext_wakeup sources. This patch makes it > possible to enable ext_wakeup (and set it's polarity), depending on > board configuration. AM335x's dedicated PMIC (tps65217) uses ext_wakeup > in SLEEP mode (RTC-only) to notify about power-button presses. Handling > power-button presses enables to recover from RTC-only power states > correctly. > > Implementation uses gpiochip to utilize standard bindings. However, > configuration is possible only using device-tree (no runtime changes). > > Signed-off-by: Marcin Niestroj <m.niestroj-z3quKL4iOrmQ6ZAhV5LmOA@public.gmane.org> > --- Why are you doing a cover letter for a single patch. Put any commentary and version history here instead. > Documentation/devicetree/bindings/rtc/rtc-omap.txt | 18 ++- > drivers/rtc/Kconfig | 2 +- > drivers/rtc/rtc-omap.c | 137 ++++++++++++++++++++- > 3 files changed, 154 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/rtc-omap.txt b/Documentation/devicetree/bindings/rtc/rtc-omap.txt > index bf7d11a..4a7738e 100644 > --- a/Documentation/devicetree/bindings/rtc/rtc-omap.txt > +++ b/Documentation/devicetree/bindings/rtc/rtc-omap.txt > @@ -18,8 +18,12 @@ Optional properties: > through pmic_power_en > - clocks: Any internal or external clocks feeding in to rtc > - clock-names: Corresponding names of the clocks > +- gpio-controller: Mark as gpio controller when using ext_wakeup > +- #gpio-cells: Should be set to 2 > +- ngpios: Number of ext_wakeup sources supported by processor (board) This is not how this property is intended to be used. > +- ext-wakeup-gpios: List of ext_wakeup sources to configure This doesn't belong here. It should be in the PMIC node if that is where it is attached. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-11 13:57 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-06 16:32 [rtc-linux] [PATCH v2] rtc: omap: Support ext_wakeup configuration Marcin Niestroj 2016-04-06 16:32 ` Marcin Niestroj 2016-04-06 16:32 ` [rtc-linux] " Marcin Niestroj 2016-04-06 16:32 ` Marcin Niestroj 2016-04-06 19:11 ` [rtc-linux] " Tony Lindgren 2016-04-06 19:11 ` Tony Lindgren 2016-04-06 19:28 ` [rtc-linux] " Marcin Niestroj 2016-04-06 19:28 ` Marcin Niestroj 2016-04-06 22:36 ` [rtc-linux] " Tony Lindgren 2016-04-06 22:36 ` Tony Lindgren 2016-04-07 10:48 ` Grygorii Strashko 2016-04-07 10:48 ` [rtc-linux] " Grygorii Strashko [not found] ` <57063B1A.7080700-l0cyMroinI0@public.gmane.org> 2016-04-07 17:11 ` Marcin Niestroj 2016-04-07 17:11 ` [rtc-linux] " Marcin Niestroj [not found] ` <570694B0.4040500-z3quKL4iOrmQ6ZAhV5LmOA@public.gmane.org> 2016-04-08 9:18 ` Grygorii Strashko 2016-04-08 9:18 ` [rtc-linux] " Grygorii Strashko [not found] ` <57077769.1050101-l0cyMroinI0@public.gmane.org> 2016-04-08 10:08 ` Marcin Niestroj 2016-04-08 10:08 ` [rtc-linux] " Marcin Niestroj 2016-04-08 10:42 ` Grygorii Strashko 2016-04-08 10:42 ` [rtc-linux] " Grygorii Strashko 2016-04-08 14:57 ` Tony Lindgren 2016-04-08 14:57 ` [rtc-linux] " Tony Lindgren 2016-04-06 22:09 ` Alexandre Belloni 2016-04-06 22:09 ` Alexandre Belloni 2016-04-06 22:35 ` [rtc-linux] " Tony Lindgren 2016-04-06 22:35 ` Tony Lindgren 2016-04-11 13:57 ` Rob Herring [this message] 2016-04-11 13:57 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160411135753.GA29858@rob-hp-laptop \ --to=robh@kernel.org \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@free-electrons.com \ --cc=devicetree@vger.kernel.org \ --cc=j-keerthy@ti.com \ --cc=m.niestroj@grinn-global.com \ --cc=pawel.moll@arm.com \ --cc=rtc-linux@googlegroups.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.