From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> To: Minchan Kim <minchan@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jlayton@poochiereds.net, bfields@fieldses.org, Vlastimil Babka <vbabka@suse.cz>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, koct9i@gmail.com, aquini@redhat.com, virtualization@lists.linux-foundation.org, Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Rik van Riel <riel@redhat.com>, rknize@motorola.com, Gioh Kim <gi-oh.kim@profitbricks.com>, Sangseok Lee <sangseok.lee@lge.com>, Chan Gyun Jeong <chan.jeong@lge.com>, Al Viro <viro@ZenIV.linux.org.uk>, YiPing Xu <xuyiping@hisilicon.com> Subject: Re: [PATCH v3 06/16] zsmalloc: squeeze inuse into page->mapping Date: Mon, 18 Apr 2016 00:08:04 +0900 [thread overview] Message-ID: <20160417150804.GA575@swordfish> (raw) In-Reply-To: <1459321935-3655-7-git-send-email-minchan@kernel.org> Hello, On (03/30/16 16:12), Minchan Kim wrote: [..] > +static int get_zspage_inuse(struct page *first_page) > +{ > + struct zs_meta *m; > + > + VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); > + > + m = (struct zs_meta *)&first_page->mapping; .. > +static void set_zspage_inuse(struct page *first_page, int val) > +{ > + struct zs_meta *m; > + > + VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); > + > + m = (struct zs_meta *)&first_page->mapping; .. > +static void mod_zspage_inuse(struct page *first_page, int val) > +{ > + struct zs_meta *m; > + > + VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); > + > + m = (struct zs_meta *)&first_page->mapping; .. > static void get_zspage_mapping(struct page *first_page, > unsigned int *class_idx, > enum fullness_group *fullness) > { > - unsigned long m; > + struct zs_meta *m; > + > VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); > + m = (struct zs_meta *)&first_page->mapping; .. > static void set_zspage_mapping(struct page *first_page, > unsigned int class_idx, > enum fullness_group fullness) > { > + struct zs_meta *m; > + > VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); > > + m = (struct zs_meta *)&first_page->mapping; > + m->fullness = fullness; > + m->class = class_idx; > } a nitpick: this struct zs_meta *m; VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); m = (struct zs_meta *)&first_page->mapping; seems to be common in several places, may be it makes sense to factor it out and turn into a macro or a static inline helper? other than that, looks good to me Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> -ss
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> To: Minchan Kim <minchan@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jlayton@poochiereds.net, bfields@fieldses.org, Vlastimil Babka <vbabka@suse.cz>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, koct9i@gmail.com, aquini@redhat.com, virtualization@lists.linux-foundation.org, Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Rik van Riel <riel@redhat.com>, rknize@motorola.com, Gioh Kim <gi-oh.kim@profitbricks.com>, Sangseok Lee <sangseok.lee@lge.com>, Chan Gyun Jeong <chan.jeong@lge.com>, Al Viro <viro@ZenIV.linux.org.uk>, YiPing Xu <xuyiping@hisilicon.com> Subject: Re: [PATCH v3 06/16] zsmalloc: squeeze inuse into page->mapping Date: Mon, 18 Apr 2016 00:08:04 +0900 [thread overview] Message-ID: <20160417150804.GA575@swordfish> (raw) In-Reply-To: <1459321935-3655-7-git-send-email-minchan@kernel.org> Hello, On (03/30/16 16:12), Minchan Kim wrote: [..] > +static int get_zspage_inuse(struct page *first_page) > +{ > + struct zs_meta *m; > + > + VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); > + > + m = (struct zs_meta *)&first_page->mapping; .. > +static void set_zspage_inuse(struct page *first_page, int val) > +{ > + struct zs_meta *m; > + > + VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); > + > + m = (struct zs_meta *)&first_page->mapping; .. > +static void mod_zspage_inuse(struct page *first_page, int val) > +{ > + struct zs_meta *m; > + > + VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); > + > + m = (struct zs_meta *)&first_page->mapping; .. > static void get_zspage_mapping(struct page *first_page, > unsigned int *class_idx, > enum fullness_group *fullness) > { > - unsigned long m; > + struct zs_meta *m; > + > VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); > + m = (struct zs_meta *)&first_page->mapping; .. > static void set_zspage_mapping(struct page *first_page, > unsigned int class_idx, > enum fullness_group fullness) > { > + struct zs_meta *m; > + > VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); > > + m = (struct zs_meta *)&first_page->mapping; > + m->fullness = fullness; > + m->class = class_idx; > } a nitpick: this struct zs_meta *m; VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); m = (struct zs_meta *)&first_page->mapping; seems to be common in several places, may be it makes sense to factor it out and turn into a macro or a static inline helper? other than that, looks good to me Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-04-17 14:10 UTC|newest] Thread overview: 185+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-30 7:11 [PATCH v3 00/16] Support non-lru page migration Minchan Kim 2016-03-30 7:11 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 01/16] mm: use put_page to free page instead of putback_lru_page Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-01 12:58 ` Vlastimil Babka 2016-04-01 12:58 ` Vlastimil Babka 2016-04-01 12:58 ` Vlastimil Babka 2016-04-04 1:39 ` Minchan Kim 2016-04-04 1:39 ` Minchan Kim 2016-04-04 1:39 ` Minchan Kim 2016-04-04 4:45 ` Naoya Horiguchi 2016-04-04 4:45 ` Naoya Horiguchi 2016-04-04 14:46 ` Vlastimil Babka 2016-04-04 14:46 ` Vlastimil Babka 2016-04-04 14:46 ` Vlastimil Babka 2016-04-05 1:54 ` Naoya Horiguchi 2016-04-05 1:54 ` Naoya Horiguchi 2016-04-05 1:54 ` Naoya Horiguchi 2016-04-05 8:20 ` Vlastimil Babka 2016-04-05 8:20 ` Vlastimil Babka 2016-04-05 8:20 ` Vlastimil Babka 2016-04-06 0:54 ` Naoya Horiguchi 2016-04-06 0:54 ` Naoya Horiguchi 2016-04-06 0:54 ` Naoya Horiguchi 2016-04-06 7:57 ` Vlastimil Babka 2016-04-06 7:57 ` Vlastimil Babka 2016-04-06 7:57 ` Vlastimil Babka 2016-04-04 4:45 ` Naoya Horiguchi 2016-04-04 5:53 ` Balbir Singh 2016-04-04 5:53 ` Balbir Singh 2016-04-04 5:53 ` Balbir Singh 2016-04-04 6:01 ` Minchan Kim 2016-04-04 6:01 ` Minchan Kim 2016-04-04 6:01 ` Minchan Kim 2016-04-05 3:10 ` Balbir Singh 2016-04-05 3:10 ` Balbir Singh 2016-04-05 3:10 ` Balbir Singh 2016-03-30 7:12 ` [PATCH v3 02/16] mm/compaction: support non-lru movable page migration Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-01 21:29 ` Vlastimil Babka 2016-04-01 21:29 ` Vlastimil Babka 2016-04-04 5:12 ` Minchan Kim 2016-04-04 5:12 ` Minchan Kim 2016-04-04 13:24 ` Vlastimil Babka 2016-04-04 13:24 ` Vlastimil Babka 2016-04-04 13:24 ` Vlastimil Babka 2016-04-07 2:35 ` Minchan Kim 2016-04-07 2:35 ` Minchan Kim 2016-04-07 2:35 ` Minchan Kim 2016-04-04 13:24 ` Vlastimil Babka 2016-04-04 5:12 ` Minchan Kim 2016-04-01 21:29 ` Vlastimil Babka 2016-04-12 8:00 ` Chulmin Kim 2016-04-12 8:00 ` Chulmin Kim 2016-04-12 14:25 ` Minchan Kim 2016-04-12 14:25 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 03/16] mm: add non-lru movable page support document Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-01 14:38 ` Vlastimil Babka 2016-04-01 14:38 ` Vlastimil Babka 2016-04-01 14:38 ` Vlastimil Babka 2016-04-04 2:25 ` Minchan Kim 2016-04-04 2:25 ` Minchan Kim 2016-04-04 2:25 ` Minchan Kim 2016-04-04 13:09 ` Vlastimil Babka 2016-04-04 13:09 ` Vlastimil Babka 2016-04-04 13:09 ` Vlastimil Babka 2016-04-07 2:27 ` Minchan Kim 2016-04-07 2:27 ` Minchan Kim 2016-04-07 2:27 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 04/16] mm/balloon: use general movable page feature into balloon Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-05 12:03 ` Vlastimil Babka 2016-04-05 12:03 ` Vlastimil Babka 2016-04-05 12:03 ` Vlastimil Babka 2016-04-11 4:29 ` Minchan Kim 2016-04-11 4:29 ` Minchan Kim 2016-04-11 4:29 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 05/16] zsmalloc: keep max_object in size_class Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-17 15:08 ` Sergey Senozhatsky 2016-04-17 15:08 ` Sergey Senozhatsky 2016-04-17 15:08 ` Sergey Senozhatsky 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 06/16] zsmalloc: squeeze inuse into page->mapping Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-17 15:08 ` Sergey Senozhatsky 2016-04-17 15:08 ` Sergey Senozhatsky [this message] 2016-04-17 15:08 ` Sergey Senozhatsky 2016-04-19 7:40 ` Minchan Kim 2016-04-19 7:40 ` Minchan Kim 2016-04-19 7:40 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 07/16] zsmalloc: remove page_mapcount_reset Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-17 15:11 ` Sergey Senozhatsky 2016-04-17 15:11 ` Sergey Senozhatsky 2016-04-17 15:11 ` Sergey Senozhatsky 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 08/16] zsmalloc: squeeze freelist into page->mapping Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-17 15:56 ` Sergey Senozhatsky 2016-04-17 15:56 ` Sergey Senozhatsky 2016-04-17 15:56 ` Sergey Senozhatsky 2016-04-19 7:42 ` Minchan Kim 2016-04-19 7:42 ` Minchan Kim 2016-04-19 7:42 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 09/16] zsmalloc: move struct zs_meta from mapping to freelist Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-17 15:22 ` Sergey Senozhatsky 2016-04-17 15:22 ` Sergey Senozhatsky 2016-04-17 15:22 ` Sergey Senozhatsky 2016-03-30 7:12 ` [PATCH v3 10/16] zsmalloc: factor page chain functionality out Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-18 0:33 ` Sergey Senozhatsky 2016-04-18 0:33 ` Sergey Senozhatsky 2016-04-19 7:46 ` Minchan Kim 2016-04-19 7:46 ` Minchan Kim 2016-04-19 7:46 ` Minchan Kim 2016-04-18 0:33 ` Sergey Senozhatsky 2016-03-30 7:12 ` [PATCH v3 11/16] zsmalloc: separate free_zspage from putback_zspage Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-18 1:04 ` Sergey Senozhatsky 2016-04-18 1:04 ` Sergey Senozhatsky 2016-04-19 7:51 ` Minchan Kim 2016-04-19 7:51 ` Minchan Kim 2016-04-19 7:53 ` Sergey Senozhatsky 2016-04-19 7:53 ` Sergey Senozhatsky 2016-04-19 7:53 ` Sergey Senozhatsky 2016-04-19 7:51 ` Minchan Kim 2016-04-18 1:04 ` Sergey Senozhatsky 2016-03-30 7:12 ` [PATCH v3 12/16] zsmalloc: zs_compact refactoring Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-04 8:04 ` Chulmin Kim 2016-04-04 8:04 ` Chulmin Kim 2016-04-04 9:01 ` Minchan Kim 2016-04-04 9:01 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 13/16] zsmalloc: migrate head page of zspage Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-06 13:01 ` Chulmin Kim 2016-04-06 13:01 ` Chulmin Kim 2016-04-07 0:34 ` Chulmin Kim 2016-04-07 0:34 ` Chulmin Kim 2016-04-07 0:43 ` Minchan Kim 2016-04-07 0:43 ` Minchan Kim 2016-04-19 6:08 ` Chulmin Kim 2016-04-19 6:08 ` Chulmin Kim 2016-04-19 6:15 ` Minchan Kim 2016-04-19 6:15 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 14/16] zsmalloc: use single linked list for page chain Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 15/16] zsmalloc: migrate tail pages in zspage Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 16/16] zram: use __GFP_MOVABLE for memory allocation Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 23:11 ` [PATCH v3 00/16] Support non-lru page migration Andrew Morton 2016-03-30 23:11 ` Andrew Morton 2016-03-30 23:11 ` Andrew Morton 2016-03-31 0:29 ` Sergey Senozhatsky 2016-03-31 0:29 ` Sergey Senozhatsky 2016-03-31 0:29 ` Sergey Senozhatsky 2016-03-31 0:57 ` Minchan Kim 2016-03-31 0:57 ` Minchan Kim 2016-03-31 0:57 ` Minchan Kim 2016-03-31 0:57 ` Minchan Kim 2016-03-31 0:57 ` Minchan Kim 2016-03-31 0:57 ` Minchan Kim 2016-04-04 13:17 ` John Einar Reitan 2016-04-04 13:17 ` John Einar Reitan 2016-04-11 4:35 ` Minchan Kim 2016-04-11 4:35 ` Minchan Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160417150804.GA575@swordfish \ --to=sergey.senozhatsky@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=aquini@redhat.com \ --cc=bfields@fieldses.org \ --cc=chan.jeong@lge.com \ --cc=gi-oh.kim@profitbricks.com \ --cc=hughd@google.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=jlayton@poochiereds.net \ --cc=koct9i@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=minchan@kernel.org \ --cc=riel@redhat.com \ --cc=rknize@motorola.com \ --cc=sangseok.lee@lge.com \ --cc=vbabka@suse.cz \ --cc=viro@ZenIV.linux.org.uk \ --cc=virtualization@lists.linux-foundation.org \ --cc=xuyiping@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.