All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Sergey Fedorov <sergey.fedorov@linaro.org>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Sergey Fedorov" <serge.fdrv@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Alexander Graf" <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling
Date: Mon, 18 Apr 2016 17:34:09 +0200	[thread overview]
Message-ID: <20160418173409.44564649.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20160418165116.4a27b947.cornelia.huck@de.ibm.com>

On Mon, 18 Apr 2016 16:51:16 +0200
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:

> On Thu,  7 Apr 2016 18:53:44 +0300
> Sergey Fedorov <sergey.fedorov@linaro.org> wrote:
> 
> > From: Sergey Fedorov <serge.fdrv@gmail.com>
> > 
> > Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> > Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
> > ---
> >  pc-bios/s390-ccw/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
> > index 4208cb429593..5ce6d4ccbaf5 100644
> > --- a/pc-bios/s390-ccw/Makefile
> > +++ b/pc-bios/s390-ccw/Makefile
> > @@ -20,7 +20,7 @@ s390-ccw.elf: $(OBJECTS)
> >  	$(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"  Building $(TARGET_DIR)$@")
> > 
> >  s390-ccw.img: s390-ccw.elf
> > -	$(call quiet-command,strip --strip-unneeded $< -o $@,"  Stripping $(TARGET_DIR)$@")
> > +	$(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"  Stripping $(TARGET_DIR)$@")
> > 
> >  $(OBJECTS): Makefile
> > 
> 
> Thanks, applied to s390-next.

Uhm, scratch that.

This fails to build with --disable-strip, as $STRIP is unset in that
case:

  Building s390-ccw/s390-ccw.elf
  Stripping s390-ccw/s390-ccw.img
/bin/sh: --strip-unneeded: command not found
make[1]: *** [s390-ccw.img] Error 127


The catch is that we always want to strip that binary. Care to send a
patch that deals with that?

  reply	other threads:[~2016-04-18 15:34 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 15:53 [Qemu-devel] [PATCH 00/11] tcg: Make direct jump patching thread-safe Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 01/11] tci: Fix build regression Sergey Fedorov
2016-04-07 18:15   ` Richard Henderson
2016-04-07 19:16     ` Stefan Weil
2016-04-07 20:37       ` Stefan Weil
2016-04-08  3:40         ` Richard Henderson
2016-04-07 15:53 ` [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling Sergey Fedorov
2016-04-07 16:18   ` Cornelia Huck
2016-04-07 16:22     ` Sergey Fedorov
2016-04-18 13:15     ` Sergey Fedorov
2016-04-18 14:51   ` Cornelia Huck
2016-04-18 15:34     ` Cornelia Huck [this message]
2016-04-18 15:47       ` Sergey Fedorov
2016-04-21 17:36         ` Sergey Fedorov
2016-04-21 17:49           ` Alex Bennée
2016-04-21 18:56             ` Sergey Fedorov
2016-04-22  8:08           ` Cornelia Huck
2016-05-09 12:49             ` Paolo Bonzini
2016-05-10 10:47               ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 03/11] tci: Make direct jump patching thread-safe Sergey Fedorov
2016-04-20  9:42   ` Alex Bennée
2016-04-20 11:40     ` Sergey Fedorov
2016-04-20 13:14       ` Alex Bennée
2016-04-22 11:31         ` Sergey Fedorov
2016-04-22 12:49           ` Alex Bennée
2016-04-07 15:53 ` [Qemu-devel] [PATCH 04/11] tcg/ppc: " Sergey Fedorov
2016-04-20  9:49   ` Alex Bennée
2016-04-07 15:53 ` [Qemu-devel] [PATCH 05/11] tcg/i386: " Sergey Fedorov
2016-04-20  9:55   ` Alex Bennée
2016-04-20 11:43     ` Sergey Fedorov
2016-04-20 15:04     ` Richard Henderson
2016-04-20 16:15       ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 06/11] tcg/s390: " Sergey Fedorov
2016-04-20 10:01   ` Alex Bennée
2016-04-20 11:45     ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 07/11] tcg/arm: " Sergey Fedorov
2016-04-20 13:33   ` Alex Bennée
2016-04-20 14:29     ` Sergey Fedorov
2016-04-20 14:40       ` Alex Bennée
2016-04-20 16:12         ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 08/11] tcg/aarch64: " Sergey Fedorov
2016-04-20 14:01   ` Alex Bennée
2016-04-20 15:08     ` Richard Henderson
2016-04-20 18:22       ` Alex Bennée
2016-04-20 18:57         ` Richard Henderson
2016-04-20 19:51           ` Alex Bennée
2016-04-20 18:44       ` Sergey Fedorov
2016-04-21 15:47   ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 09/11] tcg/sparc: " Sergey Fedorov
2016-04-20 14:23   ` Alex Bennée
2016-04-07 15:53 ` [Qemu-devel] [PATCH 10/11] tcg/mips: " Sergey Fedorov
2016-04-07 16:01   ` Paolo Bonzini
2016-04-07 16:09     ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 11/11] tcg: Note requirement on atomic direct jump patching Sergey Fedorov
2016-04-20 14:25   ` Alex Bennée
2016-04-07 15:56 ` [Qemu-devel] [PATCH 00/11] tcg: Make direct jump patching thread-safe Sergey Fedorov
2016-04-20  8:44 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160418173409.44564649.cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=alex.bennee@linaro.org \
    --cc=borntraeger@de.ibm.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=serge.fdrv@gmail.com \
    --cc=sergey.fedorov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.