All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Richard Henderson <rth@twiddle.net>,
	Sergey Fedorov <sergey.fedorov@linaro.org>,
	qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Sergey Fedorov" <serge.fdrv@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 01/11] tci: Fix build regression
Date: Thu, 7 Apr 2016 21:16:22 +0200	[thread overview]
Message-ID: <5706B206.904@weilnetz.de> (raw)
In-Reply-To: <5706A3C6.7030707@twiddle.net>

Am 07.04.2016 um 20:15 schrieb Richard Henderson:
> On 04/07/2016 08:53 AM, Sergey Fedorov wrote:
>> +/* Enable TCI assertions only when debugging TCG (and without NDEBUG
>> defined).
>> + * Without assertions, the interpreter runs much faster. */
>> +#if defined(CONFIG_DEBUG_TCG)
>> +# define tci_assert(cond) assert(cond)
>> +#else
>> +# define tci_assert(cond) ((void)0)
>>   #endif
>>
> 
> Please just use tcg_debug_assert.
> 
> 
> r~


Hi Richard,

that's a good suggestion, but maybe a little late for 2.6-rc2.
I already sent a pull request an hour ago after Michael had added
his tested-by.

My first priority is fixing the build regression in 2.6. I can
try to prepare a new patch, wait for reviews and send a pull
request, but I am afraid this might not be finished in time
for 2.6.

Regards
Stefan

  reply	other threads:[~2016-04-07 19:16 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 15:53 [Qemu-devel] [PATCH 00/11] tcg: Make direct jump patching thread-safe Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 01/11] tci: Fix build regression Sergey Fedorov
2016-04-07 18:15   ` Richard Henderson
2016-04-07 19:16     ` Stefan Weil [this message]
2016-04-07 20:37       ` Stefan Weil
2016-04-08  3:40         ` Richard Henderson
2016-04-07 15:53 ` [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling Sergey Fedorov
2016-04-07 16:18   ` Cornelia Huck
2016-04-07 16:22     ` Sergey Fedorov
2016-04-18 13:15     ` Sergey Fedorov
2016-04-18 14:51   ` Cornelia Huck
2016-04-18 15:34     ` Cornelia Huck
2016-04-18 15:47       ` Sergey Fedorov
2016-04-21 17:36         ` Sergey Fedorov
2016-04-21 17:49           ` Alex Bennée
2016-04-21 18:56             ` Sergey Fedorov
2016-04-22  8:08           ` Cornelia Huck
2016-05-09 12:49             ` Paolo Bonzini
2016-05-10 10:47               ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 03/11] tci: Make direct jump patching thread-safe Sergey Fedorov
2016-04-20  9:42   ` Alex Bennée
2016-04-20 11:40     ` Sergey Fedorov
2016-04-20 13:14       ` Alex Bennée
2016-04-22 11:31         ` Sergey Fedorov
2016-04-22 12:49           ` Alex Bennée
2016-04-07 15:53 ` [Qemu-devel] [PATCH 04/11] tcg/ppc: " Sergey Fedorov
2016-04-20  9:49   ` Alex Bennée
2016-04-07 15:53 ` [Qemu-devel] [PATCH 05/11] tcg/i386: " Sergey Fedorov
2016-04-20  9:55   ` Alex Bennée
2016-04-20 11:43     ` Sergey Fedorov
2016-04-20 15:04     ` Richard Henderson
2016-04-20 16:15       ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 06/11] tcg/s390: " Sergey Fedorov
2016-04-20 10:01   ` Alex Bennée
2016-04-20 11:45     ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 07/11] tcg/arm: " Sergey Fedorov
2016-04-20 13:33   ` Alex Bennée
2016-04-20 14:29     ` Sergey Fedorov
2016-04-20 14:40       ` Alex Bennée
2016-04-20 16:12         ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 08/11] tcg/aarch64: " Sergey Fedorov
2016-04-20 14:01   ` Alex Bennée
2016-04-20 15:08     ` Richard Henderson
2016-04-20 18:22       ` Alex Bennée
2016-04-20 18:57         ` Richard Henderson
2016-04-20 19:51           ` Alex Bennée
2016-04-20 18:44       ` Sergey Fedorov
2016-04-21 15:47   ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 09/11] tcg/sparc: " Sergey Fedorov
2016-04-20 14:23   ` Alex Bennée
2016-04-07 15:53 ` [Qemu-devel] [PATCH 10/11] tcg/mips: " Sergey Fedorov
2016-04-07 16:01   ` Paolo Bonzini
2016-04-07 16:09     ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 11/11] tcg: Note requirement on atomic direct jump patching Sergey Fedorov
2016-04-20 14:25   ` Alex Bennée
2016-04-07 15:56 ` [Qemu-devel] [PATCH 00/11] tcg: Make direct jump patching thread-safe Sergey Fedorov
2016-04-20  8:44 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5706B206.904@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=alex.bennee@linaro.org \
    --cc=crosthwaite.peter@gmail.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=serge.fdrv@gmail.com \
    --cc=sergey.fedorov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.