All of lore.kernel.org
 help / color / mirror / Atom feed
From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/memory-failure: fix race with compound page split/merge
Date: Mon, 18 Apr 2016 23:15:52 +0000	[thread overview]
Message-ID: <20160418231551.GA18493@hori1.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <146097982568.15733.13924990169211134049.stgit@buzz>

# CCed Andrew,

On Mon, Apr 18, 2016 at 02:43:45PM +0300, Konstantin Khlebnikov wrote:
> Get_hwpoison_page() must recheck relation between head and tail pages.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>

Looks good to me. Without this recheck, the race causes kernel to pin
an irrelevant page, and finally makes kernel crash for refcount mismcach...

Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

> ---
>  mm/memory-failure.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 78f5f2641b91..ca5acee53b7a 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -888,7 +888,15 @@ int get_hwpoison_page(struct page *page)
>  		}
>  	}
>  
> -	return get_page_unless_zero(head);
> +	if (get_page_unless_zero(head)) {
> +		if (head == compound_head(page))
> +			return 1;
> +
> +		pr_info("MCE: %#lx cannot catch tail\n", page_to_pfn(page));

Recently Chen Yucong replaced the label "MCE:" with "Memory failure:",
but the resolution is trivial, I think.

Thanks,
Naoya Horiguchi

> +		put_page(head);
> +	}
> +
> +	return 0;
>  }
>  EXPORT_SYMBOL_GPL(get_hwpoison_page);
>  
> 

WARNING: multiple messages have this Message-ID (diff)
From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/memory-failure: fix race with compound page split/merge
Date: Mon, 18 Apr 2016 23:15:52 +0000	[thread overview]
Message-ID: <20160418231551.GA18493@hori1.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <146097982568.15733.13924990169211134049.stgit@buzz>

# CCed Andrew,

On Mon, Apr 18, 2016 at 02:43:45PM +0300, Konstantin Khlebnikov wrote:
> Get_hwpoison_page() must recheck relation between head and tail pages.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>

Looks good to me. Without this recheck, the race causes kernel to pin
an irrelevant page, and finally makes kernel crash for refcount mismcach...

Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

> ---
>  mm/memory-failure.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 78f5f2641b91..ca5acee53b7a 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -888,7 +888,15 @@ int get_hwpoison_page(struct page *page)
>  		}
>  	}
>  
> -	return get_page_unless_zero(head);
> +	if (get_page_unless_zero(head)) {
> +		if (head == compound_head(page))
> +			return 1;
> +
> +		pr_info("MCE: %#lx cannot catch tail\n", page_to_pfn(page));

Recently Chen Yucong replaced the label "MCE:" with "Memory failure:",
but the resolution is trivial, I think.

Thanks,
Naoya Horiguchi

> +		put_page(head);
> +	}
> +
> +	return 0;
>  }
>  EXPORT_SYMBOL_GPL(get_hwpoison_page);
>  
> 
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-04-18 23:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18 11:43 [PATCH] mm/memory-failure: fix race with compound page split/merge Konstantin Khlebnikov
2016-04-18 11:43 ` Konstantin Khlebnikov
2016-04-18 23:15 ` Naoya Horiguchi [this message]
2016-04-18 23:15   ` Naoya Horiguchi
2016-04-19  5:54   ` Konstantin Khlebnikov
2016-04-19  5:54     ` Konstantin Khlebnikov
2016-04-21 23:44   ` Andrew Morton
2016-04-21 23:44     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160418231551.GA18493@hori1.linux.bs1.fc.nec.co.jp \
    --to=n-horiguchi@ah.jp.nec.com \
    --cc=akpm@linux-foundation.org \
    --cc=khlebnikov@yandex-team.ru \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.