* [Buildroot] [PATCH] i386: properly define BR2_ARCH for all x86 subarchitectures
@ 2016-04-21 19:52 Thomas Petazzoni
2016-04-21 20:57 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2016-04-21 19:52 UTC (permalink / raw)
To: buildroot
We were not defining BR2_ARCH for two of the x86 subarchitecture,
which means the architecture part of the GNU_TARGET_NAME tuple was
empty, leading to weird build failures.
This commit fixes that by defining the appropriate values.
Fixes bug #8861.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
arch/Config.in.x86 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/Config.in.x86 b/arch/Config.in.x86
index 4039db8..efa9567 100644
--- a/arch/Config.in.x86
+++ b/arch/Config.in.x86
@@ -226,6 +226,8 @@ config BR2_ARCH
default "i686" if BR2_x86_nocona && BR2_i386
default "i686" if BR2_x86_core2 && BR2_i386
default "i686" if BR2_x86_corei7 && BR2_i386
+ default "i686" if BR2_x86_corei7_avx && BR2_i386
+ default "i686" if BR2_x86_corei7_avx2 && BR2_i386
default "i686" if BR2_x86_atom && BR2_i386
default "i686" if BR2_x86_opteron && BR2_i386
default "i686" if BR2_x86_opteron_sse3 && BR2_i386
--
2.6.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] i386: properly define BR2_ARCH for all x86 subarchitectures
2016-04-21 19:52 [Buildroot] [PATCH] i386: properly define BR2_ARCH for all x86 subarchitectures Thomas Petazzoni
@ 2016-04-21 20:57 ` Arnout Vandecappelle
2016-04-21 21:02 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2016-04-21 20:57 UTC (permalink / raw)
To: buildroot
On 04/21/16 21:52, Thomas Petazzoni wrote:
> We were not defining BR2_ARCH for two of the x86 subarchitecture,
> which means the architecture part of the GNU_TARGET_NAME tuple was
> empty, leading to weird build failures.
>
> This commit fixes that by defining the appropriate values.
>
> Fixes bug #8861.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
It would be nice if we would have a way to check something like that...
Regards,
Arnout
> ---
> arch/Config.in.x86 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/Config.in.x86 b/arch/Config.in.x86
> index 4039db8..efa9567 100644
> --- a/arch/Config.in.x86
> +++ b/arch/Config.in.x86
> @@ -226,6 +226,8 @@ config BR2_ARCH
> default "i686" if BR2_x86_nocona && BR2_i386
> default "i686" if BR2_x86_core2 && BR2_i386
> default "i686" if BR2_x86_corei7 && BR2_i386
> + default "i686" if BR2_x86_corei7_avx && BR2_i386
> + default "i686" if BR2_x86_corei7_avx2 && BR2_i386
> default "i686" if BR2_x86_atom && BR2_i386
> default "i686" if BR2_x86_opteron && BR2_i386
> default "i686" if BR2_x86_opteron_sse3 && BR2_i386
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] i386: properly define BR2_ARCH for all x86 subarchitectures
2016-04-21 20:57 ` Arnout Vandecappelle
@ 2016-04-21 21:02 ` Thomas Petazzoni
2016-04-21 23:05 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2016-04-21 21:02 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 21 Apr 2016 22:57:21 +0200, Arnout Vandecappelle wrote:
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Thanks!
> It would be nice if we would have a way to check something like that...
ifeq ($(call qstrip,$(BR2_ARCH)),)
$(error Blurp!)
endif
?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] i386: properly define BR2_ARCH for all x86 subarchitectures
2016-04-21 21:02 ` Thomas Petazzoni
@ 2016-04-21 23:05 ` Arnout Vandecappelle
0 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2016-04-21 23:05 UTC (permalink / raw)
To: buildroot
On 04/21/16 23:02, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 21 Apr 2016 22:57:21 +0200, Arnout Vandecappelle wrote:
>
>> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> Thanks!
>
>> It would be nice if we would have a way to check something like that...
>
> ifeq ($(call qstrip,$(BR2_ARCH)),)
> $(error Blurp!)
> endif
I meant statically, somehow. This will only be hit by users who actually
select that arch option, not by autobuilders.
Regards,
Arnout
>
> ?
>
> Thomas
>
--
Arnout Vandecappelle arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-21 23:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-21 19:52 [Buildroot] [PATCH] i386: properly define BR2_ARCH for all x86 subarchitectures Thomas Petazzoni
2016-04-21 20:57 ` Arnout Vandecappelle
2016-04-21 21:02 ` Thomas Petazzoni
2016-04-21 23:05 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.