From: Mark Fasheh <mfasheh@suse.de>
To: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Qu Wenruo <quwenruo@cn.fujitsu.com>
Subject: Re: [PATCH] btrfs: Test that qgroup counts are valid after snapshot creation
Date: Thu, 21 Apr 2016 16:53:48 -0700 [thread overview]
Message-ID: <20160421235348.GW2187@wotan.suse.de> (raw)
In-Reply-To: <5716D1F6.6010507@jp.fujitsu.com>
Thank you for the review, comments are below.
On Wed, Apr 20, 2016 at 09:48:54AM +0900, Satoru Takeuchi wrote:
> On 2016/04/20 7:25, Mark Fasheh wrote:
> >+# Force a small leaf size to make it easier to blow out our root
> >+# subvolume tree
> >+_scratch_mkfs "--nodesize 16384"
>
> nodesize 16384 is the default value. Do you
> intend other value, for example 4096?
"future proofing" I suppose - if we up the default, the for loop below may
not create a level 1 tree.
If we force it smaller than 16K I believe that may mean we can't run this
test on some kernels with page size larger than the typical 4k.
--Mark
--
Mark Fasheh
next prev parent reply other threads:[~2016-04-21 23:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 22:25 [PATCH] btrfs: Test that qgroup counts are valid after snapshot creation Mark Fasheh
2016-04-20 0:48 ` Satoru Takeuchi
2016-04-20 0:48 ` Satoru Takeuchi
2016-04-21 23:53 ` Mark Fasheh [this message]
2016-04-22 0:26 ` Qu Wenruo
2016-04-22 0:26 ` Qu Wenruo
2016-04-22 20:47 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421235348.GW2187@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
--cc=takeuchi_satoru@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.