From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com> To: Mark Fasheh <mfasheh@suse.de>, fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: Qu Wenruo <quwenruo@cn.fujitsu.com> Subject: Re: [PATCH] btrfs: Test that qgroup counts are valid after snapshot creation Date: Wed, 20 Apr 2016 09:48:54 +0900 [thread overview] Message-ID: <5716D1F6.6010507@jp.fujitsu.com> (raw) In-Reply-To: <20160419222530.GU2187@wotan.suse.de> On 2016/04/20 7:25, Mark Fasheh wrote: > This has been broken since Linux v4.1. We may have worked out a solution on > the btrfs list but in the meantime sending a test to expose the issue seems > like a good idea. > > Signed-off-by: Mark Fasheh <mfasheh@suse.de> > --- > tests/btrfs/122 | 88 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/btrfs/group | 1 + You forgot to add tests/btrfs/122.out. > 2 files changed, 89 insertions(+) > create mode 100755 tests/btrfs/122 > > diff --git a/tests/btrfs/122 b/tests/btrfs/122 > new file mode 100755 > index 0000000..b7e9e4b > --- /dev/null > +++ b/tests/btrfs/122 > @@ -0,0 +1,88 @@ > +#! /bin/bash > +# FS QA Test No. btrfs/122 > +# > +# Test that qgroup counts are valid after snapshot creation. This has > +# been broken in btrfs since Linux v4.1 > +# > +#----------------------------------------------------------------------- > +# Copyright (C) 2016 SUSE Linux Products GmbH. All Rights Reserved. > +# > +# This program is free software; you can redistribute it and/or > +# modify it under the terms of the GNU General Public License as > +# published by the Free Software Foundation. > +# > +# This program is distributed in the hope that it would be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write the Free Software Foundation, > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > +# > +#----------------------------------------------------------------------- > +# > + > +seq=`basename $0` > +seqres=$RESULT_DIR/$seq > +echo "QA output created by $seq" > + > +here=`pwd` > +tmp=/tmp/$$ > +status=1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +_cleanup() > +{ > + cd / > + rm -f $tmp.* > +} > + > +# get standard environment, filters and checks > +. ./common/rc > +. ./common/filter > + > +# remove previous $seqres.full before test > +rm -f $seqres.full > + > +# real QA test starts here > +_supported_fs btrfs > +_supported_os Linux > +_require_scratch > + > +rm -f $seqres.full > + > +# Force a small leaf size to make it easier to blow out our root > +# subvolume tree > +_scratch_mkfs "--nodesize 16384" nodesize 16384 is the default value. Do you intend other value, for example 4096? > +_scratch_mount > +_run_btrfs_util_prog quota enable $SCRATCH_MNT > + > +mkdir "$SCRATCH_MNT/snaps" > + > +# First make some simple snapshots - the bug was initially reproduced like this > +_run_btrfs_util_prog subvolume snapshot $SCRATCH_MNT "$SCRATCH_MNT/snaps/empty1" > +_run_btrfs_util_prog subvolume snapshot $SCRATCH_MNT "$SCRATCH_MNT/snaps/empty2" > + > +# This forces the fs tree out past level 0, adding at least one tree > +# block which must be properly accounted for when we make our next > +# snapshots. > +mkdir "$SCRATCH_MNT/data" > +for i in `seq 0 640`; do > + $XFS_IO_PROG -f -c "pwrite 0 1M" "$SCRATCH_MNT/data/file$i" > /dev/null 2>&1 > +done; ";" after "done" is not necessary. Thanks, Satoru > + > +# Snapshot twice. > +_run_btrfs_util_prog subvolume snapshot $SCRATCH_MNT "$SCRATCH_MNT/snaps/snap1" > +_run_btrfs_util_prog subvolume snapshot $SCRATCH_MNT "$SCRATCH_MNT/snaps/snap2" > + > +_scratch_unmount > + > +# generate a qgroup report and look for inconsistent groups > +$BTRFS_UTIL_PROG check --qgroup-report $SCRATCH_DEV 2>&1 | \ > + grep -q -E "Counts for qgroup.*are different" > +if [ $? -ne 0 ]; then > + status=0 > +fi > + > +exit > diff --git a/tests/btrfs/group b/tests/btrfs/group > index 9403daa..f7e8cff 100644 > --- a/tests/btrfs/group > +++ b/tests/btrfs/group > @@ -122,3 +122,4 @@ > 119 auto quick snapshot metadata qgroup > 120 auto quick snapshot metadata > 121 auto quick snapshot qgroup > +122 auto quick snapshot qgroup >
WARNING: multiple messages have this Message-ID (diff)
From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com> To: Mark Fasheh <mfasheh@suse.de>, fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: Qu Wenruo <quwenruo@cn.fujitsu.com> Subject: Re: [PATCH] btrfs: Test that qgroup counts are valid after snapshot creation Date: Tue, 19 Apr 2016 17:48:54 -0700 (PDT) [thread overview] Message-ID: <5716D1F6.6010507@jp.fujitsu.com> (raw) In-Reply-To: <20160419222530.GU2187@wotan.suse.de> On 2016/04/20 7:25, Mark Fasheh wrote: > This has been broken since Linux v4.1. We may have worked out a solution on > the btrfs list but in the meantime sending a test to expose the issue seems > like a good idea. > > Signed-off-by: Mark Fasheh <mfasheh@suse.de> > --- > tests/btrfs/122 | 88 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/btrfs/group | 1 + You forgot to add tests/btrfs/122.out. > 2 files changed, 89 insertions(+) > create mode 100755 tests/btrfs/122 > > diff --git a/tests/btrfs/122 b/tests/btrfs/122 > new file mode 100755 > index 0000000..b7e9e4b > --- /dev/null > +++ b/tests/btrfs/122 > @@ -0,0 +1,88 @@ > +#! /bin/bash > +# FS QA Test No. btrfs/122 > +# > +# Test that qgroup counts are valid after snapshot creation. This has > +# been broken in btrfs since Linux v4.1 > +# > +#----------------------------------------------------------------------- > +# Copyright (C) 2016 SUSE Linux Products GmbH. All Rights Reserved. > +# > +# This program is free software; you can redistribute it and/or > +# modify it under the terms of the GNU General Public License as > +# published by the Free Software Foundation. > +# > +# This program is distributed in the hope that it would be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write the Free Software Foundation, > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > +# > +#----------------------------------------------------------------------- > +# > + > +seq=`basename $0` > +seqres=$RESULT_DIR/$seq > +echo "QA output created by $seq" > + > +here=`pwd` > +tmp=/tmp/$$ > +status=1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +_cleanup() > +{ > + cd / > + rm -f $tmp.* > +} > + > +# get standard environment, filters and checks > +. ./common/rc > +. ./common/filter > + > +# remove previous $seqres.full before test > +rm -f $seqres.full > + > +# real QA test starts here > +_supported_fs btrfs > +_supported_os Linux > +_require_scratch > + > +rm -f $seqres.full > + > +# Force a small leaf size to make it easier to blow out our root > +# subvolume tree > +_scratch_mkfs "--nodesize 16384" nodesize 16384 is the default value. Do you intend other value, for example 4096? > +_scratch_mount > +_run_btrfs_util_prog quota enable $SCRATCH_MNT > + > +mkdir "$SCRATCH_MNT/snaps" > + > +# First make some simple snapshots - the bug was initially reproduced like this > +_run_btrfs_util_prog subvolume snapshot $SCRATCH_MNT "$SCRATCH_MNT/snaps/empty1" > +_run_btrfs_util_prog subvolume snapshot $SCRATCH_MNT "$SCRATCH_MNT/snaps/empty2" > + > +# This forces the fs tree out past level 0, adding at least one tree > +# block which must be properly accounted for when we make our next > +# snapshots. > +mkdir "$SCRATCH_MNT/data" > +for i in `seq 0 640`; do > + $XFS_IO_PROG -f -c "pwrite 0 1M" "$SCRATCH_MNT/data/file$i" > /dev/null 2>&1 > +done; ";" after "done" is not necessary. Thanks, Satoru > + > +# Snapshot twice. > +_run_btrfs_util_prog subvolume snapshot $SCRATCH_MNT "$SCRATCH_MNT/snaps/snap1" > +_run_btrfs_util_prog subvolume snapshot $SCRATCH_MNT "$SCRATCH_MNT/snaps/snap2" > + > +_scratch_unmount > + > +# generate a qgroup report and look for inconsistent groups > +$BTRFS_UTIL_PROG check --qgroup-report $SCRATCH_DEV 2>&1 | \ > + grep -q -E "Counts for qgroup.*are different" > +if [ $? -ne 0 ]; then > + status=0 > +fi > + > +exit > diff --git a/tests/btrfs/group b/tests/btrfs/group > index 9403daa..f7e8cff 100644 > --- a/tests/btrfs/group > +++ b/tests/btrfs/group > @@ -122,3 +122,4 @@ > 119 auto quick snapshot metadata qgroup > 120 auto quick snapshot metadata > 121 auto quick snapshot qgroup > +122 auto quick snapshot qgroup >
next prev parent reply other threads:[~2016-04-20 0:49 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-19 22:25 [PATCH] btrfs: Test that qgroup counts are valid after snapshot creation Mark Fasheh 2016-04-20 0:48 ` Satoru Takeuchi [this message] 2016-04-20 0:48 ` Satoru Takeuchi 2016-04-21 23:53 ` Mark Fasheh 2016-04-22 0:26 ` Qu Wenruo 2016-04-22 0:26 ` Qu Wenruo 2016-04-22 20:47 ` Mark Fasheh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5716D1F6.6010507@jp.fujitsu.com \ --to=takeuchi_satoru@jp.fujitsu.com \ --cc=fstests@vger.kernel.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=mfasheh@suse.de \ --cc=quwenruo@cn.fujitsu.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.