All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Andy Gross <andy.gross@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Stephen Boyd <sboyd@codeaurora.org>,
	devicetree@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@sonymobile.com>,
	jilai wang <jilaiw@codeaurora.org>
Subject: Re: [PATCH 6/8] firmware: qcom: scm: Add memory allocation API
Date: Fri, 22 Apr 2016 16:23:31 -0700	[thread overview]
Message-ID: <20160422232331.GG3202@tuxbot> (raw)
In-Reply-To: <1461363432-5730-7-git-send-email-andy.gross@linaro.org>

On Fri 22 Apr 15:17 PDT 2016, Andy Gross wrote:

> This patch adds APIs for the scm-32 and scm-64 to use for coherent memory
> allocation.
> 
> Signed-off-by: Andy Gross <andy.gross@linaro.org>

This patch must come before the ARM64 implementation.

> ---
>  drivers/firmware/qcom_scm.c | 17 +++++++++++++++++
>  drivers/firmware/qcom_scm.h |  4 ++++
>  2 files changed, 21 insertions(+)
> 
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
[..]
> +
> +void qcom_scm_free_buffer(size_t size, void *cpu_addr,
> +				 dma_addr_t dma_addr)
> +{
> +	if (__scm)

This would be quite bad and the caller expects that the memory is
released when you return from here. This should also only happen if the
arch specific implementation is buggy, so just let it go BANG!

> +		dma_free_writecombine(__scm->dev, size, cpu_addr, dma_addr);
> +}
> +

Regards,
Bjorn

WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/8] firmware: qcom: scm: Add memory allocation API
Date: Fri, 22 Apr 2016 16:23:31 -0700	[thread overview]
Message-ID: <20160422232331.GG3202@tuxbot> (raw)
In-Reply-To: <1461363432-5730-7-git-send-email-andy.gross@linaro.org>

On Fri 22 Apr 15:17 PDT 2016, Andy Gross wrote:

> This patch adds APIs for the scm-32 and scm-64 to use for coherent memory
> allocation.
> 
> Signed-off-by: Andy Gross <andy.gross@linaro.org>

This patch must come before the ARM64 implementation.

> ---
>  drivers/firmware/qcom_scm.c | 17 +++++++++++++++++
>  drivers/firmware/qcom_scm.h |  4 ++++
>  2 files changed, 21 insertions(+)
> 
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
[..]
> +
> +void qcom_scm_free_buffer(size_t size, void *cpu_addr,
> +				 dma_addr_t dma_addr)
> +{
> +	if (__scm)

This would be quite bad and the caller expects that the memory is
released when you return from here. This should also only happen if the
arch specific implementation is buggy, so just let it go BANG!

> +		dma_free_writecombine(__scm->dev, size, cpu_addr, dma_addr);
> +}
> +

Regards,
Bjorn

  reply	other threads:[~2016-04-22 23:23 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 22:17 [PATCH 0/8] Qualcomm SCM Rework Andy Gross
2016-04-22 22:17 ` Andy Gross
2016-04-22 22:17 ` Andy Gross
2016-04-22 22:17 ` [PATCH 1/8] dt/bindings: firmware: Add Qualcomm SCM binding Andy Gross
2016-04-22 22:17   ` Andy Gross
2016-04-22 22:17   ` Andy Gross
     [not found]   ` <1461363432-5730-2-git-send-email-andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-22 23:12     ` Bjorn Andersson
2016-04-22 23:12       ` Bjorn Andersson
2016-04-22 23:12       ` Bjorn Andersson
2016-04-23  7:51   ` Stanimir Varbanov
2016-04-23  7:51     ` Stanimir Varbanov
2016-04-23 16:56   ` Rob Herring
2016-04-23 16:56     ` Rob Herring
2016-04-23 16:56     ` Rob Herring
2016-04-23 17:33     ` Andy Gross
2016-04-23 17:33       ` Andy Gross
2016-04-23 17:33       ` Andy Gross
2016-04-25 13:14       ` Rob Herring
2016-04-25 13:14         ` Rob Herring
2016-04-25 13:14         ` Rob Herring
2016-04-22 22:17 ` [PATCH 2/8] firmware: qcom: scm: Convert SCM to platform driver Andy Gross
2016-04-22 22:17   ` Andy Gross
2016-04-22 22:17   ` Andy Gross
2016-04-22 23:11   ` Bjorn Andersson
2016-04-22 23:11     ` Bjorn Andersson
2016-04-23  4:43     ` Andy Gross
2016-04-23  4:43       ` Andy Gross
2016-04-23  4:43       ` Andy Gross
2016-04-22 22:17 ` [PATCH 3/8] firmware: qcom: scm: Generalize shared error map Andy Gross
2016-04-22 22:17   ` Andy Gross
2016-04-22 22:17   ` Andy Gross
     [not found]   ` <1461363432-5730-4-git-send-email-andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-22 23:13     ` Bjorn Andersson
2016-04-22 23:13       ` Bjorn Andersson
2016-04-22 23:13       ` Bjorn Andersson
2016-04-22 22:17 ` [PATCH 4/8] firmware: qcom: scm: Add support for ARM64 SoCs Andy Gross
2016-04-22 22:17   ` Andy Gross
2016-04-22 22:17   ` Andy Gross
2016-04-22 23:41   ` Bjorn Andersson
2016-04-22 23:41     ` Bjorn Andersson
2016-04-23  4:52     ` Andy Gross
2016-04-23  4:52       ` Andy Gross
2016-04-23  4:52       ` Andy Gross
2016-04-23 14:18       ` Bjorn Andersson
2016-04-23 14:18         ` Bjorn Andersson
     [not found] ` <1461363432-5730-1-git-send-email-andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-22 22:17   ` [PATCH 5/8] firmware: qcom: scm: Use atomic SCM for cold boot Andy Gross
2016-04-22 22:17     ` Andy Gross
2016-04-22 22:17     ` Andy Gross
     [not found]     ` <1461363432-5730-6-git-send-email-andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-22 23:50       ` Bjorn Andersson
2016-04-22 23:50         ` Bjorn Andersson
2016-04-22 23:50         ` Bjorn Andersson
2016-04-23  4:46         ` Andy Gross
2016-04-23  4:46           ` Andy Gross
2016-04-23  4:46           ` Andy Gross
2016-04-22 22:17 ` [PATCH 6/8] firmware: qcom: scm: Add memory allocation API Andy Gross
2016-04-22 22:17   ` Andy Gross
2016-04-22 23:23   ` Bjorn Andersson [this message]
2016-04-22 23:23     ` Bjorn Andersson
2016-04-23  4:45     ` Andy Gross
2016-04-23  4:45       ` Andy Gross
2016-04-22 22:17 ` [PATCH 7/8] dts: qcom: apq8084: Add SCM firmware node Andy Gross
2016-04-22 22:17   ` Andy Gross
2016-04-22 23:50   ` Bjorn Andersson
2016-04-22 23:50     ` Bjorn Andersson
2016-04-22 22:17 ` [PATCH 8/8] arm64: dts: msm8916: " Andy Gross
2016-04-22 22:17   ` Andy Gross
2016-04-23  0:03   ` Bjorn Andersson
2016-04-23  0:03     ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160422232331.GG3202@tuxbot \
    --to=bjorn.andersson@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jilaiw@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.