All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] md/raid0: remove empty line printk from dump_zones
@ 2016-04-24 16:11 Michał Pecio
  2016-04-25 15:42 ` Shaohua Li
  0 siblings, 1 reply; 2+ messages in thread
From: Michał Pecio @ 2016-04-24 16:11 UTC (permalink / raw)
  To: Neil Brown; +Cc: linux-raid


Remove the final printk. All preceding output is already properly
newline-terminated and the printk isn't even KERN_CONT to begin with,
so it only adds one empty line to the log.

Signed-off-by: Michal Pecio <michal.pecio@gmail.com>
---
 drivers/md/raid0.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index f8e5db0..3e51f4d 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -70,7 +70,6 @@ static void dump_zones(struct mddev *mddev)
 			(unsigned long long)zone_size>>1);
 		zone_start = conf->strip_zone[j].zone_end;
 	}
-	printk(KERN_INFO "\n");
 }
 
 static int create_strip_zones(struct mddev *mddev, struct r0conf **private_conf)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] md/raid0: remove empty line printk from dump_zones
  2016-04-24 16:11 [PATCH] md/raid0: remove empty line printk from dump_zones Michał Pecio
@ 2016-04-25 15:42 ` Shaohua Li
  0 siblings, 0 replies; 2+ messages in thread
From: Shaohua Li @ 2016-04-25 15:42 UTC (permalink / raw)
  To: Michał Pecio; +Cc: Neil Brown, linux-raid

On Sun, Apr 24, 2016 at 06:11:45PM +0200, Michał Pecio wrote:
> 
> Remove the final printk. All preceding output is already properly
> newline-terminated and the printk isn't even KERN_CONT to begin with,
> so it only adds one empty line to the log.
> 
> Signed-off-by: Michal Pecio <michal.pecio@gmail.com>
> ---
>  drivers/md/raid0.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
> index f8e5db0..3e51f4d 100644
> --- a/drivers/md/raid0.c
> +++ b/drivers/md/raid0.c
> @@ -70,7 +70,6 @@ static void dump_zones(struct mddev *mddev)
>  			(unsigned long long)zone_size>>1);
>  		zone_start = conf->strip_zone[j].zone_end;
>  	}
> -	printk(KERN_INFO "\n");
>  }

applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-25 15:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-24 16:11 [PATCH] md/raid0: remove empty line printk from dump_zones Michał Pecio
2016-04-25 15:42 ` Shaohua Li

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.