All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Robin Murphy <robin.murphy@arm.com>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption
Date: Mon, 25 Apr 2016 17:03:25 +0100	[thread overview]
Message-ID: <20160425160324.GB24831@leverpostej> (raw)
In-Reply-To: <20160425155922.GC2829@codeblueprint.co.uk>

On Mon, Apr 25, 2016 at 04:59:22PM +0100, Matt Fleming wrote:
> On Mon, 25 Apr, at 03:27:35PM, Mark Rutland wrote:
> > 
> > I have no strong preference so long as the code is correct.
> > 
> > Another option is to get rid of the bool entirely:
> > 
> > 	flags ^= cur_flags;
> > 	if (!WARN_ON(flags & ARCH_EFI_IRQ_FLAGS_MASK))
> > 		return;
> 
> OK, let's do the following because we need flags to be preserved for
> printing,
> 
> ---
> 
> 	unsigned long cur_flags, mismatch;
> 
> 	local_save_flags(cur_flags);
> 
> 	mismatch = flags ^ cur_flags;
> 	if (!WARN_ON_ONCE(mismatch & ARCH_EFI_IRQ_FLAGS_MASK))
> 		return;
> 

Sure; that looks good to me.

Cheers,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption
Date: Mon, 25 Apr 2016 17:03:25 +0100	[thread overview]
Message-ID: <20160425160324.GB24831@leverpostej> (raw)
In-Reply-To: <20160425155922.GC2829@codeblueprint.co.uk>

On Mon, Apr 25, 2016 at 04:59:22PM +0100, Matt Fleming wrote:
> On Mon, 25 Apr, at 03:27:35PM, Mark Rutland wrote:
> > 
> > I have no strong preference so long as the code is correct.
> > 
> > Another option is to get rid of the bool entirely:
> > 
> > 	flags ^= cur_flags;
> > 	if (!WARN_ON(flags & ARCH_EFI_IRQ_FLAGS_MASK))
> > 		return;
> 
> OK, let's do the following because we need flags to be preserved for
> printing,
> 
> ---
> 
> 	unsigned long cur_flags, mismatch;
> 
> 	local_save_flags(cur_flags);
> 
> 	mismatch = flags ^ cur_flags;
> 	if (!WARN_ON_ONCE(mismatch & ARCH_EFI_IRQ_FLAGS_MASK))
> 		return;
> 

Sure; that looks good to me.

Cheers,
Mark.

  reply	other threads:[~2016-04-25 16:03 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 13:46 [PATCHv3 0/5] efi: detect erroneous firmware IRQ manipulation Mark Rutland
2016-04-25 13:46 ` Mark Rutland
2016-04-25 13:46 ` Mark Rutland
2016-04-25 13:46 ` [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption Mark Rutland
2016-04-25 13:46   ` Mark Rutland
2016-04-25 14:12   ` Robin Murphy
2016-04-25 14:12     ` Robin Murphy
2016-04-25 14:12     ` Robin Murphy
2016-04-25 14:15     ` Matt Fleming
2016-04-25 14:15       ` Matt Fleming
2016-04-25 14:18       ` Ard Biesheuvel
2016-04-25 14:18         ` Ard Biesheuvel
2016-04-25 14:18         ` Ard Biesheuvel
2016-04-25 14:24         ` Matt Fleming
2016-04-25 14:24           ` Matt Fleming
2016-04-25 14:24           ` Matt Fleming
2016-04-25 14:27           ` Mark Rutland
2016-04-25 14:27             ` Mark Rutland
2016-04-25 14:27             ` Mark Rutland
2016-04-25 15:59             ` Matt Fleming
2016-04-25 15:59               ` Matt Fleming
2016-04-25 15:59               ` Matt Fleming
2016-04-25 16:03               ` Mark Rutland [this message]
2016-04-25 16:03                 ` Mark Rutland
2016-04-25 16:03                 ` Mark Rutland
2016-04-25 14:33           ` Robin Murphy
2016-04-25 14:33             ` Robin Murphy
2016-04-25 14:33             ` Robin Murphy
2016-04-25 13:46 ` [PATCHv3 2/5] arm64/efi: enable runtime call flag checking Mark Rutland
2016-04-25 13:46   ` Mark Rutland
2016-04-25 13:46   ` Mark Rutland
2016-04-25 13:54   ` Will Deacon
2016-04-25 13:54     ` Will Deacon
2016-04-25 13:46 ` [PATCHv3 3/5] arm/efi: " Mark Rutland
2016-04-25 13:46   ` Mark Rutland
2016-04-25 13:46 ` [PATCHv3 4/5] x86/efi: " Mark Rutland
2016-04-25 13:46   ` Mark Rutland
2016-04-25 13:46 ` [PATCHv3 5/5] efi/runtime-wrappers: remove ARCH_EFI_IRQ_FLAGS_MASK ifdef Mark Rutland
2016-04-25 13:46   ` Mark Rutland
2016-04-25 16:03 ` [PATCHv3 0/5] efi: detect erroneous firmware IRQ manipulation Matt Fleming
2016-04-25 16:03   ` Matt Fleming
2016-04-25 16:03   ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160425160324.GB24831@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=hpa@zytor.com \
    --cc=leif.lindholm@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@redhat.com \
    --cc=robin.murphy@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.