All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Jan Glauber <jglauber@cavium.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
	David Daney <ddaney@caviumnetworks.com>,
	David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v7 09/15] i2c: octeon: Add workaround for broken irqs on CN3860
Date: Tue, 26 Apr 2016 23:17:59 +0200	[thread overview]
Message-ID: <20160426211759.GD4587@katana> (raw)
In-Reply-To: <1461594824-7215-10-git-send-email-jglauber@cavium.com>

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

On Mon, Apr 25, 2016 at 04:33:38PM +0200, Jan Glauber wrote:
> From: David Daney <david.daney@cavium.com>
> 
> CN3860 does not interrupt the CPU when the i2c status changes. If
> we get a timeout, and see the status has in fact changed, we know we
> have this problem, and drop back to polling.
> 
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>

My code checkers say something:

    CHECKPATCH
CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
#37: FILE: drivers/i2c/busses/i2c-octeon.c:390:
+			udelay(50);

CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
#70: FILE: drivers/i2c/busses/i2c-octeon.c:529:
+			udelay(50);

Dunno if you want to change that? Seems reasonable to me. Also:

    SMATCH
drivers/i2c/busses/i2c-octeon.c:544 octeon_i2c_hlc_wait() warn: inconsistent indenting

This is true as well.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-04-26 21:18 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 14:33 [PATCH v7 00/15] i2c-octeon and i2c-thunderx drivers Jan Glauber
2016-04-25 14:33 ` [PATCH v7 01/15] i2c: octeon: Improve error status checking Jan Glauber
2016-04-25 21:20   ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 02/15] i2c: octeon: Use i2c recovery framework Jan Glauber
2016-04-25 21:29   ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 03/15] i2c: octeon: Remove I2C_FUNC_SMBUS_QUICK support Jan Glauber
2016-04-25 22:16   ` Wolfram Sang
2016-04-25 22:28     ` David Daney
2016-04-25 22:28       ` David Daney
2016-04-26  5:58     ` Jan Glauber
2016-04-26  5:58       ` Jan Glauber
2016-04-26  6:42       ` Jan Glauber
2016-04-26  6:42         ` Jan Glauber
2016-04-26  7:36         ` Wolfram Sang
2016-04-26 12:34           ` Jan Glauber
2016-04-26 12:34             ` Jan Glauber
2016-04-26 12:53             ` Wolfram Sang
2016-04-26 14:26               ` [PATCH] i2c: octeon: Remove zero-length message support Jan Glauber
2016-04-26 21:04                 ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 04/15] i2c: octeon: Add flush writeq helper function Jan Glauber
2016-04-25 21:33   ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 05/15] i2c: octeon: Enable High-Level Controller Jan Glauber
2016-04-25 21:44   ` Wolfram Sang
2016-04-26  5:51     ` Jan Glauber
2016-04-26  5:51       ` Jan Glauber
2016-04-25 14:33 ` [PATCH v7 06/15] dt-bindings: i2c: Add Octeon cn78xx TWSI Jan Glauber
2016-04-25 21:47   ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 07/15] i2c: octeon: Add support for cn78xx chips Jan Glauber
2016-04-25 21:47   ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 08/15] i2c: octeon: Improve performance if interrupt is early Jan Glauber
2016-04-26 21:10   ` Wolfram Sang
2016-04-26 21:19     ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 09/15] i2c: octeon: Add workaround for broken irqs on CN3860 Jan Glauber
2016-04-26 21:17   ` Wolfram Sang [this message]
2016-04-27  9:37     ` Jan Glauber
2016-04-27  9:37       ` Jan Glauber
2016-04-27  9:44     ` [PATCH] " Jan Glauber
2016-04-27 16:56       ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 10/15] i2c: octeon: Move read function before write Jan Glauber
2016-04-25 14:33 ` [PATCH v7 11/15] i2c: octeon: Rename driver to prepare for split Jan Glauber
2016-04-25 14:33 ` [PATCH v7 12/15] i2c: octeon: Split the driver into two parts Jan Glauber
2016-04-25 14:33 ` [PATCH v7 13/15] i2c: thunderx: Add i2c driver for ThunderX SOC Jan Glauber
2016-04-25 14:33 ` [PATCH v7 14/15] i2c: octeon,thunderx: Move register offsets to struct Jan Glauber
2016-04-25 14:33 ` [PATCH v7 15/15] i2c: thunderx: Add smbus alert support Jan Glauber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160426211759.GD4587@katana \
    --to=wsa@the-dreams.de \
    --cc=david.daney@cavium.com \
    --cc=ddaney@caviumnetworks.com \
    --cc=jglauber@cavium.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.