From: Jan Glauber <jan.glauber@caviumnetworks.com> To: Wolfram Sang <wsa@the-dreams.de> Cc: <linux-kernel@vger.kernel.org>, <linux-i2c@vger.kernel.org>, David Daney <ddaney@caviumnetworks.com> Subject: Re: [PATCH v7 03/15] i2c: octeon: Remove I2C_FUNC_SMBUS_QUICK support Date: Tue, 26 Apr 2016 14:34:44 +0200 [thread overview] Message-ID: <20160426123444.GB9796@hardcore> (raw) In-Reply-To: <20160426073620.GA1543@katana> On Tue, Apr 26, 2016 at 09:36:20AM +0200, Wolfram Sang wrote: > > > > Yes, I thought briefly about splitting SMBUS_QUICK into read-write > > > variants too. To me the question is if this feature is still used on modern > > > devices or if this is more a relict of the past. I don't know enough > > > about SMBUS to answer that. > > Well, note that there are zero-length messages in I2C allowed as well. > Not only in SMBUS. I mainly use the term SMBUS_QUICK because it covers > both cases. > > > > Checking on ThunderX: > ... > > Do all these other numbers make sense (although there are no > > devices)? > > It makes sense in a way that it shows SMBUS_QUICK_WRITE is broken :) It > doesn't react to ACK/NACK properly. So, what needs to be done: > > 1) remove SMBUS_QUICK as you did in this patch 2) move the length check > so it doesn't only check read messages but also write messages. That is > to prevent handling custom setup I2C messages with a length of 0 (which > is legal). I'd suggest to return -EOPNOTSUPP in this case. OK, I'll do that. Should I rebase the remaining patches or would you like to review them first ? :) Thanks, Jan > Thanks, > > Wolfram >
WARNING: multiple messages have this Message-ID (diff)
From: Jan Glauber <jan.glauber@caviumnetworks.com> To: Wolfram Sang <wsa@the-dreams.de> Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, David Daney <ddaney@caviumnetworks.com> Subject: Re: [PATCH v7 03/15] i2c: octeon: Remove I2C_FUNC_SMBUS_QUICK support Date: Tue, 26 Apr 2016 14:34:44 +0200 [thread overview] Message-ID: <20160426123444.GB9796@hardcore> (raw) In-Reply-To: <20160426073620.GA1543@katana> On Tue, Apr 26, 2016 at 09:36:20AM +0200, Wolfram Sang wrote: > > > > Yes, I thought briefly about splitting SMBUS_QUICK into read-write > > > variants too. To me the question is if this feature is still used on modern > > > devices or if this is more a relict of the past. I don't know enough > > > about SMBUS to answer that. > > Well, note that there are zero-length messages in I2C allowed as well. > Not only in SMBUS. I mainly use the term SMBUS_QUICK because it covers > both cases. > > > > Checking on ThunderX: > ... > > Do all these other numbers make sense (although there are no > > devices)? > > It makes sense in a way that it shows SMBUS_QUICK_WRITE is broken :) It > doesn't react to ACK/NACK properly. So, what needs to be done: > > 1) remove SMBUS_QUICK as you did in this patch 2) move the length check > so it doesn't only check read messages but also write messages. That is > to prevent handling custom setup I2C messages with a length of 0 (which > is legal). I'd suggest to return -EOPNOTSUPP in this case. OK, I'll do that. Should I rebase the remaining patches or would you like to review them first ? :) Thanks, Jan > Thanks, > > Wolfram >
next prev parent reply other threads:[~2016-04-26 12:35 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-25 14:33 [PATCH v7 00/15] i2c-octeon and i2c-thunderx drivers Jan Glauber 2016-04-25 14:33 ` [PATCH v7 01/15] i2c: octeon: Improve error status checking Jan Glauber 2016-04-25 21:20 ` Wolfram Sang 2016-04-25 14:33 ` [PATCH v7 02/15] i2c: octeon: Use i2c recovery framework Jan Glauber 2016-04-25 21:29 ` Wolfram Sang 2016-04-25 14:33 ` [PATCH v7 03/15] i2c: octeon: Remove I2C_FUNC_SMBUS_QUICK support Jan Glauber 2016-04-25 22:16 ` Wolfram Sang 2016-04-25 22:28 ` David Daney 2016-04-25 22:28 ` David Daney 2016-04-26 5:58 ` Jan Glauber 2016-04-26 5:58 ` Jan Glauber 2016-04-26 6:42 ` Jan Glauber 2016-04-26 6:42 ` Jan Glauber 2016-04-26 7:36 ` Wolfram Sang 2016-04-26 12:34 ` Jan Glauber [this message] 2016-04-26 12:34 ` Jan Glauber 2016-04-26 12:53 ` Wolfram Sang 2016-04-26 14:26 ` [PATCH] i2c: octeon: Remove zero-length message support Jan Glauber 2016-04-26 21:04 ` Wolfram Sang 2016-04-25 14:33 ` [PATCH v7 04/15] i2c: octeon: Add flush writeq helper function Jan Glauber 2016-04-25 21:33 ` Wolfram Sang 2016-04-25 14:33 ` [PATCH v7 05/15] i2c: octeon: Enable High-Level Controller Jan Glauber 2016-04-25 21:44 ` Wolfram Sang 2016-04-26 5:51 ` Jan Glauber 2016-04-26 5:51 ` Jan Glauber 2016-04-25 14:33 ` [PATCH v7 06/15] dt-bindings: i2c: Add Octeon cn78xx TWSI Jan Glauber 2016-04-25 21:47 ` Wolfram Sang 2016-04-25 14:33 ` [PATCH v7 07/15] i2c: octeon: Add support for cn78xx chips Jan Glauber 2016-04-25 21:47 ` Wolfram Sang 2016-04-25 14:33 ` [PATCH v7 08/15] i2c: octeon: Improve performance if interrupt is early Jan Glauber 2016-04-26 21:10 ` Wolfram Sang 2016-04-26 21:19 ` Wolfram Sang 2016-04-25 14:33 ` [PATCH v7 09/15] i2c: octeon: Add workaround for broken irqs on CN3860 Jan Glauber 2016-04-26 21:17 ` Wolfram Sang 2016-04-27 9:37 ` Jan Glauber 2016-04-27 9:37 ` Jan Glauber 2016-04-27 9:44 ` [PATCH] " Jan Glauber 2016-04-27 16:56 ` Wolfram Sang 2016-04-25 14:33 ` [PATCH v7 10/15] i2c: octeon: Move read function before write Jan Glauber 2016-04-25 14:33 ` [PATCH v7 11/15] i2c: octeon: Rename driver to prepare for split Jan Glauber 2016-04-25 14:33 ` [PATCH v7 12/15] i2c: octeon: Split the driver into two parts Jan Glauber 2016-04-25 14:33 ` [PATCH v7 13/15] i2c: thunderx: Add i2c driver for ThunderX SOC Jan Glauber 2016-04-25 14:33 ` [PATCH v7 14/15] i2c: octeon,thunderx: Move register offsets to struct Jan Glauber 2016-04-25 14:33 ` [PATCH v7 15/15] i2c: thunderx: Add smbus alert support Jan Glauber
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160426123444.GB9796@hardcore \ --to=jan.glauber@caviumnetworks.com \ --cc=ddaney@caviumnetworks.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.