From: Kees Cook <keescook@chromium.org> To: Julia Lawall <Julia.Lawall@lip6.fr> Cc: linux-kernel@vger.kernel.org, Gilles Muller <Gilles.Muller@lip6.fr>, Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>, Pengfei Wang <wpengfeinudt@gmail.com>, cocci@systeme.lip6.fr Subject: [PATCH] coccicheck: add a test for repeat copy_from_user Date: Tue, 26 Apr 2016 15:24:42 -0700 [thread overview] Message-ID: <20160426222442.GA8104@www.outflux.net> (raw) This is usually a sign of a resized request. This adds a check for potential races or confusions. The check isn't 100% accurate, so it needs some manual review. Signed-off-by: Kees Cook <keescook@chromium.org> --- scripts/coccinelle/tests/reusercopy.cocci | 36 +++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 scripts/coccinelle/tests/reusercopy.cocci diff --git a/scripts/coccinelle/tests/reusercopy.cocci b/scripts/coccinelle/tests/reusercopy.cocci new file mode 100644 index 000000000000..53645de8ae95 --- /dev/null +++ b/scripts/coccinelle/tests/reusercopy.cocci @@ -0,0 +1,36 @@ +/// Recopying from the same user buffer frequently indicates a pattern of +/// Reading a size header, allocating, and then re-reading an entire +/// structure. If the structure's size is not re-validated, this can lead +/// to structure or data size confusions. +/// +// Confidence: Moderate +// Copyright: (C) 2016 Kees Cook, Google. License: GPLv2. +// URL: http://coccinelle.lip6.fr/ +// Comments: +// Options: -no_includes -include_headers + +virtual report +virtual org + +@cfu_twice@ +position p; +identifier src; +expression dest1, dest2, size1, size2, offset; +@@ + +*copy_from_user(dest1, src, size1) + ... when != src = offset + when != src += offset +*copy_from_user@p(dest2, src, size2) + +@script:python depends on org@ +p << cfu_twice.p; +@@ + +cocci.print_main("potentially dangerous second copy_from_user()",p) + +@script:python depends on report@ +p << cfu_twice.p; +@@ + +coccilib.report.print_report(p[0],"potentially dangerous second copy_from_user()") -- 2.6.3 -- Kees Cook Chrome OS & Brillo Security
WARNING: multiple messages have this Message-ID (diff)
From: keescook@chromium.org (Kees Cook) To: cocci@systeme.lip6.fr Subject: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user Date: Tue, 26 Apr 2016 15:24:42 -0700 [thread overview] Message-ID: <20160426222442.GA8104@www.outflux.net> (raw) This is usually a sign of a resized request. This adds a check for potential races or confusions. The check isn't 100% accurate, so it needs some manual review. Signed-off-by: Kees Cook <keescook@chromium.org> --- scripts/coccinelle/tests/reusercopy.cocci | 36 +++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 scripts/coccinelle/tests/reusercopy.cocci diff --git a/scripts/coccinelle/tests/reusercopy.cocci b/scripts/coccinelle/tests/reusercopy.cocci new file mode 100644 index 000000000000..53645de8ae95 --- /dev/null +++ b/scripts/coccinelle/tests/reusercopy.cocci @@ -0,0 +1,36 @@ +/// Recopying from the same user buffer frequently indicates a pattern of +/// Reading a size header, allocating, and then re-reading an entire +/// structure. If the structure's size is not re-validated, this can lead +/// to structure or data size confusions. +/// +// Confidence: Moderate +// Copyright: (C) 2016 Kees Cook, Google. License: GPLv2. +// URL: http://coccinelle.lip6.fr/ +// Comments: +// Options: -no_includes -include_headers + +virtual report +virtual org + + at cfu_twice@ +position p; +identifier src; +expression dest1, dest2, size1, size2, offset; +@@ + +*copy_from_user(dest1, src, size1) + ... when != src = offset + when != src += offset +*copy_from_user at p(dest2, src, size2) + + at script:python depends on org@ +p << cfu_twice.p; +@@ + +cocci.print_main("potentially dangerous second copy_from_user()",p) + +@script:python depends on report@ +p << cfu_twice.p; +@@ + +coccilib.report.print_report(p[0],"potentially dangerous second copy_from_user()") -- 2.6.3 -- Kees Cook Chrome OS & Brillo Security
next reply other threads:[~2016-04-26 22:24 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-26 22:24 Kees Cook [this message] 2016-04-26 22:24 ` [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user Kees Cook 2016-04-26 22:30 ` Kees Cook 2016-04-26 22:30 ` [Cocci] " Kees Cook 2016-12-27 18:21 ` Julia Lawall 2016-12-27 18:21 ` [Cocci] " Julia Lawall 2017-01-02 15:45 ` Pengfei Wang 2017-01-09 17:05 ` Vaishali Thakkar 2017-01-09 17:05 ` Vaishali Thakkar 2017-01-09 19:08 ` Julia Lawall 2017-01-09 19:08 ` Julia Lawall 2017-01-09 20:56 ` Kees Cook 2017-01-09 20:56 ` Kees Cook 2017-01-09 22:02 ` Kees Cook 2017-01-09 22:02 ` Kees Cook 2017-01-10 8:21 ` Pengfei Wang 2017-01-10 8:40 ` Vaishali Thakkar 2017-01-10 8:40 ` Vaishali Thakkar 2017-01-10 9:02 ` Pengfei Wang 2017-01-10 17:46 ` Vaishali Thakkar 2017-01-10 17:46 ` Vaishali Thakkar 2017-01-11 2:10 ` Pengfei Wang 2017-01-11 6:10 ` Vaishali Thakkar 2017-01-11 6:12 ` Julia Lawall 2017-01-11 6:12 ` Julia Lawall 2017-01-11 13:44 ` Pengfei Wang 2017-01-11 13:44 ` Pengfei Wang 2017-01-10 19:16 ` Kees Cook 2017-01-10 19:16 ` Kees Cook 2017-01-10 19:15 ` Kees Cook 2017-01-10 19:15 ` Kees Cook
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160426222442.GA8104@www.outflux.net \ --to=keescook@chromium.org \ --cc=Gilles.Muller@lip6.fr \ --cc=Julia.Lawall@lip6.fr \ --cc=cocci@systeme.lip6.fr \ --cc=linux-kernel@vger.kernel.org \ --cc=mmarek@suse.com \ --cc=nicolas.palix@imag.fr \ --cc=wpengfeinudt@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.