All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] whymb: Remove redundant words
@ 2016-04-28 11:18 Akira Yokosawa
  2016-04-28 14:07 ` Paul E. McKenney
  0 siblings, 1 reply; 4+ messages in thread
From: Akira Yokosawa @ 2016-04-28 11:18 UTC (permalink / raw)
  To: paulmck; +Cc: perfbook, Akira Yokosawa

From 53364b467603cd5ec9e1f6a12ad9377a76ebb72a Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <akiysw@gmail.com>
Date: Thu, 28 Apr 2016 20:08:32 +0900
Subject: [PATCH] whymb: Remove redundant words

The sentence fixed in commit 3d3ce3673746 ("Fix now-obsolete back
reference to Compaq Wizard web page") has redundant words around
the citation. This commit removes them.

Signed-off-by: Akira Yokosawa <akiysw@gmail.com>
---
 appendix/whymb/whymemorybarriers.tex | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/appendix/whymb/whymemorybarriers.tex b/appendix/whymb/whymemorybarriers.tex
index 6d09bfc..0c3b83e 100644
--- a/appendix/whymb/whymemorybarriers.tex
+++ b/appendix/whymb/whymemorybarriers.tex
@@ -1788,8 +1788,7 @@ busy, but cache bank~0 is idle.
 This could result in the cache invalidates for the new element being
 delayed, so that the reading CPU gets the new value for the pointer,
 but sees the old cached values for the new element.
-See the documentation called out earlier~\cite{Compaq01} called out
-earlier for more information,
+See the documentation~\cite{Compaq01} called out earlier for more information,
 or, again, if you think that I am just making all this up.\footnote{
 	Of course, the astute reader will have already recognized that
 	Alpha is nowhere near as mean and nasty as it could be,
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] whymb: Remove redundant words
  2016-04-28 11:18 [PATCH] whymb: Remove redundant words Akira Yokosawa
@ 2016-04-28 14:07 ` Paul E. McKenney
  2016-04-28 15:46   ` Akira Yokosawa
  0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2016-04-28 14:07 UTC (permalink / raw)
  To: Akira Yokosawa; +Cc: perfbook

On Thu, Apr 28, 2016 at 08:18:15PM +0900, Akira Yokosawa wrote:
> >From 53364b467603cd5ec9e1f6a12ad9377a76ebb72a Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiysw@gmail.com>
> Date: Thu, 28 Apr 2016 20:08:32 +0900
> Subject: [PATCH] whymb: Remove redundant words
> 
> The sentence fixed in commit 3d3ce3673746 ("Fix now-obsolete back
> reference to Compaq Wizard web page") has redundant words around
> the citation. This commit removes them.
> 
> Signed-off-by: Akira Yokosawa <akiysw@gmail.com>

Good catch, queued!

And no, that change wasn't one of my better efforts, was it?

							Thanx, Paul

> ---
>  appendix/whymb/whymemorybarriers.tex | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/appendix/whymb/whymemorybarriers.tex b/appendix/whymb/whymemorybarriers.tex
> index 6d09bfc..0c3b83e 100644
> --- a/appendix/whymb/whymemorybarriers.tex
> +++ b/appendix/whymb/whymemorybarriers.tex
> @@ -1788,8 +1788,7 @@ busy, but cache bank~0 is idle.
>  This could result in the cache invalidates for the new element being
>  delayed, so that the reading CPU gets the new value for the pointer,
>  but sees the old cached values for the new element.
> -See the documentation called out earlier~\cite{Compaq01} called out
> -earlier for more information,
> +See the documentation~\cite{Compaq01} called out earlier for more information,
>  or, again, if you think that I am just making all this up.\footnote{
>  	Of course, the astute reader will have already recognized that
>  	Alpha is nowhere near as mean and nasty as it could be,
> -- 
> 1.9.1
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] whymb: Remove redundant words
  2016-04-28 14:07 ` Paul E. McKenney
@ 2016-04-28 15:46   ` Akira Yokosawa
  2016-04-28 16:31     ` Paul E. McKenney
  0 siblings, 1 reply; 4+ messages in thread
From: Akira Yokosawa @ 2016-04-28 15:46 UTC (permalink / raw)
  To: paulmck; +Cc: perfbook, Akira Yokosawa

On 2016/04/28 23:07, Paul E. McKenney wrote:
> On Thu, Apr 28, 2016 at 08:18:15PM +0900, Akira Yokosawa wrote:
>> >From 53364b467603cd5ec9e1f6a12ad9377a76ebb72a Mon Sep 17 00:00:00 2001
>> From: Akira Yokosawa <akiysw@gmail.com>
>> Date: Thu, 28 Apr 2016 20:08:32 +0900
>> Subject: [PATCH] whymb: Remove redundant words
>>
>> The sentence fixed in commit 3d3ce3673746 ("Fix now-obsolete back
>> reference to Compaq Wizard web page") has redundant words around
>> the citation. This commit removes them.
>>
>> Signed-off-by: Akira Yokosawa <akiysw@gmail.com>
> 
> Good catch, queued!
> 
> And no, that change wasn't one of my better efforts, was it?
> 
> 							Thanx, Paul

Perhaps, you shouldn't apply your own patch on your own.
But, who else can manage the perfbook repository.

Or, in cases such as this one, you could ask an ack from the person
in reported-by. Just a suggestion.

                                              Thanks, Akira.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] whymb: Remove redundant words
  2016-04-28 15:46   ` Akira Yokosawa
@ 2016-04-28 16:31     ` Paul E. McKenney
  0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2016-04-28 16:31 UTC (permalink / raw)
  To: Akira Yokosawa; +Cc: perfbook

On Fri, Apr 29, 2016 at 12:46:45AM +0900, Akira Yokosawa wrote:
> On 2016/04/28 23:07, Paul E. McKenney wrote:
> > On Thu, Apr 28, 2016 at 08:18:15PM +0900, Akira Yokosawa wrote:
> >> >From 53364b467603cd5ec9e1f6a12ad9377a76ebb72a Mon Sep 17 00:00:00 2001
> >> From: Akira Yokosawa <akiysw@gmail.com>
> >> Date: Thu, 28 Apr 2016 20:08:32 +0900
> >> Subject: [PATCH] whymb: Remove redundant words
> >>
> >> The sentence fixed in commit 3d3ce3673746 ("Fix now-obsolete back
> >> reference to Compaq Wizard web page") has redundant words around
> >> the citation. This commit removes them.
> >>
> >> Signed-off-by: Akira Yokosawa <akiysw@gmail.com>
> > 
> > Good catch, queued!
> > 
> > And no, that change wasn't one of my better efforts, was it?
> > 
> > 							Thanx, Paul
> 
> Perhaps, you shouldn't apply your own patch on your own.
> But, who else can manage the perfbook repository.
> 
> Or, in cases such as this one, you could ask an ack from the person
> in reported-by. Just a suggestion.

So the following approaches seem reasonable:

1.	Get an ack, as you say.  I would need to put the patch on a
	separate branch in the meantime, but that is eminently doable.

2.	Let the person reporting the issue produce the patch.

3.	Wait until I am not massively distracted to produce the patch.

These all have drawbacks.  Almost like we are living in the real world!

This particular case actually worked well -- you inspected my commit,
found the problem, and submitted the patch.  All is well that ends well!

							Thanx, Paul


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-04-28 16:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-28 11:18 [PATCH] whymb: Remove redundant words Akira Yokosawa
2016-04-28 14:07 ` Paul E. McKenney
2016-04-28 15:46   ` Akira Yokosawa
2016-04-28 16:31     ` Paul E. McKenney

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.