* [nft PATCH] dist: include tests/ directory and files in tarball
@ 2016-04-28 9:14 Arturo Borrero Gonzalez
2016-04-28 9:27 ` Pablo Neira Ayuso
2016-04-29 9:19 ` Pablo Neira Ayuso
0 siblings, 2 replies; 6+ messages in thread
From: Arturo Borrero Gonzalez @ 2016-04-28 9:14 UTC (permalink / raw)
To: netfilter-devel
If we include tests/ in the release tarball, downstream distributors
can run the testsuites themselves while developing the packages.
This way, tests can be run in a more integrated environment and they can
discover errors related to the integration with the given distribution itself.
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 068009b..10aa40f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -4,3 +4,5 @@ SUBDIRS = src \
include \
doc \
files
+
+EXTRA_DIST = tests
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [nft PATCH] dist: include tests/ directory and files in tarball
2016-04-28 9:14 [nft PATCH] dist: include tests/ directory and files in tarball Arturo Borrero Gonzalez
@ 2016-04-28 9:27 ` Pablo Neira Ayuso
2016-04-28 10:07 ` Arturo Borrero Gonzalez
2016-04-29 9:19 ` Pablo Neira Ayuso
1 sibling, 1 reply; 6+ messages in thread
From: Pablo Neira Ayuso @ 2016-04-28 9:27 UTC (permalink / raw)
To: Arturo Borrero Gonzalez; +Cc: netfilter-devel
On Thu, Apr 28, 2016 at 11:14:38AM +0200, Arturo Borrero Gonzalez wrote:
> If we include tests/ in the release tarball, downstream distributors
> can run the testsuites themselves while developing the packages.
>
> This way, tests can be run in a more integrated environment and they can
> discover errors related to the integration with the given distribution itself.
>
> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
> ---
> Makefile.am | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Makefile.am b/Makefile.am
> index 068009b..10aa40f 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -4,3 +4,5 @@ SUBDIRS = src \
> include \
> doc \
> files
> +
> +EXTRA_DIST = tests
You can get a git clone instead?
This is going to bloat the tarball for something that only a few
developer need.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nft PATCH] dist: include tests/ directory and files in tarball
2016-04-28 9:27 ` Pablo Neira Ayuso
@ 2016-04-28 10:07 ` Arturo Borrero Gonzalez
2016-04-28 12:20 ` Pablo Neira Ayuso
0 siblings, 1 reply; 6+ messages in thread
From: Arturo Borrero Gonzalez @ 2016-04-28 10:07 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Netfilter Development Mailing list
On 28 April 2016 at 11:27, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Thu, Apr 28, 2016 at 11:14:38AM +0200, Arturo Borrero Gonzalez wrote:
>> If we include tests/ in the release tarball, downstream distributors
>> can run the testsuites themselves while developing the packages.
>>
>> This way, tests can be run in a more integrated environment and they can
>> discover errors related to the integration with the given distribution itself.
>>
>> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
>> ---
>> Makefile.am | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index 068009b..10aa40f 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -4,3 +4,5 @@ SUBDIRS = src \
>> include \
>> doc \
>> files
>> +
>> +EXTRA_DIST = tests
>
> You can get a git clone instead?
>
> This is going to bloat the tarball for something that only a few
> developer need.
It seems these are the numbers:
In the case of nftables
* 327K withtout tests
* 388K with tests
In case of conntrack-tools
* 496K without tests
* 503K with tests
I don't think this is a big deal.
Other release tarballs include tests or qa files (libnftnl, ipset,
libnetfilter-conntrack...)
--
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nft PATCH] dist: include tests/ directory and files in tarball
2016-04-28 10:07 ` Arturo Borrero Gonzalez
@ 2016-04-28 12:20 ` Pablo Neira Ayuso
2016-04-28 13:35 ` Arturo Borrero Gonzalez
0 siblings, 1 reply; 6+ messages in thread
From: Pablo Neira Ayuso @ 2016-04-28 12:20 UTC (permalink / raw)
To: Arturo Borrero Gonzalez; +Cc: Netfilter Development Mailing list
On Thu, Apr 28, 2016 at 12:07:10PM +0200, Arturo Borrero Gonzalez wrote:
> On 28 April 2016 at 11:27, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Thu, Apr 28, 2016 at 11:14:38AM +0200, Arturo Borrero Gonzalez wrote:
> >> If we include tests/ in the release tarball, downstream distributors
> >> can run the testsuites themselves while developing the packages.
> >>
> >> This way, tests can be run in a more integrated environment and they can
> >> discover errors related to the integration with the given distribution itself.
> >>
> >> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
> >> ---
> >> Makefile.am | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/Makefile.am b/Makefile.am
> >> index 068009b..10aa40f 100644
> >> --- a/Makefile.am
> >> +++ b/Makefile.am
> >> @@ -4,3 +4,5 @@ SUBDIRS = src \
> >> include \
> >> doc \
> >> files
> >> +
> >> +EXTRA_DIST = tests
> >
> > You can get a git clone instead?
> >
> > This is going to bloat the tarball for something that only a few
> > developer need.
>
> It seems these are the numbers:
>
> In the case of nftables
> * 327K withtout tests
> * 388K with tests
>
> In case of conntrack-tools
> * 496K without tests
> * 503K with tests
>
> I don't think this is a big deal.
>
> Other release tarballs include tests or qa files (libnftnl, ipset,
> libnetfilter-conntrack...)
Right, but libnftnl tests are self-contained (not kernel dependent).
Anyway, nft tests are dependent of the kernel version, given that
we've been augmenting the feature set along the nft development.
So integrating this can be useful to you?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nft PATCH] dist: include tests/ directory and files in tarball
2016-04-28 12:20 ` Pablo Neira Ayuso
@ 2016-04-28 13:35 ` Arturo Borrero Gonzalez
0 siblings, 0 replies; 6+ messages in thread
From: Arturo Borrero Gonzalez @ 2016-04-28 13:35 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Netfilter Development Mailing list
On 28 April 2016 at 14:20, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> So integrating this can be useful to you?
Yes, my plan is to launch the tests from the debian continuous
integration system.
--
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nft PATCH] dist: include tests/ directory and files in tarball
2016-04-28 9:14 [nft PATCH] dist: include tests/ directory and files in tarball Arturo Borrero Gonzalez
2016-04-28 9:27 ` Pablo Neira Ayuso
@ 2016-04-29 9:19 ` Pablo Neira Ayuso
1 sibling, 0 replies; 6+ messages in thread
From: Pablo Neira Ayuso @ 2016-04-29 9:19 UTC (permalink / raw)
To: Arturo Borrero Gonzalez; +Cc: netfilter-devel
On Thu, Apr 28, 2016 at 11:14:38AM +0200, Arturo Borrero Gonzalez wrote:
> If we include tests/ in the release tarball, downstream distributors
> can run the testsuites themselves while developing the packages.
>
> This way, tests can be run in a more integrated environment and they can
> discover errors related to the integration with the given distribution itself.
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-29 9:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-28 9:14 [nft PATCH] dist: include tests/ directory and files in tarball Arturo Borrero Gonzalez
2016-04-28 9:27 ` Pablo Neira Ayuso
2016-04-28 10:07 ` Arturo Borrero Gonzalez
2016-04-28 12:20 ` Pablo Neira Ayuso
2016-04-28 13:35 ` Arturo Borrero Gonzalez
2016-04-29 9:19 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.