* [PATCH] drm/i915/lvds: do not set border bits when panel fitter is not enabled
@ 2016-04-29 9:36 Jani Nikula
2016-04-29 10:12 ` Ville Syrjälä
2016-04-29 11:18 ` ✓ Fi.CI.BAT: success for " Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Jani Nikula @ 2016-04-29 9:36 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
We also don't read the border bits in i9xx_get_pfit_config() when the
panel fitter is not enabled, causing the state checker warning:
[drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in
gmch_pfit.lvds_border_bits (expected 0x00008000, found 0x00000000)
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87632
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_panel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
index 828f0fcaaaf8..67cf2e22ba51 100644
--- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c
@@ -363,6 +363,7 @@ out:
if ((pfit_control & PFIT_ENABLE) == 0) {
pfit_control = 0;
pfit_pgm_ratios = 0;
+ border = 0;
}
/* Make sure pre-965 set dither correctly for 18bpp panels. */
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/lvds: do not set border bits when panel fitter is not enabled
2016-04-29 9:36 [PATCH] drm/i915/lvds: do not set border bits when panel fitter is not enabled Jani Nikula
@ 2016-04-29 10:12 ` Ville Syrjälä
2016-04-29 11:57 ` Ville Syrjälä
2016-04-29 11:18 ` ✓ Fi.CI.BAT: success for " Patchwork
1 sibling, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2016-04-29 10:12 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Fri, Apr 29, 2016 at 12:36:35PM +0300, Jani Nikula wrote:
> We also don't read the border bits in i9xx_get_pfit_config() when the
> panel fitter is not enabled, causing the state checker warning:
>
> [drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in
> gmch_pfit.lvds_border_bits (expected 0x00008000, found 0x00000000)
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87632
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_panel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index 828f0fcaaaf8..67cf2e22ba51 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -363,6 +363,7 @@ out:
> if ((pfit_control & PFIT_ENABLE) == 0) {
> pfit_control = 0;
> pfit_pgm_ratios = 0;
> + border = 0;
That doesn't seem right. We especially want the border for "center".
> }
>
> /* Make sure pre-965 set dither correctly for 18bpp panels. */
> --
> 2.1.4
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/lvds: do not set border bits when panel fitter is not enabled
2016-04-29 9:36 [PATCH] drm/i915/lvds: do not set border bits when panel fitter is not enabled Jani Nikula
2016-04-29 10:12 ` Ville Syrjälä
@ 2016-04-29 11:18 ` Patchwork
1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2016-04-29 11:18 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/lvds: do not set border bits when panel fitter is not enabled
URL : https://patchwork.freedesktop.org/series/6530/
State : success
== Summary ==
Series 6530v1 drm/i915/lvds: do not set border bits when panel fitter is not enabled
http://patchwork.freedesktop.org/api/1.0/series/6530/revisions/1/mbox/
bdw-nuci7-2 total:201 pass:189 dwarn:0 dfail:0 fail:0 skip:12
bdw-ultra total:201 pass:176 dwarn:0 dfail:0 fail:0 skip:25
bsw-nuc-2 total:200 pass:159 dwarn:0 dfail:0 fail:0 skip:41
byt-nuc total:200 pass:159 dwarn:0 dfail:0 fail:0 skip:41
hsw-brixbox total:201 pass:175 dwarn:0 dfail:0 fail:0 skip:26
hsw-gt2 total:201 pass:179 dwarn:0 dfail:0 fail:1 skip:21
ilk-hp8440p total:201 pass:140 dwarn:0 dfail:0 fail:0 skip:61
ivb-t430s total:201 pass:170 dwarn:0 dfail:0 fail:0 skip:31
skl-i7k-2 total:201 pass:174 dwarn:0 dfail:0 fail:0 skip:27
skl-nuci5 total:201 pass:190 dwarn:0 dfail:0 fail:0 skip:11
snb-dellxps total:201 pass:159 dwarn:0 dfail:0 fail:0 skip:42
snb-x220t total:201 pass:159 dwarn:0 dfail:0 fail:1 skip:41
Results at /archive/results/CI_IGT_test/Patchwork_2111/
1d56af10bdd6f4714e0892c05ff01d11e77f54fc drm-intel-nightly: 2016y-04m-29d-09h-21m-52s UTC integration manifest
42aec19 drm/i915/lvds: do not set border bits when panel fitter is not enabled
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/lvds: do not set border bits when panel fitter is not enabled
2016-04-29 10:12 ` Ville Syrjälä
@ 2016-04-29 11:57 ` Ville Syrjälä
2016-04-29 12:35 ` Jani Nikula
0 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2016-04-29 11:57 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Fri, Apr 29, 2016 at 01:12:33PM +0300, Ville Syrjälä wrote:
> On Fri, Apr 29, 2016 at 12:36:35PM +0300, Jani Nikula wrote:
> > We also don't read the border bits in i9xx_get_pfit_config() when the
> > panel fitter is not enabled, causing the state checker warning:
> >
> > [drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in
> > gmch_pfit.lvds_border_bits (expected 0x00008000, found 0x00000000)
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87632
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_panel.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> > index 828f0fcaaaf8..67cf2e22ba51 100644
> > --- a/drivers/gpu/drm/i915/intel_panel.c
> > +++ b/drivers/gpu/drm/i915/intel_panel.c
> > @@ -363,6 +363,7 @@ out:
> > if ((pfit_control & PFIT_ENABLE) == 0) {
> > pfit_control = 0;
> > pfit_pgm_ratios = 0;
> > + border = 0;
>
> That doesn't seem right. We especially want the border for "center".
So after looking at this again, I think we should just move the border
bit readout to the lvds get_config() hook.
Or was there some magic reason for doing the readout in the wrong
place? Daniel?
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/lvds: do not set border bits when panel fitter is not enabled
2016-04-29 11:57 ` Ville Syrjälä
@ 2016-04-29 12:35 ` Jani Nikula
2016-05-02 9:09 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2016-04-29 12:35 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Fri, 29 Apr 2016, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Apr 29, 2016 at 01:12:33PM +0300, Ville Syrjälä wrote:
>> On Fri, Apr 29, 2016 at 12:36:35PM +0300, Jani Nikula wrote:
>> > We also don't read the border bits in i9xx_get_pfit_config() when the
>> > panel fitter is not enabled, causing the state checker warning:
>> >
>> > [drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in
>> > gmch_pfit.lvds_border_bits (expected 0x00008000, found 0x00000000)
>> >
>> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87632
>> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> > ---
>> > drivers/gpu/drm/i915/intel_panel.c | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
>> > index 828f0fcaaaf8..67cf2e22ba51 100644
>> > --- a/drivers/gpu/drm/i915/intel_panel.c
>> > +++ b/drivers/gpu/drm/i915/intel_panel.c
>> > @@ -363,6 +363,7 @@ out:
>> > if ((pfit_control & PFIT_ENABLE) == 0) {
>> > pfit_control = 0;
>> > pfit_pgm_ratios = 0;
>> > + border = 0;
>>
>> That doesn't seem right. We especially want the border for "center".
Doh.
> So after looking at this again, I think we should just move the border
> bit readout to the lvds get_config() hook.
Agreed. Patches sent [1].
> Or was there some magic reason for doing the readout in the wrong
> place? Daniel?
I tried to dig the history, didn't find anything.
BR,
Jani.
[1] http://patchwork.freedesktop.org/patch/msgid/1461933243-2140-1-git-send-email-jani.nikula@intel.com
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/lvds: do not set border bits when panel fitter is not enabled
2016-04-29 12:35 ` Jani Nikula
@ 2016-05-02 9:09 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2016-05-02 9:09 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Fri, Apr 29, 2016 at 03:35:43PM +0300, Jani Nikula wrote:
> On Fri, 29 Apr 2016, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Fri, Apr 29, 2016 at 01:12:33PM +0300, Ville Syrjälä wrote:
> >> On Fri, Apr 29, 2016 at 12:36:35PM +0300, Jani Nikula wrote:
> >> > We also don't read the border bits in i9xx_get_pfit_config() when the
> >> > panel fitter is not enabled, causing the state checker warning:
> >> >
> >> > [drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in
> >> > gmch_pfit.lvds_border_bits (expected 0x00008000, found 0x00000000)
> >> >
> >> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87632
> >> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> > ---
> >> > drivers/gpu/drm/i915/intel_panel.c | 1 +
> >> > 1 file changed, 1 insertion(+)
> >> >
> >> > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> >> > index 828f0fcaaaf8..67cf2e22ba51 100644
> >> > --- a/drivers/gpu/drm/i915/intel_panel.c
> >> > +++ b/drivers/gpu/drm/i915/intel_panel.c
> >> > @@ -363,6 +363,7 @@ out:
> >> > if ((pfit_control & PFIT_ENABLE) == 0) {
> >> > pfit_control = 0;
> >> > pfit_pgm_ratios = 0;
> >> > + border = 0;
> >>
> >> That doesn't seem right. We especially want the border for "center".
>
> Doh.
>
> > So after looking at this again, I think we should just move the border
> > bit readout to the lvds get_config() hook.
>
> Agreed. Patches sent [1].
Oops, year-long standing misunderstanding from me - I thought border only
makes sense when pfit is enabled ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-02 9:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-29 9:36 [PATCH] drm/i915/lvds: do not set border bits when panel fitter is not enabled Jani Nikula
2016-04-29 10:12 ` Ville Syrjälä
2016-04-29 11:57 ` Ville Syrjälä
2016-04-29 12:35 ` Jani Nikula
2016-05-02 9:09 ` Daniel Vetter
2016-04-29 11:18 ` ✓ Fi.CI.BAT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.