From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org,
linux.amoon@gmail.com, tjakobi@math.uni-bielefeld.de,
m.szyprowski@samsung.com, hverkuil@xs4all.nl,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after bootloader initialization
Date: Fri, 29 Apr 2016 17:44:48 +0100 [thread overview]
Message-ID: <20160429164448.GY3217@sirena.org.uk> (raw)
In-Reply-To: <57234BA2.6020304@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]
On Fri, Apr 29, 2016 at 01:55:14PM +0200, Krzysztof Kozlowski wrote:
> On 04/29/2016 01:30 PM, Mark Brown wrote:
> > Supplies are only optional if they may be physically absent. In this
> > case it's possible that on device regulators may be used instead, a
> > pattern more like that used for arizona-ldo1 where we represent those
> > regulators might be better as it's more clearly describing the
> > situation. I'm just wondering if the supply lookup stuff there should
> > be factored out as this is not an uncommon pattern..
> > It should at least be clearly stated what's going on, ignoring failure
> > to get supplies is generally a bug and people will tend to blindly cut
> > and paste things (witness all the breakage in graphics drivers with
> > this).
> The VDD33 is really optional. The device can work in different
> configuration, e.g. only on VBAT. How the reset logic would work then? I
> don't know... I would suspect that it could be exactly the same (just
> replace VDD33 with VBAT) but I am not sure.
What the Arizona example I mentioned does is look for the property
specifying an external supply in DT and if there isn't one assumes that
it must be using the internal regulator. That's a bit icky but it does
the right thing and is much simpler from a user point of view.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after bootloader initialization
Date: Fri, 29 Apr 2016 17:44:48 +0100 [thread overview]
Message-ID: <20160429164448.GY3217@sirena.org.uk> (raw)
In-Reply-To: <57234BA2.6020304@samsung.com>
On Fri, Apr 29, 2016 at 01:55:14PM +0200, Krzysztof Kozlowski wrote:
> On 04/29/2016 01:30 PM, Mark Brown wrote:
> > Supplies are only optional if they may be physically absent. In this
> > case it's possible that on device regulators may be used instead, a
> > pattern more like that used for arizona-ldo1 where we represent those
> > regulators might be better as it's more clearly describing the
> > situation. I'm just wondering if the supply lookup stuff there should
> > be factored out as this is not an uncommon pattern..
> > It should at least be clearly stated what's going on, ignoring failure
> > to get supplies is generally a bug and people will tend to blindly cut
> > and paste things (witness all the breakage in graphics drivers with
> > this).
> The VDD33 is really optional. The device can work in different
> configuration, e.g. only on VBAT. How the reset logic would work then? I
> don't know... I would suspect that it could be exactly the same (just
> replace VDD33 with VBAT) but I am not sure.
What the Arizona example I mentioned does is look for the property
specifying an external supply in DT and if there isn't one assumes that
it must be using the internal regulator. That's a bit icky but it does
the right thing and is much simpler from a user point of view.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160429/988b5d5b/attachment.sig>
next prev parent reply other threads:[~2016-04-29 16:45 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 10:59 [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP booting Krzysztof Kozlowski
2016-04-29 10:59 ` Krzysztof Kozlowski
2016-04-29 10:59 ` [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after bootloader initialization Krzysztof Kozlowski
2016-04-29 10:59 ` Krzysztof Kozlowski
2016-04-29 11:30 ` Mark Brown
2016-04-29 11:30 ` Mark Brown
2016-04-29 11:55 ` Krzysztof Kozlowski
2016-04-29 11:55 ` Krzysztof Kozlowski
2016-04-29 16:44 ` Mark Brown [this message]
2016-04-29 16:44 ` Mark Brown
2016-05-02 9:49 ` Krzysztof Kozlowski
2016-05-02 9:49 ` Krzysztof Kozlowski
2016-05-02 10:49 ` Krzysztof Kozlowski
2016-05-02 10:49 ` Krzysztof Kozlowski
2016-05-02 10:55 ` Mark Brown
2016-05-02 10:55 ` Mark Brown
2016-05-03 18:00 ` Rob Herring
2016-05-03 18:00 ` Rob Herring
2016-05-04 12:01 ` Krzysztof Kozlowski
2016-05-04 12:01 ` Krzysztof Kozlowski
2016-05-04 12:01 ` Krzysztof Kozlowski
2016-05-04 18:25 ` Mark Brown
2016-05-04 18:25 ` Mark Brown
2016-04-29 10:59 ` [RFT PATCH 2/3] ARM: dts: exynos: Provide regulator for usb3503 on Odroid to fix device detection Krzysztof Kozlowski
2016-04-29 10:59 ` Krzysztof Kozlowski
2016-04-29 10:59 ` Krzysztof Kozlowski
2016-04-29 10:59 ` [PATCH 3/3] regulator: max77686: Configure enable time to properly handle regulator enable Krzysztof Kozlowski
2016-04-29 10:59 ` Krzysztof Kozlowski
2016-04-29 10:59 ` Krzysztof Kozlowski
2016-04-29 11:31 ` Applied "regulator: max77686: Configure enable time to properly handle regulator enable" to the regulator tree Mark Brown
2016-04-29 11:31 ` Mark Brown
2016-04-29 11:31 ` Mark Brown
2016-04-30 9:43 ` [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP booting Hans Verkuil
2016-04-30 9:43 ` Hans Verkuil
2016-04-30 9:43 ` Hans Verkuil
2016-05-01 13:17 ` Krzysztof Kozlowski
2016-05-01 13:17 ` Krzysztof Kozlowski
2016-05-01 13:17 ` Krzysztof Kozlowski
2016-05-01 14:09 ` Hans Verkuil
2016-05-01 14:09 ` Hans Verkuil
2016-05-01 16:01 ` Hans Verkuil
2016-05-01 16:01 ` Hans Verkuil
2016-05-01 16:01 ` Hans Verkuil
2016-05-01 16:42 ` Krzysztof Kozlowski
2016-05-01 16:42 ` Krzysztof Kozlowski
2016-05-02 13:40 ` Hans Verkuil
2016-05-02 13:40 ` Hans Verkuil
2016-05-02 13:40 ` Hans Verkuil
2016-05-02 13:41 ` Krzysztof Kozlowski
2016-05-02 13:41 ` Krzysztof Kozlowski
2016-05-02 5:50 ` Marek Szyprowski
2016-05-02 5:50 ` Marek Szyprowski
2016-05-02 5:50 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429164448.GY3217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=m.szyprowski@samsung.com \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.