From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Subject: Re: [PATCH v6] spi: orion.c: Add direct access mode
Date: Mon, 2 May 2016 16:40:23 +0100 [thread overview]
Message-ID: <20160502154023.GI6292@sirena.org.uk> (raw)
In-Reply-To: <8919835.yGyvx4h0Tr@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]
On Mon, May 02, 2016 at 09:28:34AM +0200, Arnd Bergmann wrote:
> On Monday 02 May 2016 08:47:15 Stefan Roese wrote:
> > Its been a while since v6 of this direct write access mode has been
> > posted. This is a gentle ping on its status.
> > Arnd / Mark, do you have any additional change requests or are you okay
> > with the current version?
Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review. If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings just adds to the mail volume (if they are
seen at all) and if something has gone wrong you'll have to resend the
patches anyway.
> - you now always send a multiple of four byte in each transfer, are
> there any downsides in doing this, e.g. some SPI devices that might
> get confused by receiving additional uninitialized data?
Yes, this will break a large proportion of devices.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6] spi: orion.c: Add direct access mode
Date: Mon, 2 May 2016 16:40:23 +0100 [thread overview]
Message-ID: <20160502154023.GI6292@sirena.org.uk> (raw)
In-Reply-To: <8919835.yGyvx4h0Tr@wuerfel>
On Mon, May 02, 2016 at 09:28:34AM +0200, Arnd Bergmann wrote:
> On Monday 02 May 2016 08:47:15 Stefan Roese wrote:
> > Its been a while since v6 of this direct write access mode has been
> > posted. This is a gentle ping on its status.
> > Arnd / Mark, do you have any additional change requests or are you okay
> > with the current version?
Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review. If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings just adds to the mail volume (if they are
seen at all) and if something has gone wrong you'll have to resend the
patches anyway.
> - you now always send a multiple of four byte in each transfer, are
> there any downsides in doing this, e.g. some SPI devices that might
> get confused by receiving additional uninitialized data?
Yes, this will break a large proportion of devices.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160502/b84af846/attachment.sig>
next prev parent reply other threads:[~2016-05-02 15:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 10:11 [PATCH v6] spi: orion.c: Add direct access mode Stefan Roese
2016-04-20 10:11 ` Stefan Roese
[not found] ` <1461147068-4829-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org>
2016-04-20 11:58 ` Gregory CLEMENT
2016-04-20 11:58 ` Gregory CLEMENT
[not found] ` <87k2jswky0.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-04-20 12:09 ` Stefan Roese
2016-04-20 12:09 ` Stefan Roese
[not found] ` <5717715D.6030701-ynQEQJNshbs@public.gmane.org>
2016-06-16 9:23 ` Gregory CLEMENT
2016-06-16 9:23 ` Gregory CLEMENT
[not found] ` <87d1nhbi83.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-16 9:42 ` Stefan Roese
2016-06-16 9:42 ` Stefan Roese
2016-05-02 6:47 ` Stefan Roese
2016-05-02 6:47 ` Stefan Roese
[not found] ` <5726F7F3.9070700-ynQEQJNshbs@public.gmane.org>
2016-05-02 7:28 ` Arnd Bergmann
2016-05-02 7:28 ` Arnd Bergmann
2016-05-02 10:33 ` Stefan Roese
2016-05-02 10:33 ` Stefan Roese
2016-05-02 15:40 ` Mark Brown [this message]
2016-05-02 15:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502154023.GI6292@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=andrew-g2DYL2Zd6BY@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sr-ynQEQJNshbs@public.gmane.org \
--cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.