From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, philipp.reisner@linbit.com,
drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org
Subject: Re: [Drbd-dev] [PATCH net-next v2] block/drbd: use nla_put_u64_64bit()
Date: Wed, 4 May 2016 14:52:53 +0200 [thread overview]
Message-ID: <20160504125253.GP16459@soda.linbit> (raw)
In-Reply-To: <5729EFBC.7040002@6wind.com>
On Wed, May 04, 2016 at 02:49:00PM +0200, Nicolas Dichtel wrote:
> Le 04/05/2016 11:05, Lars Ellenberg a écrit :
> [snip]
> > We don't have an "alignment problem" there, btw.
> > Last time I checked, we did work fine without this alignment magic,
> > we already take care of that, yes, even on affected architectures.
> The code adds several consecutive u64 attributes. The nl attribute header is 4
> bytes, thus the full attribute length is 12 bytes. If the first u64 is aligned
> on 8 (nla_data()), the next one is not aligned on 8: it starts 12 bytes (8 (u64)
> + 4 (nl attr hdr)) after the previous u64.
Yes. Which in our case is not a problem.
But I don't object to the padding per se,
if that is how things "should be".
I try to understand why you so much object to using 0 as pad.
Lars
WARNING: multiple messages have this Message-ID (diff)
From: Lars Ellenberg <lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org>
To: Nicolas Dichtel
<nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH net-next v2] block/drbd: use nla_put_u64_64bit()
Date: Wed, 4 May 2016 14:52:53 +0200 [thread overview]
Message-ID: <20160504125253.GP16459@soda.linbit> (raw)
In-Reply-To: <5729EFBC.7040002-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
On Wed, May 04, 2016 at 02:49:00PM +0200, Nicolas Dichtel wrote:
> Le 04/05/2016 11:05, Lars Ellenberg a écrit :
> [snip]
> > We don't have an "alignment problem" there, btw.
> > Last time I checked, we did work fine without this alignment magic,
> > we already take care of that, yes, even on affected architectures.
> The code adds several consecutive u64 attributes. The nl attribute header is 4
> bytes, thus the full attribute length is 12 bytes. If the first u64 is aligned
> on 8 (nla_data()), the next one is not aligned on 8: it starts 12 bytes (8 (u64)
> + 4 (nl attr hdr)) after the previous u64.
Yes. Which in our case is not a problem.
But I don't object to the padding per se,
if that is how things "should be".
I try to understand why you so much object to using 0 as pad.
Lars
next prev parent reply other threads:[~2016-05-04 12:53 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 8:06 [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 1/8] macsec: use nla_put_u64_64bit() Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 2/8] drivers/wireless: " Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 3/8] fs/quota: " Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 11:08 ` Jan Kara
2016-04-26 11:08 ` Jan Kara
2016-04-26 12:31 ` Nicolas Dichtel
2016-04-26 12:31 ` Nicolas Dichtel
2016-04-26 12:37 ` Jan Kara
2016-04-26 12:37 ` Jan Kara
2016-04-26 16:24 ` David Miller
2016-04-26 8:06 ` [PATCH net-next 4/8] sock_diag: align nlattr properly when needed Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 5/8] ovs: " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 6/8] rtnl: " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 7/8] neigh: " Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 8/8] sched: " Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 11:54 ` [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) Lars Ellenberg
2016-04-26 11:54 ` Lars Ellenberg
2016-04-26 12:18 ` [Drbd-dev] " Lars Ellenberg
2016-04-26 12:18 ` Lars Ellenberg
2016-05-03 8:50 ` [PATCH net-next] block/drbd: use nla_put_u64_64bit() Nicolas Dichtel
2016-05-03 9:28 ` Nicolas Dichtel
2016-05-03 9:39 ` [PATCH net-next v2] " Nicolas Dichtel
2016-05-03 10:06 ` Lars Ellenberg
2016-05-03 10:06 ` Lars Ellenberg
2016-05-03 12:07 ` Nicolas Dichtel
2016-05-03 16:05 ` David Miller
2016-05-04 9:05 ` Lars Ellenberg
2016-05-04 9:05 ` Lars Ellenberg
2016-05-04 12:49 ` Nicolas Dichtel
2016-05-04 12:52 ` Lars Ellenberg [this message]
2016-05-04 12:52 ` Lars Ellenberg
2016-05-04 14:27 ` Eric Dumazet
2016-05-04 16:50 ` David Miller
2016-05-04 17:13 ` Eric Dumazet
2016-05-04 16:47 ` David Miller
2016-05-03 16:06 ` David Miller
2016-05-09 9:40 ` [PATCH net-next v3] block/drbd: align properly u64 in nl messages Nicolas Dichtel
2016-05-09 13:15 ` Lars Ellenberg
2016-05-09 13:15 ` Lars Ellenberg
2016-05-10 9:09 ` Nicolas Dichtel
2016-05-10 9:09 ` Nicolas Dichtel
2016-05-10 9:40 ` [Drbd-dev] " Lars Ellenberg
2016-05-10 9:40 ` Lars Ellenberg
2016-05-10 10:06 ` [Drbd-dev] " Nicolas Dichtel
2016-05-10 15:39 ` David Miller
2016-05-10 19:09 ` Lars Ellenberg
2016-05-10 19:09 ` Lars Ellenberg
2016-05-10 19:26 ` [Drbd-dev] " David Miller
2016-04-26 16:25 ` [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) David Miller
2016-04-26 16:25 ` David Miller
2016-04-26 16:02 ` David Miller
2016-04-26 16:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504125253.GP16459@soda.linbit \
--to=lars.ellenberg@linbit.com \
--cc=davem@davemloft.net \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.