Re: [PATCH] edgerouter: fix machine tune

Re: [PATCH] edgerouter: fix machine tune

[Kevin Hao]

On Fri, May 06, 2016 at 09:47:43AM -0700, Ruslan Babayev wrote:
> 
> Octeon+ lacks FPU
> 
> Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
> ---
>  meta-yocto-bsp/conf/machine/edgerouter.conf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-yocto-bsp/conf/machine/edgerouter.conf b/meta-yocto-bsp/conf/machine/edgerouter.conf
> index 6343dfc..062d896 100644
> --- a/meta-yocto-bsp/conf/machine/edgerouter.conf
> +++ b/meta-yocto-bsp/conf/machine/edgerouter.conf
> @@ -2,6 +2,7 @@
>  #@NAME: Edgerouter
>  #@DESCRIPTION: Edgerouter
>  
> +DEFAULTTUNE ?= "mips64-nf"

The change looks fine to me. But unfortunately the libjpeg-turbo can't build
with the mips64-nf. I have filed a bug (9606) for it. I think we can merge
this once we fix the build failure.

Thanks,
Kevin

>  require conf/machine/include/tune-mips64.inc
>  
>  MACHINE_FEATURES = "pci ext2 ext3 serial"
> -- 
> 2.7.4

Re: [PATCH] edgerouter: fix machine tune

[Kevin Hao]

On Sun, May 08, 2016 at 11:08:35AM -0700, Ruslan Babayev wrote:
> 
> Kevin Hao writes:
> 
> > On Fri, May 06, 2016 at 09:47:43AM -0700, Ruslan Babayev wrote:
> >> 
> >> Octeon+ lacks FPU
> >> 
> >> Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
> >> ---
> >>  meta-yocto-bsp/conf/machine/edgerouter.conf | 1 +
> >>  1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/meta-yocto-bsp/conf/machine/edgerouter.conf b/meta-yocto-bsp/conf/machine/edgerouter.conf
> >> index 6343dfc..062d896 100644
> >> --- a/meta-yocto-bsp/conf/machine/edgerouter.conf
> >> +++ b/meta-yocto-bsp/conf/machine/edgerouter.conf
> >> @@ -2,6 +2,7 @@
> >>  #@NAME: Edgerouter
> >>  #@DESCRIPTION: Edgerouter
> >>  
> >> +DEFAULTTUNE ?= "mips64-nf"
> >
> > The change looks fine to me. But unfortunately the libjpeg-turbo can't build
> > with the mips64-nf. I have filed a bug (9606) for it. I think we can merge
> > this once we fix the build failure.
> >
> 
> Without this change OpenSSH (ssh-keygen) dies with SIGILL at
> runtime. 

The ssh-keygen works pretty well for me. Could you show the steps to
reproduce this issue?

>How about blacklisting libjpeg for edgerouter? 

Or we can easily workaround this by using the method [1] suggested by
Peter Kjellerstedt.

>It's not very
> useful on a little headless router.

Agreed.

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=9606

Thanks,
Kevin

> 
> Thanks,
> Ruslan

Re: [PATCH] edgerouter: fix machine tune

[Kevin Hao]

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

On Mon, May 09, 2016 at 11:39:17AM -0700, Ruslan Babayev wrote:
> 
> Kevin Hao writes:
> 
> >> 
> >> Without this change OpenSSH (ssh-keygen) dies with SIGILL at
> >> runtime. 
> >
> > The ssh-keygen works pretty well for me. Could you show the steps to
> > reproduce this issue?
> >
> 
> Sorry, I should have mentioned I have seen the crash with TCLIBC =
> "musl" only. Not sure what's going on. Perhaps glibc by default falls
> back to soft-float at run-time.

Since the kernel has FPU emulation, we should not run into this crash even if
musl use the hard float instructions. That is also why the edgerouter BSP
can works previously. It seems a bug in musl.

> 
> With "musl" I also saw a mips related compilation failure in libffi which I
> have fixed.
> 
> Just to verify I have rebuilt core-image-minimal with glibc and I ssh-keygen
> works. Regarding core-image-sato, is it even officially supported for
> edgerouter? The release notes [1] only mention core-image-minimal.

We don't have an officially image type supported list for each BSP.
The core-image-minimal is only referred as an example in release note, but
that doesn't mean we only support this image type. A patch should not break
the build of an image type which is buildable currently at least.

Thanks,
Kevin

> 
> 
> Regards,
> Ruslan
> 
> [1] https://www.yoctoproject.org/downloads/bsps/krogoth21/edgerouter

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: [PATCH] edgerouter: fix machine tune

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]


> On May 9, 2016, at 8:33 PM, Kevin Hao <kexin.hao@windriver.com> wrote:
> 
> On Mon, May 09, 2016 at 11:39:17AM -0700, Ruslan Babayev wrote:
>> 
>> Kevin Hao writes:
>> 
>>>> 
>>>> Without this change OpenSSH (ssh-keygen) dies with SIGILL at
>>>> runtime.
>>> 
>>> The ssh-keygen works pretty well for me. Could you show the steps to
>>> reproduce this issue?
>>> 
>> 
>> Sorry, I should have mentioned I have seen the crash with TCLIBC =
>> "musl" only. Not sure what's going on. Perhaps glibc by default falls
>> back to soft-float at run-time.
> 
> Since the kernel has FPU emulation, we should not run into this crash even if
> musl use the hard float instructions. That is also why the edgerouter BSP
> can works previously. It seems a bug in musl.

it would be good if you can narrow it down. musl supports both hf and sf variants for mips64


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]