All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Shannon Zhao <shannon.zhao@linaro.org>
Cc: Shannon Zhao <zhaoshenglong@huawei.com>,
	linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
	will.deacon@arm.com, sstabellini@kernel.org, stefano@aporeto.com,
	julien.grall@arm.com, ard.biesheuvel@linaro.org,
	xen-devel@lists.xen.org, devicetree@vger.kernel.org,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	peter.huangpeng@huawei.com
Subject: Re: [PATCH] Xen: EFI: Parse DT parameters for Xen specific UEFI
Date: Thu, 12 May 2016 00:24:44 +0100	[thread overview]
Message-ID: <20160511232444.GY2839@codeblueprint.co.uk> (raw)
In-Reply-To: <57333533.2030206@linaro.org>

On Wed, 11 May, at 09:35:47PM, Shannon Zhao wrote:
> > 
> > Also, why do you need to setup efi.runtime_version here? Isn't that
> > done inside uefi_init()?
> > 
> I don't see any codes which setup efi.runtime_version in uefi_init().
 
Look in the EFI tree,

  https://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/tree/drivers/firmware/efi/arm-init.c?h=next#n120

> > Here is how I would have expected this patch to look:
> > 
> >   - Add FDT code to find hypervisor EFI params
> > 
> >   - Force enable EFI_RUNTIME_SERVICES for Xen and call
> >     xen_efi_runtime_setup() inside xen_guest_init()
> > 
> >   - Change arm_enable_runtime_services() to handle the case where
> >     EFI_RUNTIME_SERVICES is already set
> > 
> > Am I misunderstanding some ordering issues?
> 
> Since xen_guest_init() and arm_enable_runtime_services() are both
> early_initcall and the calling order is random I think.

Urgh, right, I missed that.

> And when we call xen_efi_runtime_setup() and setup
> efi.runtime_version in xen_guest_init(), the efi.systab might be
> NULL. So it needs to map the systanle explicitly before we use
> efi.systab.

Could you explain why you need to copy efi.runtime_version instead of
letting the existing code in uefi_init() set it up?

Also, efi.systab isn't used by xen_efi_runtime_setup() as far I can
see, not sure why you need that either?

WARNING: multiple messages have this Message-ID (diff)
From: matt@codeblueprint.co.uk (Matt Fleming)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Xen: EFI: Parse DT parameters for Xen specific UEFI
Date: Thu, 12 May 2016 00:24:44 +0100	[thread overview]
Message-ID: <20160511232444.GY2839@codeblueprint.co.uk> (raw)
In-Reply-To: <57333533.2030206@linaro.org>

On Wed, 11 May, at 09:35:47PM, Shannon Zhao wrote:
> > 
> > Also, why do you need to setup efi.runtime_version here? Isn't that
> > done inside uefi_init()?
> > 
> I don't see any codes which setup efi.runtime_version in uefi_init().
 
Look in the EFI tree,

  https://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/tree/drivers/firmware/efi/arm-init.c?h=next#n120

> > Here is how I would have expected this patch to look:
> > 
> >   - Add FDT code to find hypervisor EFI params
> > 
> >   - Force enable EFI_RUNTIME_SERVICES for Xen and call
> >     xen_efi_runtime_setup() inside xen_guest_init()
> > 
> >   - Change arm_enable_runtime_services() to handle the case where
> >     EFI_RUNTIME_SERVICES is already set
> > 
> > Am I misunderstanding some ordering issues?
> 
> Since xen_guest_init() and arm_enable_runtime_services() are both
> early_initcall and the calling order is random I think.

Urgh, right, I missed that.

> And when we call xen_efi_runtime_setup() and setup
> efi.runtime_version in xen_guest_init(), the efi.systab might be
> NULL. So it needs to map the systanle explicitly before we use
> efi.systab.

Could you explain why you need to copy efi.runtime_version instead of
letting the existing code in uefi_init() set it up?

Also, efi.systab isn't used by xen_efi_runtime_setup() as far I can
see, not sure why you need that either?

  reply	other threads:[~2016-05-11 23:24 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06  8:32 [PATCH] Xen: EFI: Parse DT parameters for Xen specific UEFI Shannon Zhao
2016-05-06  8:32 ` Shannon Zhao
2016-05-06  8:32 ` Shannon Zhao
2016-05-06 15:52 ` Mathieu Poirier
2016-05-06 15:52   ` Mathieu Poirier
2016-05-06 15:52   ` Mathieu Poirier
2016-05-11 12:29   ` Matt Fleming
2016-05-11 12:29   ` Matt Fleming
2016-05-11 12:29     ` Matt Fleming
2016-05-11 12:29     ` Matt Fleming
2016-05-06 15:52 ` Mathieu Poirier
2016-05-11 12:27 ` Matt Fleming
2016-05-11 12:27 ` Matt Fleming
2016-05-11 12:27   ` Matt Fleming
2016-05-11 12:27   ` Matt Fleming
2016-05-11 13:35   ` Shannon Zhao
2016-05-11 13:35   ` Shannon Zhao
2016-05-11 13:35     ` Shannon Zhao
2016-05-11 13:35     ` Shannon Zhao
2016-05-11 23:24     ` Matt Fleming [this message]
2016-05-11 23:24       ` Matt Fleming
2016-05-12  2:22       ` Shannon Zhao
2016-05-12  2:22         ` Shannon Zhao
2016-05-12  2:22         ` Shannon Zhao
2016-05-12 10:04         ` Matt Fleming
2016-05-12 10:04           ` Matt Fleming
2016-05-12 10:04           ` Matt Fleming
2016-05-12 10:58           ` Stefano Stabellini
2016-05-12 10:58             ` Stefano Stabellini
2016-05-12 10:58             ` Stefano Stabellini
2016-05-12 10:58           ` Stefano Stabellini
2016-05-12 10:04         ` Matt Fleming
2016-05-12  2:22       ` Shannon Zhao
2016-05-11 23:24     ` Matt Fleming
  -- strict thread matches above, loose matches on Subject: below --
2016-05-06  8:32 Shannon Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160511232444.GY2839@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=julien.grall@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.huangpeng@huawei.com \
    --cc=shannon.zhao@linaro.org \
    --cc=sstabellini@kernel.org \
    --cc=stefano@aporeto.com \
    --cc=will.deacon@arm.com \
    --cc=xen-devel@lists.xen.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.