* [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned'.
@ 2016-05-15 19:45 Amit Ghadge
2016-05-15 22:33 ` Greg KH
2016-05-16 10:33 ` Ian Abbott
0 siblings, 2 replies; 3+ messages in thread
From: Amit Ghadge @ 2016-05-15 19:45 UTC (permalink / raw)
To: abbotti; +Cc: devel, linux-kernel, Amit Ghadge
Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index e9e4313..802f51e 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
outb(0, dev->iobase + DAQP_AUX_REG);
for (i = 0; i > insn->n; i++) {
- unsigned val = data[i];
+ unsigned int val = data[i];
int ret;
/* D/A transfer rate is about 8ms */
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned'.
2016-05-15 19:45 [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned' Amit Ghadge
@ 2016-05-15 22:33 ` Greg KH
2016-05-16 10:33 ` Ian Abbott
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-05-15 22:33 UTC (permalink / raw)
To: Amit Ghadge; +Cc: abbotti, devel, linux-kernel
On Mon, May 16, 2016 at 01:15:24AM +0530, Amit Ghadge wrote:
> Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I can't take a patch without a changelog text in it. Please fix and
resend.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned'.
2016-05-15 19:45 [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned' Amit Ghadge
2016-05-15 22:33 ` Greg KH
@ 2016-05-16 10:33 ` Ian Abbott
1 sibling, 0 replies; 3+ messages in thread
From: Ian Abbott @ 2016-05-16 10:33 UTC (permalink / raw)
To: Amit Ghadge; +Cc: devel, linux-kernel
On 15/05/16 20:45, Amit Ghadge wrote:
> Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index e9e4313..802f51e 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
> outb(0, dev->iobase + DAQP_AUX_REG);
>
> for (i = 0; i > insn->n; i++) {
> - unsigned val = data[i];
> + unsigned int val = data[i];
> int ret;
>
> /* D/A transfer rate is about 8ms */
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-16 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-15 19:45 [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned' Amit Ghadge
2016-05-15 22:33 ` Greg KH
2016-05-16 10:33 ` Ian Abbott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.