[Buildroot] [PATCH v1] uclibc: enable debug build option

[Buildroot] [PATCH v1] uclibc: enable debug build option

[Peter Seiderer]

Set uclibc DODEBUG in case BR2_ENABLE_DEBUG is set.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/uclibc/uclibc.mk | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
index b8ccee2..d68385d 100644
--- a/package/uclibc/uclibc.mk
+++ b/package/uclibc/uclibc.mk
@@ -182,6 +182,15 @@ endef
 endif
 
 #
+# Debug
+#
+ifeq ($(BR2_ENABLE_DEBUG),y)
+define UCLIBC_DEBUG_CONFIG
+	$(call KCONFIG_ENABLE_OPT,DODEBUG=y,$(@D)/.config)
+endef
+endif
+
+#
 # Endianness
 #
 
@@ -394,6 +403,7 @@ define UCLIBC_KCONFIG_FIXUP_CMDS
 	$(UCLIBC_SPARC_TYPE_CONFIG)
 	$(UCLIBC_POWERPC_TYPE_CONFIG)
 	$(UCLIBC_X86_TYPE_CONFIG)
+	$(UCLIBC_DEBUG_CONFIG)
 	$(UCLIBC_ENDIAN_CONFIG)
 	$(UCLIBC_LARGEFILE_CONFIG)
 	$(UCLIBC_IPV6_CONFIG)
-- 
2.8.1

[Buildroot] [PATCH v1] uclibc: enable debug build option

[Arnout Vandecappelle]

On 05/12/16 20:25, Peter Seiderer wrote:
> Set uclibc DODEBUG in case BR2_ENABLE_DEBUG is set.
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

  Regards,
  Arnout

> ---
>  package/uclibc/uclibc.mk | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
> index b8ccee2..d68385d 100644
> --- a/package/uclibc/uclibc.mk
> +++ b/package/uclibc/uclibc.mk
> @@ -182,6 +182,15 @@ endef
>  endif
>
>  #
> +# Debug
> +#
> +ifeq ($(BR2_ENABLE_DEBUG),y)
> +define UCLIBC_DEBUG_CONFIG
> +	$(call KCONFIG_ENABLE_OPT,DODEBUG=y,$(@D)/.config)
> +endef
> +endif
> +
> +#
>  # Endianness
>  #
>
> @@ -394,6 +403,7 @@ define UCLIBC_KCONFIG_FIXUP_CMDS
>  	$(UCLIBC_SPARC_TYPE_CONFIG)
>  	$(UCLIBC_POWERPC_TYPE_CONFIG)
>  	$(UCLIBC_X86_TYPE_CONFIG)
> +	$(UCLIBC_DEBUG_CONFIG)
>  	$(UCLIBC_ENDIAN_CONFIG)
>  	$(UCLIBC_LARGEFILE_CONFIG)
>  	$(UCLIBC_IPV6_CONFIG)
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH v1] uclibc: enable debug build option

[Thomas Petazzoni]

Hello,

On Thu, 12 May 2016 20:25:04 +0200, Peter Seiderer wrote:

>  #
> +# Debug
> +#
> +ifeq ($(BR2_ENABLE_DEBUG),y)
> +define UCLIBC_DEBUG_CONFIG
> +	$(call KCONFIG_ENABLE_OPT,DODEBUG=y,$(@D)/.config)

Has this patch really been tested? Inded, I think this line should be:

	$(call KCONFIG_ENABLE_OPT,DODEBUG,$(@D)/.config)

Indeed, setting =y is done by KCONFIG_ENABLE_OPT.

It is worth mentioning that we used to do exactly this (setting
DODEBUG=y when BR2_ENABLE_DEBUG=y), but removed that in commit
70b7079d3797304fe3c9ba2941d3f446af3cea79in December 2013 because
DODEBUG=y was breaking the build. But since then, uClibc has been
replaced by uClibc-ng and I guess Waldemar has fixed DODEBUG=y.

Peter, did you do a test build on ARM, to verify that you're not
falling into the issue mentioned in commit
70b7079d3797304fe3c9ba2941d3f446af3cea79 ?

In any case, please resend an updated version with the =y removed. I
normally do such minor fixups myself when applying, but in this case, I
really want to be sure that you have done a test build.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v1] uclibc: enable debug build option

[Peter Seiderer]

Hello Thomas,

On Sun, 15 May 2016 21:59:50 +0200, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Hello,
> 
> On Thu, 12 May 2016 20:25:04 +0200, Peter Seiderer wrote:
> 
> >  #
> > +# Debug
> > +#
> > +ifeq ($(BR2_ENABLE_DEBUG),y)
> > +define UCLIBC_DEBUG_CONFIG
> > +	$(call KCONFIG_ENABLE_OPT,DODEBUG=y,$(@D)/.config)
> 
> Has this patch really been tested? Inded, I think this line should be:
> 
> 	$(call KCONFIG_ENABLE_OPT,DODEBUG,$(@D)/.config)
> 
> Indeed, setting =y is done by KCONFIG_ENABLE_OPT.
> 

Yes, seems to work including the typo:

$ diff -u uclibc-1.0.14-config-orig build/uclibc-1.0.14/.config
--- uclibc-1.0.14-config-orig   2016-05-12 20:09:24.612415956 +0200
+++ build/uclibc-1.0.14/.config 2016-05-15 22:20:47.504628970 +0200
@@ -237,13 +237,12 @@
 #
 CROSS_COMPILER_PREFIX="/home/seiderer/Work/zeiss/freescale-imx6/build_rpi_010/host/usr/bin/arm-buildroot-linux-uclibcgnueabihf-"
 UCLIBC_EXTRA_CFLAGS=""
-# DODEBUG is not set
-# DOSTRIP is not set
+DODEBUG=y
 # DOASSERTS is not set
 # SUPPORT_LD_DEBUG is not set
 # SUPPORT_LD_DEBUG_EARLY is not set
 # UCLIBC_MALLOC_DEBUGGING is not set
 # UCLIBC_HAS_BACKTRACE is not set
 WARNINGS="-Wall"
-# EXTRA_WARNINGS is not set
+EXTRA_WARNINGS=y
 # DOMULTI is not set

Will send an updated patch with the typo fixed immediately...

> It is worth mentioning that we used to do exactly this (setting
> DODEBUG=y when BR2_ENABLE_DEBUG=y), but removed that in commit
> 70b7079d3797304fe3c9ba2941d3f446af3cea79in December 2013 because
> DODEBUG=y was breaking the build. But since then, uClibc has been
> replaced by uClibc-ng and I guess Waldemar has fixed DODEBUG=y.
> 
> Peter, did you do a test build on ARM, to verify that you're not
> falling into the issue mentioned in commit
> 70b7079d3797304fe3c9ba2941d3f446af3cea79 ?
> 

Was not aware of the history, but I did compile test the patch with
raspberrypi3_defconfig and additional BR2_ENABLE_DEBUG=y
 
> In any case, please resend an updated version with the =y removed. I
> normally do such minor fixups myself when applying, but in this case, I
> really want to be sure that you have done a test build.
> 

Thanks for spotting the typo, updated patch follows...

Regards,
Peter

> Thanks!
> 
> Thomas