From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: brouer@redhat.com, dave.taht@gmail.com, netdev@vger.kernel.org,
moeller0@gmx.de
Subject: Re: [PATCH net-next] fq_codel: fix memory limitation drift
Date: Mon, 16 May 2016 21:57:03 -0400 (EDT) [thread overview]
Message-ID: <20160516.215703.1101489106168609896.davem@davemloft.net> (raw)
In-Reply-To: <1463361398.18194.62.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 15 May 2016 18:16:38 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> memory_usage must be decreased in dequeue_func(), not in
> fq_codel_dequeue(), otherwise packets dropped by Codel algo
> are missing this decrease.
>
> Also we need to clear memory_usage in fq_codel_reset()
>
> Fixes: 95b58430abe7 ("fq_codel: add memory limitation per queue")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
next prev parent reply other threads:[~2016-05-17 1:57 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-01 3:41 fq_codel_drop vs a udp flood Dave Taht
2016-05-01 4:46 ` [Make-wifi-fast] " Jonathan Morton
2016-05-01 5:08 ` Ben Greear
2016-05-01 5:23 ` Dave Taht
2016-05-01 14:47 ` [Make-wifi-fast] " dpreed
2016-05-02 14:03 ` Roman Yeryomin
2016-05-02 18:40 ` Dave Taht
2016-05-05 13:55 ` Roman Yeryomin
2016-05-05 14:55 ` Roman Yeryomin
2016-05-02 19:47 ` David Lang
2016-05-01 17:59 ` [Codel] " Eric Dumazet
2016-05-01 18:20 ` Jonathan Morton
2016-05-01 18:46 ` Eric Dumazet
2016-05-01 19:55 ` Eric Dumazet
2016-05-02 7:47 ` Jesper Dangaard Brouer
2016-05-01 20:35 ` Jonathan Morton
2016-05-01 20:55 ` Eric Dumazet
2016-05-02 14:18 ` Roman Yeryomin
2016-05-02 15:07 ` Eric Dumazet
2016-05-02 15:43 ` Roman Yeryomin
2016-05-02 16:14 ` Eric Dumazet
2016-05-02 17:08 ` Dave Taht
2016-05-02 17:44 ` Eric Dumazet
2016-05-05 14:32 ` Roman Yeryomin
2016-05-05 14:53 ` Roman Yeryomin
2016-05-05 15:32 ` Dave Taht
2016-05-05 16:07 ` Roman Yeryomin
2016-05-05 16:59 ` Jonathan Morton
2016-05-05 17:39 ` Roman Yeryomin
2016-05-05 18:16 ` Dave Taht
2016-05-05 18:33 ` Dave Taht
2016-05-05 16:12 ` Eric Dumazet
2016-05-05 16:25 ` Roman Yeryomin
2016-05-05 16:42 ` Roman Yeryomin
2016-05-06 10:55 ` Roman Yeryomin
2016-05-05 19:23 ` Eric Dumazet
2016-05-05 19:41 ` Dave Taht
2016-05-06 8:41 ` moeller0
2016-05-06 11:33 ` Jesper Dangaard Brouer
2016-05-06 11:46 ` moeller0
2016-05-06 13:25 ` Eric Dumazet
2016-05-06 15:25 ` moeller0
2016-05-06 15:58 ` Eric Dumazet
2016-05-06 16:30 ` moeller0
2016-05-06 15:55 ` [PATCH net-next] fq_codel: add memory limitation per queue Eric Dumazet
2016-05-09 3:49 ` David Miller
2016-05-09 4:14 ` Cong Wang
2016-05-09 4:31 ` Eric Dumazet
2016-05-09 5:07 ` Cong Wang
2016-05-09 14:26 ` Eric Dumazet
2016-05-10 4:34 ` Cong Wang
2016-05-10 4:45 ` Eric Dumazet
2016-05-10 4:57 ` Cong Wang
2016-05-10 5:10 ` Eric Dumazet
2016-05-16 1:16 ` [PATCH net-next] fq_codel: fix memory limitation drift Eric Dumazet
2016-05-17 1:57 ` David Miller [this message]
2016-05-06 9:42 ` OpenWRT wrong adjustment of fq_codel defaults (Was: fq_codel_drop vs a udp flood) Jesper Dangaard Brouer
2016-05-06 9:42 ` OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Jesper Dangaard Brouer
2016-05-06 12:47 ` OpenWRT wrong adjustment of fq_codel defaults (Was: " Jesper Dangaard Brouer
2016-05-06 12:47 ` OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Jesper Dangaard Brouer
2016-05-06 18:43 ` OpenWRT wrong adjustment of fq_codel defaults (Was: " Roman Yeryomin
2016-05-06 18:43 ` OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Roman Yeryomin
2016-05-06 18:56 ` OpenWRT wrong adjustment of fq_codel defaults (Was: " Roman Yeryomin
2016-05-06 18:56 ` OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Roman Yeryomin
2016-05-06 19:43 ` OpenWRT wrong adjustment of fq_codel defaults (Was: " Dave Taht
2016-05-06 19:43 ` OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Dave Taht
2016-05-15 22:34 ` OpenWRT wrong adjustment of fq_codel defaults (Was: " Roman Yeryomin
2016-05-15 22:34 ` OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Roman Yeryomin
2016-05-15 23:07 ` OpenWRT wrong adjustment of fq_codel defaults (Was: " Eric Dumazet
2016-05-15 23:07 ` OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Eric Dumazet
2016-05-15 23:27 ` OpenWRT wrong adjustment of fq_codel defaults (Was: " Roman Yeryomin
2016-05-15 23:27 ` OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Roman Yeryomin
2016-05-16 8:12 ` [Make-wifi-fast] OpenWRT wrong adjustment of fq_codel defaults (Was: " David Lang
2016-05-16 8:12 ` [Make-wifi-fast] OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " David Lang
2016-05-16 8:26 ` Roman Yeryomin
2016-05-16 8:26 ` Roman Yeryomin
2016-05-16 8:46 ` [Make-wifi-fast] OpenWRT wrong adjustment of fq_codel defaults (Was: " David Lang
2016-05-16 8:46 ` [Make-wifi-fast] OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " David Lang
2016-05-16 10:34 ` [OpenWrt-Devel] [Make-wifi-fast] OpenWRT wrong adjustment of fq_codel defaults (Was: " Sebastian Moeller
2016-05-16 10:34 ` [OpenWrt-Devel] [Make-wifi-fast] OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Sebastian Moeller
2016-05-16 8:14 ` OpenWRT wrong adjustment of fq_codel defaults (Was: " Roman Yeryomin
2016-05-16 8:14 ` OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Roman Yeryomin
2016-05-16 14:23 ` [Make-wifi-fast] OpenWRT wrong adjustment of fq_codel defaults (Was: " Eric Dumazet
2016-05-16 14:23 ` [Make-wifi-fast] OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Eric Dumazet
2016-05-16 16:04 ` Dave Taht
2016-05-16 16:04 ` Dave Taht
2016-05-16 19:46 ` OpenWRT wrong adjustment of fq_codel defaults (Was: " Roman Yeryomin
2016-05-16 19:46 ` OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Roman Yeryomin
2016-05-07 9:57 ` Kevin Darbyshire-Bryant
2016-05-15 22:47 ` Roman Yeryomin
2016-05-15 22:47 ` Roman Yeryomin
2016-05-03 2:26 ` [Codel] fq_codel_drop vs a udp flood Dave Taht
2016-05-03 5:21 ` Dave Taht
2016-05-03 12:39 ` Agarwal, Anil
2016-05-03 12:50 ` Agarwal, Anil
2016-05-03 13:35 ` Eric Dumazet
2016-05-03 15:37 ` Agarwal, Anil
2016-05-03 17:37 ` Dave Taht
2016-05-03 17:54 ` Eric Dumazet
2016-05-03 18:11 ` Dave Taht
2016-05-03 13:20 ` Kevin Darbyshire-Bryant
2016-05-01 18:26 ` Dave Taht
2016-05-01 22:30 ` Eric Dumazet
2016-05-02 14:09 ` Roman Yeryomin
2016-05-02 15:04 ` Eric Dumazet
2016-05-02 15:42 ` Roman Yeryomin
2016-05-02 13:47 ` [Make-wifi-fast] " Roman Yeryomin
2016-05-02 15:01 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516.215703.1101489106168609896.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=dave.taht@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=moeller0@gmx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.