All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pcmcia: cm4040 remove KERN_INFO as it is not at start of printk message
@ 2016-05-16 12:12 Colin King
  2016-05-16 14:06 ` Harald Welte
  0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-05-16 12:12 UTC (permalink / raw)
  To: Harald Welte; +Cc: linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The debug is being printed using DEBUGP which prepends the string
with and so the KERN_INFO text should not be included.  Also remove the
MODULE_NAME to keep this consistent with other DEBUGP debug messages.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/char/pcmcia/cm4040_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/pcmcia/cm4040_cs.c b/drivers/char/pcmcia/cm4040_cs.c
index fc061f7..4a606f1 100644
--- a/drivers/char/pcmcia/cm4040_cs.c
+++ b/drivers/char/pcmcia/cm4040_cs.c
@@ -506,7 +506,7 @@ static void cm4040_reader_release(struct pcmcia_device *link)
 
 	DEBUGP(3, dev, "-> cm4040_reader_release\n");
 	while (link->open) {
-		DEBUGP(3, dev, KERN_INFO MODULE_NAME ": delaying release "
+		DEBUGP(3, dev, "delaying release "
 		       "until process has terminated\n");
  		wait_event(dev->devq, (link->open == 0));
 	}
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] pcmcia: cm4040 remove KERN_INFO as it is not at start of printk message
  2016-05-16 12:12 [PATCH] pcmcia: cm4040 remove KERN_INFO as it is not at start of printk message Colin King
@ 2016-05-16 14:06 ` Harald Welte
  0 siblings, 0 replies; 2+ messages in thread
From: Harald Welte @ 2016-05-16 14:06 UTC (permalink / raw)
  To: Colin King; +Cc: linux-kernel

Hi Colin,

the fix is obviously correct, but still for a matter of the record:

Acked-by: Harald Welte <laforge@gnumonks.org>

-- 
- Harald Welte <laforge@gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-16 14:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-16 12:12 [PATCH] pcmcia: cm4040 remove KERN_INFO as it is not at start of printk message Colin King
2016-05-16 14:06 ` Harald Welte

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.