[PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Raghav Dogra]

The new IFC controller version 2.0 has a different memory map page.
Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
This patch segregates the IFC global and runtime registers to appropriate
PAGE sizes.

Signed-off-by: Jaiprakash Singh <b44839@freescale.com>
Signed-off-by: Raghav Dogra <raghav@freescale.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
---
Changes for v3: not dependent on 
"drivers/memory: Add deep sleep support for IFC" patch

Changes for v2: rebased to resolve conflicts
Applicable to git://git.infradead.org/l2-mtd.git

This patch is dependent on "drivers/memory: Add deep sleep support for IFC"
https://patchwork.ozlabs.org/patch/582762/
which is also applicable to git://git.infradead.org/l2-mtd.git

This patch is the new version of following patch with changed title:
https://patchwork.ozlabs.org/patch/557391/

 drivers/memory/fsl_ifc.c        | 36 ++++++++++-----------
 drivers/mtd/nand/fsl_ifc_nand.c | 72 ++++++++++++++++++++++-------------------
 include/linux/fsl_ifc.h         | 45 +++++++++++++++++---------
 3 files changed, 87 insertions(+), 66 deletions(-)

diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c
index 2a691da..904b4af 100644
--- a/drivers/memory/fsl_ifc.c
+++ b/drivers/memory/fsl_ifc.c
@@ -59,11 +59,11 @@ int fsl_ifc_find(phys_addr_t addr_base)
 {
 	int i = 0;
 
-	if (!fsl_ifc_ctrl_dev || !fsl_ifc_ctrl_dev->regs)
+	if (!fsl_ifc_ctrl_dev || !fsl_ifc_ctrl_dev->gregs)
 		return -ENODEV;
 
 	for (i = 0; i < fsl_ifc_ctrl_dev->banks; i++) {
-		u32 cspr = ifc_in32(&fsl_ifc_ctrl_dev->regs->cspr_cs[i].cspr);
+		u32 cspr = ifc_in32(&fsl_ifc_ctrl_dev->gregs->cspr_cs[i].cspr);
 		if (cspr & CSPR_V && (cspr & CSPR_BA) ==
 				convert_ifc_address(addr_base))
 			return i;
@@ -75,7 +75,7 @@ EXPORT_SYMBOL(fsl_ifc_find);
 
 static int fsl_ifc_ctrl_init(struct fsl_ifc_ctrl *ctrl)
 {
-	struct fsl_ifc_regs __iomem *ifc = ctrl->regs;
+	struct fsl_ifc_global __iomem *ifc = ctrl->gregs;
 
 	/*
 	 * Clear all the common status and event registers
@@ -104,7 +104,7 @@ static int fsl_ifc_ctrl_remove(struct platform_device *dev)
 	irq_dispose_mapping(ctrl->nand_irq);
 	irq_dispose_mapping(ctrl->irq);
 
-	iounmap(ctrl->regs);
+	iounmap(ctrl->gregs);
 
 	dev_set_drvdata(&dev->dev, NULL);
 	kfree(ctrl);
@@ -122,7 +122,7 @@ static DEFINE_SPINLOCK(nand_irq_lock);
 
 static u32 check_nand_stat(struct fsl_ifc_ctrl *ctrl)
 {
-	struct fsl_ifc_regs __iomem *ifc = ctrl->regs;
+	struct fsl_ifc_runtime __iomem *ifc = ctrl->rregs;
 	unsigned long flags;
 	u32 stat;
 
@@ -157,7 +157,7 @@ static irqreturn_t fsl_ifc_nand_irq(int irqno, void *data)
 static irqreturn_t fsl_ifc_ctrl_irq(int irqno, void *data)
 {
 	struct fsl_ifc_ctrl *ctrl = data;
-	struct fsl_ifc_regs __iomem *ifc = ctrl->regs;
+	struct fsl_ifc_global __iomem *ifc = ctrl->gregs;
 	u32 err_axiid, err_srcid, status, cs_err, err_addr;
 	irqreturn_t ret = IRQ_NONE;
 
@@ -215,6 +215,7 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev)
 {
 	int ret = 0;
 	int version, banks;
+	void __iomem *addr;
 
 	dev_info(&dev->dev, "Freescale Integrated Flash Controller\n");
 
@@ -225,22 +226,13 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev)
 	dev_set_drvdata(&dev->dev, fsl_ifc_ctrl_dev);
 
 	/* IOMAP the entire IFC region */
-	fsl_ifc_ctrl_dev->regs = of_iomap(dev->dev.of_node, 0);
-	if (!fsl_ifc_ctrl_dev->regs) {
+	fsl_ifc_ctrl_dev->gregs = of_iomap(dev->dev.of_node, 0);
+	if (!fsl_ifc_ctrl_dev->gregs) {
 		dev_err(&dev->dev, "failed to get memory region\n");
 		ret = -ENODEV;
 		goto err;
 	}
 
-	version = ifc_in32(&fsl_ifc_ctrl_dev->regs->ifc_rev) &
-			FSL_IFC_VERSION_MASK;
-	banks = (version == FSL_IFC_VERSION_1_0_0) ? 4 : 8;
-	dev_info(&dev->dev, "IFC version %d.%d, %d banks\n",
-		version >> 24, (version >> 16) & 0xf, banks);
-
-	fsl_ifc_ctrl_dev->version = version;
-	fsl_ifc_ctrl_dev->banks = banks;
-
 	if (of_property_read_bool(dev->dev.of_node, "little-endian")) {
 		fsl_ifc_ctrl_dev->little_endian = true;
 		dev_dbg(&dev->dev, "IFC REGISTERS are LITTLE endian\n");
@@ -249,8 +241,9 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev)
 		dev_dbg(&dev->dev, "IFC REGISTERS are BIG endian\n");
 	}
 
-	version = ioread32be(&fsl_ifc_ctrl_dev->regs->ifc_rev) &
+	version = ifc_in32(&fsl_ifc_ctrl_dev->gregs->ifc_rev) &
 			FSL_IFC_VERSION_MASK;
+
 	banks = (version == FSL_IFC_VERSION_1_0_0) ? 4 : 8;
 	dev_info(&dev->dev, "IFC version %d.%d, %d banks\n",
 		version >> 24, (version >> 16) & 0xf, banks);
@@ -258,6 +251,13 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev)
 	fsl_ifc_ctrl_dev->version = version;
 	fsl_ifc_ctrl_dev->banks = banks;
 
+	addr = fsl_ifc_ctrl_dev->gregs;
+	if (version >= FSL_IFC_VERSION_2_0_0)
+		addr += PGOFFSET_64K;
+	else
+		addr += PGOFFSET_4K;
+	fsl_ifc_ctrl_dev->rregs = addr;
+
 	/* get the Controller level irq */
 	fsl_ifc_ctrl_dev->irq = irq_of_parse_and_map(dev->dev.of_node, 0);
 	if (fsl_ifc_ctrl_dev->irq == 0) {
diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
index 43f5a3a..f8a016f 100644
--- a/drivers/mtd/nand/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/fsl_ifc_nand.c
@@ -232,7 +232,7 @@ static void set_addr(struct mtd_info *mtd, int column, int page_addr, int oob)
 	struct nand_chip *chip = mtd_to_nand(mtd);
 	struct fsl_ifc_mtd *priv = nand_get_controller_data(chip);
 	struct fsl_ifc_ctrl *ctrl = priv->ctrl;
-	struct fsl_ifc_regs __iomem *ifc = ctrl->regs;
+	struct fsl_ifc_runtime __iomem *ifc = ctrl->rregs;
 	int buf_num;
 
 	ifc_nand_ctrl->page = page_addr;
@@ -295,7 +295,7 @@ static void fsl_ifc_run_command(struct mtd_info *mtd)
 	struct fsl_ifc_mtd *priv = nand_get_controller_data(chip);
 	struct fsl_ifc_ctrl *ctrl = priv->ctrl;
 	struct fsl_ifc_nand_ctrl *nctrl = ifc_nand_ctrl;
-	struct fsl_ifc_regs __iomem *ifc = ctrl->regs;
+	struct fsl_ifc_runtime __iomem *ifc = ctrl->rregs;
 	u32 eccstat[4];
 	int i;
 
@@ -371,7 +371,7 @@ static void fsl_ifc_do_read(struct nand_chip *chip,
 {
 	struct fsl_ifc_mtd *priv = nand_get_controller_data(chip);
 	struct fsl_ifc_ctrl *ctrl = priv->ctrl;
-	struct fsl_ifc_regs __iomem *ifc = ctrl->regs;
+	struct fsl_ifc_runtime __iomem *ifc = ctrl->rregs;
 
 	/* Program FIR/IFC_NAND_FCR0 for Small/Large page */
 	if (mtd->writesize > 512) {
@@ -411,7 +411,7 @@ static void fsl_ifc_cmdfunc(struct mtd_info *mtd, unsigned int command,
 	struct nand_chip *chip = mtd_to_nand(mtd);
 	struct fsl_ifc_mtd *priv = nand_get_controller_data(chip);
 	struct fsl_ifc_ctrl *ctrl = priv->ctrl;
-	struct fsl_ifc_regs __iomem *ifc = ctrl->regs;
+	struct fsl_ifc_runtime __iomem *ifc = ctrl->rregs;
 
 	/* clear the read buffer */
 	ifc_nand_ctrl->read_bytes = 0;
@@ -723,7 +723,7 @@ static int fsl_ifc_wait(struct mtd_info *mtd, struct nand_chip *chip)
 {
 	struct fsl_ifc_mtd *priv = nand_get_controller_data(chip);
 	struct fsl_ifc_ctrl *ctrl = priv->ctrl;
-	struct fsl_ifc_regs __iomem *ifc = ctrl->regs;
+	struct fsl_ifc_runtime __iomem *ifc = ctrl->rregs;
 	u32 nand_fsr;
 
 	/* Use READ_STATUS command, but wait for the device to be ready */
@@ -825,39 +825,42 @@ static int fsl_ifc_chip_init_tail(struct mtd_info *mtd)
 static void fsl_ifc_sram_init(struct fsl_ifc_mtd *priv)
 {
 	struct fsl_ifc_ctrl *ctrl = priv->ctrl;
-	struct fsl_ifc_regs __iomem *ifc = ctrl->regs;
+	struct fsl_ifc_runtime __iomem *ifc_runtime = ctrl->rregs;
+	struct fsl_ifc_global __iomem *ifc_global = ctrl->gregs;
 	uint32_t csor = 0, csor_8k = 0, csor_ext = 0;
 	uint32_t cs = priv->bank;
 
 	/* Save CSOR and CSOR_ext */
-	csor = ifc_in32(&ifc->csor_cs[cs].csor);
-	csor_ext = ifc_in32(&ifc->csor_cs[cs].csor_ext);
+	csor = ifc_in32(&ifc_global->csor_cs[cs].csor);
+	csor_ext = ifc_in32(&ifc_global->csor_cs[cs].csor_ext);
 
 	/* chage PageSize 8K and SpareSize 1K*/
 	csor_8k = (csor & ~(CSOR_NAND_PGS_MASK)) | 0x0018C000;
-	ifc_out32(csor_8k, &ifc->csor_cs[cs].csor);
-	ifc_out32(0x0000400, &ifc->csor_cs[cs].csor_ext);
+	ifc_out32(csor_8k, &ifc_global->csor_cs[cs].csor);
+	ifc_out32(0x0000400, &ifc_global->csor_cs[cs].csor_ext);
 
 	/* READID */
 	ifc_out32((IFC_FIR_OP_CW0 << IFC_NAND_FIR0_OP0_SHIFT) |
-		  (IFC_FIR_OP_UA  << IFC_NAND_FIR0_OP1_SHIFT) |
-		  (IFC_FIR_OP_RB << IFC_NAND_FIR0_OP2_SHIFT),
-		  &ifc->ifc_nand.nand_fir0);
+		    (IFC_FIR_OP_UA  << IFC_NAND_FIR0_OP1_SHIFT) |
+		    (IFC_FIR_OP_RB << IFC_NAND_FIR0_OP2_SHIFT),
+		    &ifc_runtime->ifc_nand.nand_fir0);
 	ifc_out32(NAND_CMD_READID << IFC_NAND_FCR0_CMD0_SHIFT,
-		  &ifc->ifc_nand.nand_fcr0);
-	ifc_out32(0x0, &ifc->ifc_nand.row3);
+		    &ifc_runtime->ifc_nand.nand_fcr0);
+	ifc_out32(0x0, &ifc_runtime->ifc_nand.row3);
 
-	ifc_out32(0x0, &ifc->ifc_nand.nand_fbcr);
+	ifc_out32(0x0, &ifc_runtime->ifc_nand.nand_fbcr);
 
 	/* Program ROW0/COL0 */
-	ifc_out32(0x0, &ifc->ifc_nand.row0);
-	ifc_out32(0x0, &ifc->ifc_nand.col0);
+	ifc_out32(0x0, &ifc_runtime->ifc_nand.row0);
+	ifc_out32(0x0, &ifc_runtime->ifc_nand.col0);
 
 	/* set the chip select for NAND Transaction */
-	ifc_out32(cs << IFC_NAND_CSEL_SHIFT, &ifc->ifc_nand.nand_csel);
+	ifc_out32(cs << IFC_NAND_CSEL_SHIFT,
+		&ifc_runtime->ifc_nand.nand_csel);
 
 	/* start read seq */
-	ifc_out32(IFC_NAND_SEQ_STRT_FIR_STRT, &ifc->ifc_nand.nandseq_strt);
+	ifc_out32(IFC_NAND_SEQ_STRT_FIR_STRT,
+		&ifc_runtime->ifc_nand.nandseq_strt);
 
 	/* wait for command complete flag or timeout */
 	wait_event_timeout(ctrl->nand_wait, ctrl->nand_stat,
@@ -867,14 +870,15 @@ static void fsl_ifc_sram_init(struct fsl_ifc_mtd *priv)
 		printk(KERN_ERR "fsl-ifc: Failed to Initialise SRAM\n");
 
 	/* Restore CSOR and CSOR_ext */
-	ifc_out32(csor, &ifc->csor_cs[cs].csor);
-	ifc_out32(csor_ext, &ifc->csor_cs[cs].csor_ext);
+	ifc_out32(csor, &ifc_global->csor_cs[cs].csor);
+	ifc_out32(csor_ext, &ifc_global->csor_cs[cs].csor_ext);
 }
 
 static int fsl_ifc_chip_init(struct fsl_ifc_mtd *priv)
 {
 	struct fsl_ifc_ctrl *ctrl = priv->ctrl;
-	struct fsl_ifc_regs __iomem *ifc = ctrl->regs;
+	struct fsl_ifc_global __iomem *ifc_global = ctrl->gregs;
+	struct fsl_ifc_runtime __iomem *ifc_runtime = ctrl->rregs;
 	struct nand_chip *chip = &priv->chip;
 	struct mtd_info *mtd = nand_to_mtd(&priv->chip);
 	struct nand_ecclayout *layout;
@@ -886,7 +890,8 @@ static int fsl_ifc_chip_init(struct fsl_ifc_mtd *priv)
 
 	/* fill in nand_chip structure */
 	/* set up function call table */
-	if ((ifc_in32(&ifc->cspr_cs[priv->bank].cspr)) & CSPR_PORT_SIZE_16)
+	if ((ifc_in32(&ifc_global->cspr_cs[priv->bank].cspr))
+		& CSPR_PORT_SIZE_16)
 		chip->read_byte = fsl_ifc_read_byte16;
 	else
 		chip->read_byte = fsl_ifc_read_byte;
@@ -900,13 +905,14 @@ static int fsl_ifc_chip_init(struct fsl_ifc_mtd *priv)
 	chip->bbt_td = &bbt_main_descr;
 	chip->bbt_md = &bbt_mirror_descr;
 
-	ifc_out32(0x0, &ifc->ifc_nand.ncfgr);
+	ifc_out32(0x0, &ifc_runtime->ifc_nand.ncfgr);
 
 	/* set up nand options */
 	chip->bbt_options = NAND_BBT_USE_FLASH;
 	chip->options = NAND_NO_SUBPAGE_WRITE;
 
-	if (ifc_in32(&ifc->cspr_cs[priv->bank].cspr) & CSPR_PORT_SIZE_16) {
+	if (ifc_in32(&ifc_global->cspr_cs[priv->bank].cspr)
+		& CSPR_PORT_SIZE_16) {
 		chip->read_byte = fsl_ifc_read_byte16;
 		chip->options |= NAND_BUSWIDTH_16;
 	} else {
@@ -919,7 +925,7 @@ static int fsl_ifc_chip_init(struct fsl_ifc_mtd *priv)
 	chip->ecc.read_page = fsl_ifc_read_page;
 	chip->ecc.write_page = fsl_ifc_write_page;
 
-	csor = ifc_in32(&ifc->csor_cs[priv->bank].csor);
+	csor = ifc_in32(&ifc_global->csor_cs[priv->bank].csor);
 
 	/* Hardware generates ECC per 512 Bytes */
 	chip->ecc.size = 512;
@@ -1007,10 +1013,10 @@ static int fsl_ifc_chip_remove(struct fsl_ifc_mtd *priv)
 	return 0;
 }
 
-static int match_bank(struct fsl_ifc_regs __iomem *ifc, int bank,
+static int match_bank(struct fsl_ifc_global __iomem *ifc_global, int bank,
 		      phys_addr_t addr)
 {
-	u32 cspr = ifc_in32(&ifc->cspr_cs[bank].cspr);
+	u32 cspr = ifc_in32(&ifc_global->cspr_cs[bank].cspr);
 
 	if (!(cspr & CSPR_V))
 		return 0;
@@ -1024,7 +1030,7 @@ static DEFINE_MUTEX(fsl_ifc_nand_mutex);
 
 static int fsl_ifc_nand_probe(struct platform_device *dev)
 {
-	struct fsl_ifc_regs __iomem *ifc;
+	struct fsl_ifc_runtime __iomem *ifc;
 	struct fsl_ifc_mtd *priv;
 	struct resource res;
 	static const char *part_probe_types[]
@@ -1034,9 +1040,9 @@ static int fsl_ifc_nand_probe(struct platform_device *dev)
 	struct device_node *node = dev->dev.of_node;
 	struct mtd_info *mtd;
 
-	if (!fsl_ifc_ctrl_dev || !fsl_ifc_ctrl_dev->regs)
+	if (!fsl_ifc_ctrl_dev || !fsl_ifc_ctrl_dev->rregs)
 		return -ENODEV;
-	ifc = fsl_ifc_ctrl_dev->regs;
+	ifc = fsl_ifc_ctrl_dev->rregs;
 
 	/* get, allocate and map the memory resource */
 	ret = of_address_to_resource(node, 0, &res);
@@ -1047,7 +1053,7 @@ static int fsl_ifc_nand_probe(struct platform_device *dev)
 
 	/* find which chip select it is connected to */
 	for (bank = 0; bank < fsl_ifc_ctrl_dev->banks; bank++) {
-		if (match_bank(ifc, bank, res.start))
+		if (match_bank(fsl_ifc_ctrl_dev->gregs, bank, res.start))
 			break;
 	}
 
diff --git a/include/linux/fsl_ifc.h b/include/linux/fsl_ifc.h
index 0023088..3f9778c 100644
--- a/include/linux/fsl_ifc.h
+++ b/include/linux/fsl_ifc.h
@@ -39,6 +39,10 @@
 #define FSL_IFC_VERSION_MASK	0x0F0F0000
 #define FSL_IFC_VERSION_1_0_0	0x01000000
 #define FSL_IFC_VERSION_1_1_0	0x01010000
+#define FSL_IFC_VERSION_2_0_0	0x02000000
+
+#define PGOFFSET_64K	(64*1024)
+#define PGOFFSET_4K	(4*1024)
 
 /*
  * CSPR - Chip Select Property Register
@@ -723,20 +727,26 @@ struct fsl_ifc_nand {
 	__be32 nand_evter_en;
 	u32 res17[0x2];
 	__be32 nand_evter_intr_en;
-	u32 res18[0x2];
+	__be32 nand_vol_addr_stat;
+	u32 res18;
 	__be32 nand_erattr0;
 	__be32 nand_erattr1;
 	u32 res19[0x10];
 	__be32 nand_fsr;
-	u32 res20;
-	__be32 nand_eccstat[4];
-	u32 res21[0x20];
+	u32 res20[0x3];
+	__be32 nand_eccstat[6];
+	u32 res21[0x1c];
 	__be32 nanndcr;
 	u32 res22[0x2];
 	__be32 nand_autoboot_trgr;
 	u32 res23;
 	__be32 nand_mdr;
-	u32 res24[0x5C];
+	u32 res24[0x1C];
+	__be32 nand_dll_lowcfg0;
+	__be32 nand_dll_lowcfg1;
+	u32 res25;
+	__be32 nand_dll_lowstat;
+	u32 res26[0x3c];
 };
 
 /*
@@ -771,13 +781,12 @@ struct fsl_ifc_gpcm {
 	__be32 gpcm_erattr1;
 	__be32 gpcm_erattr2;
 	__be32 gpcm_stat;
-	u32 res4[0x1F3];
 };
 
 /*
  * IFC Controller Registers
  */
-struct fsl_ifc_regs {
+struct fsl_ifc_global {
 	__be32 ifc_rev;
 	u32 res1[0x2];
 	struct {
@@ -803,21 +812,26 @@ struct fsl_ifc_regs {
 	} ftim_cs[FSL_IFC_BANK_COUNT];
 	u32 res9[0x30];
 	__be32 rb_stat;
-	u32 res10[0x2];
+	__be32 rb_map;
+	__be32 wb_map;
 	__be32 ifc_gcr;
-	u32 res11[0x2];
+	u32 res10[0x2];
 	__be32 cm_evter_stat;
-	u32 res12[0x2];
+	u32 res11[0x2];
 	__be32 cm_evter_en;
-	u32 res13[0x2];
+	u32 res12[0x2];
 	__be32 cm_evter_intr_en;
-	u32 res14[0x2];
+	u32 res13[0x2];
 	__be32 cm_erattr0;
 	__be32 cm_erattr1;
-	u32 res15[0x2];
+	u32 res14[0x2];
 	__be32 ifc_ccr;
 	__be32 ifc_csr;
-	u32 res16[0x2EB];
+	__be32 ddr_ccr_low;
+};
+
+
+struct fsl_ifc_runtime {
 	struct fsl_ifc_nand ifc_nand;
 	struct fsl_ifc_nor ifc_nor;
 	struct fsl_ifc_gpcm ifc_gpcm;
@@ -831,7 +845,8 @@ extern int fsl_ifc_find(phys_addr_t addr_base);
 struct fsl_ifc_ctrl {
 	/* device info */
 	struct device			*dev;
-	struct fsl_ifc_regs __iomem	*regs;
+	struct fsl_ifc_global __iomem	*gregs;
+	struct fsl_ifc_runtime __iomem	*rregs;
 	int				irq;
 	int				nand_irq;
 	spinlock_t			lock;
-- 
1.9.1

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Scott Wood]

On Wed, 2016-02-17 at 16:54 +0530, Raghav Dogra wrote:
> The new IFC controller version 2.0 has a different memory map page.
> Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
> This patch segregates the IFC global and runtime registers to appropriate
> PAGE sizes.
> 
> Signed-off-by: Jaiprakash Singh <b44839@freescale.com>
> Signed-off-by: Raghav Dogra <raghav@freescale.com>
> Acked-by: Li Yang <leoyang.li@nxp.com>
> Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
> ---
> Changes for v3: not dependent on 
> "drivers/memory: Add deep sleep support for IFC" patch
> 
> Changes for v2: rebased to resolve conflicts
> Applicable to git://git.infradead.org/l2-mtd.git
> 
> This patch is dependent on "drivers/memory: Add deep sleep support for IFC"
> https://patchwork.ozlabs.org/patch/582762/
> which is also applicable to git://git.infradead.org/l2-mtd.git
> 
> This patch is the new version of following patch with changed title:
> https://patchwork.ozlabs.org/patch/557391/
> 
>  drivers/memory/fsl_ifc.c        | 36 ++++++++++-----------
>  drivers/mtd/nand/fsl_ifc_nand.c | 72 ++++++++++++++++++++++----------------
> ---
>  include/linux/fsl_ifc.h         | 45 +++++++++++++++++---------
>  3 files changed, 87 insertions(+), 66 deletions(-)

Acked-by: Scott Wood <oss@buserror.net>

-Scott

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Leo Li]

On Wed, Feb 17, 2016 at 5:24 AM, Raghav Dogra <raghav.dogra@nxp.com> wrote:
> The new IFC controller version 2.0 has a different memory map page.
> Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
> This patch segregates the IFC global and runtime registers to appropriate
> PAGE sizes.
>
> Signed-off-by: Jaiprakash Singh <b44839@freescale.com>
> Signed-off-by: Raghav Dogra <raghav@freescale.com>
> Acked-by: Li Yang <leoyang.li@nxp.com>
> Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
> ---
> Changes for v3: not dependent on
> "drivers/memory: Add deep sleep support for IFC" patch
>
> Changes for v2: rebased to resolve conflicts
> Applicable to git://git.infradead.org/l2-mtd.git
>
> This patch is dependent on "drivers/memory: Add deep sleep support for IFC"
> https://patchwork.ozlabs.org/patch/582762/
> which is also applicable to git://git.infradead.org/l2-mtd.git

This patch seems to be in good shape, but the dependency is still
having quite some feedback to be addressed.  Depending on it will
greatly delay the time that this critical patch for LS2 to be merged.
Could you remove the dependency like Scott already suggested?

Regards,
Leo

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Scott Wood]

On Thu, 2016-02-18 at 15:18 -0600, Leo Li wrote:
> On Wed, Feb 17, 2016 at 5:24 AM, Raghav Dogra <raghav.dogra@nxp.com> wrote:
> > The new IFC controller version 2.0 has a different memory map page.
> > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
> > This patch segregates the IFC global and runtime registers to appropriate
> > PAGE sizes.
> > 
> > Signed-off-by: Jaiprakash Singh <b44839@freescale.com>
> > Signed-off-by: Raghav Dogra <raghav@freescale.com>
> > Acked-by: Li Yang <leoyang.li@nxp.com>
> > Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
> > ---
> > Changes for v3: not dependent on
> > "drivers/memory: Add deep sleep support for IFC" patch
> > 
> > Changes for v2: rebased to resolve conflicts
> > Applicable to git://git.infradead.org/l2-mtd.git
> > 
> > This patch is dependent on "drivers/memory: Add deep sleep support for
> > IFC"
> > https://patchwork.ozlabs.org/patch/582762/
> > which is also applicable to git://git.infradead.org/l2-mtd.git
> 
> This patch seems to be in good shape, but the dependency is still
> having quite some feedback to be addressed.  Depending on it will
> greatly delay the time that this critical patch for LS2 to be merged.
> Could you remove the dependency like Scott already suggested?

According to the changelog the dependency has been removed (it would have been
clearer to remove this comment as well...).

-Scott

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Li Yang]

Hi Brian,

Could you help to review and pull in this patch and the Kconfig update
after this patch(https://patchwork.ozlabs.org/patch/557389/)?  It
stated a dependency in the notes, but actually it should be applied
cleanly without that patch.  These patches are critical to make NAND
mtd feature work for our new chips.

Regards,
Leo

On Thu, Feb 18, 2016 at 6:07 PM, Scott Wood <oss@buserror.net> wrote:
> On Thu, 2016-02-18 at 15:18 -0600, Leo Li wrote:
>> On Wed, Feb 17, 2016 at 5:24 AM, Raghav Dogra <raghav.dogra@nxp.com> wrote:
>> > The new IFC controller version 2.0 has a different memory map page.
>> > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
>> > This patch segregates the IFC global and runtime registers to appropriate
>> > PAGE sizes.
>> >
>> > Signed-off-by: Jaiprakash Singh <b44839@freescale.com>
>> > Signed-off-by: Raghav Dogra <raghav@freescale.com>
>> > Acked-by: Li Yang <leoyang.li@nxp.com>
>> > Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
>> > ---
>> > Changes for v3: not dependent on
>> > "drivers/memory: Add deep sleep support for IFC" patch
>> >
>> > Changes for v2: rebased to resolve conflicts
>> > Applicable to git://git.infradead.org/l2-mtd.git
>> >
>> > This patch is dependent on "drivers/memory: Add deep sleep support for
>> > IFC"
>> > https://patchwork.ozlabs.org/patch/582762/
>> > which is also applicable to git://git.infradead.org/l2-mtd.git
>>
>> This patch seems to be in good shape, but the dependency is still
>> having quite some feedback to be addressed.  Depending on it will
>> greatly delay the time that this critical patch for LS2 to be merged.
>> Could you remove the dependency like Scott already suggested?
>
> According to the changelog the dependency has been removed (it would have been
> clearer to remove this comment as well...).
>
> -Scott
>



-- 
- Leo

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Brian Norris]

Hi,

On Wed, Mar 30, 2016 at 03:43:40PM -0500, Li Yang wrote:
> Hi Brian,
> 
> Could you help to review and pull in this patch and the Kconfig update
> after this patch(https://patchwork.ozlabs.org/patch/557389/)?  It

It's probably best for Boris to apply this now.

> stated a dependency in the notes, but actually it should be applied
> cleanly without that patch.  These patches are critical to make NAND
> mtd feature work for our new chips.
> 
> Regards,
> Leo
> 
> On Thu, Feb 18, 2016 at 6:07 PM, Scott Wood <oss@buserror.net> wrote:
> > On Thu, 2016-02-18 at 15:18 -0600, Leo Li wrote:
> >> On Wed, Feb 17, 2016 at 5:24 AM, Raghav Dogra <raghav.dogra@nxp.com> wrote:
> >> > The new IFC controller version 2.0 has a different memory map page.
> >> > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
> >> > This patch segregates the IFC global and runtime registers to appropriate
> >> > PAGE sizes.
> >> >
> >> > Signed-off-by: Jaiprakash Singh <b44839@freescale.com>
> >> > Signed-off-by: Raghav Dogra <raghav@freescale.com>
> >> > Acked-by: Li Yang <leoyang.li@nxp.com>
> >> > Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
> >> > ---
> >> > Changes for v3: not dependent on
> >> > "drivers/memory: Add deep sleep support for IFC" patch
> >> >
> >> > Changes for v2: rebased to resolve conflicts
> >> > Applicable to git://git.infradead.org/l2-mtd.git
> >> >
> >> > This patch is dependent on "drivers/memory: Add deep sleep support for
> >> > IFC"
> >> > https://patchwork.ozlabs.org/patch/582762/
> >> > which is also applicable to git://git.infradead.org/l2-mtd.git

For the patch:

Acked-by: Brian Norris <computersforpeace@gmail.com>

> >> This patch seems to be in good shape, but the dependency is still
> >> having quite some feedback to be addressed.  Depending on it will
> >> greatly delay the time that this critical patch for LS2 to be merged.
> >> Could you remove the dependency like Scott already suggested?
> >
> > According to the changelog the dependency has been removed (it would have been
> > clearer to remove this comment as well...).
> >
> > -Scott
> >
> 
> 
> 
> -- 
> - Leo

RE: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Yang-Leo Li]

> -----Original Message-----
> From: Brian Norris [mailto:computersforpeace@gmail.com]
> Sent: Wednesday, April 06, 2016 12:53 PM
> To: Li Yang <leoli@freescale.com>
> Cc: Scott Wood <oss@buserror.net>; Raghav Dogra <raghav.dogra@nxp.com>;
> linux-mtd@lists.infradead.org; linuxppc-dev <linuxppc-dev@lists.ozlabs.or=
g>;
> Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Raghav Dogra
> <raghav@freescale.com>; Jaiprakash Singh <b44839@freescale.com>; Boris
> Brezillon <boris.brezillon@free-electrons.com>
> Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version =
2.0
>=20
> Hi,
>=20
> On Wed, Mar 30, 2016 at 03:43:40PM -0500, Li Yang wrote:
> > Hi Brian,
> >
> > Could you help to review and pull in this patch and the Kconfig update
> > after this patch(https://patchwork.ozlabs.org/patch/557389/)?  It
>=20
> It's probably best for Boris to apply this now.

Thanks Brian.  I see Boris is taking over the maintenance of NAND recently,=
 we will follow up with him.

Hi Boris,

Can you consider to pull in this patch and then Kconfig patch (https://patc=
hwork.ozlabs.org/patch/557389/)?

Regards,
Leo

>=20
> > stated a dependency in the notes, but actually it should be applied
> > cleanly without that patch.  These patches are critical to make NAND
> > mtd feature work for our new chips.
> >
> > Regards,
> > Leo
> >
> > On Thu, Feb 18, 2016 at 6:07 PM, Scott Wood <oss@buserror.net> wrote:
> > > On Thu, 2016-02-18 at 15:18 -0600, Leo Li wrote:
> > >> On Wed, Feb 17, 2016 at 5:24 AM, Raghav Dogra <raghav.dogra@nxp.com>
> wrote:
> > >> > The new IFC controller version 2.0 has a different memory map page=
.
> > >> > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
> > >> > This patch segregates the IFC global and runtime registers to
> > >> > appropriate PAGE sizes.
> > >> >
> > >> > Signed-off-by: Jaiprakash Singh <b44839@freescale.com>
> > >> > Signed-off-by: Raghav Dogra <raghav@freescale.com>
> > >> > Acked-by: Li Yang <leoyang.li@nxp.com>
> > >> > Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
> > >> > ---
> > >> > Changes for v3: not dependent on
> > >> > "drivers/memory: Add deep sleep support for IFC" patch
> > >> >
> > >> > Changes for v2: rebased to resolve conflicts Applicable to
> > >> > git://git.infradead.org/l2-mtd.git
> > >> >
> > >> > This patch is dependent on "drivers/memory: Add deep sleep
> > >> > support for IFC"
> > >> > https://patchwork.ozlabs.org/patch/582762/
> > >> > which is also applicable to git://git.infradead.org/l2-mtd.git
>=20
> For the patch:
>=20
> Acked-by: Brian Norris <computersforpeace@gmail.com>
>=20
> > >> This patch seems to be in good shape, but the dependency is still
> > >> having quite some feedback to be addressed.  Depending on it will
> > >> greatly delay the time that this critical patch for LS2 to be merged=
.
> > >> Could you remove the dependency like Scott already suggested?
> > >
> > > According to the changelog the dependency has been removed (it would
> > > have been clearer to remove this comment as well...).
> > >
> > > -Scott
> > >
> >
> >
> >
> > --
> > - Leo

RE: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Yang-Leo Li]

> -----Original Message-----
> From: Brian Norris [mailto:computersforpeace@gmail.com]
> Sent: Wednesday, April 06, 2016 12:53 PM
> To: Li Yang <leoli@freescale.com>
> Cc: Scott Wood <oss@buserror.net>; Raghav Dogra <raghav.dogra@nxp.com>;
> linux-mtd@lists.infradead.org; linuxppc-dev <linuxppc-dev@lists.ozlabs.org>;
> Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Raghav Dogra
> <raghav@freescale.com>; Jaiprakash Singh <b44839@freescale.com>; Boris
> Brezillon <boris.brezillon@free-electrons.com>
> Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0
> 
> Hi,
> 
> On Wed, Mar 30, 2016 at 03:43:40PM -0500, Li Yang wrote:
> > Hi Brian,
> >
> > Could you help to review and pull in this patch and the Kconfig update
> > after this patch(https://patchwork.ozlabs.org/patch/557389/)?  It
> 
> It's probably best for Boris to apply this now.

Thanks Brian.  I see Boris is taking over the maintenance of NAND recently, we will follow up with him.

Hi Boris,

Can you consider to pull in this patch and then Kconfig patch (https://patchwork.ozlabs.org/patch/557389/)?

Regards,
Leo

> 
> > stated a dependency in the notes, but actually it should be applied
> > cleanly without that patch.  These patches are critical to make NAND
> > mtd feature work for our new chips.
> >
> > Regards,
> > Leo
> >
> > On Thu, Feb 18, 2016 at 6:07 PM, Scott Wood <oss@buserror.net> wrote:
> > > On Thu, 2016-02-18 at 15:18 -0600, Leo Li wrote:
> > >> On Wed, Feb 17, 2016 at 5:24 AM, Raghav Dogra <raghav.dogra@nxp.com>
> wrote:
> > >> > The new IFC controller version 2.0 has a different memory map page.
> > >> > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
> > >> > This patch segregates the IFC global and runtime registers to
> > >> > appropriate PAGE sizes.
> > >> >
> > >> > Signed-off-by: Jaiprakash Singh <b44839@freescale.com>
> > >> > Signed-off-by: Raghav Dogra <raghav@freescale.com>
> > >> > Acked-by: Li Yang <leoyang.li@nxp.com>
> > >> > Signed-off-by: Raghav Dogra <raghav.dogra@nxp.com>
> > >> > ---
> > >> > Changes for v3: not dependent on
> > >> > "drivers/memory: Add deep sleep support for IFC" patch
> > >> >
> > >> > Changes for v2: rebased to resolve conflicts Applicable to
> > >> > git://git.infradead.org/l2-mtd.git
> > >> >
> > >> > This patch is dependent on "drivers/memory: Add deep sleep
> > >> > support for IFC"
> > >> > https://patchwork.ozlabs.org/patch/582762/
> > >> > which is also applicable to git://git.infradead.org/l2-mtd.git
> 
> For the patch:
> 
> Acked-by: Brian Norris <computersforpeace@gmail.com>
> 
> > >> This patch seems to be in good shape, but the dependency is still
> > >> having quite some feedback to be addressed.  Depending on it will
> > >> greatly delay the time that this critical patch for LS2 to be merged.
> > >> Could you remove the dependency like Scott already suggested?
> > >
> > > According to the changelog the dependency has been removed (it would
> > > have been clearer to remove this comment as well...).
> > >
> > > -Scott
> > >
> >
> >
> >
> > --
> > - Leo

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Boris Brezillon]

On Wed, 6 Apr 2016 18:53:39 +0000
Yang-Leo Li <leoyang.li@nxp.com> wrote:

> 
> 
> > -----Original Message-----
> > From: Brian Norris [mailto:computersforpeace@gmail.com]
> > Sent: Wednesday, April 06, 2016 12:53 PM
> > To: Li Yang <leoli@freescale.com>
> > Cc: Scott Wood <oss@buserror.net>; Raghav Dogra <raghav.dogra@nxp.com>;
> > linux-mtd@lists.infradead.org; linuxppc-dev <linuxppc-dev@lists.ozlabs.org>;
> > Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Raghav Dogra
> > <raghav@freescale.com>; Jaiprakash Singh <b44839@freescale.com>; Boris
> > Brezillon <boris.brezillon@free-electrons.com>
> > Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0
> > 
> > Hi,
> > 
> > On Wed, Mar 30, 2016 at 03:43:40PM -0500, Li Yang wrote:
> > > Hi Brian,
> > >
> > > Could you help to review and pull in this patch and the Kconfig update
> > > after this patch(https://patchwork.ozlabs.org/patch/557389/)?  It
> > 
> > It's probably best for Boris to apply this now.
> 
> Thanks Brian.  I see Boris is taking over the maintenance of NAND recently, we will follow up with him.
> 
> Hi Boris,
> 
> Can you consider to pull in this patch and then Kconfig patch (https://patchwork.ozlabs.org/patch/557389/)?

Applied.

Thanks,

Boris


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Leo Li]

On Thu, Apr 7, 2016 at 7:45 PM, Boris Brezillon
<boris.brezillon@free-electrons.com> wrote:
> On Wed, 6 Apr 2016 18:53:39 +0000
> Yang-Leo Li <leoyang.li@nxp.com> wrote:
>
>>
>>
>> > -----Original Message-----
>> > From: Brian Norris [mailto:computersforpeace@gmail.com]
>> > Sent: Wednesday, April 06, 2016 12:53 PM
>> > To: Li Yang <leoli@freescale.com>
>> > Cc: Scott Wood <oss@buserror.net>; Raghav Dogra <raghav.dogra@nxp.com>;
>> > linux-mtd@lists.infradead.org; linuxppc-dev <linuxppc-dev@lists.ozlabs.org>;
>> > Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Raghav Dogra
>> > <raghav@freescale.com>; Jaiprakash Singh <b44839@freescale.com>; Boris
>> > Brezillon <boris.brezillon@free-electrons.com>
>> > Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0
>> >
>> > Hi,
>> >
>> > On Wed, Mar 30, 2016 at 03:43:40PM -0500, Li Yang wrote:
>> > > Hi Brian,
>> > >
>> > > Could you help to review and pull in this patch and the Kconfig update
>> > > after this patch(https://patchwork.ozlabs.org/patch/557389/)?  It
>> >
>> > It's probably best for Boris to apply this now.
>>
>> Thanks Brian.  I see Boris is taking over the maintenance of NAND recently, we will follow up with him.
>>
>> Hi Boris,
>>
>> Can you consider to pull in this patch and then Kconfig patch (https://patchwork.ozlabs.org/patch/557389/)?
>
> Applied.
>
> Thanks,
>
> Boris

Hi Boris,

It seems that the patch at https://patchwork.ozlabs.org/patch/557389/
mentioned above was not in tree for 4.7.  Can you review and apply
that patch too?

Regards,
Leo

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Boris Brezillon]

On Wed, 25 May 2016 14:18:43 -0500
Leo Li <pku.leo@gmail.com> wrote:

> On Thu, Apr 7, 2016 at 7:45 PM, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> > On Wed, 6 Apr 2016 18:53:39 +0000
> > Yang-Leo Li <leoyang.li@nxp.com> wrote:
> >  
> >>
> >>  
> >> > -----Original Message-----
> >> > From: Brian Norris [mailto:computersforpeace@gmail.com]
> >> > Sent: Wednesday, April 06, 2016 12:53 PM
> >> > To: Li Yang <leoli@freescale.com>
> >> > Cc: Scott Wood <oss@buserror.net>; Raghav Dogra <raghav.dogra@nxp.com>;
> >> > linux-mtd@lists.infradead.org; linuxppc-dev <linuxppc-dev@lists.ozlabs.org>;
> >> > Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Raghav Dogra
> >> > <raghav@freescale.com>; Jaiprakash Singh <b44839@freescale.com>; Boris
> >> > Brezillon <boris.brezillon@free-electrons.com>
> >> > Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0
> >> >
> >> > Hi,
> >> >
> >> > On Wed, Mar 30, 2016 at 03:43:40PM -0500, Li Yang wrote:  
> >> > > Hi Brian,
> >> > >
> >> > > Could you help to review and pull in this patch and the Kconfig update
> >> > > after this patch(https://patchwork.ozlabs.org/patch/557389/)?  It  
> >> >
> >> > It's probably best for Boris to apply this now.  
> >>
> >> Thanks Brian.  I see Boris is taking over the maintenance of NAND recently, we will follow up with him.
> >>
> >> Hi Boris,
> >>
> >> Can you consider to pull in this patch and then Kconfig patch (https://patchwork.ozlabs.org/patch/557389/)?  
> >
> > Applied.
> >
> > Thanks,
> >
> > Boris  
> 
> Hi Boris,
> 
> It seems that the patch at https://patchwork.ozlabs.org/patch/557389/
> mentioned above was not in tree for 4.7.  Can you review and apply
> that patch too?

I see it in the PR Brian sent 2 days ago [1], so it should appear in
Linus tree soon.

Regards,

Boris

[1]https://lkml.org/lkml/2016/5/24/9

> 
> Regards,
> Leo



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Leo Li]

On Wed, May 25, 2016 at 3:34 PM, Boris Brezillon
<boris.brezillon@free-electrons.com> wrote:
> On Wed, 25 May 2016 14:18:43 -0500
> Leo Li <pku.leo@gmail.com> wrote:
>
>> On Thu, Apr 7, 2016 at 7:45 PM, Boris Brezillon
>> <boris.brezillon@free-electrons.com> wrote:
>> > On Wed, 6 Apr 2016 18:53:39 +0000
>> > Yang-Leo Li <leoyang.li@nxp.com> wrote:
>> >
>> >>
>> >>
>> >> > -----Original Message-----
>> >> > From: Brian Norris [mailto:computersforpeace@gmail.com]
>> >> > Sent: Wednesday, April 06, 2016 12:53 PM
>> >> > To: Li Yang <leoli@freescale.com>
>> >> > Cc: Scott Wood <oss@buserror.net>; Raghav Dogra <raghav.dogra@nxp.com>;
>> >> > linux-mtd@lists.infradead.org; linuxppc-dev <linuxppc-dev@lists.ozlabs.org>;
>> >> > Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Raghav Dogra
>> >> > <raghav@freescale.com>; Jaiprakash Singh <b44839@freescale.com>; Boris
>> >> > Brezillon <boris.brezillon@free-electrons.com>
>> >> > Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0
>> >> >
>> >> > Hi,
>> >> >
>> >> > On Wed, Mar 30, 2016 at 03:43:40PM -0500, Li Yang wrote:
>> >> > > Hi Brian,
>> >> > >
>> >> > > Could you help to review and pull in this patch and the Kconfig update
>> >> > > after this patch(https://patchwork.ozlabs.org/patch/557389/)?  It
>> >> >
>> >> > It's probably best for Boris to apply this now.
>> >>
>> >> Thanks Brian.  I see Boris is taking over the maintenance of NAND recently, we will follow up with him.
>> >>
>> >> Hi Boris,
>> >>
>> >> Can you consider to pull in this patch and then Kconfig patch (https://patchwork.ozlabs.org/patch/557389/)?
>> >
>> > Applied.
>> >
>> > Thanks,
>> >
>> > Boris
>>
>> Hi Boris,
>>
>> It seems that the patch at https://patchwork.ozlabs.org/patch/557389/
>> mentioned above was not in tree for 4.7.  Can you review and apply
>> that patch too?
>
> I see it in the PR Brian sent 2 days ago [1], so it should appear in
> Linus tree soon.
>
> Regards,
>
> Boris
>
> [1]https://lkml.org/lkml/2016/5/24/9


The pull request does have patch "mtd/ifc: Add support for IFC
controller version 2.0", but it doesn't have another patch
"driver/memory: Update dependency of IFC for
Layerscape"(https://patchwork.ozlabs.org/patch/557389/) needed to make
the driver selectable on new hardware.

Regards,
Leo

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Boris Brezillon]

Hi Leo,

On Fri, 27 May 2016 15:15:00 -0500
Leo Li <pku.leo@gmail.com> wrote:

> On Wed, May 25, 2016 at 3:34 PM, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> > On Wed, 25 May 2016 14:18:43 -0500
> > Leo Li <pku.leo@gmail.com> wrote:
> >  
> >> On Thu, Apr 7, 2016 at 7:45 PM, Boris Brezillon
> >> <boris.brezillon@free-electrons.com> wrote:  
> >> > On Wed, 6 Apr 2016 18:53:39 +0000
> >> > Yang-Leo Li <leoyang.li@nxp.com> wrote:
> >> >  
> >> >>
> >> >>  
> >> >> > -----Original Message-----
> >> >> > From: Brian Norris [mailto:computersforpeace@gmail.com]
> >> >> > Sent: Wednesday, April 06, 2016 12:53 PM
> >> >> > To: Li Yang <leoli@freescale.com>
> >> >> > Cc: Scott Wood <oss@buserror.net>; Raghav Dogra <raghav.dogra@nxp.com>;
> >> >> > linux-mtd@lists.infradead.org; linuxppc-dev <linuxppc-dev@lists.ozlabs.org>;
> >> >> > Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Raghav Dogra
> >> >> > <raghav@freescale.com>; Jaiprakash Singh <b44839@freescale.com>; Boris
> >> >> > Brezillon <boris.brezillon@free-electrons.com>
> >> >> > Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0
> >> >> >
> >> >> > Hi,
> >> >> >
> >> >> > On Wed, Mar 30, 2016 at 03:43:40PM -0500, Li Yang wrote:  
> >> >> > > Hi Brian,
> >> >> > >
> >> >> > > Could you help to review and pull in this patch and the Kconfig update
> >> >> > > after this patch(https://patchwork.ozlabs.org/patch/557389/)?  It  
> >> >> >
> >> >> > It's probably best for Boris to apply this now.  
> >> >>
> >> >> Thanks Brian.  I see Boris is taking over the maintenance of NAND recently, we will follow up with him.
> >> >>
> >> >> Hi Boris,
> >> >>
> >> >> Can you consider to pull in this patch and then Kconfig patch (https://patchwork.ozlabs.org/patch/557389/)?  
> >> >
> >> > Applied.
> >> >
> >> > Thanks,
> >> >
> >> > Boris  
> >>
> >> Hi Boris,
> >>
> >> It seems that the patch at https://patchwork.ozlabs.org/patch/557389/
> >> mentioned above was not in tree for 4.7.  Can you review and apply
> >> that patch too?  
> >
> > I see it in the PR Brian sent 2 days ago [1], so it should appear in
> > Linus tree soon.
> >
> > Regards,
> >
> > Boris
> >
> > [1]https://lkml.org/lkml/2016/5/24/9  
> 
> 
> The pull request does have patch "mtd/ifc: Add support for IFC
> controller version 2.0", but it doesn't have another patch
> "driver/memory: Update dependency of IFC for
> Layerscape"(https://patchwork.ozlabs.org/patch/557389/) needed to make
> the driver selectable on new hardware.

Sorry, I overlooked that part in your different emails (even though you
clearly stated that you needed both patches).

For my defense, I haven't followed the patch series from the beginning,
and only took the patch because Brian suggested to do so (and the
changes seemed ok).
It would have been clearer if the different patches were part of the
same series.

Anyway, Brian, can you take it into your tree and make it appear in
-rc1 (or earlier if it's still possible)?

BTW, in the patch description you say you're only modifying a Kconfig
dependency, but you're actually doing more than that: you're removing
an asm header inclusion and manually include several other headers
(which I guess were previously included by asm/prom.h).

Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Brian Norris]

Hi Leo,

On Fri, May 27, 2016 at 10:44:01PM +0200, Boris Brezillon wrote:
> On Fri, 27 May 2016 15:15:00 -0500
> Leo Li <pku.leo@gmail.com> wrote:
> > On Wed, May 25, 2016 at 3:34 PM, Boris Brezillon
> > <boris.brezillon@free-electrons.com> wrote:
> > > On Wed, 25 May 2016 14:18:43 -0500
> > > Leo Li <pku.leo@gmail.com> wrote:
> > >> It seems that the patch at https://patchwork.ozlabs.org/patch/557389/
> > >> mentioned above was not in tree for 4.7.  Can you review and apply
> > >> that patch too?  
> > >
> > > I see it in the PR Brian sent 2 days ago [1], so it should appear in
> > > Linus tree soon.
> > >
> > > Regards,
> > >
> > > Boris
> > >
> > > [1]https://lkml.org/lkml/2016/5/24/9  
> > 
> > 
> > The pull request does have patch "mtd/ifc: Add support for IFC
> > controller version 2.0", but it doesn't have another patch
> > "driver/memory: Update dependency of IFC for
> > Layerscape"(https://patchwork.ozlabs.org/patch/557389/) needed to make
> > the driver selectable on new hardware.

Your patches seem to have broken threading. Or at least, in my mailbox,
I have that patch, but I can't easily find [PATCH 1/3] or [PATCH 3/3].
Please fix your threading next time, to help ensure things get handled
together.

(It also helps when you reply to the patch you're asking about, and not
to a different patch.)

> Sorry, I overlooked that part in your different emails (even though you
> clearly stated that you needed both patches).
> 
> For my defense, I haven't followed the patch series from the beginning,
> and only took the patch because Brian suggested to do so (and the
> changes seemed ok).
> It would have been clearer if the different patches were part of the
> same series.

+1 to the last sentence.

> Anyway, Brian, can you take it into your tree and make it appear in
> -rc1 (or earlier if it's still possible)?

Not sure how I could get it any "earlier"? It's not making -rc1 at this
point.

> BTW, in the patch description you say you're only modifying a Kconfig
> dependency, but you're actually doing more than that: you're removing
> an asm header inclusion and manually include several other headers
> (which I guess were previously included by asm/prom.h).

Please resend this patch with a more complete commit description; I'd
like it to get actual review (and time in linux-next) before it gets
merged, so at best, it'll wait a few -rc's. I also suspect the patch
isn't optimal. I believe Scott has suggested [1] that we didn't need the
FSL_SOC dependency on the LBC driver. I think IFC looks like a similar
case?

Brian

[1] http://lists.infradead.org/pipermail/linux-mtd/2016-January/064855.html

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Boris Brezillon]

On Fri, 27 May 2016 14:12:47 -0700
Brian Norris <computersforpeace@gmail.com> wrote:
> 
> > Anyway, Brian, can you take it into your tree and make it appear in
> > -rc1 (or earlier if it's still possible)?  
> 
> Not sure how I could get it any "earlier"? It's not making -rc1 at this
> point.

I meant -rc2 :)


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Leo Li]

On Fri, May 27, 2016 at 4:12 PM, Brian Norris
<computersforpeace@gmail.com> wrote:
> Hi Leo,
>
> On Fri, May 27, 2016 at 10:44:01PM +0200, Boris Brezillon wrote:
>> On Fri, 27 May 2016 15:15:00 -0500
>> Leo Li <pku.leo@gmail.com> wrote:
>> > On Wed, May 25, 2016 at 3:34 PM, Boris Brezillon
>> > <boris.brezillon@free-electrons.com> wrote:
>> > > On Wed, 25 May 2016 14:18:43 -0500
>> > > Leo Li <pku.leo@gmail.com> wrote:
>> > >> It seems that the patch at https://patchwork.ozlabs.org/patch/557389/
>> > >> mentioned above was not in tree for 4.7.  Can you review and apply
>> > >> that patch too?
>> > >
>> > > I see it in the PR Brian sent 2 days ago [1], so it should appear in
>> > > Linus tree soon.
>> > >
>> > > Regards,
>> > >
>> > > Boris
>> > >
>> > > [1]https://lkml.org/lkml/2016/5/24/9
>> >
>> >
>> > The pull request does have patch "mtd/ifc: Add support for IFC
>> > controller version 2.0", but it doesn't have another patch
>> > "driver/memory: Update dependency of IFC for
>> > Layerscape"(https://patchwork.ozlabs.org/patch/557389/) needed to make
>> > the driver selectable on new hardware.
>
> Your patches seem to have broken threading. Or at least, in my mailbox,
> I have that patch, but I can't easily find [PATCH 1/3] or [PATCH 3/3].
> Please fix your threading next time, to help ensure things get handled
> together.
>
> (It also helps when you reply to the patch you're asking about, and not
> to a different patch.)
>
>> Sorry, I overlooked that part in your different emails (even though you
>> clearly stated that you needed both patches).
>>
>> For my defense, I haven't followed the patch series from the beginning,
>> and only took the patch because Brian suggested to do so (and the
>> changes seemed ok).
>> It would have been clearer if the different patches were part of the
>> same series.
>
> +1 to the last sentence.
>
>> Anyway, Brian, can you take it into your tree and make it appear in
>> -rc1 (or earlier if it's still possible)?
>
> Not sure how I could get it any "earlier"? It's not making -rc1 at this
> point.
>
>> BTW, in the patch description you say you're only modifying a Kconfig
>> dependency, but you're actually doing more than that: you're removing
>> an asm header inclusion and manually include several other headers
>> (which I guess were previously included by asm/prom.h).
>
> Please resend this patch with a more complete commit description; I'd
> like it to get actual review (and time in linux-next) before it gets
> merged, so at best, it'll wait a few -rc's. I also suspect the patch
> isn't optimal. I believe Scott has suggested [1] that we didn't need the
> FSL_SOC dependency on the LBC driver. I think IFC looks like a similar
> case?

Thanks Brian.

Raghav, Can you do that as soon as possible?

Regards,
Leo

RE: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Raghav Dogra]

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogTGVvIExpIFttYWlsdG86
cGt1Lmxlb0BnbWFpbC5jb21dDQo+IFNlbnQ6IFNhdHVyZGF5LCBNYXkgMjgsIDIwMTYgMzozNCBB
TQ0KPiBUbzogQnJpYW4gTm9ycmlzIDxjb21wdXRlcnNmb3JwZWFjZUBnbWFpbC5jb20+OyBSYWdo
YXYgRG9ncmENCj4gPHJhZ2hhdi5kb2dyYUBueHAuY29tPg0KPiBDYzogQm9yaXMgQnJlemlsbG9u
IDxib3Jpcy5icmV6aWxsb25AZnJlZS1lbGVjdHJvbnMuY29tPjsgWWFuZy1MZW8gTGkNCj4gPGxl
b3lhbmcubGlAbnhwLmNvbT47IFByYWJoYWthciBLdXNod2FoYQ0KPiA8cHJhYmhha2FyLmt1c2h3
YWhhQG54cC5jb20+OyBTY290dCBXb29kIDxvc3NAYnVzZXJyb3IubmV0PjsgbGludXgtDQo+IG10
ZEBsaXN0cy5pbmZyYWRlYWQub3JnOyBsaW51eHBwYy1kZXYgPGxpbnV4cHBjLWRldkBsaXN0cy5v
emxhYnMub3JnPjsNCj4gUmFnaGF2IERvZ3JhIDxyYWdoYXZAZnJlZXNjYWxlLmNvbT47IEphaXBy
YWthc2ggU2luZ2gNCj4gPGI0NDgzOUBmcmVlc2NhbGUuY29tPg0KPiBTdWJqZWN0OiBSZTogW1BB
VENIXVt2M10gbXRkL2lmYzogQWRkIHN1cHBvcnQgZm9yIElGQyBjb250cm9sbGVyIHZlcnNpb24g
Mi4wDQo+IA0KPiBPbiBGcmksIE1heSAyNywgMjAxNiBhdCA0OjEyIFBNLCBCcmlhbiBOb3JyaXMN
Cj4gPGNvbXB1dGVyc2ZvcnBlYWNlQGdtYWlsLmNvbT4gd3JvdGU6DQo+ID4gSGkgTGVvLA0KPiA+
DQo+ID4gT24gRnJpLCBNYXkgMjcsIDIwMTYgYXQgMTA6NDQ6MDFQTSArMDIwMCwgQm9yaXMgQnJl
emlsbG9uIHdyb3RlOg0KPiA+PiBPbiBGcmksIDI3IE1heSAyMDE2IDE1OjE1OjAwIC0wNTAwDQo+
ID4+IExlbyBMaSA8cGt1Lmxlb0BnbWFpbC5jb20+IHdyb3RlOg0KPiA+PiA+IE9uIFdlZCwgTWF5
IDI1LCAyMDE2IGF0IDM6MzQgUE0sIEJvcmlzIEJyZXppbGxvbg0KPiA+PiA+IDxib3Jpcy5icmV6
aWxsb25AZnJlZS1lbGVjdHJvbnMuY29tPiB3cm90ZToNCj4gPj4gPiA+IE9uIFdlZCwgMjUgTWF5
IDIwMTYgMTQ6MTg6NDMgLTA1MDAgTGVvIExpIDxwa3UubGVvQGdtYWlsLmNvbT4NCj4gPj4gPiA+
IHdyb3RlOg0KPiA+PiA+ID4+IEl0IHNlZW1zIHRoYXQgdGhlIHBhdGNoIGF0DQo+ID4+ID4gPj4g
aHR0cHM6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9wYXRjaC81NTczODkvDQo+ID4+ID4gPj4gbWVu
dGlvbmVkIGFib3ZlIHdhcyBub3QgaW4gdHJlZSBmb3IgNC43LiAgQ2FuIHlvdSByZXZpZXcgYW5k
DQo+ID4+ID4gPj4gYXBwbHkgdGhhdCBwYXRjaCB0b28/DQo+ID4+ID4gPg0KPiA+PiA+ID4gSSBz
ZWUgaXQgaW4gdGhlIFBSIEJyaWFuIHNlbnQgMiBkYXlzIGFnbyBbMV0sIHNvIGl0IHNob3VsZCBh
cHBlYXINCj4gPj4gPiA+IGluIExpbnVzIHRyZWUgc29vbi4NCj4gPj4gPiA+DQo+ID4+ID4gPiBS
ZWdhcmRzLA0KPiA+PiA+ID4NCj4gPj4gPiA+IEJvcmlzDQo+ID4+ID4gPg0KPiA+PiA+ID4gWzFd
aHR0cHM6Ly9sa21sLm9yZy9sa21sLzIwMTYvNS8yNC85DQo+ID4+ID4NCj4gPj4gPg0KPiA+PiA+
IFRoZSBwdWxsIHJlcXVlc3QgZG9lcyBoYXZlIHBhdGNoICJtdGQvaWZjOiBBZGQgc3VwcG9ydCBm
b3IgSUZDDQo+ID4+ID4gY29udHJvbGxlciB2ZXJzaW9uIDIuMCIsIGJ1dCBpdCBkb2Vzbid0IGhh
dmUgYW5vdGhlciBwYXRjaA0KPiA+PiA+ICJkcml2ZXIvbWVtb3J5OiBVcGRhdGUgZGVwZW5kZW5j
eSBvZiBJRkMgZm9yDQo+ID4+ID4gTGF5ZXJzY2FwZSIoaHR0cHM6Ly9wYXRjaHdvcmsub3psYWJz
Lm9yZy9wYXRjaC81NTczODkvKSBuZWVkZWQgdG8NCj4gPj4gPiBtYWtlIHRoZSBkcml2ZXIgc2Vs
ZWN0YWJsZSBvbiBuZXcgaGFyZHdhcmUuDQo+ID4NCj4gPiBZb3VyIHBhdGNoZXMgc2VlbSB0byBo
YXZlIGJyb2tlbiB0aHJlYWRpbmcuIE9yIGF0IGxlYXN0LCBpbiBteQ0KPiA+IG1haWxib3gsIEkg
aGF2ZSB0aGF0IHBhdGNoLCBidXQgSSBjYW4ndCBlYXNpbHkgZmluZCBbUEFUQ0ggMS8zXSBvciBb
UEFUQ0gNCj4gMy8zXS4NCj4gPiBQbGVhc2UgZml4IHlvdXIgdGhyZWFkaW5nIG5leHQgdGltZSwg
dG8gaGVscCBlbnN1cmUgdGhpbmdzIGdldCBoYW5kbGVkDQo+ID4gdG9nZXRoZXIuDQo+ID4NCj4g
PiAoSXQgYWxzbyBoZWxwcyB3aGVuIHlvdSByZXBseSB0byB0aGUgcGF0Y2ggeW91J3JlIGFza2lu
ZyBhYm91dCwgYW5kDQo+ID4gbm90IHRvIGEgZGlmZmVyZW50IHBhdGNoLikNCj4gPg0KPiA+PiBT
b3JyeSwgSSBvdmVybG9va2VkIHRoYXQgcGFydCBpbiB5b3VyIGRpZmZlcmVudCBlbWFpbHMgKGV2
ZW4gdGhvdWdoDQo+ID4+IHlvdSBjbGVhcmx5IHN0YXRlZCB0aGF0IHlvdSBuZWVkZWQgYm90aCBw
YXRjaGVzKS4NCj4gPj4NCj4gPj4gRm9yIG15IGRlZmVuc2UsIEkgaGF2ZW4ndCBmb2xsb3dlZCB0
aGUgcGF0Y2ggc2VyaWVzIGZyb20gdGhlDQo+ID4+IGJlZ2lubmluZywgYW5kIG9ubHkgdG9vayB0
aGUgcGF0Y2ggYmVjYXVzZSBCcmlhbiBzdWdnZXN0ZWQgdG8gZG8gc28NCj4gPj4gKGFuZCB0aGUg
Y2hhbmdlcyBzZWVtZWQgb2spLg0KPiA+PiBJdCB3b3VsZCBoYXZlIGJlZW4gY2xlYXJlciBpZiB0
aGUgZGlmZmVyZW50IHBhdGNoZXMgd2VyZSBwYXJ0IG9mIHRoZQ0KPiA+PiBzYW1lIHNlcmllcy4N
Cj4gPg0KPiA+ICsxIHRvIHRoZSBsYXN0IHNlbnRlbmNlLg0KPiA+DQo+ID4+IEFueXdheSwgQnJp
YW4sIGNhbiB5b3UgdGFrZSBpdCBpbnRvIHlvdXIgdHJlZSBhbmQgbWFrZSBpdCBhcHBlYXIgaW4N
Cj4gPj4gLXJjMSAob3IgZWFybGllciBpZiBpdCdzIHN0aWxsIHBvc3NpYmxlKT8NCj4gPg0KPiA+
IE5vdCBzdXJlIGhvdyBJIGNvdWxkIGdldCBpdCBhbnkgImVhcmxpZXIiPyBJdCdzIG5vdCBtYWtp
bmcgLXJjMSBhdA0KPiA+IHRoaXMgcG9pbnQuDQo+ID4NCj4gPj4gQlRXLCBpbiB0aGUgcGF0Y2gg
ZGVzY3JpcHRpb24geW91IHNheSB5b3UncmUgb25seSBtb2RpZnlpbmcgYSBLY29uZmlnDQo+ID4+
IGRlcGVuZGVuY3ksIGJ1dCB5b3UncmUgYWN0dWFsbHkgZG9pbmcgbW9yZSB0aGFuIHRoYXQ6IHlv
dSdyZSByZW1vdmluZw0KPiA+PiBhbiBhc20gaGVhZGVyIGluY2x1c2lvbiBhbmQgbWFudWFsbHkg
aW5jbHVkZSBzZXZlcmFsIG90aGVyIGhlYWRlcnMNCj4gPj4gKHdoaWNoIEkgZ3Vlc3Mgd2VyZSBw
cmV2aW91c2x5IGluY2x1ZGVkIGJ5IGFzbS9wcm9tLmgpLg0KPiA+DQo+ID4gUGxlYXNlIHJlc2Vu
ZCB0aGlzIHBhdGNoIHdpdGggYSBtb3JlIGNvbXBsZXRlIGNvbW1pdCBkZXNjcmlwdGlvbjsgSSdk
DQo+ID4gbGlrZSBpdCB0byBnZXQgYWN0dWFsIHJldmlldyAoYW5kIHRpbWUgaW4gbGludXgtbmV4
dCkgYmVmb3JlIGl0IGdldHMNCj4gPiBtZXJnZWQsIHNvIGF0IGJlc3QsIGl0J2xsIHdhaXQgYSBm
ZXcgLXJjJ3MuIEkgYWxzbyBzdXNwZWN0IHRoZSBwYXRjaA0KPiA+IGlzbid0IG9wdGltYWwuIEkg
YmVsaWV2ZSBTY290dCBoYXMgc3VnZ2VzdGVkIFsxXSB0aGF0IHdlIGRpZG4ndCBuZWVkDQo+ID4g
dGhlIEZTTF9TT0MgZGVwZW5kZW5jeSBvbiB0aGUgTEJDIGRyaXZlci4gSSB0aGluayBJRkMgbG9v
a3MgbGlrZSBhDQo+ID4gc2ltaWxhciBjYXNlPw0KDQpIaSBCcmlhbiwNCg0KVGhlIHBhdGNoIGJl
aW5nIHRhbGtlZCBhYm91dCBkb2VzIG5vdCBhZGQgYSBGU0xfU09DIGRlcGVuZGVuY3kgb24gdGhl
IElGQyBkcml2ZXIuDQpJdCB1c2VzIGEgZ2VuZXJpYyBBUkNIX0xBWUVSU0NBUEUgbWFjcm8gdG8g
ZW5hYmxlIElGQy4gVGhpcyBzaG91bGQgYmUgT2s/IA0KDQpSZWdhcmRzLA0KUmFnaGF2DQo+IA0K
PiBUaGFua3MgQnJpYW4uDQo+IA0KPiBSYWdoYXYsIENhbiB5b3UgZG8gdGhhdCBhcyBzb29uIGFz
IHBvc3NpYmxlPw0KPiANCj4gUmVnYXJkcywNCj4gTGVvDQo=

RE: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Raghav Dogra]

> -----Original Message-----
> From: Leo Li [mailto:pku.leo@gmail.com]
> Sent: Saturday, May 28, 2016 3:34 AM
> To: Brian Norris <computersforpeace@gmail.com>; Raghav Dogra
> <raghav.dogra@nxp.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>; Yang-Leo Li
> <leoyang.li@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; Scott Wood <oss@buserror.net>; linux-
> mtd@lists.infradead.org; linuxppc-dev <linuxppc-dev@lists.ozlabs.org>;
> Raghav Dogra <raghav@freescale.com>; Jaiprakash Singh
> <b44839@freescale.com>
> Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0
> 
> On Fri, May 27, 2016 at 4:12 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
> > Hi Leo,
> >
> > On Fri, May 27, 2016 at 10:44:01PM +0200, Boris Brezillon wrote:
> >> On Fri, 27 May 2016 15:15:00 -0500
> >> Leo Li <pku.leo@gmail.com> wrote:
> >> > On Wed, May 25, 2016 at 3:34 PM, Boris Brezillon
> >> > <boris.brezillon@free-electrons.com> wrote:
> >> > > On Wed, 25 May 2016 14:18:43 -0500 Leo Li <pku.leo@gmail.com>
> >> > > wrote:
> >> > >> It seems that the patch at
> >> > >> https://patchwork.ozlabs.org/patch/557389/
> >> > >> mentioned above was not in tree for 4.7.  Can you review and
> >> > >> apply that patch too?
> >> > >
> >> > > I see it in the PR Brian sent 2 days ago [1], so it should appear
> >> > > in Linus tree soon.
> >> > >
> >> > > Regards,
> >> > >
> >> > > Boris
> >> > >
> >> > > [1]https://lkml.org/lkml/2016/5/24/9
> >> >
> >> >
> >> > The pull request does have patch "mtd/ifc: Add support for IFC
> >> > controller version 2.0", but it doesn't have another patch
> >> > "driver/memory: Update dependency of IFC for
> >> > Layerscape"(https://patchwork.ozlabs.org/patch/557389/) needed to
> >> > make the driver selectable on new hardware.
> >
> > Your patches seem to have broken threading. Or at least, in my
> > mailbox, I have that patch, but I can't easily find [PATCH 1/3] or [PATCH
> 3/3].
> > Please fix your threading next time, to help ensure things get handled
> > together.
> >
> > (It also helps when you reply to the patch you're asking about, and
> > not to a different patch.)
> >
> >> Sorry, I overlooked that part in your different emails (even though
> >> you clearly stated that you needed both patches).
> >>
> >> For my defense, I haven't followed the patch series from the
> >> beginning, and only took the patch because Brian suggested to do so
> >> (and the changes seemed ok).
> >> It would have been clearer if the different patches were part of the
> >> same series.
> >
> > +1 to the last sentence.
> >
> >> Anyway, Brian, can you take it into your tree and make it appear in
> >> -rc1 (or earlier if it's still possible)?
> >
> > Not sure how I could get it any "earlier"? It's not making -rc1 at
> > this point.
> >
> >> BTW, in the patch description you say you're only modifying a Kconfig
> >> dependency, but you're actually doing more than that: you're removing
> >> an asm header inclusion and manually include several other headers
> >> (which I guess were previously included by asm/prom.h).
> >
> > Please resend this patch with a more complete commit description; I'd
> > like it to get actual review (and time in linux-next) before it gets
> > merged, so at best, it'll wait a few -rc's. I also suspect the patch
> > isn't optimal. I believe Scott has suggested [1] that we didn't need
> > the FSL_SOC dependency on the LBC driver. I think IFC looks like a
> > similar case?

Hi Brian,

The patch being talked about does not add a FSL_SOC dependency on the IFC driver.
It uses a generic ARCH_LAYERSCAPE macro to enable IFC. This should be Ok? 

Regards,
Raghav
> 
> Thanks Brian.
> 
> Raghav, Can you do that as soon as possible?
> 
> Regards,
> Leo

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Brian Norris]

Hi,

On Wed, Jun 29, 2016 at 02:53:03PM +0000, Raghav Dogra wrote:
> 
> 
> > -----Original Message-----
> > From: Leo Li [mailto:pku.leo@gmail.com]
> > Sent: Saturday, May 28, 2016 3:34 AM

1 month delay? So much for the rush...

> > To: Brian Norris <computersforpeace@gmail.com>; Raghav Dogra
> > <raghav.dogra@nxp.com>
> > Cc: Boris Brezillon <boris.brezillon@free-electrons.com>; Yang-Leo Li
> > <leoyang.li@nxp.com>; Prabhakar Kushwaha
> > <prabhakar.kushwaha@nxp.com>; Scott Wood <oss@buserror.net>; linux-
> > mtd@lists.infradead.org; linuxppc-dev <linuxppc-dev@lists.ozlabs.org>;
> > Raghav Dogra <raghav@freescale.com>; Jaiprakash Singh
> > <b44839@freescale.com>
> > Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0
> > 
> > On Fri, May 27, 2016 at 4:12 PM, Brian Norris
> > <computersforpeace@gmail.com> wrote:
> > > On Fri, May 27, 2016 at 10:44:01PM +0200, Boris Brezillon wrote:
> > >> On Fri, 27 May 2016 15:15:00 -0500
> > >> Leo Li <pku.leo@gmail.com> wrote:
> > >> >
> > >> > The pull request does have patch "mtd/ifc: Add support for IFC
> > >> > controller version 2.0", but it doesn't have another patch
> > >> > "driver/memory: Update dependency of IFC for
> > >> > Layerscape"(https://patchwork.ozlabs.org/patch/557389/) needed to
> > >> > make the driver selectable on new hardware.
> > >
[...]

> > >> BTW, in the patch description you say you're only modifying a Kconfig
> > >> dependency, but you're actually doing more than that: you're removing
> > >> an asm header inclusion and manually include several other headers
> > >> (which I guess were previously included by asm/prom.h).
> > >
> > > Please resend this patch with a more complete commit description; I'd
> > > like it to get actual review (and time in linux-next) before it gets
> > > merged, so at best, it'll wait a few -rc's. I also suspect the patch
> > > isn't optimal. I believe Scott has suggested [1] that we didn't need
> > > the FSL_SOC dependency on the LBC driver. I think IFC looks like a
> > > similar case?
> 
> Hi Brian,
> 
> The patch being talked about does not add a FSL_SOC dependency on the IFC driver.
> It uses a generic ARCH_LAYERSCAPE macro to enable IFC. This should be Ok? 

Maybe... but if we know that this driver doesn't actually have an
FSL_SOC dependency, and the FSL maintainers don't really want it in the
first place, then a simpler patch is to just remove the FSL_SOC
dependency, rather than making the deps more complicated.

But anyway, if you resend with the comments addresses (e.g., better
commit description), then we can consider applying it. If the FSL folks
have nothing to contribute here, then I don't see why we wouldn't take
your patch.

Regards,
Brian