* [RFC v2 1/2] NET: PHY: adds driver for Lantiq PHY11G
@ 2016-05-28 16:59 Hauke Mehrtens
2016-05-28 16:59 ` [RFC v2 2/2] NET: PHY: lantiq: add LED configuration support Hauke Mehrtens
2016-05-28 17:55 ` [RFC v2 1/2] NET: PHY: adds driver for Lantiq PHY11G Andrew Lunn
0 siblings, 2 replies; 6+ messages in thread
From: Hauke Mehrtens @ 2016-05-28 16:59 UTC (permalink / raw)
To: f.fainelli
Cc: alexander.stein, netdev, andrew, john, openwrt, hauke.mehrtens,
daniel.schwierzeck, eckert.florian, Hauke Mehrtens
Supports the Lantiq / Intel CHD 11G and 22E PHYs.
These PHYs are also named PEF 7061, PEF 7071, PEF 7072
Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
drivers/net/phy/Kconfig | 6 +
drivers/net/phy/Makefile | 1 +
drivers/net/phy/lantiq.c | 390 +++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 397 insertions(+)
create mode 100644 drivers/net/phy/lantiq.c
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index f0a7702..f3685ef 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -257,6 +257,12 @@ config MDIO_BCM_IPROC
This module provides a driver for the MDIO busses found in the
Broadcom iProc SoC's.
+config LANTIQ_PHY
+ tristate "Driver for Lantiq PHYs"
+ ---help---
+ Supports the Lantiq / Intel CHD 11G and 22E PHYs.
+ These PHYs are also named PEF 7061, PEF 7071 and PEF 7072
+
endif # PHYLIB
config MICREL_KS8995MA
diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
index 680e88f9..042b0ef6 100644
--- a/drivers/net/phy/Makefile
+++ b/drivers/net/phy/Makefile
@@ -42,3 +42,4 @@ obj-$(CONFIG_MDIO_MOXART) += mdio-moxart.o
obj-$(CONFIG_MDIO_BCM_UNIMAC) += mdio-bcm-unimac.o
obj-$(CONFIG_MICROCHIP_PHY) += microchip.o
obj-$(CONFIG_MDIO_BCM_IPROC) += mdio-bcm-iproc.o
+obj-$(CONFIG_LANTIQ_PHY) += lantiq.o
diff --git a/drivers/net/phy/lantiq.c b/drivers/net/phy/lantiq.c
new file mode 100644
index 0000000..a2adc4b
--- /dev/null
+++ b/drivers/net/phy/lantiq.c
@@ -0,0 +1,390 @@
+/*
+ * Copyright (C) 2012 Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
+ * Copyright (C) 2016 Hauke Mehrtens <hauke@hauke-m.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/mdio.h>
+#include <linux/module.h>
+#include <linux/phy.h>
+#include <linux/of.h>
+
+#define LANTIQ_MDIO_IMASK 0x19 /* interrupt mask */
+#define LANTIQ_MDIO_ISTAT 0x1A /* interrupt status */
+
+#define LANTIQ_MDIO_INIT_WOL BIT(15) /* Wake-On-LAN */
+#define LANTIQ_MDIO_INIT_MSRE BIT(14)
+#define LANTIQ_MDIO_INIT_NPRX BIT(13)
+#define LANTIQ_MDIO_INIT_NPTX BIT(12)
+#define LANTIQ_MDIO_INIT_ANE BIT(11) /* Auto-Neg error */
+#define LANTIQ_MDIO_INIT_ANC BIT(10) /* Auto-Neg complete */
+#define LANTIQ_MDIO_INIT_ADSC BIT(5) /* Link auto-downspeed detect */
+#define LANTIQ_MDIO_INIT_MPIPC BIT(4)
+#define LANTIQ_MDIO_INIT_MDIXC BIT(3)
+#define LANTIQ_MDIO_INIT_DXMC BIT(2) /* Duplex mode change */
+#define LANTIQ_MDIO_INIT_LSPC BIT(1) /* Link speed change */
+#define LANTIQ_MDIO_INIT_LSTC BIT(0) /* Link state change */
+#define LANTIQ_MDIO_INIT_MASK (LANTIQ_MDIO_INIT_LSTC | \
+ LANTIQ_MDIO_INIT_ADSC)
+
+#define ADVERTISED_MPD BIT(10) /* Multi-port device */
+
+/* LED Configuration */
+#define LANTIQ_MMD_LEDCH 0x01E0
+/* Inverse of SCAN Function */
+#define LANTIQ_MMD_LEDCH_NACS_NONE 0x0000
+#define LANTIQ_MMD_LEDCH_NACS_LINK 0x0001
+#define LANTIQ_MMD_LEDCH_NACS_PDOWN 0x0002
+#define LANTIQ_MMD_LEDCH_NACS_EEE 0x0003
+#define LANTIQ_MMD_LEDCH_NACS_ANEG 0x0004
+#define LANTIQ_MMD_LEDCH_NACS_ABIST 0x0005
+#define LANTIQ_MMD_LEDCH_NACS_CDIAG 0x0006
+#define LANTIQ_MMD_LEDCH_NACS_TEST 0x0007
+/* Slow Blink Frequency */
+#define LANTIQ_MMD_LEDCH_SBF_F02HZ 0x0000
+#define LANTIQ_MMD_LEDCH_SBF_F04HZ 0x0010
+#define LANTIQ_MMD_LEDCH_SBF_F08HZ 0x0020
+#define LANTIQ_MMD_LEDCH_SBF_F16HZ 0x0030
+/* Fast Blink Frequency */
+#define LANTIQ_MMD_LEDCH_FBF_F02HZ 0x0000
+#define LANTIQ_MMD_LEDCH_FBF_F04HZ 0x0040
+#define LANTIQ_MMD_LEDCH_FBF_F08HZ 0x0080
+#define LANTIQ_MMD_LEDCH_FBF_F16HZ 0x00C0
+/* LED Configuration */
+#define LANTIQ_MMD_LEDCL 0x01E1
+/* Complex Blinking Configuration */
+#define LANTIQ_MMD_LEDCH_CBLINK_NONE 0x0000
+#define LANTIQ_MMD_LEDCH_CBLINK_LINK 0x0001
+#define LANTIQ_MMD_LEDCH_CBLINK_PDOWN 0x0002
+#define LANTIQ_MMD_LEDCH_CBLINK_EEE 0x0003
+#define LANTIQ_MMD_LEDCH_CBLINK_ANEG 0x0004
+#define LANTIQ_MMD_LEDCH_CBLINK_ABIST 0x0005
+#define LANTIQ_MMD_LEDCH_CBLINK_CDIAG 0x0006
+#define LANTIQ_MMD_LEDCH_CBLINK_TEST 0x0007
+/* Complex SCAN Configuration */
+#define LANTIQ_MMD_LEDCH_SCAN_NONE 0x0000
+#define LANTIQ_MMD_LEDCH_SCAN_LINK 0x0010
+#define LANTIQ_MMD_LEDCH_SCAN_PDOWN 0x0020
+#define LANTIQ_MMD_LEDCH_SCAN_EEE 0x0030
+#define LANTIQ_MMD_LEDCH_SCAN_ANEG 0x0040
+#define LANTIQ_MMD_LEDCH_SCAN_ABIST 0x0050
+#define LANTIQ_MMD_LEDCH_SCAN_CDIAG 0x0060
+#define LANTIQ_MMD_LEDCH_SCAN_TEST 0x0070
+/* Configuration for LED Pin x */
+#define LANTIQ_MMD_LED0H 0x01E2
+/* Fast Blinking Configuration */
+#define LANTIQ_MMD_LEDxH_BLINKF_MASK 0x000F
+#define LANTIQ_MMD_LEDxH_BLINKF_NONE 0x0000
+#define LANTIQ_MMD_LEDxH_BLINKF_LINK10 0x0001
+#define LANTIQ_MMD_LEDxH_BLINKF_LINK100 0x0002
+#define LANTIQ_MMD_LEDxH_BLINKF_LINK10X 0x0003
+#define LANTIQ_MMD_LEDxH_BLINKF_LINK1000 0x0004
+#define LANTIQ_MMD_LEDxH_BLINKF_LINK10_0 0x0005
+#define LANTIQ_MMD_LEDxH_BLINKF_LINK100X 0x0006
+#define LANTIQ_MMD_LEDxH_BLINKF_LINK10XX 0x0007
+#define LANTIQ_MMD_LEDxH_BLINKF_PDOWN 0x0008
+#define LANTIQ_MMD_LEDxH_BLINKF_EEE 0x0009
+#define LANTIQ_MMD_LEDxH_BLINKF_ANEG 0x000A
+#define LANTIQ_MMD_LEDxH_BLINKF_ABIST 0x000B
+#define LANTIQ_MMD_LEDxH_BLINKF_CDIAG 0x000C
+/* Constant On Configuration */
+#define LANTIQ_MMD_LEDxH_CON_MASK 0x00F0
+#define LANTIQ_MMD_LEDxH_CON_NONE 0x0000
+#define LANTIQ_MMD_LEDxH_CON_LINK10 0x0010
+#define LANTIQ_MMD_LEDxH_CON_LINK100 0x0020
+#define LANTIQ_MMD_LEDxH_CON_LINK10X 0x0030
+#define LANTIQ_MMD_LEDxH_CON_LINK1000 0x0040
+#define LANTIQ_MMD_LEDxH_CON_LINK10_0 0x0050
+#define LANTIQ_MMD_LEDxH_CON_LINK100X 0x0060
+#define LANTIQ_MMD_LEDxH_CON_LINK10XX 0x0070
+#define LANTIQ_MMD_LEDxH_CON_PDOWN 0x0080
+#define LANTIQ_MMD_LEDxH_CON_EEE 0x0090
+#define LANTIQ_MMD_LEDxH_CON_ANEG 0x00A0
+#define LANTIQ_MMD_LEDxH_CON_ABIST 0x00B0
+#define LANTIQ_MMD_LEDxH_CON_CDIAG 0x00C0
+#define LANTIQ_MMD_LEDxH_CON_COPPER 0x00D0
+#define LANTIQ_MMD_LEDxH_CON_FIBER 0x00E0
+/* Configuration for LED Pin x */
+#define LANTIQ_MMD_LED0L 0x01E3
+/* Pulsing Configuration */
+#define LANTIQ_MMD_LEDxL_PULSE_MASK 0x000F
+#define LANTIQ_MMD_LEDxL_PULSE_NONE 0x0000
+#define LANTIQ_MMD_LEDxL_PULSE_TXACT 0x0001
+#define LANTIQ_MMD_LEDxL_PULSE_RXACT 0x0002
+#define LANTIQ_MMD_LEDxL_PULSE_COL 0x0004
+/* Slow Blinking Configuration */
+#define LANTIQ_MMD_LEDxL_BLINKS_MASK 0x00F0
+#define LANTIQ_MMD_LEDxL_BLINKS_NONE 0x0000
+#define LANTIQ_MMD_LEDxL_BLINKS_LINK10 0x0010
+#define LANTIQ_MMD_LEDxL_BLINKS_LINK100 0x0020
+#define LANTIQ_MMD_LEDxL_BLINKS_LINK10X 0x0030
+#define LANTIQ_MMD_LEDxL_BLINKS_LINK1000 0x0040
+#define LANTIQ_MMD_LEDxL_BLINKS_LINK10_0 0x0050
+#define LANTIQ_MMD_LEDxL_BLINKS_LINK100X 0x0060
+#define LANTIQ_MMD_LEDxL_BLINKS_LINK10XX 0x0070
+#define LANTIQ_MMD_LEDxL_BLINKS_PDOWN 0x0080
+#define LANTIQ_MMD_LEDxL_BLINKS_EEE 0x0090
+#define LANTIQ_MMD_LEDxL_BLINKS_ANEG 0x00A0
+#define LANTIQ_MMD_LEDxL_BLINKS_ABIST 0x00B0
+#define LANTIQ_MMD_LEDxL_BLINKS_CDIAG 0x00C0
+#define LANTIQ_MMD_LED1H 0x01E4
+#define LANTIQ_MMD_LED1L 0x01E5
+#define LANTIQ_MMD_LED2H 0x01E6
+#define LANTIQ_MMD_LED2L 0x01E7
+#define LANTIQ_MMD_LED3H 0x01E8
+#define LANTIQ_MMD_LED3L 0x01E9
+
+#define PHY_ID_PHY11G_1_3 0x030260D1
+#define PHY_ID_PHY22F_1_3 0x030260E1
+#define PHY_ID_PHY11G_1_4 0xD565A400
+#define PHY_ID_PHY22F_1_4 0xD565A410
+#define PHY_ID_PHY11G_1_5 0xD565A401
+#define PHY_ID_PHY22F_1_5 0xD565A411
+#define PHY_ID_PHY11G_VR9 0xD565A409
+#define PHY_ID_PHY22F_VR9 0xD565A419
+
+static int lantiq_gphy_config_init(struct phy_device *phydev)
+{
+ int err;
+ u32 ledxh;
+ u32 ledxl;
+
+ /* Mask all interrupts */
+ err = phy_write(phydev, LANTIQ_MDIO_IMASK, 0);
+ if (err)
+ return err;
+
+ /* Clear all pending interrupts */
+ phy_read(phydev, LANTIQ_MDIO_ISTAT);
+
+ phy_write_mmd_indirect(phydev, LANTIQ_MMD_LEDCH, MDIO_MMD_VEND2,
+ LANTIQ_MMD_LEDCH_NACS_NONE |
+ LANTIQ_MMD_LEDCH_SBF_F02HZ |
+ LANTIQ_MMD_LEDCH_FBF_F16HZ);
+ phy_write_mmd_indirect(phydev, LANTIQ_MMD_LEDCL, MDIO_MMD_VEND2,
+ LANTIQ_MMD_LEDCH_CBLINK_NONE |
+ LANTIQ_MMD_LEDCH_SCAN_NONE);
+
+ /**
+ * In most cases only one LED is connected to this phy, so
+ * configure them all to constant on and plue mode. LED3 is
+ * only available in some packages, let it in its reset
+ * configuration.
+ */
+ ledxh = LANTIQ_MMD_LEDxH_BLINKF_NONE | LANTIQ_MMD_LEDxH_CON_LINK10XX;
+ ledxl = LANTIQ_MMD_LEDxL_PULSE_TXACT | LANTIQ_MMD_LEDxL_PULSE_RXACT |
+ LANTIQ_MMD_LEDxL_BLINKS_NONE;
+ phy_write_mmd_indirect(phydev, LANTIQ_MMD_LED0H, MDIO_MMD_VEND2, ledxh);
+ phy_write_mmd_indirect(phydev, LANTIQ_MMD_LED0L, MDIO_MMD_VEND2, ledxl);
+ phy_write_mmd_indirect(phydev, LANTIQ_MMD_LED1H, MDIO_MMD_VEND2, ledxh);
+ phy_write_mmd_indirect(phydev, LANTIQ_MMD_LED1L, MDIO_MMD_VEND2, ledxl);
+ phy_write_mmd_indirect(phydev, LANTIQ_MMD_LED2H, MDIO_MMD_VEND2, ledxh);
+ phy_write_mmd_indirect(phydev, LANTIQ_MMD_LED2L, MDIO_MMD_VEND2, ledxl);
+
+ return 0;
+}
+
+static int lantiq_gphy14_config_aneg(struct phy_device *phydev)
+{
+ int reg, err;
+
+ /* Advertise as multi-port device, see IEEE802.3-2002 40.5.1.1 */
+ /* This is a workaround for an errata in rev < 1.5 devices */
+ reg = phy_read(phydev, MII_CTRL1000);
+ reg |= ADVERTISED_MPD;
+ err = phy_write(phydev, MII_CTRL1000, reg);
+ if (err)
+ return err;
+
+ return genphy_config_aneg(phydev);
+}
+
+static int lantiq_gphy_ack_interrupt(struct phy_device *phydev)
+{
+ int reg;
+
+ /**
+ * Possible IRQ numbers:
+ * - IM3_IRL18 for GPHY0
+ * - IM3_IRL17 for GPHY1
+ *
+ * Due to a silicon bug IRQ lines are not really independent from
+ * each other. Sometimes the two lines are driven at the same time
+ * if only one GPHY core raises the interrupt.
+ */
+ reg = phy_read(phydev, LANTIQ_MDIO_ISTAT);
+
+ return (reg < 0) ? reg : 0;
+}
+
+static int lantiq_gphy_did_interrupt(struct phy_device *phydev)
+{
+ int reg;
+
+ reg = phy_read(phydev, LANTIQ_MDIO_ISTAT);
+
+ return reg & LANTIQ_MDIO_INIT_MASK;
+}
+
+static int lantiq_gphy_config_intr(struct phy_device *phydev)
+{
+ u16 mask = 0;
+
+ if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
+ mask = LANTIQ_MDIO_INIT_MASK;
+
+ return phy_write(phydev, LANTIQ_MDIO_IMASK, mask);
+}
+
+static struct phy_driver lantiq_gphy[] = {
+ {
+ .phy_id = PHY_ID_PHY11G_1_3,
+ .phy_id_mask = 0xffffffff,
+ .name = "Lantiq XWAY PHY11G (PEF 7071/PEF 7072) v1.3",
+ .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause |
+ SUPPORTED_Asym_Pause),
+ /* there is an errata regarding irqs in this rev */
+ .flags = 0,
+ .config_init = lantiq_gphy_config_init,
+ .config_aneg = lantiq_gphy14_config_aneg,
+ .read_status = genphy_read_status,
+ .ack_interrupt = lantiq_gphy_ack_interrupt,
+ .did_interrupt = lantiq_gphy_did_interrupt,
+ .config_intr = lantiq_gphy_config_intr,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
+ }, {
+ .phy_id = PHY_ID_PHY22F_1_3,
+ .phy_id_mask = 0xffffffff,
+ .name = "Lantiq XWAY PHY22F (PEF 7061) v1.3",
+ .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause |
+ SUPPORTED_Asym_Pause),
+ /* there is an errata regarding irqs in this rev */
+ .flags = 0,
+ .config_init = lantiq_gphy_config_init,
+ .config_aneg = lantiq_gphy14_config_aneg,
+ .read_status = genphy_read_status,
+ .ack_interrupt = lantiq_gphy_ack_interrupt,
+ .did_interrupt = lantiq_gphy_did_interrupt,
+ .config_intr = lantiq_gphy_config_intr,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
+ }, {
+ .phy_id = PHY_ID_PHY11G_1_4,
+ .phy_id_mask = 0xffffffff,
+ .name = "Lantiq XWAY PHY11G (PEF 7071/PEF 7072) v1.4",
+ .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause |
+ SUPPORTED_Asym_Pause),
+ .flags = PHY_HAS_INTERRUPT,
+ .config_init = lantiq_gphy_config_init,
+ .config_aneg = lantiq_gphy14_config_aneg,
+ .read_status = genphy_read_status,
+ .ack_interrupt = lantiq_gphy_ack_interrupt,
+ .did_interrupt = lantiq_gphy_did_interrupt,
+ .config_intr = lantiq_gphy_config_intr,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
+ }, {
+ .phy_id = PHY_ID_PHY22F_1_4,
+ .phy_id_mask = 0xffffffff,
+ .name = "Lantiq XWAY PHY22F (PEF 7061) v1.4",
+ .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause |
+ SUPPORTED_Asym_Pause),
+ .flags = PHY_HAS_INTERRUPT,
+ .config_init = lantiq_gphy_config_init,
+ .config_aneg = lantiq_gphy14_config_aneg,
+ .read_status = genphy_read_status,
+ .ack_interrupt = lantiq_gphy_ack_interrupt,
+ .did_interrupt = lantiq_gphy_did_interrupt,
+ .config_intr = lantiq_gphy_config_intr,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
+ }, {
+ .phy_id = PHY_ID_PHY11G_1_5,
+ .phy_id_mask = 0xffffffff,
+ .name = "Lantiq XWAY PHY11G (PEF 7071/PEF 7072) v1.5 / v1.6",
+ .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause |
+ SUPPORTED_Asym_Pause),
+ .flags = PHY_HAS_INTERRUPT,
+ .config_init = lantiq_gphy_config_init,
+ .config_aneg = genphy_config_aneg,
+ .read_status = genphy_read_status,
+ .ack_interrupt = lantiq_gphy_ack_interrupt,
+ .did_interrupt = lantiq_gphy_did_interrupt,
+ .config_intr = lantiq_gphy_config_intr,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
+ }, {
+ .phy_id = PHY_ID_PHY22F_1_5,
+ .phy_id_mask = 0xffffffff,
+ .name = "Lantiq XWAY PHY22F (PEF 7061) v1.5 / v1.6",
+ .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause |
+ SUPPORTED_Asym_Pause),
+ .flags = PHY_HAS_INTERRUPT,
+ .config_init = lantiq_gphy_config_init,
+ .config_aneg = genphy_config_aneg,
+ .read_status = genphy_read_status,
+ .ack_interrupt = lantiq_gphy_ack_interrupt,
+ .did_interrupt = lantiq_gphy_did_interrupt,
+ .config_intr = lantiq_gphy_config_intr,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
+ }, {
+ .phy_id = PHY_ID_PHY11G_VR9,
+ .phy_id_mask = 0xffffffff,
+ .name = "Lantiq XWAY PHY11G (xRX200)",
+ .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause |
+ SUPPORTED_Asym_Pause),
+ .flags = PHY_HAS_INTERRUPT,
+ .config_init = lantiq_gphy_config_init,
+ .config_aneg = genphy_config_aneg,
+ .read_status = genphy_read_status,
+ .ack_interrupt = lantiq_gphy_ack_interrupt,
+ .did_interrupt = lantiq_gphy_did_interrupt,
+ .config_intr = lantiq_gphy_config_intr,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
+ }, {
+ .phy_id = PHY_ID_PHY22F_VR9,
+ .phy_id_mask = 0xffffffff,
+ .name = "Lantiq XWAY PHY22F (xRX200)",
+ .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause |
+ SUPPORTED_Asym_Pause),
+ .flags = PHY_HAS_INTERRUPT,
+ .config_init = lantiq_gphy_config_init,
+ .config_aneg = genphy_config_aneg,
+ .read_status = genphy_read_status,
+ .ack_interrupt = lantiq_gphy_ack_interrupt,
+ .did_interrupt = lantiq_gphy_did_interrupt,
+ .config_intr = lantiq_gphy_config_intr,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
+ },
+};
+module_phy_driver(lantiq_gphy);
+
+static struct mdio_device_id __maybe_unused lantiq_gphy_tbl[] = {
+ { PHY_ID_PHY11G_1_3, 0xffffffff },
+ { PHY_ID_PHY22F_1_3, 0xffffffff },
+ { PHY_ID_PHY11G_1_4, 0xffffffff },
+ { PHY_ID_PHY22F_1_4, 0xffffffff },
+ { PHY_ID_PHY11G_1_5, 0xffffffff },
+ { PHY_ID_PHY22F_1_5, 0xffffffff },
+ { PHY_ID_PHY11G_VR9, 0xffffffff },
+ { PHY_ID_PHY22F_VR9, 0xffffffff },
+ { }
+};
+MODULE_DEVICE_TABLE(mdio, lantiq_gphy_tbl);
+
+MODULE_DESCRIPTION("Lantiq PHY driver");
+MODULE_AUTHOR("Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>");
+MODULE_LICENSE("GPL");
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFC v2 2/2] NET: PHY: lantiq: add LED configuration support
2016-05-28 16:59 [RFC v2 1/2] NET: PHY: adds driver for Lantiq PHY11G Hauke Mehrtens
@ 2016-05-28 16:59 ` Hauke Mehrtens
2016-05-28 18:27 ` Andrew Lunn
2016-05-28 17:55 ` [RFC v2 1/2] NET: PHY: adds driver for Lantiq PHY11G Andrew Lunn
1 sibling, 1 reply; 6+ messages in thread
From: Hauke Mehrtens @ 2016-05-28 16:59 UTC (permalink / raw)
To: f.fainelli
Cc: alexander.stein, netdev, andrew, john, openwrt, hauke.mehrtens,
daniel.schwierzeck, eckert.florian, Hauke Mehrtens
This makes it possible to configure the behavior of the LEDs connected
to a PHY. The LEDs are controlled by the chip, this makes it possible
to configure the behavior when the hardware should activate and
deactivate the LEDs.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
Documentation/devicetree/bindings/phy/phy-leds.txt | 45 ++++++
drivers/net/phy/lantiq.c | 152 +++++++++++++++++++++
include/dt-bindings/phy/phy-leds.h | 27 ++++
3 files changed, 224 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/phy-leds.txt
create mode 100644 include/dt-bindings/phy/phy-leds.h
diff --git a/Documentation/devicetree/bindings/phy/phy-leds.txt b/Documentation/devicetree/bindings/phy/phy-leds.txt
new file mode 100644
index 0000000..6d9f5f3
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/phy-leds.txt
@@ -0,0 +1,45 @@
+LED configuration for Ethernet phys
+
+Property names:
+ led-const-on: conditions the LED should be constant on
+ led-pules: condition the LED should be pulsed on
+ led-blink-slow: condition the LED should slowly blink
+ led-blink-fast: condition the LED should fast blink
+
+property values:
+ PHY_LED_OFF: LED is off
+ PHY_LED_LINK10: link is 10MBit/s
+ PHY_LED_LINK100: link is 100MBit/s
+ PHY_LED_LINK1000: link is 1000MBit/s
+ PHY_LED_PDOWN: link is powered down
+ PHY_LED_EEE: link is in EEE mode
+ PHY_LED_ANEG: auto negotiation is running
+ PHY_LED_ABIST: analog self testing is running
+ PHY_LED_CDIAG: cable diagnostics is running
+ PHY_LED_COPPER: copper interface detected
+ PHY_LED_FIBER: fiber interface detected
+ PHY_LED_TXACT: Transmit activity
+ PHY_LED_RXACT: Receive activity
+ PHY_LED_COL: Collision
+
+Example:
+
+#include <dt-bindings/phy/phy-leds.h>
+phy@0 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0x0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ led@0 {
+ compatible = "phy,led";
+ reg = <0>;
+ led-const-on = <(PHY_LED_LINK10 | PHY_LED_LINK100 | PHY_LED_LINK1000)>;
+ led-pules = <(PHY_LED_TXACT | PHY_LED_RXACT)>;
+ };
+ led@2 {
+ compatible = "phy,led";
+ reg = <2>;
+ led-blink-slow = <PHY_LED_EEE>;
+ led-blink-fast = <PHY_LED_PDOWN>;
+ };
+};
diff --git a/drivers/net/phy/lantiq.c b/drivers/net/phy/lantiq.c
index a2adc4b..2d00b31 100644
--- a/drivers/net/phy/lantiq.c
+++ b/drivers/net/phy/lantiq.c
@@ -17,6 +17,7 @@
#include <linux/module.h>
#include <linux/phy.h>
#include <linux/of.h>
+#include <dt-bindings/phy/phy-leds.h>
#define LANTIQ_MDIO_IMASK 0x19 /* interrupt mask */
#define LANTIQ_MDIO_ISTAT 0x1A /* interrupt status */
@@ -152,11 +153,158 @@
#define PHY_ID_PHY11G_VR9 0xD565A409
#define PHY_ID_PHY22F_VR9 0xD565A419
+static void lantiq_gphy_config_led(struct phy_device *phydev,
+ struct device_node *led_np)
+{
+ const __be32 *addr, *blink_fast_p, *const_on_p, *pules_p, *blink_slow_p;
+ u32 num, blink_fast, const_on, pules, blink_slow;
+ u32 ledxl;
+ u32 ledxh;
+
+ addr = of_get_property(led_np, "reg", NULL);
+ if (!addr)
+ return;
+ num = be32_to_cpu(*addr);
+
+ if (num < 0 || num > 3)
+ return;
+
+ ledxh = LANTIQ_MMD_LEDxH_BLINKF_NONE | LANTIQ_MMD_LEDxH_CON_LINK10XX;
+ blink_fast_p = of_get_property(led_np, "led-blink-fast", NULL);
+ if (blink_fast_p) {
+ ledxh &= ~LANTIQ_MMD_LEDxH_BLINKF_MASK;
+ blink_fast = be32_to_cpu(*blink_fast_p);
+ if ((blink_fast & PHY_LED_LINK10) &&
+ (blink_fast & PHY_LED_LINK100) &&
+ (blink_fast & PHY_LED_LINK1000)) {
+ ledxh |= LANTIQ_MMD_LEDxH_BLINKF_LINK10XX;
+ } else if ((blink_fast & PHY_LED_LINK10) &&
+ (blink_fast & PHY_LED_LINK1000)) {
+ ledxh |= LANTIQ_MMD_LEDxH_BLINKF_LINK10_0;
+ } else if ((blink_fast & PHY_LED_LINK10) &&
+ (blink_fast & PHY_LED_LINK100)) {
+ ledxh |= LANTIQ_MMD_LEDxH_BLINKF_LINK10X;
+ } else if ((blink_fast & PHY_LED_LINK100) &&
+ (blink_fast & PHY_LED_LINK1000)) {
+ ledxh |= LANTIQ_MMD_LEDxH_BLINKF_LINK100X;
+ } else if (blink_fast & PHY_LED_LINK10) {
+ ledxh |= LANTIQ_MMD_LEDxH_BLINKF_LINK10;
+ } else if (blink_fast & PHY_LED_LINK100) {
+ ledxh |= LANTIQ_MMD_LEDxH_BLINKF_LINK100;
+ } else if (blink_fast & PHY_LED_LINK1000) {
+ ledxh |= LANTIQ_MMD_LEDxH_BLINKF_LINK1000;
+ } else if (blink_fast & PHY_LED_PDOWN) {
+ ledxh |= LANTIQ_MMD_LEDxH_BLINKF_PDOWN;
+ } else if (blink_fast & PHY_LED_EEE) {
+ ledxh |= LANTIQ_MMD_LEDxH_BLINKF_EEE;
+ } else if (blink_fast & PHY_LED_ANEG) {
+ ledxh |= LANTIQ_MMD_LEDxH_BLINKF_ANEG;
+ } else if (blink_fast & PHY_LED_ABIST) {
+ ledxh |= LANTIQ_MMD_LEDxH_BLINKF_ABIST;
+ } else if (blink_fast & PHY_LED_CDIAG) {
+ ledxh |= LANTIQ_MMD_LEDxH_BLINKF_CDIAG;
+ }
+ }
+ const_on_p = of_get_property(led_np, "led-const-on", NULL);
+ if (const_on_p) {
+ ledxh &= ~LANTIQ_MMD_LEDxH_CON_MASK;
+ const_on = be32_to_cpu(*const_on_p);
+ if ((const_on & PHY_LED_LINK10) &&
+ (const_on & PHY_LED_LINK100) &&
+ (const_on & PHY_LED_LINK1000)) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_LINK10XX;
+ } else if ((const_on & PHY_LED_LINK10) &&
+ (const_on & PHY_LED_LINK1000)) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_LINK10_0;
+ } else if ((const_on & PHY_LED_LINK10) &&
+ (const_on & PHY_LED_LINK100)) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_LINK10X;
+ } else if ((const_on & PHY_LED_LINK100) &&
+ (const_on & PHY_LED_LINK1000)) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_LINK100X;
+ } else if (const_on & PHY_LED_LINK10) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_LINK10;
+ } else if (const_on & PHY_LED_LINK100) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_LINK100;
+ } else if (const_on & PHY_LED_LINK1000) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_LINK1000;
+ } else if (const_on & PHY_LED_PDOWN) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_PDOWN;
+ } else if (const_on & PHY_LED_EEE) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_EEE;
+ } else if (const_on & PHY_LED_ANEG) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_ANEG;
+ } else if (const_on & PHY_LED_ABIST) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_ABIST;
+ } else if (const_on & PHY_LED_CDIAG) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_CDIAG;
+ } else if (const_on & PHY_LED_COPPER) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_COPPER;
+ } else if (const_on & PHY_LED_FIBER) {
+ ledxh |= LANTIQ_MMD_LEDxH_CON_FIBER;
+ }
+ }
+ phy_write_mmd_indirect(phydev, LANTIQ_MMD_LED0H + (num * 2),
+ MDIO_MMD_VEND2, ledxh);
+
+ ledxl = LANTIQ_MMD_LEDxL_PULSE_TXACT | LANTIQ_MMD_LEDxL_PULSE_RXACT |
+ LANTIQ_MMD_LEDxL_BLINKS_NONE;
+ pules_p = of_get_property(led_np, "led-pules", NULL);
+ if (pules_p) {
+ ledxl &= ~LANTIQ_MMD_LEDxL_PULSE_MASK;
+ pules = be32_to_cpu(*pules_p);
+ if (pules & PHY_LED_TXACT)
+ ledxl |= LANTIQ_MMD_LEDxL_PULSE_TXACT;
+ if (pules & PHY_LED_RXACT)
+ ledxl |= LANTIQ_MMD_LEDxL_PULSE_RXACT;
+ if (pules & PHY_LED_COL)
+ ledxl |= LANTIQ_MMD_LEDxL_PULSE_COL;
+ }
+ blink_slow_p = of_get_property(led_np, "led-blink-slow", NULL);
+ if (blink_slow_p) {
+ ledxl &= ~LANTIQ_MMD_LEDxL_BLINKS_MASK;
+ blink_slow = be32_to_cpu(*blink_slow_p);
+ if ((blink_slow & PHY_LED_LINK10) &&
+ (blink_slow & PHY_LED_LINK100) &&
+ (blink_slow & PHY_LED_LINK1000)) {
+ ledxl |= LANTIQ_MMD_LEDxL_BLINKS_LINK10XX;
+ } else if ((blink_slow & PHY_LED_LINK10) &&
+ (blink_slow & PHY_LED_LINK1000)) {
+ ledxl |= LANTIQ_MMD_LEDxL_BLINKS_LINK10_0;
+ } else if ((blink_slow & PHY_LED_LINK10) &&
+ (blink_slow & PHY_LED_LINK100)) {
+ ledxl |= LANTIQ_MMD_LEDxL_BLINKS_LINK10X;
+ } else if ((blink_slow & PHY_LED_LINK100) &&
+ (blink_slow & PHY_LED_LINK1000)) {
+ ledxl |= LANTIQ_MMD_LEDxL_BLINKS_LINK100X;
+ } else if (blink_slow & PHY_LED_LINK10) {
+ ledxl |= LANTIQ_MMD_LEDxL_BLINKS_LINK10;
+ } else if (blink_slow & PHY_LED_LINK100) {
+ ledxl |= LANTIQ_MMD_LEDxL_BLINKS_LINK100;
+ } else if (blink_slow & PHY_LED_LINK1000) {
+ ledxl |= LANTIQ_MMD_LEDxL_BLINKS_LINK1000;
+ } else if (blink_slow & PHY_LED_PDOWN) {
+ ledxl |= LANTIQ_MMD_LEDxL_BLINKS_PDOWN;
+ } else if (blink_slow & PHY_LED_EEE) {
+ ledxl |= LANTIQ_MMD_LEDxL_BLINKS_EEE;
+ } else if (blink_slow & PHY_LED_ANEG) {
+ ledxl |= LANTIQ_MMD_LEDxL_BLINKS_ANEG;
+ } else if (blink_slow & PHY_LED_ABIST) {
+ ledxl |= LANTIQ_MMD_LEDxL_BLINKS_ABIST;
+ } else if (blink_slow & PHY_LED_CDIAG) {
+ ledxl |= LANTIQ_MMD_LEDxL_BLINKS_CDIAG;
+ }
+ }
+ phy_write_mmd_indirect(phydev, LANTIQ_MMD_LED0L + (num * 2),
+ MDIO_MMD_VEND2, ledxl);
+}
+
static int lantiq_gphy_config_init(struct phy_device *phydev)
{
int err;
u32 ledxh;
u32 ledxl;
+ struct device_node *led_np;
/* Mask all interrupts */
err = phy_write(phydev, LANTIQ_MDIO_IMASK, 0);
@@ -190,6 +338,10 @@ static int lantiq_gphy_config_init(struct phy_device *phydev)
phy_write_mmd_indirect(phydev, LANTIQ_MMD_LED2H, MDIO_MMD_VEND2, ledxh);
phy_write_mmd_indirect(phydev, LANTIQ_MMD_LED2L, MDIO_MMD_VEND2, ledxl);
+ for_each_child_of_node(phydev->mdio.dev.of_node, led_np)
+ if (of_device_is_compatible(led_np, "phy,led"))
+ lantiq_gphy_config_led(phydev, led_np);
+
return 0;
}
diff --git a/include/dt-bindings/phy/phy-leds.h b/include/dt-bindings/phy/phy-leds.h
new file mode 100644
index 0000000..6e43245
--- /dev/null
+++ b/include/dt-bindings/phy/phy-leds.h
@@ -0,0 +1,27 @@
+/*
+ * Copyright (C) 2016 Hauke Mehrtens <hauke@hauke-m.de>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ */
+
+#ifndef _DT_BINDINGS_PHY_LEDS
+#define _DT_BINDINGS_PHY_LEDS
+
+#define PHY_LED_OFF (1 << 0) /* is off */
+#define PHY_LED_LINK10 (1 << 1) /* link is 10MBit/s */
+#define PHY_LED_LINK100 (1 << 2) /* link is 100MBit/s */
+#define PHY_LED_LINK1000 (1 << 3) /* link is 1000MBit/s */
+#define PHY_LED_PDOWN (1 << 4) /* link is powered down */
+#define PHY_LED_EEE (1 << 5) /* link is in EEE mode */
+#define PHY_LED_ANEG (1 << 6) /* auto negotiation is running */
+#define PHY_LED_ABIST (1 << 7) /* analog self testing is running */
+#define PHY_LED_CDIAG (1 << 8) /* cable diagnostics is running */
+#define PHY_LED_COPPER (1 << 9) /* copper interface detected */
+#define PHY_LED_FIBER (1 << 10) /* fiber interface detected */
+#define PHY_LED_TXACT (1 << 11) /* Transmit activity */
+#define PHY_LED_RXACT (1 << 12) /* Receive activity */
+#define PHY_LED_COL (1 << 13) /* Collision */
+
+#endif /* _DT_BINDINGS_PHY_LEDS */
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC v2 1/2] NET: PHY: adds driver for Lantiq PHY11G
2016-05-28 16:59 [RFC v2 1/2] NET: PHY: adds driver for Lantiq PHY11G Hauke Mehrtens
2016-05-28 16:59 ` [RFC v2 2/2] NET: PHY: lantiq: add LED configuration support Hauke Mehrtens
@ 2016-05-28 17:55 ` Andrew Lunn
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2016-05-28 17:55 UTC (permalink / raw)
To: Hauke Mehrtens
Cc: f.fainelli, alexander.stein, netdev, john, openwrt,
hauke.mehrtens, daniel.schwierzeck, eckert.florian
On Sat, May 28, 2016 at 06:59:00PM +0200, Hauke Mehrtens wrote:
Hi Hauke
> + /**
> + * In most cases only one LED is connected to this phy, so
> + * configure them all to constant on and plue mode. LED3 is
pulse not plue?
> + * only available in some packages, let it in its reset
leave, not let?
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC v2 2/2] NET: PHY: lantiq: add LED configuration support
2016-05-28 16:59 ` [RFC v2 2/2] NET: PHY: lantiq: add LED configuration support Hauke Mehrtens
@ 2016-05-28 18:27 ` Andrew Lunn
2016-05-28 21:23 ` Hauke Mehrtens
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2016-05-28 18:27 UTC (permalink / raw)
To: Hauke Mehrtens
Cc: f.fainelli, alexander.stein, netdev, john, openwrt,
hauke.mehrtens, daniel.schwierzeck, eckert.florian
On Sat, May 28, 2016 at 06:59:01PM +0200, Hauke Mehrtens wrote:
> This makes it possible to configure the behavior of the LEDs connected
> to a PHY. The LEDs are controlled by the chip, this makes it possible
> to configure the behavior when the hardware should activate and
> deactivate the LEDs.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Hi Hauke
This is interesting. But you definitely needs to Cc: the device tree
list.
It would also be good to see basic implementations for other PHYs, so
we know the binding is generic enough.
> +LED configuration for Ethernet phys
> +
> +Property names:
> + led-const-on: conditions the LED should be constant on
> + led-pules: condition the LED should be pulsed on
> + led-blink-slow: condition the LED should slowly blink
> + led-blink-fast: condition the LED should fast blink
A binding should make it clear if properties are required or optional.
led-pulse, not led-pules.
These properties also seem to be mutually exclusive. How can it be
constantly on, yet blink? You need better descriptions.
> +property values:
> + PHY_LED_OFF: LED is off
> + PHY_LED_LINK10: link is 10MBit/s
> + PHY_LED_LINK100: link is 100MBit/s
> + PHY_LED_LINK1000: link is 1000MBit/s
> + PHY_LED_PDOWN: link is powered down
> + PHY_LED_EEE: link is in EEE mode
> + PHY_LED_ANEG: auto negotiation is running
> + PHY_LED_ABIST: analog self testing is running
> + PHY_LED_CDIAG: cable diagnostics is running
> + PHY_LED_COPPER: copper interface detected
> + PHY_LED_FIBER: fiber interface detected
> + PHY_LED_TXACT: Transmit activity
> + PHY_LED_RXACT: Receive activity
> + PHY_LED_COL: Collision
There should be a comment that not all PHYs implement all values, or
even all properties. And some PHYS will accept an ORed list of
properties, where as other will only accept a single value.
And there should be a comment to look at the binding document for the
specific PHY for what it supports. And you need such a document for
the lantiq.
Maybe some of the implementation should be pushed into the phylib.
phy_probe() already looks for the max-speed property, so it could also
parse these properties and call a function in the phy_driver
structure.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC v2 2/2] NET: PHY: lantiq: add LED configuration support
2016-05-28 18:27 ` Andrew Lunn
@ 2016-05-28 21:23 ` Hauke Mehrtens
2016-05-28 22:03 ` Andrew Lunn
0 siblings, 1 reply; 6+ messages in thread
From: Hauke Mehrtens @ 2016-05-28 21:23 UTC (permalink / raw)
To: Andrew Lunn
Cc: f.fainelli, alexander.stein, netdev, john, openwrt,
hauke.mehrtens, daniel.schwierzeck, eckert.florian
On 05/28/2016 08:27 PM, Andrew Lunn wrote:
> On Sat, May 28, 2016 at 06:59:01PM +0200, Hauke Mehrtens wrote:
>> This makes it possible to configure the behavior of the LEDs connected
>> to a PHY. The LEDs are controlled by the chip, this makes it possible
>> to configure the behavior when the hardware should activate and
>> deactivate the LEDs.
>>
>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>
> Hi Hauke
>
> This is interesting. But you definitely needs to Cc: the device tree
> list.
Ah yes I forgot that, will fix the typos and resend it.
> It would also be good to see basic implementations for other PHYs, so
> we know the binding is generic enough.
Do you know for which PHY I could implement this? I only have access to
the documentation for the Lantiq / Intel PHYs.
>> +LED configuration for Ethernet phys
>> +
>> +Property names:
>> + led-const-on: conditions the LED should be constant on
>> + led-pules: condition the LED should be pulsed on
>> + led-blink-slow: condition the LED should slowly blink
>> + led-blink-fast: condition the LED should fast blink
>
> A binding should make it clear if properties are required or optional.
OK, I will make the all optional. Currently my intention was to make
this a generic binding, but different hardware probably has different
capabilities. Should this documentation file be specific for this PHY
driver or should I add two files for documentation one describing the
generic interface and then an additional one describing the concrete
capabilities of this PHY?
>
> led-pulse, not led-pules.
will fix that.
> These properties also seem to be mutually exclusive. How can it be
> constantly on, yet blink? You need better descriptions.
This specific phy has an order in which the attributes are applied, I
will document that.
>> +property values:
>> + PHY_LED_OFF: LED is off
>> + PHY_LED_LINK10: link is 10MBit/s
>> + PHY_LED_LINK100: link is 100MBit/s
>> + PHY_LED_LINK1000: link is 1000MBit/s
>> + PHY_LED_PDOWN: link is powered down
>> + PHY_LED_EEE: link is in EEE mode
>> + PHY_LED_ANEG: auto negotiation is running
>> + PHY_LED_ABIST: analog self testing is running
>> + PHY_LED_CDIAG: cable diagnostics is running
>> + PHY_LED_COPPER: copper interface detected
>> + PHY_LED_FIBER: fiber interface detected
>> + PHY_LED_TXACT: Transmit activity
>> + PHY_LED_RXACT: Receive activity
>> + PHY_LED_COL: Collision
>
> There should be a comment that not all PHYs implement all values, or
> even all properties. And some PHYS will accept an ORed list of
> properties, where as other will only accept a single value.
>
> And there should be a comment to look at the binding document for the
> specific PHY for what it supports. And you need such a document for
> the lantiq.
>
> Maybe some of the implementation should be pushed into the phylib.
> phy_probe() already looks for the max-speed property, so it could also
> parse these properties and call a function in the phy_driver
> structure.
I also thought about this, but as far as I know there is no standard
interface for these properties. I think setting the max speed is
standardized by the ieee. Should there be a callback with the
information needed for the PHY driver? I think having the parsing in the
generic code will not make the PHY driver much simpler, but we could
later provide these settings for different places like change the
configuration from user space.
Hauke
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC v2 2/2] NET: PHY: lantiq: add LED configuration support
2016-05-28 21:23 ` Hauke Mehrtens
@ 2016-05-28 22:03 ` Andrew Lunn
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2016-05-28 22:03 UTC (permalink / raw)
To: Hauke Mehrtens
Cc: f.fainelli, alexander.stein, netdev, john, openwrt,
hauke.mehrtens, daniel.schwierzeck, eckert.florian
> Do you know for which PHY I could implement this? I only have access to
> the documentation for the Lantiq / Intel PHYs.
Maybe actually implementing them is too far. But you could take a look
at available datasheets and thing about how you would implement the
binding. A quick search found:
http://www.davicom.com.tw/userfile/24247/DM9161-DS-F05_091008.pdf
http://www.o2xygen.com/photo/VSC8201XVZ/VSC8201XVZ_001.pdf
http://www.ti.com.cn/cn/lit/ds/symlink/dp83640.pdf
http://www.ti.com/lit/ds/symlink/dp83848-ep.pdf
http://ww1.microchip.com/downloads/en/DeviceDoc/KSZ8081MNX-RNB.pdf
Is what you have defined flexible enough?
> Should this documentation file be specific for this PHY driver or
> should I add two files for documentation one describing the generic
> interface and then an additional one describing the concrete
> capabilities of this PHY?
Yes, have a generic document which any PHY should be able to use, and
a specific one per PHY.
> I also thought about this, but as far as I know there is no standard
> interface for these properties. I think setting the max speed is
> standardized by the ieee. Should there be a callback with the
> information needed for the PHY driver? I think having the parsing in the
> generic code will not make the PHY driver much simpler, but we could
> later provide these settings for different places like change the
> configuration from user space.
What we don't want is X PHYs with Y different LED bindings. We should
be aiming to describe a binding which fits the majority of PHYs. And
since it should fit the majority of PHYs we can pull parts of it into
the infrastructure. That itself will prevent people doing something
different.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-28 22:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-28 16:59 [RFC v2 1/2] NET: PHY: adds driver for Lantiq PHY11G Hauke Mehrtens
2016-05-28 16:59 ` [RFC v2 2/2] NET: PHY: lantiq: add LED configuration support Hauke Mehrtens
2016-05-28 18:27 ` Andrew Lunn
2016-05-28 21:23 ` Hauke Mehrtens
2016-05-28 22:03 ` Andrew Lunn
2016-05-28 17:55 ` [RFC v2 1/2] NET: PHY: adds driver for Lantiq PHY11G Andrew Lunn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.