From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "George G. Davis" <george_davis@mentor.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Alexandre Courbot <gnurou@gmail.com>,
Fugang Duan <fugang.duan@nxp.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Russell King <linux@armlinux.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Kumar Gala <galak@codeaurora.org>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API
Date: Tue, 31 May 2016 19:47:48 +0200 [thread overview]
Message-ID: <20160531174748.GI26768@pengutronix.de> (raw)
In-Reply-To: <1464715071-56012-1-git-send-email-george_davis@mentor.com>
Hello George,
On Tue, May 31, 2016 at 01:17:51PM -0400, George G. Davis wrote:
> Convert the i.MX FEC driver and DT files to use the GPIOD API
> which automatically handles GPIO polarity.
additionally to what Fabio said, there is also a nicer approach in the
making. The resulting dts would look as follows:
&fec {
phy-handle = <ðphy>;
...
mdio {
#address-cells = <1>;
#size-cells = <0>;
ethphy: ethernet-phy@7 {
...
reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
};
};
};
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "George G. Davis" <george_davis@mentor.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Alexandre Courbot <gnurou@gmail.com>,
Fugang Duan <fugang.duan@nxp.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Russell King <linux@armlinux.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Kumar Gala <galak@codeaurora.org>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API
Date: Tue, 31 May 2016 19:47:48 +0200 [thread overview]
Message-ID: <20160531174748.GI26768@pengutronix.de> (raw)
In-Reply-To: <1464715071-56012-1-git-send-email-george_davis@mentor.com>
Hello George,
On Tue, May 31, 2016 at 01:17:51PM -0400, George G. Davis wrote:
> Convert the i.MX FEC driver and DT files to use the GPIOD API
> which automatically handles GPIO polarity.
additionally to what Fabio said, there is also a nicer approach in the
making. The resulting dts would look as follows:
&fec {
phy-handle = <ðphy>;
...
mdio {
#address-cells = <1>;
#size-cells = <0>;
ethphy: ethernet-phy@7 {
...
reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
};
};
};
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-05-31 17:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 17:17 [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API George G. Davis
2016-05-31 17:17 ` George G. Davis
[not found] ` <1464715071-56012-1-git-send-email-george_davis-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2016-05-31 17:26 ` Fabio Estevam
2016-05-31 17:26 ` Fabio Estevam
2016-05-31 18:24 ` George G. Davis
2016-05-31 18:26 ` Russell King - ARM Linux
2016-05-31 18:33 ` George G. Davis
2016-05-31 17:47 ` Uwe Kleine-König [this message]
2016-05-31 17:47 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531174748.GI26768@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@nxp.com \
--cc=galak@codeaurora.org \
--cc=george_davis@mentor.com \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.